[jira] [Closed] (SOLR-15635) calling SolrRequestInfo.clearRequestInfo() twice repeats hook.close()

2021-11-21 Thread Mikhail Khludnev (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15635?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mikhail Khludnev closed SOLR-15635. --- > calling SolrRequestInfo.clearRequestInfo() twice repeats hook.close() > ---

[jira] [Updated] (SOLR-15635) calling SolrRequestInfo.clearRequestInfo() twice repeats hook.close()

2021-11-21 Thread Mikhail Khludnev (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15635?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mikhail Khludnev updated SOLR-15635: Fix Version/s: 8.11.1 Resolution: Fixed Status: Resolved (was: Patch Avai

[GitHub] [solr] gerlowskija edited a comment on pull request #429: SOLR-15182: replica API conversion to annotations

2021-11-21 Thread GitBox
gerlowskija edited a comment on pull request #429: URL: https://github.com/apache/solr/pull/429#issuecomment-975021655 Hmm, yeah, looks like I've got some IntelliJ editor settings to figure out. Is there a settings file I can import or something, or is it just manual settings people have

[GitHub] [solr] gerlowskija commented on pull request #429: SOLR-15182: replica API conversion to annotations

2021-11-21 Thread GitBox
gerlowskija commented on pull request #429: URL: https://github.com/apache/solr/pull/429#issuecomment-975021655 Hmm, yeah, looks like I've got some IntelliJ editor settings to figure out. Is there a settings file we have to import or something, or is it just manual settings people have fo

[GitHub] [solr] janhoy commented on a change in pull request #427: SOLR-11623 Every request handler - PermissionNameProvider (Take 2)

2021-11-21 Thread GitBox
janhoy commented on a change in pull request #427: URL: https://github.com/apache/solr/pull/427#discussion_r753722612 ## File path: solr/core/src/test/org/apache/solr/security/BaseTestRuleBasedAuthorizationPlugin.java ## @@ -213,14 +212,14 @@ public void testBasicPermissions()

[GitHub] [solr] janhoy commented on a change in pull request #424: SOLR-15809 Get rid of blacklist/whitelist terminology

2021-11-21 Thread GitBox
janhoy commented on a change in pull request #424: URL: https://github.com/apache/solr/pull/424#discussion_r753726610 ## File path: solr/CHANGES.txt ## @@ -1578,7 +1583,7 @@ Improvements SOLR_REQUESTLOG_ENABLED=true. This will respect SOLR_LOGS_DIR if it is set. (rmuir)

[GitHub] [solr] dsmiley merged pull request #144: SOLR-15427: Nested docs: [child limit=...] now defaults to -1

2021-11-21 Thread GitBox
dsmiley merged pull request #144: URL: https://github.com/apache/solr/pull/144 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@

[GitHub] [solr] mhitza commented on pull request #428: SOLR-14410: switch from SysV to systemd service

2021-11-21 Thread GitBox
mhitza commented on pull request #428: URL: https://github.com/apache/solr/pull/428#issuecomment-974742668 @janhoy I know in the previous PR your pointed out the possibility of handling the upgrade path SysV to systemd https://github.com/apache/lucene-solr/pull/1435#discussion_r723118782 .

[GitHub] [solr] cpoerschke commented on pull request #159: [SOLR-10059] Handle appends params in distributed requests

2021-11-21 Thread GitBox
cpoerschke commented on pull request #159: URL: https://github.com/apache/solr/pull/159#issuecomment-974716554 > ... no cloud setup test though ... #426 is about adding a `SearchHandlerAppendsCloudTest` test. -- This is an automated message from the Apache Git Service. To respond t

[GitHub] [solr] dsmiley commented on pull request #427: SOLR-11623 Every request handler - PermissionNameProvider (Take 2)

2021-11-21 Thread GitBox
dsmiley commented on pull request #427: URL: https://github.com/apache/solr/pull/427#issuecomment-974745217 BTW I reviewed the the choice of which handler has which permissions (we did this in the previous PR for this) but I don't feel qualified to gauge the impact on tests, as it requires

[GitHub] [solr] epugh commented on a change in pull request #429: SOLR-15182: replica API conversion to annotations

2021-11-21 Thread GitBox
epugh commented on a change in pull request #429: URL: https://github.com/apache/solr/pull/429#discussion_r753833593 ## File path: solr/core/src/java/org/apache/solr/handler/admin/CollectionsHandler.java ## @@ -20,48 +20,26 @@ import com.google.common.collect.ImmutableSet; i

[GitHub] [solr] epugh commented on a change in pull request #429: SOLR-15182: replica API conversion to annotations

2021-11-21 Thread GitBox
epugh commented on a change in pull request #429: URL: https://github.com/apache/solr/pull/429#discussion_r753833628 ## File path: solr/core/src/java/org/apache/solr/handler/admin/CollectionsHandler.java ## @@ -20,48 +20,26 @@ import com.google.common.collect.ImmutableSet; i

[GitHub] [solr] epugh commented on a change in pull request #429: SOLR-15182: replica API conversion to annotations

2021-11-21 Thread GitBox
epugh commented on a change in pull request #429: URL: https://github.com/apache/solr/pull/429#discussion_r753833593 ## File path: solr/core/src/java/org/apache/solr/handler/admin/CollectionsHandler.java ## @@ -20,48 +20,26 @@ import com.google.common.collect.ImmutableSet; i

[GitHub] [solr] gerlowskija opened a new pull request #429: SOLR-15182: replica API conversion to annotations

2021-11-21 Thread GitBox
gerlowskija opened a new pull request #429: URL: https://github.com/apache/solr/pull/429 # Description The v2 API currently has APIs implemented two ways: using an JSON 'apispec' file, or using a JAX-RS -like annotation framework. The former framework is deprecated and we're in the