[jira] [Commented] (SOLR-8319) NPE when creating pivot

2021-11-23 Thread Isabelle Giguere (Jira)
[ https://issues.apache.org/jira/browse/SOLR-8319?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17448265#comment-17448265 ] Isabelle Giguere commented on SOLR-8319: New patch is a copy of [~houston]'s PR 22

[jira] [Updated] (SOLR-8319) NPE when creating pivot

2021-11-23 Thread Isabelle Giguere (Jira)
[ https://issues.apache.org/jira/browse/SOLR-8319?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Isabelle Giguere updated SOLR-8319: --- Attachment: SOLR-8319-1.patch > NPE when creating pivot > --- > >

[GitHub] [solr] janhoy commented on a change in pull request #428: SOLR-14410: switch from SysV to systemd service

2021-11-23 Thread GitBox
janhoy commented on a change in pull request #428: URL: https://github.com/apache/solr/pull/428#discussion_r755487160 ## File path: solr/bin/install_solr_service.sh ## @@ -352,19 +357,13 @@ find "$SOLR_VAR_DIR" -type d -print0 | xargs -0 chmod 0750 find "$SOLR_VAR_DIR" -type f

[GitHub] [solr] janhoy merged pull request #430: Fixed a typo in comment line inside AbstractEnumField.java

2021-11-23 Thread GitBox
janhoy merged pull request #430: URL: https://github.com/apache/solr/pull/430 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@s

[jira] (SOLR-8319) NPE when creating pivot

2021-11-23 Thread Isabelle Giguere (Jira)
[ https://issues.apache.org/jira/browse/SOLR-8319 ] Isabelle Giguere deleted comment on SOLR-8319: was (Author: igiguere): Latest patch is a copy of [~houston]'s PR 2273, plus the modification in PivotFacetProcessor that I mention in my pre

[jira] [Updated] (SOLR-8319) NPE when creating pivot

2021-11-23 Thread Isabelle Giguere (Jira)
[ https://issues.apache.org/jira/browse/SOLR-8319?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Isabelle Giguere updated SOLR-8319: --- Attachment: (was: SOLR-8319-1.patch) > NPE when creating pivot > --- >

[GitHub] [solr-operator] joel-bernstein edited a comment on issue #377: solr-operator is reformatting cpu and mem and likely should not be.

2021-11-23 Thread GitBox
joel-bernstein edited a comment on issue #377: URL: https://github.com/apache/solr-operator/issues/377#issuecomment-977123289 I've just been informed, that this transformation actually happens for Deployments as well. So this is a Kube issue. I'll close this. -- This is an automated mess

[GitHub] [solr-operator] joel-bernstein closed issue #377: solr-operator is reformatting cpu and mem and likely should not be.

2021-11-23 Thread GitBox
joel-bernstein closed issue #377: URL: https://github.com/apache/solr-operator/issues/377 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-u

[GitHub] [solr-operator] joel-bernstein commented on issue #377: solr-operator is reformatting cpu and mem and likely should not be.

2021-11-23 Thread GitBox
joel-bernstein commented on issue #377: URL: https://github.com/apache/solr-operator/issues/377#issuecomment-977123289 I've just been informed, that this transformation actually happens for Deployments as well. So this is Kube issue. I'll close this. -- This is an automated message from

[GitHub] [solr-operator] joel-bernstein opened a new issue #377: solr-operator is reformatting cpu and mem and likely should not be.

2021-11-23 Thread GitBox
joel-bernstein opened a new issue #377: URL: https://github.com/apache/solr-operator/issues/377 If you create a CR with the following resources: `resources: limits: memory: 1Gi requests: cpu: 1000m memory: 1Gi ` Th

[GitHub] [solr] betulince commented on pull request #430: Fixed a typo in comment line inside AbstractEnumField.java

2021-11-23 Thread GitBox
betulince commented on pull request #430: URL: https://github.com/apache/solr/pull/430#issuecomment-977030088 > Looks good. Thank you. Do you wish to fold more minor typo fixes into this branch? If not I’ll merge. Thanks! I couldn't find any other typos. You can merge. -- This is

[jira] [Commented] (SOLR-15807) Add a "LogListener" helper class that makes it easy to inspect & assert expected log messages

2021-11-23 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17448195#comment-17448195 ] Dawid Weiss commented on SOLR-15807: Yup, fine by me. > Add a "LogListener" helper c

[GitHub] [solr] betulince opened a new pull request #430: Fixed a typo in comment line inside AbstractEnumField.java

2021-11-23 Thread GitBox
betulince opened a new pull request #430: URL: https://github.com/apache/solr/pull/430 # Description Fixed a typo in comment line inside AbstractEnumField.java. There is no need to add unit test and documentation because of typo fixing. # Checklist Please review the followi

[GitHub] [solr-operator] gerlowskija opened a new issue #376: Recompute solrbackup's `.Status.NextScheduledTime` on changes to `.Spec.Recurrence.Schedule`

2021-11-23 Thread GitBox
gerlowskija opened a new issue #376: URL: https://github.com/apache/solr-operator/issues/376 Currently, changing the `schedule` property leaves the "Next Scheduled" time untouched, which causes a delay in when the `schedule` property is actually able to "take effect". e.g. Changing

[jira] [Updated] (SOLR-15807) Add a "LogListener" helper class that makes it easy to inspect & assert expected log messages

2021-11-23 Thread Chris M. Hostetter (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15807?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris M. Hostetter updated SOLR-15807: -- Attachment: SOLR-15807-2.patch Status: Open (was: Open) Bah ... yes, of course

[jira] [Updated] (SOLR-15813) Can't select my schema in Schema Designer in Admin UI: String cannot be cast to Boolean

2021-11-23 Thread Simone (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15813?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Simone updated SOLR-15813: -- Description: I can't select my schema in _Schema Designer_ tab in {_}Admin UI{_}. It happens only when I disab

[jira] [Commented] (SOLR-15815) Add TestRule support for ErrorLogMuter & LogListener

2021-11-23 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15815?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17448149#comment-17448149 ] Dawid Weiss commented on SOLR-15815: Ah... sorry - I didn't get your intention. It's

[jira] [Commented] (SOLR-15815) Add TestRule support for ErrorLogMuter & LogListener

2021-11-23 Thread Chris M. Hostetter (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15815?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17448145#comment-17448145 ] Chris M. Hostetter commented on SOLR-15815: --- {quote}The only downside I see is

[jira] [Comment Edited] (SOLR-8319) NPE when creating pivot

2021-11-23 Thread Isabelle Giguere (Jira)
[ https://issues.apache.org/jira/browse/SOLR-8319?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17448081#comment-17448081 ] Isabelle Giguere edited comment on SOLR-8319 at 11/23/21, 3:50 PM: -

[jira] [Updated] (SOLR-8319) NPE when creating pivot

2021-11-23 Thread Isabelle Giguere (Jira)
[ https://issues.apache.org/jira/browse/SOLR-8319?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Isabelle Giguere updated SOLR-8319: --- Attachment: SOLR-8319-1.patch > NPE when creating pivot > --- > >

[jira] [Updated] (SOLR-8319) NPE when creating pivot

2021-11-23 Thread Isabelle Giguere (Jira)
[ https://issues.apache.org/jira/browse/SOLR-8319?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Isabelle Giguere updated SOLR-8319: --- Attachment: (was: SOLR-8913.patch) > NPE when creating pivot > --- > >

[jira] [Commented] (SOLR-8319) NPE when creating pivot

2021-11-23 Thread Isabelle Giguere (Jira)
[ https://issues.apache.org/jira/browse/SOLR-8319?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17448081#comment-17448081 ] Isabelle Giguere commented on SOLR-8319: Latest patch is a copy of [~houston]'s PR

[jira] [Updated] (SOLR-8319) NPE when creating pivot

2021-11-23 Thread Isabelle Giguere (Jira)
[ https://issues.apache.org/jira/browse/SOLR-8319?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Isabelle Giguere updated SOLR-8319: --- Attachment: SOLR-8913.patch > NPE when creating pivot > --- > >

[GitHub] [solr] janhoy commented on a change in pull request #424: SOLR-15809 Get rid of blacklist/whitelist terminology

2021-11-23 Thread GitBox
janhoy commented on a change in pull request #424: URL: https://github.com/apache/solr/pull/424#discussion_r755206338 ## File path: dev-tools/test-patch/lucene-solr-yetus-personality.sh ## @@ -113,11 +113,11 @@ function personality_modules case ${moduleType} in submodul

[GitHub] [solr] janhoy commented on a change in pull request #424: SOLR-15809 Get rid of blacklist/whitelist terminology

2021-11-23 Thread GitBox
janhoy commented on a change in pull request #424: URL: https://github.com/apache/solr/pull/424#discussion_r755205462 ## File path: solr/solr-ref-guide/src/major-changes-in-solr-9.adoc ## @@ -82,6 +82,9 @@ All the usages are replaced by BaseHttpSolrClient.RemoteSolrException a

[GitHub] [solr] janhoy commented on a change in pull request #424: SOLR-15809 Get rid of blacklist/whitelist terminology

2021-11-23 Thread GitBox
janhoy commented on a change in pull request #424: URL: https://github.com/apache/solr/pull/424#discussion_r755203770 ## File path: solr/bin/solr ## @@ -2073,8 +2073,8 @@ else fi # IP-based access control -IP_ACL_OPTS=("-Dsolr.jetty.inetaccess.includes=${SOLR_IP_WHITELIST}"

[GitHub] [solr] janhoy commented on a change in pull request #424: SOLR-15809 Get rid of blacklist/whitelist terminology

2021-11-23 Thread GitBox
janhoy commented on a change in pull request #424: URL: https://github.com/apache/solr/pull/424#discussion_r755176129 ## File path: solr/bin/solr ## @@ -2073,8 +2073,8 @@ else fi # IP-based access control -IP_ACL_OPTS=("-Dsolr.jetty.inetaccess.includes=${SOLR_IP_WHITELIST}"

[jira] [Commented] (SOLR-15815) Add TestRule support for ErrorLogMuter & LogListener

2021-11-23 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15815?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17447940#comment-17447940 ] Dawid Weiss commented on SOLR-15815: Yup, the approach looks fine to me. The only dow

[jira] [Commented] (SOLR-15807) Add a "LogListener" helper class that makes it easy to inspect & assert expected log messages

2021-11-23 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17447934#comment-17447934 ] Dawid Weiss commented on SOLR-15807: !screenshot-1.png! Looking at the diff seems l

[jira] [Updated] (SOLR-15807) Add a "LogListener" helper class that makes it easy to inspect & assert expected log messages

2021-11-23 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15807?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dawid Weiss updated SOLR-15807: --- Attachment: screenshot-1.png > Add a "LogListener" helper class that makes it easy to inspect & asser

[jira] [Resolved] (SOLR-15816) Upgrade Jetty to 9.4.44

2021-11-23 Thread Ishan Chattopadhyaya (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15816?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ishan Chattopadhyaya resolved SOLR-15816. - Resolution: Duplicate This was done in https://issues.apache.org/jira/browse/SOLR

[jira] [Updated] (SOLR-15816) Upgrade Jetty to 9.4.44

2021-11-23 Thread Ishan Chattopadhyaya (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15816?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ishan Chattopadhyaya updated SOLR-15816: Description: In 8.9, we upgraded to Jetty 9.4.39. Also, in https://issues.apache.o

[jira] [Created] (SOLR-15816) Upgrade Jetty to 9.4.44

2021-11-23 Thread Ishan Chattopadhyaya (Jira)
Ishan Chattopadhyaya created SOLR-15816: --- Summary: Upgrade Jetty to 9.4.44 Key: SOLR-15816 URL: https://issues.apache.org/jira/browse/SOLR-15816 Project: Solr Issue Type: Task Sec