markrmiller commented on a change in pull request #585:
URL: https://github.com/apache/solr/pull/585#discussion_r819245105
##
File path:
solr/modules/s3-repository/src/test/org/apache/solr/s3/S3BackupRepositoryTest.java
##
@@ -320,17 +340,113 @@ protected URI getBaseUri() thro
markrmiller commented on a change in pull request #585:
URL: https://github.com/apache/solr/pull/585#discussion_r819244284
##
File path: solr/modules/s3-repository/build.gradle
##
@@ -39,6 +39,10 @@ dependencies {
runtimeOnly (group: 'com.fasterxml.woodstox', name: 'woodst
markrmiller commented on a change in pull request #585:
URL: https://github.com/apache/solr/pull/585#discussion_r819243244
##
File path: gradle/solr/force-versions.gradle
##
@@ -0,0 +1,35 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contribu
markrmiller commented on a change in pull request #585:
URL: https://github.com/apache/solr/pull/585#discussion_r819240165
##
File path: solr/modules/s3-repository/build.gradle
##
@@ -41,21 +41,25 @@ dependencies {
runtimeOnly(group: 'com.fasterxml.woodstox', name: 'woodstox
markrmiller commented on a change in pull request #585:
URL: https://github.com/apache/solr/pull/585#discussion_r819239772
##
File path:
solr/modules/hadoop-auth/src/test/org/apache/solr/client/solrj/impl/Krb5HttpClientUtils.java
##
@@ -36,10 +36,11 @@
public static void se
markrmiller commented on a change in pull request #585:
URL: https://github.com/apache/solr/pull/585#discussion_r819239275
##
File path: gradle/solr/force-versions.gradle
##
@@ -0,0 +1,35 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contribu
[
https://issues.apache.org/jira/browse/SOLR-6476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17501106#comment-17501106
]
Noble Paul commented on SOLR-6476:
--
{quote}Or do you feel strongly about keeping it aroun
Caa52 closed pull request #724:
URL: https://github.com/apache/solr/pull/724
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@so
Caa52 opened a new pull request #724:
URL: https://github.com/apache/solr/pull/724
https://issues.apache.org/jira/browse/SOLR-X
# Description
Please provide a short description of the changes you're making with this
pull request.
# Solution
Please
madrob commented on a change in pull request #585:
URL: https://github.com/apache/solr/pull/585#discussion_r819198076
##
File path: gradle/solr/force-versions.gradle
##
@@ -0,0 +1,35 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor l
markrmiller commented on pull request #699:
URL: https://github.com/apache/solr/pull/699#issuecomment-1058726660
Would probably make sense in the likely case Jetty 10 doesn't go out in 9.0
or if there is another 8.x release.
--
This is an automated message from the Apache Git Service.
To
markrmiller commented on pull request #585:
URL: https://github.com/apache/solr/pull/585#issuecomment-1058725898
That was a bit more effort than expected, but updated jetty from 10.0.7 to
10.0.8. That removes the need for the security policy read permission for "/".
Rebased to latest
[
https://issues.apache.org/jira/browse/SOLR-16074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17501041#comment-17501041
]
ASF subversion and git services commented on SOLR-16074:
Commit 4
[
https://issues.apache.org/jira/browse/SOLR-16074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17501033#comment-17501033
]
ASF subversion and git services commented on SOLR-16074:
Commit 4
[
https://issues.apache.org/jira/browse/SOLR-16074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17501028#comment-17501028
]
ASF subversion and git services commented on SOLR-16074:
Commit d
[
https://issues.apache.org/jira/browse/SOLR-16074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17501027#comment-17501027
]
Houston Putman commented on SOLR-16074:
---
There is another test in TestReplicationHa
[
https://issues.apache.org/jira/browse/SOLR-14920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17501019#comment-17501019
]
Kevin Risden commented on SOLR-14920:
-
solr core non test is being reviewed and proba
risdenk opened a new pull request #723:
URL: https://github.com/apache/solr/pull/723
https://issues.apache.org/jira/browse/SOLR-14920
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
risdenk opened a new pull request #722:
URL: https://github.com/apache/solr/pull/722
https://issues.apache.org/jira/browse/SOLR-14920
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
risdenk opened a new pull request #721:
URL: https://github.com/apache/solr/pull/721
https://issues.apache.org/jira/browse/SOLR-14920
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
risdenk commented on a change in pull request #705:
URL: https://github.com/apache/solr/pull/705#discussion_r819026369
##
File path: solr/core/src/java/org/apache/solr/parser/QueryParser.java
##
@@ -8,25 +8,25 @@
import java.util.HashSet;
import java.util.List;
import java.u
risdenk commented on pull request #711:
URL: https://github.com/apache/solr/pull/711#issuecomment-1058392670
Thanks @ErickErickson! I am working through your comment fixes here:
https://github.com/apache/solr/pull/720
--
This is an automated message from the Apache Git Service.
To respon
risdenk opened a new pull request #720:
URL: https://github.com/apache/solr/pull/720
https://issues.apache.org/jira/browse/SOLR-14920
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
risdenk commented on a change in pull request #711:
URL: https://github.com/apache/solr/pull/711#discussion_r818980739
##
File path: solr/core/src/test/org/apache/solr/cloud/TestHashPartitioner.java
##
@@ -86,28 +88,27 @@ public void testMapHashes() throws Exception {
fo
risdenk commented on a change in pull request #711:
URL: https://github.com/apache/solr/pull/711#discussion_r818977282
##
File path: solr/core/src/test/org/apache/solr/search/TestFilteredDocIdSet.java
##
@@ -45,76 +43,78 @@
public class TestFilteredDocIdSet extends SolrTestC
risdenk commented on a change in pull request #711:
URL: https://github.com/apache/solr/pull/711#discussion_r818969974
##
File path:
solr/core/src/test/org/apache/solr/cloud/api/collections/SplitByPrefixTest.java
##
@@ -51,15 +50,13 @@
@BeforeClass
public static void s
dsmiley commented on a change in pull request #705:
URL: https://github.com/apache/solr/pull/705#discussion_r818966572
##
File path: solr/core/src/java/org/apache/solr/parser/QueryParser.java
##
@@ -8,25 +8,25 @@
import java.util.HashSet;
import java.util.List;
import java.u
risdenk commented on a change in pull request #705:
URL: https://github.com/apache/solr/pull/705#discussion_r818949965
##
File path: solr/core/src/java/org/apache/solr/parser/QueryParser.java
##
@@ -8,25 +8,25 @@
import java.util.HashSet;
import java.util.List;
import java.u
[
https://issues.apache.org/jira/browse/SOLR-14401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17500960#comment-17500960
]
Houston Putman commented on SOLR-14401:
---
I like the new label approach the best, ea
[
https://issues.apache.org/jira/browse/SOLR-16071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17500955#comment-17500955
]
Houston Putman commented on SOLR-16071:
---
Will leave this open for a few days to che
[
https://issues.apache.org/jira/browse/SOLR-14401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17500954#comment-17500954
]
David Smiley commented on SOLR-14401:
-
Thanks for looking Jan!
Notice the PR removes
[
https://issues.apache.org/jira/browse/SOLR-16071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17500942#comment-17500942
]
ASF subversion and git services commented on SOLR-16071:
Commit b
[
https://issues.apache.org/jira/browse/SOLR-16071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17500943#comment-17500943
]
ASF subversion and git services commented on SOLR-16071:
Commit 4
[
https://issues.apache.org/jira/browse/SOLR-16071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17500941#comment-17500941
]
ASF subversion and git services commented on SOLR-16071:
Commit 7
[
https://issues.apache.org/jira/browse/SOLR-14920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17500928#comment-17500928
]
Kevin Risden commented on SOLR-14920:
-
{quote}I definitely think the scope should inc
[
https://issues.apache.org/jira/browse/SOLR-16074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17500915#comment-17500915
]
Houston Putman commented on SOLR-16074:
---
This is a weird one, it fails a lot of the
[
https://issues.apache.org/jira/browse/SOLR-16074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17500913#comment-17500913
]
Kevin Risden commented on SOLR-16074:
-
Here are 2 other reproducing seeds:
{code:ja
[
https://issues.apache.org/jira/browse/SOLR-16070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17500912#comment-17500912
]
Kevin Risden commented on SOLR-16070:
-
Feel free to push to the SOLR-16070 branch. It
HoustonPutman commented on pull request #411:
URL: https://github.com/apache/solr-operator/pull/411#issuecomment-1058265634
As I mentioned in the issue, the Solr CRDs are auto-generated by
controller-gen, so we need to go through and add the annotations after the
generation. (Until control
HoustonPutman commented on issue #410:
URL: https://github.com/apache/solr-operator/issues/410#issuecomment-1058249104
Also these files are autogenerated, and it looks like controller-gen does
not support adding annotations to the generated CRDs yet...
https://github.com/kubernetes-sigs/co
HoustonPutman commented on issue #410:
URL: https://github.com/apache/solr-operator/issues/410#issuecomment-1058246435
I imagine ArgoCD may also fix the "refresh" functionality, because that
definitely seems like a bug.
Think this is a great idea!
--
This is an automated message f
[
https://issues.apache.org/jira/browse/SOLR-16070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17500811#comment-17500811
]
Erick Erickson edited comment on SOLR-16070 at 3/3/22, 3:38 PM:
---
Erick Erickson created SOLR-16074:
-
Summary: Reproducible failure
TestReplicationHandler.doTestStressReplication
Key: SOLR-16074
URL: https://issues.apache.org/jira/browse/SOLR-16074
Project: Solr
[
https://issues.apache.org/jira/browse/SOLR-14401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17500825#comment-17500825
]
Jan Høydahl commented on SOLR-14401:
Looks like your patch does NOT rename the promet
David Smiley created SOLR-16073:
---
Summary: totalTime metric should be milliseconds (not nano)
Key: SOLR-16073
URL: https://issues.apache.org/jira/browse/SOLR-16073
Project: Solr
Issue Type: Bug
dsmiley commented on pull request #657:
URL: https://github.com/apache/solr/pull/657#issuecomment-1058139000
https://issues.apache.org/jira/browse/SOLR-16073
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abo
janhoy commented on pull request #657:
URL: https://github.com/apache/solr/pull/657#issuecomment-1058127599
> Definitely see JIRA for my overall comments.
>
> I want to point out that I observed that the "totalTime" metric has been a
nanosecond number in recent years, yet once upon a
[
https://issues.apache.org/jira/browse/SOLR-14920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17500815#comment-17500815
]
Erick Erickson commented on SOLR-14920:
---
I'll start looking at 705.
> Format code
[
https://issues.apache.org/jira/browse/SOLR-16070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17500811#comment-17500811
]
Erick Erickson commented on SOLR-16070:
---
OK, I've finished, running tests now. Just
dsmiley commented on pull request #657:
URL: https://github.com/apache/solr/pull/657#issuecomment-1058073565
Definitely see JIRA for my overall comments.
I want to point out that I observed that the "totalTime" metric has been a
nanosecond number in recent years, yet once upon a time
[
https://issues.apache.org/jira/browse/SOLR-14401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17500766#comment-17500766
]
David Smiley commented on SOLR-14401:
-
My proposed changes text is:
{quote} SOLR-1440
[
https://issues.apache.org/jira/browse/SOLR-16041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17500668#comment-17500668
]
Jan Høydahl commented on SOLR-16041:
The smoketester in Jenkins currently fails with
janhoy commented on pull request #694:
URL: https://github.com/apache/solr/pull/694#issuecomment-1057937807
> Question, when the release folder gets uploaded to svn, can we omit the
Dockerfile.official at that point? It doesn't particularly matter I guess, but
no real reason to include it
[
https://issues.apache.org/jira/browse/SOLR-16072?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jan Høydahl updated SOLR-16072:
---
Fix Version/s: 9.0
> Metrics: solr.jetty disappeared in 9
>
>
>
[
https://issues.apache.org/jira/browse/SOLR-16054?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jan Høydahl resolved SOLR-16054.
Fix Version/s: 9.0
Resolution: Fixed
> Environment banner not working if environment is not
[
https://issues.apache.org/jira/browse/SOLR-16054?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17500648#comment-17500648
]
ASF subversion and git services commented on SOLR-16054:
Commit b
[
https://issues.apache.org/jira/browse/SOLR-16054?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17500649#comment-17500649
]
ASF subversion and git services commented on SOLR-16054:
Commit 5
[
https://issues.apache.org/jira/browse/SOLR-16054?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17500637#comment-17500637
]
ASF subversion and git services commented on SOLR-16054:
Commit 0
janhoy merged pull request #701:
URL: https://github.com/apache/solr/pull/701
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@s
janhoy opened a new pull request #411:
URL: https://github.com/apache/solr-operator/pull/411
Add an annotation to our CRDs that will make ArgoCD replace instead of apply.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and us
[
https://issues.apache.org/jira/browse/SOLR-15111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17500593#comment-17500593
]
Andras Salamon commented on SOLR-15111:
---
Originally I was using JDK8 in the title t
janhoy commented on issue #410:
URL: https://github.com/apache/solr-operator/issues/410#issuecomment-1057803676
I tried this for an umbrella chart we use, manually adding this annotation
to all four CRDs. And it solved the issue, so I think this is the way to go.
If you manually "ref
62 matches
Mail list logo
