[GitHub] [solr] dsmiley commented on pull request #948: SOLR-15007: Adding ability to provide aggregated node level metrics for request handlers

2022-08-31 Thread GitBox
dsmiley commented on PR #948: URL: https://github.com/apache/solr/pull/948#issuecomment-1233735132 Looks like there was a markup / link error in the ref guide -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

[jira] [Created] (SOLR-16366) Avoid using XPath in SolrXmlConfig

2022-08-31 Thread Noble Paul (Jira)
Noble Paul created SOLR-16366: - Summary: Avoid using XPath in SolrXmlConfig Key: SOLR-16366 URL: https://issues.apache.org/jira/browse/SOLR-16366 Project: Solr Issue Type: Improvement Secur

[jira] [Resolved] (SOLR-16336) avoid fetching solrconfig.xml & schema.xml for already cached schema and config

2022-08-31 Thread Noble Paul (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16336?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Noble Paul resolved SOLR-16336. --- Fix Version/s: 9.1 Resolution: Fixed > avoid fetching solrconfig.xml & schema.xml for already

[jira] [Resolved] (SOLR-16337) metrics for Zk ops

2022-08-31 Thread Noble Paul (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16337?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Noble Paul resolved SOLR-16337. --- Fix Version/s: 9.1 Assignee: Noble Paul Resolution: Fixed > metrics for Zk ops >

[jira] [Commented] (SOLR-16336) avoid fetching solrconfig.xml & schema.xml for already cached schema and config

2022-08-31 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17598664#comment-17598664 ] ASF subversion and git services commented on SOLR-16336: Commit 6

[GitHub] [solr] dweiss commented on a diff in pull request #992: Allow skipping failure for RAT and Source Patterns

2022-08-31 Thread GitBox
dweiss commented on code in PR #992: URL: https://github.com/apache/solr/pull/992#discussion_r960013840 ## gradle/validation/rat-sources.gradle: ## @@ -274,8 +274,16 @@ class RatTask extends DefaultTask { } } if (errors) { -throw new Gr

[GitHub] [solr] madrob opened a new pull request, #992: Allow skipping failure for RAT and Source Patterns

2022-08-31 Thread GitBox
madrob opened a new pull request, #992: URL: https://github.com/apache/solr/pull/992 I'd like to be able to still run these checks and report on them, but also be able to prevent them from failing the build. Useful in CI environment where I will have the output and also want to make sure ot

[GitHub] [solr] epugh commented on a diff in pull request #975: Allow JAX-RS v2 API definition

2022-08-31 Thread GitBox
epugh commented on code in PR #975: URL: https://github.com/apache/solr/pull/975#discussion_r959893387 ## solr/core/src/java/org/apache/solr/api/V2HttpCall.java: ## @@ -397,7 +399,7 @@ protected void handleAdmin(SolrQueryResponse solrResp) { @Override protected void execut

[GitHub] [solr] dsmiley commented on a diff in pull request #990: SOLR-16362: Logs: Truncate field values in logs if a doc fails to index

2022-08-31 Thread GitBox
dsmiley commented on code in PR #990: URL: https://github.com/apache/solr/pull/990#discussion_r959850094 ## solr/core/src/java/org/apache/solr/update/DocumentBuilder.java: ## @@ -161,14 +162,21 @@ public static Document toDocument( && !sfield.multiValued()

[GitHub] [solr] epugh opened a new pull request, #991: Introduce a project inspection profile based on David Smiley's profile he uses.

2022-08-31 Thread GitBox
epugh opened a new pull request, #991: URL: https://github.com/apache/solr/pull/991 https://issues.apache.org/jira/browse/SOLR-16364 # Description Package with Solr a IntelliJ Inspection Profile to use. Tie it into the `gradlew idea` task to deploy it. # Solution

[GitHub] [solr] gerlowskija commented on a diff in pull request #975: Allow JAX-RS v2 API definition

2022-08-31 Thread GitBox
gerlowskija commented on code in PR #975: URL: https://github.com/apache/solr/pull/975#discussion_r959835650 ## solr/core/src/java/org/apache/solr/api/V2HttpCall.java: ## @@ -397,7 +399,7 @@ protected void handleAdmin(SolrQueryResponse solrResp) { @Override protected void

[jira] [Commented] (SOLR-16364) Evaluate using a shared Inspection Profile in IntelliJ

2022-08-31 Thread Eric Pugh (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16364?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17598512#comment-17598512 ] Eric Pugh commented on SOLR-16364: -- Here is what I get when running the default inspecti

[jira] [Updated] (SOLR-16364) Evaluate using a shared Inspection Profile in IntelliJ

2022-08-31 Thread Eric Pugh (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16364?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eric Pugh updated SOLR-16364: - Attachment: Screenshot at Aug 31 13-03-25.png > Evaluate using a shared Inspection Profile in IntelliJ >

[GitHub] [solr] epugh commented on a diff in pull request #975: Allow JAX-RS v2 API definition

2022-08-31 Thread GitBox
epugh commented on code in PR #975: URL: https://github.com/apache/solr/pull/975#discussion_r959821515 ## solr/core/src/java/org/apache/solr/jersey/PostRequestDecorationFilter.java: ## @@ -0,0 +1,56 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more +

[GitHub] [solr] janhoy commented on a diff in pull request #975: Allow JAX-RS v2 API definition

2022-08-31 Thread GitBox
janhoy commented on code in PR #975: URL: https://github.com/apache/solr/pull/975#discussion_r959818403 ## solr/core/src/java/org/apache/solr/handler/admin/api/SchemaNameAPI.java: ## @@ -46,7 +46,7 @@ public SchemaNameAPI(SolrCore solrCore) { } @GET - @Produces("applica

[GitHub] [solr] gerlowskija commented on a diff in pull request #975: Allow JAX-RS v2 API definition

2022-08-31 Thread GitBox
gerlowskija commented on code in PR #975: URL: https://github.com/apache/solr/pull/975#discussion_r959815458 ## solr/core/src/java/org/apache/solr/jersey/PostRequestDecorationFilter.java: ## @@ -0,0 +1,56 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or m

[GitHub] [solr] gerlowskija commented on a diff in pull request #975: Allow JAX-RS v2 API definition

2022-08-31 Thread GitBox
gerlowskija commented on code in PR #975: URL: https://github.com/apache/solr/pull/975#discussion_r959811323 ## solr/core/src/java/org/apache/solr/handler/admin/api/SchemaNameAPI.java: ## @@ -46,7 +46,7 @@ public SchemaNameAPI(SolrCore solrCore) { } @GET - @Produces("ap

[GitHub] [solr] gerlowskija commented on a diff in pull request #975: Allow JAX-RS v2 API definition

2022-08-31 Thread GitBox
gerlowskija commented on code in PR #975: URL: https://github.com/apache/solr/pull/975#discussion_r959808595 ## solr/core/src/java/org/apache/solr/core/PluginBag.java: ## @@ -27,8 +27,7 @@ import org.apache.solr.common.util.StrUtils; import org.apache.solr.handler.RequestHandl

[jira] [Updated] (SOLR-16364) Evaluate using a shared Inspection Profile in IntelliJ

2022-08-31 Thread Eric Pugh (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16364?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eric Pugh updated SOLR-16364: - Attachment: Screenshot at Aug 31 12-22-03.png > Evaluate using a shared Inspection Profile in IntelliJ >

[jira] [Updated] (SOLR-16364) Evaluate using a shared Inspection Profile in IntelliJ

2022-08-31 Thread Eric Pugh (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16364?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eric Pugh updated SOLR-16364: - Attachment: Gradle Default for Java test code.png > Evaluate using a shared Inspection Profile in Intelli

[GitHub] [solr] NazerkeBS commented on a diff in pull request #990: SOLR-16362: Truncate logs when they are too long

2022-08-31 Thread GitBox
NazerkeBS commented on code in PR #990: URL: https://github.com/apache/solr/pull/990#discussion_r959718504 ## solr/core/src/java/org/apache/solr/update/DocumentBuilder.java: ## @@ -161,14 +162,21 @@ public static Document toDocument( && !sfield.multiValued()

[GitHub] [solr] NazerkeBS commented on a diff in pull request #990: SOLR-16362: Truncate logs when they are too long

2022-08-31 Thread GitBox
NazerkeBS commented on code in PR #990: URL: https://github.com/apache/solr/pull/990#discussion_r959718504 ## solr/core/src/java/org/apache/solr/update/DocumentBuilder.java: ## @@ -161,14 +162,21 @@ public static Document toDocument( && !sfield.multiValued()

[jira] [Commented] (SOLR-16362) Truncate logs when they are too long

2022-08-31 Thread Nazerke Seidan (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17598442#comment-17598442 ] Nazerke Seidan commented on SOLR-16362: --- For example, Before: {code:java} ERROR: m

[jira] [Updated] (SOLR-16362) Logs: Truncate field values in logs if a doc fails to index

2022-08-31 Thread Nazerke Seidan (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16362?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nazerke Seidan updated SOLR-16362: -- Summary: Logs: Truncate field values in logs if a doc fails to index (was: Truncate logs when

[GitHub] [solr] danrosher commented on pull request #989: SOLR-16361 'mod' function query casts to float, returns wrong modulus for large ints

2022-08-31 Thread GitBox
danrosher commented on PR #989: URL: https://github.com/apache/solr/pull/989#issuecomment-1232980804 > Any chance of a unit test demonstrating the problem? It looks like all reasonable Java code, but it would help me see the unit test demonstrating the problem, and then the fix! Adde

[GitHub] [solr] sonatype-lift[bot] commented on a diff in pull request #987: SOLR-16336: avoid fetching solrconfig.xml & schema.xml for already cached schema and config

2022-08-31 Thread GitBox
sonatype-lift[bot] commented on code in PR #987: URL: https://github.com/apache/solr/pull/987#discussion_r959594973 ## solr/core/src/java/org/apache/solr/schema/ManagedIndexSchemaFactory.java: ## @@ -277,7 +277,7 @@ public ManagedIndexSchema create( managedSchemaR

[jira] [Commented] (SOLR-16336) avoid fetching solrconfig.xml & schema.xml for already cached schema and config

2022-08-31 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17598376#comment-17598376 ] ASF subversion and git services commented on SOLR-16336: Commit d

[GitHub] [solr] noblepaul merged pull request #987: SOLR-16336: avoid fetching solrconfig.xml & schema.xml for already cached schema and config

2022-08-31 Thread GitBox
noblepaul merged PR #987: URL: https://github.com/apache/solr/pull/987 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.or

[jira] [Created] (SOLR-16365) Add exporter "meta" metrics to grafana board

2022-08-31 Thread Jira
Jan Høydahl created SOLR-16365: -- Summary: Add exporter "meta" metrics to grafana board Key: SOLR-16365 URL: https://issues.apache.org/jira/browse/SOLR-16365 Project: Solr Issue Type: Improvement

[GitHub] [solr] madrob commented on a diff in pull request #965: SOLR-16328 : intern() strings in DocCollection to reduce memory footp…

2022-08-31 Thread GitBox
madrob commented on code in PR #965: URL: https://github.com/apache/solr/pull/965#discussion_r959491853 ## solr/core/src/java/org/apache/solr/core/CoreContainer.java: ## @@ -2424,6 +2430,34 @@ public PlacementPluginFactory getPlacementPlugi public void runAsync(Runnable r) {

[jira] [Updated] (SOLR-16364) Evaluate using a shared Inspection Profile in IntelliJ

2022-08-31 Thread Eric Pugh (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16364?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eric Pugh updated SOLR-16364: - Description: IntelliJ uses a "Inspection Profile" to decide what to flag as problems. It would be nice

[GitHub] [solr] janhoy commented on pull request #984: SOLR-16340 Provide a cluster_id label for all metrics exposed by the Solr Prometheus Exporter

2022-08-31 Thread GitBox
janhoy commented on PR #984: URL: https://github.com/apache/solr/pull/984#issuecomment-1232835455 Committed quoting of ClusterID in windows script, and resolved CHANGES conflict. Looking forward to final reviews. -- This is an automated message from the Apache Git Service. To respond to t

[jira] [Created] (SOLR-16364) Evaluate using a shared Inspection Profile in IntelliJ

2022-08-31 Thread Eric Pugh (Jira)
Eric Pugh created SOLR-16364: Summary: Evaluate using a shared Inspection Profile in IntelliJ Key: SOLR-16364 URL: https://issues.apache.org/jira/browse/SOLR-16364 Project: Solr Issue Type: Sub-t

[GitHub] [solr] epugh commented on pull request #947: SOLR-16300: migrate assert to non deprecated version

2022-08-31 Thread GitBox
epugh commented on PR #947: URL: https://github.com/apache/solr/pull/947#issuecomment-1232831100 I've fixed the merge conflict, so I'd like to merge this PR this week, so then I can move on to the new plan of fixing the unit test warnings package by package instead of type by type. --

[GitHub] [solr] epugh commented on pull request #989: SOLR-16361 'mod' function query casts to float, returns wrong modulus for large ints

2022-08-31 Thread GitBox
epugh commented on PR #989: URL: https://github.com/apache/solr/pull/989#issuecomment-1232825533 Any chance of a unit test demonstrating the problem? It looks like all reasonable Java code, but it would help me see the unit test demonstrating the problem, and then the fix! -- This is a