gerlowskija commented on PR #975:
URL: https://github.com/apache/solr/pull/975#issuecomment-1241402958
Alright, tests and precommit passing, and I _think_ I've addressed
everyone's comments, excepting a few that I asked for more info/clarification
on? Feels like this is getting close 🎉
janhoy commented on code in PR #890:
URL: https://github.com/apache/solr/pull/890#discussion_r966500640
##
solr/modules/jwt-auth/src/java/org/apache/solr/security/jwt/JWTAuthPlugin.java:
##
@@ -598,12 +598,26 @@ protected JWTAuthenticationResponse authenticate(String
authorizat
janhoy commented on code in PR #890:
URL: https://github.com/apache/solr/pull/890#discussion_r966499940
##
solr/modules/jwt-auth/src/java/org/apache/solr/security/jwt/JWTAuthPlugin.java:
##
@@ -598,12 +598,26 @@ protected JWTAuthenticationResponse authenticate(String
authorizat
sonatype-lift[bot] commented on code in PR #975:
URL: https://github.com/apache/solr/pull/975#discussion_r966312263
##
solr/solrj/src/java/org/apache/solr/client/solrj/ResponseParser.java:
##
@@ -34,11 +37,22 @@ public abstract class ResponseParser {
* A well behaved Respons
gerlowskija commented on code in PR #975:
URL: https://github.com/apache/solr/pull/975#discussion_r966259877
##
solr/core/src/java/org/apache/solr/jersey/SolrJerseyResponse.java:
##
@@ -0,0 +1,46 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * c
epugh commented on PR #975:
URL: https://github.com/apache/solr/pull/975#issuecomment-1241042225
> Found a buried question from @dsmiley that I'd failed to answer:
>
> > do you think your work here might be better characterized as a V3 API
rather than changing V2? Of course we agreed
gerlowskija commented on code in PR #975:
URL: https://github.com/apache/solr/pull/975#discussion_r966177196
##
solr/core/src/java/org/apache/solr/jersey/MessageBodyWriters.java:
##
@@ -0,0 +1,133 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ *
gerlowskija commented on code in PR #975:
URL: https://github.com/apache/solr/pull/975#discussion_r966176044
##
solr/core/src/java/org/apache/solr/core/PluginBag.java:
##
@@ -213,6 +237,24 @@ public PluginHolder put(String name, PluginHolder
plugin) {
apiBag.re
risdenk commented on PR #1001:
URL: https://github.com/apache/solr/pull/1001#issuecomment-1240923591
So in commit 02cecd6731874465537e5b688cfcf1d0e60f5503, I finally found a
log2m value that gives some accurate enough results for testing. I am beasting
this test to make sure all is good.
gerlowskija commented on PR #975:
URL: https://github.com/apache/solr/pull/975#issuecomment-1240915352
Found a buried question from @dsmiley that I'd failed to answer:
> do you think your work here might be better characterized as a V3 API
rather than changing V2? Of course we agreed
gerlowskija commented on code in PR #975:
URL: https://github.com/apache/solr/pull/975#discussion_r966121020
##
solr/core/src/java/org/apache/solr/handler/admin/api/SchemaNameAPI.java:
##
@@ -46,7 +46,7 @@ public SchemaNameAPI(SolrCore solrCore) {
}
@GET
- @Produces("ap
col-panic commented on code in PR #890:
URL: https://github.com/apache/solr/pull/890#discussion_r966054109
##
solr/modules/jwt-auth/src/java/org/apache/solr/security/jwt/JWTAuthPlugin.java:
##
@@ -598,12 +598,26 @@ protected JWTAuthenticationResponse authenticate(String
authori
gerlowskija commented on code in PR #975:
URL: https://github.com/apache/solr/pull/975#discussion_r966044159
##
solr/core/src/java/org/apache/solr/handler/admin/api/SchemaNameAPI.java:
##
@@ -46,7 +46,7 @@ public SchemaNameAPI(SolrCore solrCore) {
}
@GET
- @Produces("ap
janhoy commented on code in PR #890:
URL: https://github.com/apache/solr/pull/890#discussion_r966038450
##
solr/modules/jwt-auth/src/java/org/apache/solr/security/jwt/JWTAuthPlugin.java:
##
@@ -598,12 +598,26 @@ protected JWTAuthenticationResponse authenticate(String
authorizat
janhoy commented on code in PR #890:
URL: https://github.com/apache/solr/pull/890#discussion_r966038450
##
solr/modules/jwt-auth/src/java/org/apache/solr/security/jwt/JWTAuthPlugin.java:
##
@@ -598,12 +598,26 @@ protected JWTAuthenticationResponse authenticate(String
authorizat
janhoy commented on code in PR #890:
URL: https://github.com/apache/solr/pull/890#discussion_r966031952
##
solr/modules/jwt-auth/src/java/org/apache/solr/security/jwt/JWTAuthPlugin.java:
##
@@ -595,12 +595,26 @@ protected JWTAuthenticationResponse authenticate(String
authorizat
gerlowskija commented on code in PR #975:
URL: https://github.com/apache/solr/pull/975#discussion_r966024055
##
solr/core/src/java/org/apache/solr/handler/api/V2ApiUtils.java:
##
@@ -40,4 +44,41 @@ public static void flattenToCommaDelimitedString(
final String flattenedStr
gerlowskija commented on code in PR #975:
URL: https://github.com/apache/solr/pull/975#discussion_r966015071
##
solr/core/src/java/org/apache/solr/api/V2HttpCall.java:
##
@@ -273,7 +278,7 @@ public static Api getApiInfo(
}
if (api == null) {
- return getSubPathA
gerlowskija commented on code in PR #975:
URL: https://github.com/apache/solr/pull/975#discussion_r966010573
##
solr/core/src/java/org/apache/solr/api/V2HttpCall.java:
##
@@ -388,33 +335,65 @@ public CompositeApi add(Api api) {
}
}
+ // We don't rely on any of Jersey'
dsmiley commented on code in PR #975:
URL: https://github.com/apache/solr/pull/975#discussion_r965992444
##
solr/core/src/java/org/apache/solr/jersey/SolrJerseyResponse.java:
##
@@ -0,0 +1,46 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contr
dsmiley commented on code in PR #975:
URL: https://github.com/apache/solr/pull/975#discussion_r965990273
##
solr/core/src/java/org/apache/solr/jersey/SolrJerseyResponse.java:
##
@@ -0,0 +1,46 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contr
dsmiley commented on code in PR #975:
URL: https://github.com/apache/solr/pull/975#discussion_r965987977
##
solr/core/src/test/org/apache/solr/handler/configsets/ListConfigSetsAPITest.java:
##
@@ -0,0 +1,139 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one o
gerlowskija commented on code in PR #975:
URL: https://github.com/apache/solr/pull/975#discussion_r965970532
##
solr/core/src/java/org/apache/solr/jersey/SolrJerseyResponse.java:
##
@@ -0,0 +1,46 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * c
gerlowskija commented on code in PR #975:
URL: https://github.com/apache/solr/pull/975#discussion_r965949607
##
solr/core/src/test/org/apache/solr/handler/configsets/ListConfigSetsAPITest.java:
##
@@ -0,0 +1,139 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under o
gerlowskija commented on code in PR #975:
URL: https://github.com/apache/solr/pull/975#discussion_r965936792
##
solr/core/src/java/org/apache/solr/jersey/CatchAllExceptionMapper.java:
##
@@ -93,10 +98,12 @@ public Response toResponse(Exception exception) {
RequestHandlerB
25 matches
Mail list logo
