[jira] [Commented] (SOLR-15342) Separate out a SolrJ-Zookeeper module

2022-09-22 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17608536#comment-17608536 ] ASF subversion and git services commented on SOLR-15342: Commit 3

[GitHub] [solr-sandbox] anshumg merged pull request #43: Allow empty string for config property values.

2022-09-22 Thread GitBox
anshumg merged PR #43: URL: https://github.com/apache/solr-sandbox/pull/43 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apach

[jira] [Commented] (SOLR-16414) Race condition in PRS state updates

2022-09-22 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17608461#comment-17608461 ] ASF subversion and git services commented on SOLR-16414: Commit 5

[GitHub] [solr] epugh commented on pull request #1039: SOLR-16427: Evaluate and fix errorprone rules - part 2

2022-09-22 Thread GitBox
epugh commented on PR #1039: URL: https://github.com/apache/solr/pull/1039#issuecomment-1255680211 I've looked at about half the changes... It all *seems* good... I'm going to try and run the tests before I head to bed on this branch... -- This is an automated message from the Apache G

[GitHub] [solr] epugh commented on a diff in pull request #1039: SOLR-16427: Evaluate and fix errorprone rules - part 2

2022-09-22 Thread GitBox
epugh commented on code in PR #1039: URL: https://github.com/apache/solr/pull/1039#discussion_r978178058 ## solr/core/src/java/org/apache/solr/packagemanager/RepositoryManager.java: ## @@ -71,15 +71,16 @@ public RepositoryManager(HttpSolrClient solrClient, PackageManager packag

[GitHub] [solr] risdenk commented on a diff in pull request #1039: SOLR-16427: Evaluate and fix errorprone rules - part 2

2022-09-22 Thread GitBox
risdenk commented on code in PR #1039: URL: https://github.com/apache/solr/pull/1039#discussion_r978171652 ## gradle/validation/error-prone.gradle: ## @@ -74,17 +74,14 @@ allprojects { prj -> '-Xep:StaticAssignmentInConstructor:OFF', // we assign SolrTestCaseJ4.con

[GitHub] [solr-operator] endzyme commented on issue #475: Backups via S3 using Web Identity Tokens not working

2022-09-22 Thread GitBox
endzyme commented on issue #475: URL: https://github.com/apache/solr-operator/issues/475#issuecomment-1255651376 Thanks @joshsouza!! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

[GitHub] [solr-operator] joshsouza commented on issue #475: Backups via S3 using Web Identity Tokens not working

2022-09-22 Thread GitBox
joshsouza commented on issue #475: URL: https://github.com/apache/solr-operator/issues/475#issuecomment-1255636822 I have confirmed this by adding the following to the helm values (which propagate to the SolrCloud CRD): ``` podOptions: initContainers: - name: "add-sts"

[GitHub] [solr] dsmiley commented on a diff in pull request #1004: SOLR-16404: Use newer clients in the Prometheus Exporter

2022-09-22 Thread GitBox
dsmiley commented on code in PR #1004: URL: https://github.com/apache/solr/pull/1004#discussion_r978131765 ## solr/CHANGES.txt: ## @@ -89,6 +89,8 @@ Improvements * SOLR-16361: mod() is now accurate for all integers, floats, doubles and longs upto 2^52 (Dan Rosher via Eric Pu

[GitHub] [solr] epugh commented on a diff in pull request #1039: SOLR-16427: Evaluate and fix errorprone rules - part 2

2022-09-22 Thread GitBox
epugh commented on code in PR #1039: URL: https://github.com/apache/solr/pull/1039#discussion_r978126733 ## gradle/validation/error-prone.gradle: ## @@ -74,17 +74,14 @@ allprojects { prj -> '-Xep:StaticAssignmentInConstructor:OFF', // we assign SolrTestCaseJ4.confi

[GitHub] [solr] epugh commented on a diff in pull request #1039: SOLR-16427: Evaluate and fix errorprone rules - part 2

2022-09-22 Thread GitBox
epugh commented on code in PR #1039: URL: https://github.com/apache/solr/pull/1039#discussion_r978126229 ## solr/benchmark/src/java/org/apache/solr/bench/generators/Lists.java: ## @@ -32,17 +31,13 @@ public final class Lists { private Lists() {} static Gen> listsOf(Gen

[GitHub] [solr-operator] joshsouza commented on issue #475: Backups via S3 using Web Identity Tokens not working

2022-09-22 Thread GitBox
joshsouza commented on issue #475: URL: https://github.com/apache/solr-operator/issues/475#issuecomment-1255599619 As far as I can tell, the `sts` module isn't included in the `s3-repository` contrib module: https://repo1.maven.org/maven2/org/apache/solr/solr-s3-repository/8.11.2/solr-s3

[GitHub] [solr] dsmiley commented on a diff in pull request #1027: Add logs and comments to split workflow

2022-09-22 Thread GitBox
dsmiley commented on code in PR #1027: URL: https://github.com/apache/solr/pull/1027#discussion_r978101253 ## solr/core/src/java/org/apache/solr/handler/admin/SplitOp.java: ## @@ -189,6 +205,7 @@ public void execute(CoreAdminHandler.CallInfo it) throws Exception { parent

[GitHub] [solr] janhoy commented on a diff in pull request #1038: document the various code quality tools in our Developer FAQ

2022-09-22 Thread GitBox
janhoy commented on code in PR #1038: URL: https://github.com/apache/solr/pull/1038#discussion_r978096690 ## dev-docs/FAQ.adoc: ## @@ -51,3 +51,36 @@ Run `gradle dev`, and then `cd ./packaging/build/dev/`. Fire up your cluster via `bin/solr start -e cloud -noprompt` and then

[GitHub] [solr] sonatype-lift[bot] commented on a diff in pull request #1040: SOLR-16428: Add "permissive" mode to IgnoreLargeDocumentsProcessorFactory

2022-09-22 Thread GitBox
sonatype-lift[bot] commented on code in PR #1040: URL: https://github.com/apache/solr/pull/1040#discussion_r978094487 ## solr/core/src/java/org/apache/solr/update/processor/IgnoreLargeDocumentProcessorFactory.java: ## @@ -41,14 +46,21 @@ */ public class IgnoreLargeDocumentPro

[GitHub] [solr] dsmiley commented on pull request #977: Add shard-split.adoc

2022-09-22 Thread GitBox
dsmiley commented on PR #977: URL: https://github.com/apache/solr/pull/977#issuecomment-1255546072 Awesome docs Nazerke! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [solr] dsmiley merged pull request #977: Add shard-split.adoc

2022-09-22 Thread GitBox
dsmiley merged PR #977: URL: https://github.com/apache/solr/pull/977 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

[jira] [Commented] (SOLR-16428) IgnoreLargeDocumentsProcessorFactory should have a "permissive" mode

2022-09-22 Thread Jason Gerlowski (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16428?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17608409#comment-17608409 ] Jason Gerlowski commented on SOLR-16428: I've opened up a new PR for this [here|

[GitHub] [solr] gerlowskija opened a new pull request, #1040: SOLR-16428: Add "permissive" mode to IgnoreLargeDocumentsProcessorFactory

2022-09-22 Thread GitBox
gerlowskija opened a new pull request, #1040: URL: https://github.com/apache/solr/pull/1040 # Description IgnoreLargeDocumentProcessorFactory only has a single way to handle documents that exceed its configurable size limit. The first violation throws a SolrException: in effect, shor

[jira] [Created] (SOLR-16428) IgnoreLargeDocumentsProcessorFactory should have a "permissive" mode

2022-09-22 Thread Jason Gerlowski (Jira)
Jason Gerlowski created SOLR-16428: -- Summary: IgnoreLargeDocumentsProcessorFactory should have a "permissive" mode Key: SOLR-16428 URL: https://issues.apache.org/jira/browse/SOLR-16428 Project: Solr

[jira] [Commented] (SOLR-16427) Evaluate and fix errorprone rules

2022-09-22 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16427?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17608397#comment-17608397 ] ASF subversion and git services commented on SOLR-16427: Commit 8

[GitHub] [solr] risdenk merged pull request #1037: SOLR-16427: Evaluate and fix errorprone rules

2022-09-22 Thread GitBox
risdenk merged PR #1037: URL: https://github.com/apache/solr/pull/1037 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.or

[GitHub] [solr] risdenk opened a new pull request, #1039: SOLR-16427: Evaluate and fix errorprone rules - part 2

2022-09-22 Thread GitBox
risdenk opened a new pull request, #1039: URL: https://github.com/apache/solr/pull/1039 https://issues.apache.org/jira/browse/SOLR-16427 Builds on https://github.com/apache/solr/pull/1037 Enables the following errorprone rules: * Most of the fixes are straight forward

[GitHub] [solr] HoustonPutman commented on a diff in pull request #1004: SOLR-16404: Use newer clients in the Prometheus Exporter

2022-09-22 Thread GitBox
HoustonPutman commented on code in PR #1004: URL: https://github.com/apache/solr/pull/1004#discussion_r978011734 ## solr/prometheus-exporter/build.gradle: ## @@ -22,6 +22,7 @@ description = 'Prometheus exporter for exposing metrics from Solr using Metrics dependencies { i

[GitHub] [solr] HoustonPutman commented on a diff in pull request #1004: SOLR-16404: Use newer clients in the Prometheus Exporter

2022-09-22 Thread GitBox
HoustonPutman commented on code in PR #1004: URL: https://github.com/apache/solr/pull/1004#discussion_r978011019 ## solr/prometheus-exporter/build.gradle: ## @@ -22,6 +22,7 @@ description = 'Prometheus exporter for exposing metrics from Solr using Metrics dependencies { i

[GitHub] [solr] risdenk commented on a diff in pull request #1004: SOLR-16404: Use newer clients in the Prometheus Exporter

2022-09-22 Thread GitBox
risdenk commented on code in PR #1004: URL: https://github.com/apache/solr/pull/1004#discussion_r978003746 ## solr/prometheus-exporter/build.gradle: ## @@ -22,6 +22,7 @@ description = 'Prometheus exporter for exposing metrics from Solr using Metrics dependencies { impleme

[GitHub] [solr] HoustonPutman commented on pull request #1004: SOLR-16404: Use newer clients in the Prometheus Exporter

2022-09-22 Thread GitBox
HoustonPutman commented on PR #1004: URL: https://github.com/apache/solr/pull/1004#issuecomment-1255434177 @dsmiley Only prometheus exporter code is touched now -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

[jira] [Resolved] (SOLR-16426) LBHttp2SolrClient does not pass various component changes to child client

2022-09-22 Thread Houston Putman (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16426?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Houston Putman resolved SOLR-16426. --- Resolution: Fixed > LBHttp2SolrClient does not pass various component changes to child client

[jira] [Commented] (SOLR-16416) Fix silently failing Overseer Election joinAtHead during testDesignatedOverseerRestarts

2022-09-22 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17608380#comment-17608380 ] ASF subversion and git services commented on SOLR-16416: Commit f

[jira] [Commented] (SOLR-16426) LBHttp2SolrClient does not pass various component changes to child client

2022-09-22 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16426?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17608378#comment-17608378 ] ASF subversion and git services commented on SOLR-16426: Commit 4

[jira] [Commented] (SOLR-16426) LBHttp2SolrClient does not pass various component changes to child client

2022-09-22 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16426?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17608376#comment-17608376 ] ASF subversion and git services commented on SOLR-16426: Commit f

[GitHub] [solr] HoustonPutman merged pull request #1036: SOLR-16426: LBHttp2SolrClient now passes info to child client.

2022-09-22 Thread GitBox
HoustonPutman merged PR #1036: URL: https://github.com/apache/solr/pull/1036 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apa

[jira] [Updated] (SOLR-11865) Refactor QueryElevationComponent to prepare query subset matching

2022-09-22 Thread Drew Foulks (Jira)
[ https://issues.apache.org/jira/browse/SOLR-11865?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Drew Foulks updated SOLR-11865: --- Reporter: Bruno Roustant (was: Bruno Roustant) > Refactor QueryElevationComponent to prepare query s

[jira] [Updated] (SOLR-11866) Support efficient subset matching in query elevation rules

2022-09-22 Thread Drew Foulks (Jira)
[ https://issues.apache.org/jira/browse/SOLR-11866?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Drew Foulks updated SOLR-11866: --- Reporter: Bruno Roustant (was: Bruno Roustant) > Support efficient subset matching in query elevatio

[GitHub] [solr] risdenk commented on a diff in pull request #1038: document the various code quality tools in our Developer FAQ

2022-09-22 Thread GitBox
risdenk commented on code in PR #1038: URL: https://github.com/apache/solr/pull/1038#discussion_r977924695 ## dev-docs/FAQ.adoc: ## @@ -51,3 +51,36 @@ Run `gradle dev`, and then `cd ./packaging/build/dev/`. Fire up your cluster via `bin/solr start -e cloud -noprompt` and then

[GitHub] [solr] epugh opened a new pull request, #1038: document the various code quality tools in our Developer FAQ

2022-09-22 Thread GitBox
epugh opened a new pull request, #1038: URL: https://github.com/apache/solr/pull/1038 https://issues.apache.org/jira/browse/SOLR-X # Description there has been some great work around code quality recently, and I realized that I don't really know what all the tools are that

[jira] [Commented] (SOLR-16414) Race condition in PRS state updates

2022-09-22 Thread Chris M. Hostetter (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17608359#comment-17608359 ] Chris M. Hostetter commented on SOLR-16414: --- It looks like the NPE fix was only

[jira] [Reopened] (SOLR-16414) Race condition in PRS state updates

2022-09-22 Thread Chris M. Hostetter (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16414?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris M. Hostetter reopened SOLR-16414: --- Assignee: Noble Paul > Race condition in PRS state updates > --

[jira] [Commented] (SOLR-16427) Evaluate and fix errorprone rules

2022-09-22 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16427?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17608293#comment-17608293 ] Kevin Risden commented on SOLR-16427: - A start PR - https://github.com/apache/solr/pu

[jira] [Updated] (SOLR-16427) Evaluate and fix errorprone rules

2022-09-22 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16427?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Risden updated SOLR-16427: Status: Patch Available (was: Open) > Evaluate and fix errorprone rules >

[jira] [Created] (SOLR-16427) Evaluate and fix errorprone rules

2022-09-22 Thread Kevin Risden (Jira)
Kevin Risden created SOLR-16427: --- Summary: Evaluate and fix errorprone rules Key: SOLR-16427 URL: https://issues.apache.org/jira/browse/SOLR-16427 Project: Solr Issue Type: Task Security

[GitHub] [solr-operator] sudheerjamjam opened a new issue, #478: Reg: Solr No Space Left Issue

2022-09-22 Thread GitBox
sudheerjamjam opened a new issue, #478: URL: https://github.com/apache/solr-operator/issues/478 We have solr master-slave configuration and we were seeing No Space Left on device errors for Master Node which on kubernetes and when dig into the pod we have seen lot of space available for

[jira] [Assigned] (SOLR-13968) Support postingsFormat and docValuesFormat in schema fields

2022-09-22 Thread Drew Foulks (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13968?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Drew Foulks reassigned SOLR-13968: -- Assignee: Bruno Roustant (was: Bruno Roustant) > Support postingsFormat and docValuesFormat i

[jira] [Updated] (SOLR-13968) Support postingsFormat and docValuesFormat in schema fields

2022-09-22 Thread Drew Foulks (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13968?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Drew Foulks updated SOLR-13968: --- Reporter: Bruno Roustant (was: Bruno Roustant) > Support postingsFormat and docValuesFormat in schem

[jira] [Commented] (SOLR-16364) Evaluate using a shared Inspection Profile in IntelliJ

2022-09-22 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16364?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17608287#comment-17608287 ] Kevin Risden commented on SOLR-16364: - ecj can also help out here. ecj is already che

[GitHub] [solr] risdenk commented on a diff in pull request #1037: enable more errorprone rules and fix those things that fail

2022-09-22 Thread GitBox
risdenk commented on code in PR #1037: URL: https://github.com/apache/solr/pull/1037#discussion_r977694512 ## solr/core/src/test/org/apache/solr/update/processor/ParsingFieldUpdateProcessorsTest.java: ## @@ -819,7 +819,7 @@ public void testFailedParseMixedBoolean() throws Except

[GitHub] [solr] risdenk commented on a diff in pull request #1037: enable more errorprone rules and fix those things that fail

2022-09-22 Thread GitBox
risdenk commented on code in PR #1037: URL: https://github.com/apache/solr/pull/1037#discussion_r977693703 ## solr/core/src/test/org/apache/solr/cloud/TestStressInPlaceUpdates.java: ## @@ -485,7 +485,7 @@ public void run() { } else { fail(

[GitHub] [solr] risdenk commented on a diff in pull request #1037: enable more errorprone rules and fix those things that fail

2022-09-22 Thread GitBox
risdenk commented on code in PR #1037: URL: https://github.com/apache/solr/pull/1037#discussion_r977692979 ## solr/core/src/test/org/apache/solr/update/processor/FieldMutatingUpdateProcessorTest.java: ## @@ -104,14 +104,14 @@ public void testUniqValues() throws Exception {

[jira] [Commented] (SOLR-15730) Modularize SolrJ

2022-09-22 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17608255#comment-17608255 ] ASF subversion and git services commented on SOLR-15730: Commit c

[GitHub] [solr] dsmiley merged pull request #1021: SOLR-15730: Document SolrJ opt-in for 10x

2022-09-22 Thread GitBox
dsmiley merged PR #1021: URL: https://github.com/apache/solr/pull/1021 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.or

[jira] [Commented] (SOLR-16364) Evaluate using a shared Inspection Profile in IntelliJ

2022-09-22 Thread Eric Pugh (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16364?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17608239#comment-17608239 ] Eric Pugh commented on SOLR-16364: -- [~krisden] seeing the work you did on https://github

[GitHub] [solr] epugh commented on pull request #1037: enable more errorprone rules and fix those things that fail

2022-09-22 Thread GitBox
epugh commented on PR #1037: URL: https://github.com/apache/solr/pull/1037#issuecomment-1254931190 I'm hoping to rerun the warnings report from IntelliJ with a before and after this PR, as I suspect these fixes will directly impact those warnings! I love how you are enabling errorprone f

[GitHub] [solr] epugh commented on a diff in pull request #1037: enable more errorprone rules and fix those things that fail

2022-09-22 Thread GitBox
epugh commented on code in PR #1037: URL: https://github.com/apache/solr/pull/1037#discussion_r977566523 ## solr/core/src/test/org/apache/solr/update/processor/ParsingFieldUpdateProcessorsTest.java: ## @@ -819,7 +819,7 @@ public void testFailedParseMixedBoolean() throws Exceptio

[GitHub] [solr] epugh commented on a diff in pull request #1037: enable more errorprone rules and fix those things that fail

2022-09-22 Thread GitBox
epugh commented on code in PR #1037: URL: https://github.com/apache/solr/pull/1037#discussion_r977499035 ## solr/core/src/test/org/apache/solr/update/processor/FieldMutatingUpdateProcessorTest.java: ## @@ -104,14 +104,14 @@ public void testUniqValues() throws Exception {

[GitHub] [solr] epugh commented on a diff in pull request #1037: enable more errorprone rules and fix those things that fail

2022-09-22 Thread GitBox
epugh commented on code in PR #1037: URL: https://github.com/apache/solr/pull/1037#discussion_r977492822 ## solr/core/src/test/org/apache/solr/cloud/TestStressInPlaceUpdates.java: ## @@ -485,7 +485,7 @@ public void run() { } else { fail(