[GitHub] [solr] sonatype-lift[bot] commented on pull request #1057: SOLR-16451 PRS: Don't fetch the prs state, while registering the collection watch

2022-10-08 Thread GitBox
sonatype-lift[bot] commented on PR #1057: URL: https://github.com/apache/solr/pull/1057#issuecomment-1272466030 :warning: **314 God Classes** were detected by Lift in this project. [Visit the Lift web console](https://lift.sonatype.com/results/github.com/apache/solr/01GEXK7BNCWDJF5FSVVAEKR3

[jira] [Commented] (SOLR-16347) Add JAX-RS integration for defining v2 APIs

2022-10-08 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16347?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17614597#comment-17614597 ] David Smiley commented on SOLR-16347: - I want to add that future JIRA issues to *use*

[GitHub] [solr] dsmiley commented on a diff in pull request #1012: SOLR-16368: Use SolrClient type instead of overly specific subclasses

2022-10-08 Thread GitBox
dsmiley commented on code in PR #1012: URL: https://github.com/apache/solr/pull/1012#discussion_r990734673 ## solr/core/src/test/org/apache/solr/filestore/TestDistribPackageStore.java: ## @@ -192,10 +192,10 @@ public static void checkAllNodesForFile( assertResponseValues(

[GitHub] [solr] dsmiley commented on a diff in pull request #1012: SOLR-16368: Use SolrClient type instead of overly specific subclasses

2022-10-08 Thread GitBox
dsmiley commented on code in PR #1012: URL: https://github.com/apache/solr/pull/1012#discussion_r990734533 ## solr/core/src/test/org/apache/solr/cloud/DistributedVersionInfoTest.java: ## @@ -58,7 +56,7 @@ import org.slf4j.Logger; import org.slf4j.LoggerFactory; -@LuceneTestC

[GitHub] [solr] dsmiley commented on a diff in pull request #1012: SOLR-16368: Use SolrClient type instead of overly specific subclasses

2022-10-08 Thread GitBox
dsmiley commented on code in PR #1012: URL: https://github.com/apache/solr/pull/1012#discussion_r990733430 ## solr/core/src/java/org/apache/solr/packagemanager/RepositoryManager.java: ## @@ -141,7 +141,7 @@ public void addKey(byte[] key, String destinationKeyFilename) throws Ex

[jira] [Commented] (SOLR-8803) OOM killer for Windows

2022-10-08 Thread Shawn Heisey (Jira)
[ https://issues.apache.org/jira/browse/SOLR-8803?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17614588#comment-17614588 ] Shawn Heisey commented on SOLR-8803: ./gradlew check disagrees with me that it's ready

[jira] [Updated] (SOLR-8803) OOM killer for Windows

2022-10-08 Thread Shawn Heisey (Jira)
[ https://issues.apache.org/jira/browse/SOLR-8803?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shawn Heisey updated SOLR-8803: --- Attachment: SOLR-8803-2.patch Status: Open (was: Open) Figured out how to allow getting the p

[jira] [Commented] (SOLR-9168) Add availability to specify own oom handing script

2022-10-08 Thread Shawn Heisey (Jira)
[ https://issues.apache.org/jira/browse/SOLR-9168?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17614583#comment-17614583 ] Shawn Heisey commented on SOLR-9168: I will tackle the new OOME handling in SOLR-8803.

[jira] [Updated] (SOLR-8803) OOM killer for Windows

2022-10-08 Thread Shawn Heisey (Jira)
[ https://issues.apache.org/jira/browse/SOLR-8803?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shawn Heisey updated SOLR-8803: --- Attachment: SOLR-8803-1.patch Status: Open (was: Open) New patch that logs the exception clas

[jira] [Updated] (SOLR-8803) OOM killer for Windows

2022-10-08 Thread Shawn Heisey (Jira)
[ https://issues.apache.org/jira/browse/SOLR-8803?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shawn Heisey updated SOLR-8803: --- Attachment: SOLR-8803.patch Fix Version/s: 9.2 Affects Version/s: 9.0

[jira] [Updated] (SOLR-8803) OOM killer for Windows

2022-10-08 Thread Shawn Heisey (Jira)
[ https://issues.apache.org/jira/browse/SOLR-8803?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shawn Heisey updated SOLR-8803: --- Attachment: (was: SOLR-8803.patch) > OOM killer for Windows > -- > >

[jira] [Commented] (SOLR-8803) OOM killer for Windows

2022-10-08 Thread Shawn Heisey (Jira)
[ https://issues.apache.org/jira/browse/SOLR-8803?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17614574#comment-17614574 ] Shawn Heisey commented on SOLR-8803: Needs to be done before SOLR-9168. > OOM killer

[jira] [Assigned] (SOLR-8803) OOM killer for Windows

2022-10-08 Thread Shawn Heisey (Jira)
[ https://issues.apache.org/jira/browse/SOLR-8803?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shawn Heisey reassigned SOLR-8803: -- Assignee: Shawn Heisey > OOM killer for Windows > -- > > Ke

[jira] [Updated] (SOLR-9168) Add availability to specify own oom handing script

2022-10-08 Thread Shawn Heisey (Jira)
[ https://issues.apache.org/jira/browse/SOLR-9168?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shawn Heisey updated SOLR-9168: --- Attachment: SOLR-9168-3.patch Status: Open (was: Open) Another new patch.  This one traps and

[jira] [Updated] (SOLR-9168) Add availability to specify own oom handing script

2022-10-08 Thread Shawn Heisey (Jira)
[ https://issues.apache.org/jira/browse/SOLR-9168?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shawn Heisey updated SOLR-9168: --- Attachment: SOLR-9168-2.patch Status: Open (was: Open) Another new patch.  This one tries to

[jira] [Updated] (SOLR-9168) Add availability to specify own oom handing script

2022-10-08 Thread Shawn Heisey (Jira)
[ https://issues.apache.org/jira/browse/SOLR-9168?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shawn Heisey updated SOLR-9168: --- Fix Version/s: 9.2 (was: 9.1) > Add availability to specify own oom handing scr

[jira] [Updated] (SOLR-9168) Add availability to specify own oom handing script

2022-10-08 Thread Shawn Heisey (Jira)
[ https://issues.apache.org/jira/browse/SOLR-9168?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shawn Heisey updated SOLR-9168: --- Attachment: SOLR-9168-1.patch Status: Open (was: Open) New patch to enable crashing on OOME f

[jira] [Commented] (SOLR-9168) Add availability to specify own oom handing script

2022-10-08 Thread Shawn Heisey (Jira)
[ https://issues.apache.org/jira/browse/SOLR-9168?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17614549#comment-17614549 ] Shawn Heisey commented on SOLR-9168: Before tackling using a user-supplied script, I w

[GitHub] [solr] sonatype-lift[bot] commented on pull request #1012: SOLR-16368: Use SolrClient type instead of overly specific subclasses

2022-10-08 Thread GitBox
sonatype-lift[bot] commented on PR #1012: URL: https://github.com/apache/solr/pull/1012#issuecomment-1272388321 :warning: **311 God Classes** were detected by Lift in this project. [Visit the Lift web console](https://lift.sonatype.com/results/github.com/apache/solr/01GEWG4Z93QY9SG23PNWW42F

[GitHub] [solr] sonatype-lift[bot] commented on a diff in pull request #1012: SOLR-16368: Use SolrClient type instead of overly specific subclasses

2022-10-08 Thread GitBox
sonatype-lift[bot] commented on code in PR #1012: URL: https://github.com/apache/solr/pull/1012#discussion_r990689438 ## solr/core/src/java/org/apache/solr/packagemanager/RepositoryManager.java: ## @@ -141,7 +141,7 @@ public void addKey(byte[] key, String destinationKeyFilename