[jira] [Reopened] (SOLR-8803) OOM killer for Windows

2022-12-30 Thread Shawn Heisey (Jira)
[ https://issues.apache.org/jira/browse/SOLR-8803?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shawn Heisey reopened SOLR-8803: Need to edit the docs for this and figure out where the OOM env variable gets used for the docker image

[jira] [Updated] (SOLR-8803) Generalize OOME handling to work for any OS

2022-12-30 Thread Shawn Heisey (Jira)
[ https://issues.apache.org/jira/browse/SOLR-8803?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shawn Heisey updated SOLR-8803: --- Summary: Generalize OOME handling to work for any OS (was: OOM killer for Windows) > Generalize OOME

[jira] [Commented] (SOLR-8803) OOM killer for Windows

2022-12-30 Thread Shawn Heisey (Jira)
[ https://issues.apache.org/jira/browse/SOLR-8803?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17653246#comment-17653246 ] Shawn Heisey commented on SOLR-8803: I realized while looking at the ref guide for som

[jira] [Commented] (SOLR-16600) Use Array instead of ObjectList when dealling with parallelCachesRefresh in CloudSolrClient

2022-12-30 Thread Alex Deparvu (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17653219#comment-17653219 ] Alex Deparvu commented on SOLR-16600: - thank you [~epugh]! waiting for PR #1248 to go

[GitHub] [solr] dsmiley commented on a diff in pull request #1253: SOLR-10452: setQueryParams should be deprecated in favor of SolrClientBuilder methods

2022-12-30 Thread GitBox
dsmiley commented on code in PR #1253: URL: https://github.com/apache/solr/pull/1253#discussion_r1059545466 ## solr/solrj/src/java/org/apache/solr/client/solrj/impl/HttpSolrClient.java: ## @@ -1041,6 +1052,15 @@ public HttpSolrClient build() { if (this.invariantParams.ge

[GitHub] [solr] stillalex commented on a diff in pull request #1253: SOLR-10452: setQueryParams should be deprecated in favor of SolrClientBuilder methods

2022-12-30 Thread GitBox
stillalex commented on code in PR #1253: URL: https://github.com/apache/solr/pull/1253#discussion_r1059544372 ## solr/solrj/src/java/org/apache/solr/client/solrj/impl/HttpSolrClient.java: ## @@ -1041,6 +1052,15 @@ public HttpSolrClient build() { if (this.invariantParams.

[GitHub] [solr] dsmiley commented on a diff in pull request #1248: SOLR-10470: setParallelCacheRefreshes should be deprecated in favor of SolrClientBuilder methods

2022-12-30 Thread GitBox
dsmiley commented on code in PR #1248: URL: https://github.com/apache/solr/pull/1248#discussion_r1059533965 ## solr/solrj/src/java/org/apache/solr/client/solrj/impl/CloudSolrClient.java: ## @@ -1222,11 +1222,22 @@ public boolean isDirectUpdatesToLeadersOnly() { /** * If c

[GitHub] [solr] stillalex commented on pull request #1248: SOLR-10470: setParallelCacheRefreshes should be deprecated in favor of SolrClientBuilder methods

2022-12-30 Thread GitBox
stillalex commented on PR #1248: URL: https://github.com/apache/solr/pull/1248#issuecomment-1368118096 looks good to me, will leave @dsmiley to add any concerns if any. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use t

[jira] [Resolved] (SOLR-992) Add Ability To Use JNDI Keys In Configuration String Replacement Tags

2022-12-30 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-992?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Smiley resolved SOLR-992. --- Resolution: Won't Do > Add Ability To Use JNDI Keys In Configuration String Replacement Tags >

[jira] [Resolved] (SOLR-646) Configuration properties enhancements in solr.xml

2022-12-30 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-646?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Smiley resolved SOLR-646. --- Resolution: Won't Do > Configuration properties enhancements in solr.xml >

[GitHub] [solr] justinrsweeney opened a new pull request, #1258: Refactoring to move live nodes handling out of ZkStateReader and into own class

2022-12-30 Thread GitBox
justinrsweeney opened a new pull request, #1258: URL: https://github.com/apache/solr/pull/1258 https://issues.apache.org/jira/browse/SOLR-X # Description Please provide a short description of the changes you're making with this pull request. # Solution

[jira] [Commented] (SOLR-10465) setIdField should be deprecated in favor of SolrClientBuilder methods

2022-12-30 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-10465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17653199#comment-17653199 ] David Smiley commented on SOLR-10465: - BTW your concerns resonate with me but I think

[GitHub] [solr] dsmiley commented on a diff in pull request #1253: SOLR-10452: setQueryParams should be deprecated in favor of SolrClientBuilder methods

2022-12-30 Thread GitBox
dsmiley commented on code in PR #1253: URL: https://github.com/apache/solr/pull/1253#discussion_r1059527327 ## solr/solrj/src/java/org/apache/solr/client/solrj/impl/ConcurrentUpdateSolrClient.java: ## @@ -140,15 +141,26 @@ protected ConcurrentUpdateSolrClient(Builder builder) {

[GitHub] [solr-operator] endzyme opened a new pull request, #514: Change Zookeeper Cluster CRD Spec Labels

2022-12-30 Thread GitBox
endzyme opened a new pull request, #514: URL: https://github.com/apache/solr-operator/pull/514 Zookeeper cluster CRD spec.pod.labels presently does not function as intended. StatefulSet pods receive all their labels from spec.labels. This is outlined in https://github.com/pravega/zookeeper-

[jira] [Created] (SOLR-16602) Update Ref Guide steps for Packages

2022-12-30 Thread Eric Pugh (Jira)
Eric Pugh created SOLR-16602: Summary: Update Ref Guide steps for Packages Key: SOLR-16602 URL: https://issues.apache.org/jira/browse/SOLR-16602 Project: Solr Issue Type: Bug Security Level

[GitHub] [solr] epugh commented on pull request #1182: SOLR-16504 Convert CLI tools to Jetty HTTP 2 client.

2022-12-30 Thread GitBox
epugh commented on PR #1182: URL: https://github.com/apache/solr/pull/1182#issuecomment-1368048938 @bszabo97 I am poking at this, and it *may* be that in PackageStoreAPI.java we attempt to write the raw data back via `writeRawFile`, and it wants to use filestream, but we have specified `wt=

[GitHub] [solr] epugh commented on a diff in pull request #1182: SOLR-16504 Convert CLI tools to Jetty HTTP 2 client.

2022-12-30 Thread GitBox
epugh commented on code in PR #1182: URL: https://github.com/apache/solr/pull/1182#discussion_r1059415280 ## solr/core/src/java/org/apache/solr/packagemanager/PackageManager.java: ## @@ -228,20 +230,20 @@ public List fetchInstalledPackageInstances() throws SolrExc public Map

[GitHub] [solr] aruggero opened a new pull request, #1257: SOLR-16596: LTR MultipleAdditiveTreeModel does not support missing features' value

2022-12-30 Thread GitBox
aruggero opened a new pull request, #1257: URL: https://github.com/apache/solr/pull/1257 https://issues.apache.org/jira/browse/SOLR-16596 # Description In some scenarios, a null value for a feature has a different meaning than a zero value. There are models that are trained aware o

[jira] [Commented] (SOLR-10468) setZkClientTimeout should be deprecated in favor of SolrClientBuilder methods

2022-12-30 Thread Eric Pugh (Jira)
[ https://issues.apache.org/jira/browse/SOLR-10468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17653120#comment-17653120 ] Eric Pugh commented on SOLR-10468: -- Candidate for wont-fix. > setZkClientTimeout should

[jira] [Created] (SOLR-16601) Remove Deprecated Methods from Solr Clients

2022-12-30 Thread Eric Pugh (Jira)
Eric Pugh created SOLR-16601: Summary: Remove Deprecated Methods from Solr Clients Key: SOLR-16601 URL: https://issues.apache.org/jira/browse/SOLR-16601 Project: Solr Issue Type: Sub-task

[jira] [Commented] (SOLR-16600) Use Array instead of ObjectList when dealling with parallelCachesRefresh in CloudSolrClient

2022-12-30 Thread Eric Pugh (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17653119#comment-17653119 ] Eric Pugh commented on SOLR-16600: -- [~stillalex] this one is for you ;-) If you are sti

[GitHub] [solr] epugh commented on pull request #1248: SOLR-10470: setParallelCacheRefreshes should be deprecated in favor of SolrClientBuilder methods

2022-12-30 Thread GitBox
epugh commented on PR #1248: URL: https://github.com/apache/solr/pull/1248#issuecomment-1367889316 Okay, any angst to me merging this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec