[
https://issues.apache.org/jira/browse/SOLR-16676?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17692443#comment-17692443
]
David Smiley commented on SOLR-16676:
-
I'd be happy to review!
> Http2SolrClient los
dsmiley commented on code in PR #1375:
URL: https://github.com/apache/solr/pull/1375#discussion_r1115164201
##
.github/renovate.json:
##
@@ -0,0 +1,33 @@
+{
Review Comment:
If it can live elsewhere easily then cool. But I think it's inclusion isn't
a blocker either. I bel
[
https://issues.apache.org/jira/browse/SOLR-16556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17692422#comment-17692422
]
Maulin commented on SOLR-16556:
---
Hi [~epugh] Sorry for late reply.. I am working on your
[
https://issues.apache.org/jira/browse/SOLR-16664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17692421#comment-17692421
]
Noble Paul commented on SOLR-16664:
---
lemme investigate
> TestCoordinatorRole fails doc
chatman commented on code in PR #1375:
URL: https://github.com/apache/solr/pull/1375#discussion_r1115092683
##
.github/renovate.json:
##
@@ -0,0 +1,33 @@
+{
Review Comment:
Does this file need to be in solr repository for the entire integration to
work? Can't it be added to
chatman commented on code in PR #1375:
URL: https://github.com/apache/solr/pull/1375#discussion_r1115092683
##
.github/renovate.json:
##
@@ -0,0 +1,33 @@
+{
Review Comment:
Does this file need to be in solr repository for the entire integration to
work? Can't it be added to
chatman commented on PR #1375:
URL: https://github.com/apache/solr/pull/1375#issuecomment-1440972336
> I changed teh commit email to SolrBot , see
[renovate
config](https://github.com/solrbot/renovate-github-action/blob/main/solr/renovate-config.js).
Who controls that email address?
janhoy commented on code in PR #1375:
URL: https://github.com/apache/solr/pull/1375#discussion_r1114973119
##
.github/renovate.json:
##
@@ -0,0 +1,30 @@
+{
+ "$schema": "https://docs.renovatebot.com/renovate-schema.json";,
+ "dependencyDashboard": false,
+ "enabledManagers":
[
https://issues.apache.org/jira/browse/SOLR-16488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17689195#comment-17689195
]
Jason Gerlowski edited comment on SOLR-16488 at 2/22/23 9:07 PM:
--
risdenk commented on code in PR #1377:
URL: https://github.com/apache/solr/pull/1377#discussion_r1114901342
##
solr/benchmark/src/java/org/apache/solr/bench/lifecycle/SolrStartup.java:
##
@@ -0,0 +1,121 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or mor
gerlowskija commented on PR #1377:
URL: https://github.com/apache/solr/pull/1377#issuecomment-1440732740
FYI @noblepaul , I know you'd expressed interest in this following the last
virtual meetup.
--
This is an automated message from the Apache Git Service.
To respond to the message, plea
risdenk commented on code in PR #1377:
URL: https://github.com/apache/solr/pull/1377#discussion_r1114900274
##
solr/benchmark/src/java/org/apache/solr/bench/lifecycle/SolrStartup.java:
##
@@ -0,0 +1,121 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or mor
gerlowskija commented on code in PR #1377:
URL: https://github.com/apache/solr/pull/1377#discussion_r1114897492
##
solr/benchmark/src/java/org/apache/solr/bench/lifecycle/SolrStartup.java:
##
@@ -0,0 +1,121 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or
risdenk commented on code in PR #1377:
URL: https://github.com/apache/solr/pull/1377#discussion_r1114861555
##
solr/benchmark/src/java/org/apache/solr/bench/lifecycle/SolrStartup.java:
##
@@ -0,0 +1,121 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or mor
gerlowskija opened a new pull request, #1377:
URL: https://github.com/apache/solr/pull/1377
https://issues.apache.org/jira/browse/SOLR-16680
# Description
Solr has a benchmarking module built around an integration with JMH. But it
doesn't have a ton of benchmarks to run quite
justinrsweeney commented on PR #1348:
URL: https://github.com/apache/solr/pull/1348#issuecomment-1440676642
> This looks like it does the job. However, I was sort of thinking that
compression would be more of a wrapper around the underlying data structure?
Kind of like a `ZipInputStream` mi
Jason Gerlowski created SOLR-16680:
--
Summary: Add JMH benchmark for Solr Startup
Key: SOLR-16680
URL: https://issues.apache.org/jira/browse/SOLR-16680
Project: Solr
Issue Type: Improvement
joshgog commented on code in PR #1374:
URL: https://github.com/apache/solr/pull/1374#discussion_r1114796900
##
solr/test-framework/src/java/org/apache/solr/SolrJettyTestBase.java:
##
@@ -136,7 +136,7 @@ public synchronized SolrClient getSolrClient() {
* options.
*/
pu
joshgog commented on code in PR #1374:
URL: https://github.com/apache/solr/pull/1374#discussion_r1114780615
##
solr/test-framework/src/java/org/apache/solr/util/SolrJettyTestRule.java:
##
@@ -52,13 +53,18 @@ protected void after() {
try {
jetty.stop();
} c
dsmiley commented on code in PR #1375:
URL: https://github.com/apache/solr/pull/1375#discussion_r1114753773
##
.github/renovate.json:
##
@@ -0,0 +1,30 @@
+{
+ "$schema": "https://docs.renovatebot.com/renovate-schema.json";,
+ "dependencyDashboard": false,
+ "enabledManagers":
[ https://issues.apache.org/jira/browse/SOLR-16664 ]
Kevin Risden deleted comment on SOLR-16664:
-
was (Author: risdenk):
Well this is definitely where the message being generated before trying to
process it with javabin...
https://github.com/a
[ https://issues.apache.org/jira/browse/SOLR-16664 ]
Kevin Risden deleted comment on SOLR-16664:
-
was (Author: risdenk):
I was able to capture a failure in IDE debugger and the message that can't be
decoded was:
{code:java}
Error 404 Can
[
https://issues.apache.org/jira/browse/SOLR-16664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17692301#comment-17692301
]
Kevin Risden commented on SOLR-16664:
-
Well this is definitely where the message bein
[
https://issues.apache.org/jira/browse/SOLR-16664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17692300#comment-17692300
]
Kevin Risden commented on SOLR-16664:
-
I was able to capture a failure in IDE debugg
gerlowskija commented on PR #1160:
URL: https://github.com/apache/solr/pull/1160#issuecomment-1440488697
My schedule is a little inflexible at this point to set up anything formal,
but I'm more than happy to help out as I can! Do you have particular questions
about this PR, or APIs in Solr
epugh commented on PR #1374:
URL: https://github.com/apache/solr/pull/1374#issuecomment-1440473853
Thanks for sharing the summary from the review... I think you answered
some questions I had! Really looking forward to seeing this land ;-).
--
This is an automated message from the Ap
gerlowskija commented on code in PR #1224:
URL: https://github.com/apache/solr/pull/1224#discussion_r1114647260
##
solr/core/src/java/org/apache/solr/handler/admin/api/BackupCoreAPI.java:
##
@@ -0,0 +1,255 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or
dsmiley commented on PR #1374:
URL: https://github.com/apache/solr/pull/1374#issuecomment-1440449203
FYI Eric/others this is a re-do PR to reduce the scope of change to
JettySolrTestBase & subclasses. Too much work to fix/improve them in greater
detail.
From our online review today:
alessandrobenedetti commented on PR #937:
URL: https://github.com/apache/solr/pull/937#issuecomment-1440410507
My bad, it seems this information is not in the documentation (I may have
just put it in the original blog post telling the story of the contribution).
If these changes don't mak
coolstim opened a new issue, #526:
URL: https://github.com/apache/solr-operator/issues/526
The default solr.xml does not contain a default entry for maxBooleanClauses.
This prevents the value to be set via javaOpts and forces uses to implement
a custom config map with a custom solr.xml;
janhoy commented on PR #1375:
URL: https://github.com/apache/solr/pull/1375#issuecomment-1440398151
> I can file an INFRA ticket to create a private `solr-pmc` git repo, PMC
only, where we can share secrets
We now got a private repo `solr-private`, and Infra suggests storing
encrypte
cpoerschke commented on code in PR #937:
URL: https://github.com/apache/solr/pull/937#discussion_r1114585921
##
solr/modules/ltr/src/java/org/apache/solr/ltr/interleaving/LTRInterleavingScoringQuery.java:
##
@@ -25,7 +26,7 @@
public class LTRInterleavingScoringQuery extends LTR
gerlowskija commented on PR #1224:
URL: https://github.com/apache/solr/pull/1224#issuecomment-1440345064
Hi @iamsanjay , sorry for the delay in getting to this. I've been mostly
attending to a blocker for the JAX-RS and v2 API work, SOLR-16531. But with
that recently cleared away I'm turn
cpoerschke commented on code in PR #937:
URL: https://github.com/apache/solr/pull/937#discussion_r1114582258
##
solr/modules/ltr/src/java/org/apache/solr/ltr/response/transform/LTRFeatureLoggerTransformerFactory.java:
##
@@ -362,9 +363,13 @@ private void implTransform(SolrDocume
cpoerschke commented on code in PR #937:
URL: https://github.com/apache/solr/pull/937#discussion_r1114576195
##
solr/modules/ltr/src/java/org/apache/solr/ltr/response/transform/LTRFeatureLoggerTransformerFactory.java:
##
@@ -362,9 +363,13 @@ private void implTransform(SolrDocume
[
https://issues.apache.org/jira/browse/SOLR-15493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17692257#comment-17692257
]
Alessandro Benedetti commented on SOLR-15493:
-
We are finalising a draft pull
[
https://issues.apache.org/jira/browse/SOLR-16664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17692246#comment-17692246
]
Kevin Risden commented on SOLR-16664:
-
It looks like the failure parsing the message
[
https://issues.apache.org/jira/browse/SOLR-16664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17692239#comment-17692239
]
Kevin Risden commented on SOLR-16664:
-
I went back to recent Jenkins failures to see
[
https://issues.apache.org/jira/browse/SOLR-16664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17692236#comment-17692236
]
Kevin Risden edited comment on SOLR-16664 at 2/22/23 3:17 PM:
-
[
https://issues.apache.org/jira/browse/SOLR-16664?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kevin Risden reopened SOLR-16664:
-
Here is a failure with the new logging:
{code:java}
2> 465235 INFO
(TEST-TestCoordinatorRole.tes
[
https://issues.apache.org/jira/browse/SOLR-16664?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kevin Risden reassigned SOLR-16664:
---
Assignee: (was: Kevin Risden)
> TestCoordinatorRole fails docs is null
> ---
[
https://issues.apache.org/jira/browse/SOLR-16679?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kevin Risden updated SOLR-16679:
Status: Patch Available (was: Open)
> Fix solr.jetty.ssl.verifyClientHostName logging
> --
risdenk opened a new pull request, #1376:
URL: https://github.com/apache/solr/pull/1376
https://issues.apache.org/jira/browse/SOLR-16679
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specif
[
https://issues.apache.org/jira/browse/SOLR-16669?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kevin Risden updated SOLR-16669:
Status: Patch Available (was: Open)
> Http2SolrClient defaults checkPeerName incorrectly
> ---
Kevin Risden created SOLR-16679:
---
Summary: Fix solr.jetty.ssl.verifyClientHostName logging
Key: SOLR-16679
URL: https://issues.apache.org/jira/browse/SOLR-16679
Project: Solr
Issue Type: Task
risdenk commented on PR #1367:
URL: https://github.com/apache/solr/pull/1367#issuecomment-1440146823
Oooo thanks for digging @HoustonPutman agree that
```
sslContextFactory.setEndpointIdentificationAlgorithm(
System.getProperty("solr.jetty.ssl.verifyClientHostName"));
[
https://issues.apache.org/jira/browse/SOLR-16664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17692217#comment-17692217
]
ASF subversion and git services commented on SOLR-16664:
Commit b
[
https://issues.apache.org/jira/browse/SOLR-16664?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kevin Risden updated SOLR-16664:
Fix Version/s: main (10.0)
9.2
> TestCoordinatorRole fails docs is null
> --
[
https://issues.apache.org/jira/browse/SOLR-16664?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kevin Risden updated SOLR-16664:
Assignee: Kevin Risden
Resolution: Fixed
Status: Resolved (was: Patch Available)
I'm
[
https://issues.apache.org/jira/browse/SOLR-16664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17692213#comment-17692213
]
ASF subversion and git services commented on SOLR-16664:
Commit 0
risdenk merged PR #1363:
URL: https://github.com/apache/solr/pull/1363
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.or
janhoy commented on PR #1375:
URL: https://github.com/apache/solr/pull/1375#issuecomment-1439979338
> I remember there is a private svn repo per PMC, but could not find it.
I found https://svn.apache.org/repos/private/pmc/lucene/ for Lucene, but
there is no equivalent for Solr at
htt
cpoerschke commented on code in PR #1234:
URL: https://github.com/apache/solr/pull/1234#discussion_r1114215511
##
solr/core/src/java/org/apache/solr/core/SolrCore.java:
##
@@ -2902,35 +2902,43 @@ public static void preDecorateResponse(SolrQueryRequest
req, SolrQueryResponse r
janhoy commented on PR #1375:
URL: https://github.com/apache/solr/pull/1375#issuecomment-1439920945
As of now, the git author for the PRs will be `SolrBot
`. I used an email address on my own downain, the same I
used to create the github account. The git commit message could of course be
a
janhoy commented on code in PR #1375:
URL: https://github.com/apache/solr/pull/1375#discussion_r1114226413
##
.github/renovate.json:
##
@@ -0,0 +1,30 @@
+{
+ "$schema": "https://docs.renovatebot.com/renovate-schema.json";,
+ "dependencyDashboard": false,
+ "enabledManagers":
janhoy opened a new pull request, #1375:
URL: https://github.com/apache/solr/pull/1375
This PR adds automatic dependency housekeeping to the project through
[Renovatebot](https://github.com/renovatebot/renovate), which is an alternative
to dependabot. See [slack discussion
here](https://th
alessandrobenedetti commented on PR #1260:
URL: https://github.com/apache/solr/pull/1260#issuecomment-1439846587
Back in the days, in 2017 when I was not a committer yet, I did a massive
refactor of the Lucene More Like This code
(https://www.slideshare.net/SeaseLtd/how-the-lucene-more-like
[
https://issues.apache.org/jira/browse/SOLR-16661?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jan Høydahl updated SOLR-16661:
---
Priority: Blocker (was: Major)
> Remove analytics component in 10.0
> --
[
https://issues.apache.org/jira/browse/SOLR-16661?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jan Høydahl updated SOLR-16661:
---
Fix Version/s: main (10.0)
> Remove analytics component in 10.0
> --
[
https://issues.apache.org/jira/browse/SOLR-13931?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17692121#comment-17692121
]
Jan Høydahl commented on SOLR-13931:
The module is now deprecated in 9.2 with a call
HoustonPutman commented on PR #1367:
URL: https://github.com/apache/solr/pull/1367#issuecomment-1439796112
Ok @janhoy , checking the logs message.
Main with #1366 included:
```
2023-02-22 09:28:49.232 WARN (main) [] o.e.j.u.s.S.config Trusting all
certificates configured fo
[
https://issues.apache.org/jira/browse/SOLR-16532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17692114#comment-17692114
]
ASF subversion and git services commented on SOLR-16532:
Commit 8
[
https://issues.apache.org/jira/browse/SOLR-16650?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17692113#comment-17692113
]
ASF subversion and git services commented on SOLR-16650:
Commit 8
[
https://issues.apache.org/jira/browse/SOLR-16650?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jan Høydahl resolved SOLR-16650.
Fix Version/s: 9.2
Resolution: Fixed
> OTEL tracer additional tags
> ---
[
https://issues.apache.org/jira/browse/SOLR-16532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17692112#comment-17692112
]
ASF subversion and git services commented on SOLR-16532:
Commit 7
[
https://issues.apache.org/jira/browse/SOLR-16650?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17692111#comment-17692111
]
ASF subversion and git services commented on SOLR-16650:
Commit 7
janhoy merged PR #1342:
URL: https://github.com/apache/solr/pull/1342
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
Julien Massiera created SOLR-16678:
--
Summary: Collection API v2 CREATE does not handle user-defined
properties
Key: SOLR-16678
URL: https://issues.apache.org/jira/browse/SOLR-16678
Project: Solr
[
https://issues.apache.org/jira/browse/SOLR-15959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17692092#comment-17692092
]
ASF subversion and git services commented on SOLR-15959:
Commit 1
[
https://issues.apache.org/jira/browse/SOLR-15959?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jan Høydahl resolved SOLR-15959.
Fix Version/s: 9.2
Resolution: Fixed
> Deprecate loading of solr.xml from ZK
> -
[
https://issues.apache.org/jira/browse/SOLR-15959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17692091#comment-17692091
]
ASF subversion and git services commented on SOLR-15959:
Commit 5
janhoy merged PR #1362:
URL: https://github.com/apache/solr/pull/1362
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
[
https://issues.apache.org/jira/browse/SOLR-16660?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jan Høydahl resolved SOLR-16660.
Fix Version/s: 9.2
Resolution: Fixed
> Deprecate analytics component
> -
[
https://issues.apache.org/jira/browse/SOLR-16660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17692087#comment-17692087
]
ASF subversion and git services commented on SOLR-16660:
Commit 0
[
https://issues.apache.org/jira/browse/SOLR-16660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17692085#comment-17692085
]
ASF subversion and git services commented on SOLR-16660:
Commit e
janhoy merged PR #1361:
URL: https://github.com/apache/solr/pull/1361
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
HoustonPutman commented on code in PR #1361:
URL: https://github.com/apache/solr/pull/1361#discussion_r1114042387
##
solr/solr-ref-guide/modules/query-guide/pages/analytics-mapping-functions.adoc:
##
@@ -18,6 +18,8 @@
Mapping functions map values for each Solr Document or Red
77 matches
Mail list logo
