vinayakphegde commented on code in PR #1360:
URL: https://github.com/apache/solr/pull/1360#discussion_r1125349206
##
solr/core/src/java/org/apache/solr/core/MMapDirectoryFactory.java:
##
@@ -63,7 +63,7 @@ protected Directory create(String path, LockFactory
lockFactory, DirConte
stillalex commented on PR #1357:
URL: https://github.com/apache/solr/pull/1357#issuecomment-1454324266
@gerlowskija do you want to mark SOLR-16540 as resolved too?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
UR
stillalex commented on code in PR #1410:
URL: https://github.com/apache/solr/pull/1410#discussion_r1125194334
##
solr/solrj/src/java/org/apache/solr/client/solrj/impl/Http2SolrClient.java:
##
@@ -1273,4 +1287,33 @@ static SslContextFactory.Client
getDefaultSslContextFactory() {
stillalex commented on code in PR #1410:
URL: https://github.com/apache/solr/pull/1410#discussion_r1125193069
##
solr/solrj/src/test/org/apache/solr/client/solrj/impl/Http2SolrClientTest.java:
##
@@ -469,6 +474,43 @@ public void testGetById() throws Exception {
}
}
+
stillalex commented on code in PR #1410:
URL: https://github.com/apache/solr/pull/1410#discussion_r1125191417
##
solr/core/src/test/org/apache/solr/handler/TestHttpRequestId.java:
##
@@ -0,0 +1,143 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ *
dsmiley commented on PR #1360:
URL: https://github.com/apache/solr/pull/1360#issuecomment-1454217841
TestComplexPhraseQParserPlugin: I anticipated this failure.
https://github.com/apache/lucene/pull/11807
This weekend I'll see if I could fix it. I'm going to look into overriding
getHi
dsmiley commented on code in PR #1410:
URL: https://github.com/apache/solr/pull/1410#discussion_r1124950966
##
solr/solrj/src/java/org/apache/solr/client/solrj/impl/Http2SolrClient.java:
##
@@ -1273,4 +1287,33 @@ static SslContextFactory.Client
getDefaultSslContextFactory() {
uschindler commented on code in PR #1360:
URL: https://github.com/apache/solr/pull/1360#discussion_r1124940846
##
solr/core/src/java/org/apache/solr/core/MMapDirectoryFactory.java:
##
@@ -63,7 +63,7 @@ protected Directory create(String path, LockFactory
lockFactory, DirContext
dsmiley commented on code in PR #1182:
URL: https://github.com/apache/solr/pull/1182#discussion_r1124880964
##
solr/core/src/java/org/apache/solr/packagemanager/DefaultPackageRepository.java:
##
@@ -101,16 +106,21 @@ public Path download(String artifactName) throws
SolrExceptio
mkhludnev opened a new pull request, #1430:
URL: https://github.com/apache/solr/pull/1430
https://issues.apache.org/jira/browse/SOLR-16585
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
[
https://issues.apache.org/jira/browse/SOLR-16585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17696271#comment-17696271
]
ASF subversion and git services commented on SOLR-16585:
Commit 7
mkhludnev merged PR #1378:
URL: https://github.com/apache/solr/pull/1378
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.
[
https://issues.apache.org/jira/browse/SOLR-8238?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17696260#comment-17696260
]
David Smiley commented on SOLR-8238:
bq. What if the node is out of commission permane
epugh commented on PR #1182:
URL: https://github.com/apache/solr/pull/1182#issuecomment-1453825905
This is really exciting work! I did a bit of poking, and we have these
integration tests in `./solr/packaging/test/` that use BATS for testing the
SolrCLI. I wonder if this is the right pl
sonatype-lift[bot] commented on code in PR #1182:
URL: https://github.com/apache/solr/pull/1182#discussion_r1124750911
##
solr/core/src/java/org/apache/solr/util/SolrCLI.java:
##
@@ -648,164 +619,30 @@ public static NamedList postJsonToSolr(
return solrClient.request(req);
[
https://issues.apache.org/jira/browse/SOLR-8238?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17696219#comment-17696219
]
Erick Erickson commented on SOLR-8238:
--
Yes, I was describing the background for pref
bszabo97 commented on PR #1182:
URL: https://github.com/apache/solr/pull/1182#issuecomment-1453772240
Sorry that an update from me took so long, I was pretty stuck on a problem
regarding the package manager.
Now I have uploaded a new commit which resolved that problem and also
remove
stillalex commented on PR #1410:
URL: https://github.com/apache/solr/pull/1410#issuecomment-1453570691
deadlock avoided by setting corePoolSzize to 3. thanks @risdenk! waiting for
test results but PR should be open for review again.
--
This is an automated message from the Apache Git Serv
[
https://issues.apache.org/jira/browse/SOLR-16289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17696125#comment-17696125
]
Christine Poerschke commented on SOLR-16289:
Picking up here from the
[https
[
https://issues.apache.org/jira/browse/SOLR-16438?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bruno Roustant resolved SOLR-16438.
---
Resolution: Abandoned
> Shard split should be able to set preferred leaders on other replicas
[
https://issues.apache.org/jira/browse/SOLR-16438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17696108#comment-17696108
]
Bruno Roustant edited comment on SOLR-16438 at 3/3/23 10:07 AM:
---
[
https://issues.apache.org/jira/browse/SOLR-16438?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bruno Roustant reopened SOLR-16438:
---
> Shard split should be able to set preferred leaders on other replicas
> ---
[
https://issues.apache.org/jira/browse/SOLR-16438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17696108#comment-17696108
]
Bruno Roustant commented on SOLR-16438:
---
Fully reverted these PRs (the initial and
[
https://issues.apache.org/jira/browse/SOLR-16438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17696106#comment-17696106
]
ASF subversion and git services commented on SOLR-16438:
Commit 3
[
https://issues.apache.org/jira/browse/SOLR-16438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17696104#comment-17696104
]
ASF subversion and git services commented on SOLR-16438:
Commit c
vinayakphegde commented on PR #1360:
URL: https://github.com/apache/solr/pull/1360#issuecomment-1453164773
tried to address all the issues/comments except "performance degradation for
any query that isn't using timeouts" mentioned by @dsmiley
now, only `org.apache.solr.search.TestComplex
26 matches
Mail list logo
