[GitHub] [solr] noblepaul commented on a diff in pull request #1585: Use Zookeeper persistent recursive Zookeeper watches

noblepaul commented on code in PR #1585: URL: https://github.com/apache/solr/pull/1585#discussion_r1208801000 ## solr/solrj-zookeeper/src/java/org/apache/solr/common/cloud/ZkStateReader.java: ## @@ -368,10 +368,152 @@ private StatefulCollectionWatch compute( BiFunction

[GitHub] [solr] noblepaul commented on a diff in pull request #1585: Use Zookeeper persistent recursive Zookeeper watches

noblepaul commented on code in PR #1585: URL: https://github.com/apache/solr/pull/1585#discussion_r1208800892 ## solr/solrj-zookeeper/src/java/org/apache/solr/common/cloud/ZkStateReader.java: ## @@ -326,14 +326,14 @@ private boolean updateDocCollection(String collection, DocCol

[GitHub] [solr] noblepaul commented on a diff in pull request #1625: SOLR-16507: Refactor out ImplicitSnitch

noblepaul commented on code in PR #1625: URL: https://github.com/apache/solr/pull/1625#discussion_r1208800672 ## solr/solrj-zookeeper/src/java/org/apache/solr/client/solrj/impl/NodeValueFetcher.java: ## @@ -0,0 +1,203 @@ +/* + * Licensed to the Apache Software Foundation (ASF) u

[jira] [Commented] (SOLR-16779) Umm... what is bin/solr cp ???

[ https://issues.apache.org/jira/browse/SOLR-16779?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17726899#comment-17726899 ] Senthil Kumar commented on SOLR-16779: -- [~epugh] Eric, I don't see we have "bin/solr

[jira] [Commented] (SOLR-16826) Validate if authentication plugin class name are valid

[ https://issues.apache.org/jira/browse/SOLR-16826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17726895#comment-17726895 ] Senthil Kumar commented on SOLR-16826: -- Hi  [~epugh] ,   Could you be kind to revi

[GitHub] [solr] senthh commented on pull request #1669: SOLR-16826: Validate if authentication plugin class name are valid

senthh commented on PR #1669: URL: https://github.com/apache/solr/pull/1669#issuecomment-1565958896 @epugh Eric Pugh, could you please review this PR -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go