[GitHub] [solr-operator] radu-gheorghe commented on pull request #596: Add in a retry queue for clusterOps

2023-08-06 Thread via GitHub
radu-gheorghe commented on PR #596: URL: https://github.com/apache/solr-operator/pull/596#issuecomment-1667184938 I am, thank you! I'll take a look this week, thanks for poking me. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitH

[GitHub] [solr] rahulgoswami commented on a diff in pull request #1816: SOLR-16360: Atomic update on boolean fields doesn't reflect when value starts with "1", "t" or "T"

2023-08-06 Thread via GitHub
rahulgoswami commented on code in PR #1816: URL: https://github.com/apache/solr/pull/1816#discussion_r1285342351 ## solr/core/src/java/org/apache/solr/schema/BoolField.java: ## @@ -211,7 +212,7 @@ public List createFields(SchemaField field, Object value) { @Override publi

[GitHub] [solr] rahulgoswami commented on a diff in pull request #1816: SOLR-16360: Atomic update on boolean fields doesn't reflect when value starts with "1", "t" or "T"

2023-08-06 Thread via GitHub
rahulgoswami commented on code in PR #1816: URL: https://github.com/apache/solr/pull/1816#discussion_r1285342351 ## solr/core/src/java/org/apache/solr/schema/BoolField.java: ## @@ -211,7 +212,7 @@ public List createFields(SchemaField field, Object value) { @Override publi

[jira] [Commented] (SOLR-16822) change hostname parameter on start and restart to only be -host, no -h

2023-08-06 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-16822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17751417#comment-17751417 ] Jan Høydahl commented on SOLR-16822: Thanks! This has been a weird arg for so long!

[jira] [Commented] (SOLR-16907) Strange behaviour after upgrade to 9.x when security json has no longer existing permission

2023-08-06 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-16907?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17751416#comment-17751416 ] Jan Høydahl commented on SOLR-16907: +1 to keep shadow perms to warn (and fail loadin

[GitHub] [solr] janhoy commented on a diff in pull request #1768: SOLR-16824: Adopt Linux Command line tool pattern of -- for long option commands

2023-08-06 Thread via GitHub
janhoy commented on code in PR #1768: URL: https://github.com/apache/solr/pull/1768#discussion_r1285258930 ## solr/solr-ref-guide/modules/upgrade-notes/pages/major-changes-in-solr-10.adoc: ## @@ -42,3 +42,15 @@ has been removed. Please use `-Dsolr.hiddenSysProps` or the envVar

[jira] [Commented] (SOLR-9698) Fix bin/solr script calculations - start/stop wait time and RMI_PORT on Windows

2023-08-06 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-9698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17751407#comment-17751407 ] Jan Høydahl commented on SOLR-9698: --- [~colvinco] Can this Jira be closed now? > Fix bin

[jira] [Commented] (SOLR-16536) Replace OpenTracing instrumentation with OpenTelemetry

2023-08-06 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-16536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17751406#comment-17751406 ] Jan Høydahl commented on SOLR-16536: Thanks [~stillalex]  for taking on this task! >

[GitHub] [solr] epugh commented on pull request #1808: SOLR-16800: Move towards using the root of Solr as the -solrUrl in the CLI.

2023-08-06 Thread via GitHub
epugh commented on PR #1808: URL: https://github.com/apache/solr/pull/1808#issuecomment-1666953093 @chatman I've got some optimizations to the Package tool if you want to look. @gerlowskija I'd love another looksee now that hostContext has been sorted -- This is an automated message

[GitHub] [solr] epugh commented on pull request #1374: SOLR-16623:SolrClientTestRule for JettySolrRunnerV2

2023-08-06 Thread via GitHub
epugh commented on PR #1374: URL: https://github.com/apache/solr/pull/1374#issuecomment-1666952512 Some nice cleans up @dsmiley in the current round! The tests read much simpler... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

[jira] [Commented] (SOLR-16921) bin/solr upconfig and downconfig reference solrUrl but don't list it as option!

2023-08-06 Thread Eric Pugh (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17751402#comment-17751402 ] Eric Pugh commented on SOLR-16921: -- the cp and mv commands have the same pattern... > b

[jira] [Updated] (SOLR-16921) bin/solr upconfig and downconfig reference solrUrl but don't list it as option!

2023-08-06 Thread Eric Pugh (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16921?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eric Pugh updated SOLR-16921: - Description: We have a message like: if (zkHost == null) { throw new IllegalStateException(

[jira] [Created] (SOLR-16921) bin/solr upconfig and downconfig reference solrUrl but don't list it as option!

2023-08-06 Thread Eric Pugh (Jira)
Eric Pugh created SOLR-16921: Summary: bin/solr upconfig and downconfig reference solrUrl but don't list it as option! Key: SOLR-16921 URL: https://issues.apache.org/jira/browse/SOLR-16921 Project: Solr

[GitHub] [solr] epugh commented on a diff in pull request #1808: SOLR-16800: Move towards using the root of Solr as the -solrUrl in the CLI.

2023-08-06 Thread via GitHub
epugh commented on code in PR #1808: URL: https://github.com/apache/solr/pull/1808#discussion_r1285218105 ## solr/core/src/java/org/apache/solr/cli/SolrCLI.java: ## @@ -383,6 +383,11 @@ public static boolean exceptionIsAuthRelated(Exception exc) { } public static SolrCl