Raghavan1988 opened a new pull request, #1843:
URL: https://github.com/apache/solr/pull/1843
https://issues.apache.org/jira/browse/SOLR-X
# Description
Please provide a short description of the changes you're making with this
pull request.
# Solution
stillalex commented on PR #1841:
URL: https://github.com/apache/solr/pull/1841#issuecomment-1679730960
> Perhaps we should emit both for some versions, or implement the suggested
env var OTEL_SEMCONV_STABILITY_OPT_IN?
if this is for 2 fields only (`http.status_code` =>
`http.response
janhoy commented on PR #1841:
URL: https://github.com/apache/solr/pull/1841#issuecomment-1679714260
> * 9.3 spans have `http.status_code` attrib, where PR has `http.status`
Please consult the [otel semantic
conventions](https://github.com/open-telemetry/semantic-conventions/tree/main/
stillalex commented on code in PR #1841:
URL: https://github.com/apache/solr/pull/1841#discussion_r1295202810
##
solr/core/src/java/org/apache/solr/api/V2HttpCall.java:
##
@@ -510,18 +507,21 @@ protected void populateTracingSpan(Span span) {
// if this api has commands ...
stillalex commented on PR #1841:
URL: https://github.com/apache/solr/pull/1841#issuecomment-1679674060
quick comparison of _Indexing_ span data (exporting from jaeger on 9.3 vs
this PR):
Update spans on this PR
```
{
"data": [
{
"trac
stillalex commented on PR #1841:
URL: https://github.com/apache/solr/pull/1841#issuecomment-1679664416
quick comparison of span data (exporting from jaeger on 9.3 vs this PR):
Query spans on this PR
```
{
"data": [
{
"traceID": "b3e378
[
https://issues.apache.org/jira/browse/SOLR-16937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17754778#comment-17754778
]
Jan Høydahl commented on SOLR-16937:
As mentioned in
https://issues.apache.org/jira/
[
https://issues.apache.org/jira/browse/SOLR-16937?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alex Deparvu updated SOLR-16937:
Description:
Using GlobalOpenTelemetry is considered an anti-pattern, usage of the global
instance
[
https://issues.apache.org/jira/browse/SOLR-16936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17754769#comment-17754769
]
Jan Høydahl commented on SOLR-16936:
Some use of Span.log today seems to be not time
janhoy merged PR #1814:
URL: https://github.com/apache/solr/pull/1814
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
stillalex commented on PR #1841:
URL: https://github.com/apache/solr/pull/1841#issuecomment-1679599489
sorry, had to do a rebase on top of main branch to fix some conflicts.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
stillalex commented on PR #1835:
URL: https://github.com/apache/solr/pull/1835#issuecomment-1679592153
@joel-bernstein do you think you will have some time to review this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
stillalex commented on code in PR #1841:
URL: https://github.com/apache/solr/pull/1841#discussion_r1295082536
##
solr/core/src/java/org/apache/solr/servlet/SolrDispatchFilter.java:
##
@@ -255,15 +247,12 @@ private void dispatch(
Action result = call.call();
switch
stillalex commented on code in PR #1841:
URL: https://github.com/apache/solr/pull/1841#discussion_r1295080612
##
solr/core/src/java/org/apache/solr/api/AnnotatedApi.java:
##
@@ -215,7 +214,6 @@ public void call(SolrQueryRequest req, SolrQueryResponse
rsp) {
}
for (C
Alex Deparvu created SOLR-16937:
---
Summary: Remove use of GlobalOpenTelemetry
Key: SOLR-16937
URL: https://issues.apache.org/jira/browse/SOLR-16937
Project: Solr
Issue Type: Sub-task
[
https://issues.apache.org/jira/browse/SOLR-16933?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Houston Putman updated SOLR-16933:
--
Description:
When running Solr 9.3 in Docker:
{code:bash}
$ solr api -get http://localhost:8983
[
https://issues.apache.org/jira/browse/SOLR-16933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17754761#comment-17754761
]
Houston Putman commented on SOLR-16933:
---
Sorry, messed up my copy and paste. One of
[
https://issues.apache.org/jira/browse/SOLR-16933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17754759#comment-17754759
]
Eric Pugh commented on SOLR-16933:
--
I am being a bit dense, but I don't quite understand
stillalex commented on code in PR #1841:
URL: https://github.com/apache/solr/pull/1841#discussion_r1295031075
##
solr/core/src/java/org/apache/solr/api/AnnotatedApi.java:
##
@@ -215,7 +214,6 @@ public void call(SolrQueryRequest req, SolrQueryResponse
rsp) {
}
for (C
stillalex commented on code in PR #1841:
URL: https://github.com/apache/solr/pull/1841#discussion_r1295032461
##
solr/modules/opentelemetry/src/java/org/apache/solr/opentelemetry/OtelTracerConfigurator.java:
##
@@ -16,38 +16,56 @@
*/
package org.apache.solr.opentelemetry;
-
Alex Deparvu created SOLR-16936:
---
Summary: Consider removal of the Span.addEvent methods
Key: SOLR-16936
URL: https://issues.apache.org/jira/browse/SOLR-16936
Project: Solr
Issue Type: Sub-task
janhoy merged PR #1813:
URL: https://github.com/apache/solr/pull/1813
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
janhoy commented on code in PR #1841:
URL: https://github.com/apache/solr/pull/1841#discussion_r1294974887
##
solr/core/src/java/org/apache/solr/api/AnnotatedApi.java:
##
@@ -215,7 +214,6 @@ public void call(SolrQueryRequest req, SolrQueryResponse
rsp) {
}
for (Comm
janhoy commented on code in PR #1841:
URL: https://github.com/apache/solr/pull/1841#discussion_r1294974887
##
solr/core/src/java/org/apache/solr/api/AnnotatedApi.java:
##
@@ -215,7 +214,6 @@ public void call(SolrQueryRequest req, SolrQueryResponse
rsp) {
}
for (Comm
janhoy commented on code in PR #1841:
URL: https://github.com/apache/solr/pull/1841#discussion_r1294975785
##
solr/modules/opentelemetry/src/java/org/apache/solr/opentelemetry/OtelTracerConfigurator.java:
##
@@ -16,38 +16,56 @@
*/
package org.apache.solr.opentelemetry;
-imp
Alex Deparvu created SOLR-16935:
---
Summary: Add spans to cover gaps in query processing
Key: SOLR-16935
URL: https://issues.apache.org/jira/browse/SOLR-16935
Project: Solr
Issue Type: Sub-task
Houston Putman created SOLR-16934:
-
Summary: Solr does not have permissions to read from the client
truststore/keystore
Key: SOLR-16934
URL: https://issues.apache.org/jira/browse/SOLR-16934
Project: S
Houston Putman created SOLR-16933:
-
Summary: The API Tool throws away the response for Solr Queries
Key: SOLR-16933
URL: https://issues.apache.org/jira/browse/SOLR-16933
Project: Solr
Issue T
madrob commented on issue #600:
URL: https://github.com/apache/solr-operator/issues/600#issuecomment-1678967712
Do we have input from the zookeeper community about their preferred or
recommended approach?
--
This is an automated message from the Apache Git Service.
To respond to the messa
janhoy opened a new issue, #600:
URL: https://github.com/apache/solr-operator/issues/600
Ref discussions in
https://github.com/apache/solr-operator/issues/517#issuecomment-1428310490
The ZK operator is a project that is not well maintained ([74 open
issues](https://github.com/pravega
stillalex commented on PR #1841:
URL: https://github.com/apache/solr/pull/1841#issuecomment-1678936745
Thank you @janhoy for the review!
I think the biggest question was the removal of span.log. it felt strange to
have logs mixed with spans. maybe I misunderstood the use. happy to loo
stillalex commented on code in PR #1841:
URL: https://github.com/apache/solr/pull/1841#discussion_r1294595678
##
solr/core/src/java/org/apache/solr/util/tracing/HttpServletRequestGetter.java:
##
@@ -0,0 +1,42 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
stillalex commented on code in PR #1841:
URL: https://github.com/apache/solr/pull/1841#discussion_r1294592758
##
solr/core/src/java/org/apache/solr/servlet/HttpSolrCall.java:
##
@@ -977,15 +979,32 @@ protected void writeResponse(
}
if (Method.HEAD != reqMethod) {
stillalex commented on code in PR #1841:
URL: https://github.com/apache/solr/pull/1841#discussion_r1294592415
##
solr/core/src/java/org/apache/solr/handler/RequestHandlerBase.java:
##
@@ -241,6 +243,18 @@ public void handleRequest(SolrQueryRequest req,
SolrQueryResponse rsp) {
stillalex commented on code in PR #1841:
URL: https://github.com/apache/solr/pull/1841#discussion_r1294580656
##
solr/core/src/java/org/apache/solr/api/V2HttpCall.java:
##
@@ -510,18 +507,21 @@ protected void populateTracingSpan(Span span) {
// if this api has commands ...
stillalex commented on code in PR #1841:
URL: https://github.com/apache/solr/pull/1841#discussion_r1294556596
##
solr/core/src/java/org/apache/solr/servlet/HttpSolrCall.java:
##
@@ -977,15 +979,32 @@ protected void writeResponse(
}
if (Method.HEAD != reqMethod) {
stillalex commented on code in PR #1841:
URL: https://github.com/apache/solr/pull/1841#discussion_r1294577381
##
solr/modules/opentelemetry/src/java/org/apache/solr/opentelemetry/OtelTracerConfigurator.java:
##
@@ -16,38 +16,56 @@
*/
package org.apache.solr.opentelemetry;
-
stillalex commented on code in PR #1841:
URL: https://github.com/apache/solr/pull/1841#discussion_r1294556596
##
solr/core/src/java/org/apache/solr/servlet/HttpSolrCall.java:
##
@@ -977,15 +979,32 @@ protected void writeResponse(
}
if (Method.HEAD != reqMethod) {
stillalex commented on code in PR #1841:
URL: https://github.com/apache/solr/pull/1841#discussion_r1294555321
##
solr/modules/opentelemetry/src/java/org/apache/solr/opentelemetry/OtelTracerConfigurator.java:
##
@@ -16,38 +16,56 @@
*/
package org.apache.solr.opentelemetry;
-
stillalex commented on code in PR #1841:
URL: https://github.com/apache/solr/pull/1841#discussion_r1294554607
##
solr/core/src/java/org/apache/solr/core/TracerConfigurator.java:
##
@@ -17,83 +17,88 @@
package org.apache.solr.core;
-import io.opentracing.Scope;
-import io.op
stillalex commented on code in PR #1841:
URL: https://github.com/apache/solr/pull/1841#discussion_r1294552518
##
solr/modules/opentelemetry/src/java/org/apache/solr/opentelemetry/OtelTracerConfigurator.java:
##
@@ -16,38 +16,56 @@
*/
package org.apache.solr.opentelemetry;
-
stillalex commented on code in PR #1841:
URL: https://github.com/apache/solr/pull/1841#discussion_r1294549451
##
solr/core/src/java/org/apache/solr/api/AnnotatedApi.java:
##
@@ -215,7 +214,6 @@ public void call(SolrQueryRequest req, SolrQueryResponse
rsp) {
}
for (C
janhoy commented on PR #1841:
URL: https://github.com/apache/solr/pull/1841#issuecomment-1678855564
> WARNING: there were unreferenced files under license folder:
> -
/home/runner/work/solr/solr/solr/licenses/opentracing-api-LICENSE-ASL.txt
> - /home/runner/work/solr/solr/solr/lice
janhoy commented on PR #1841:
URL: https://github.com/apache/solr/pull/1841#issuecomment-1678854385
> Dependency analysis found issues.
> usedUndeclaredArtifacts
>- io.opentelemetry:opentelemetry-api:1.28.0@jar
>- org.apache.solr:solrj:10.0.0-SNAPSHOT@
> unusedDeclared
janhoy commented on code in PR #1841:
URL: https://github.com/apache/solr/pull/1841#discussion_r1294526185
##
solr/core/src/java/org/apache/solr/servlet/HttpSolrCall.java:
##
@@ -977,15 +979,32 @@ protected void writeResponse(
}
if (Method.HEAD != reqMethod) {
-
janhoy commented on code in PR #1841:
URL: https://github.com/apache/solr/pull/1841#discussion_r1294524997
##
solr/core/src/java/org/apache/solr/core/TracerConfigurator.java:
##
@@ -17,83 +17,88 @@
package org.apache.solr.core;
-import io.opentracing.Scope;
-import io.opent
janhoy commented on code in PR #1841:
URL: https://github.com/apache/solr/pull/1841#discussion_r1294442984
##
solr/modules/opentelemetry/src/java/org/apache/solr/opentelemetry/OtelTracerConfigurator.java:
##
@@ -16,38 +16,56 @@
*/
package org.apache.solr.opentelemetry;
-imp
Raghavan1988 opened a new pull request, #1842:
URL: https://github.com/apache/solr/pull/1842
https://issues.apache.org/jira/browse/SOLR-16644
# Description
Entropy has been adjusted in the ubuntu kernels > 5.15+ causing warning to
be echoed.
# Solution
Introduce
48 matches
Mail list logo
