[GitHub] [solr] dsmiley commented on a diff in pull request #1854: SOLR-15367 Convert "rid" functionality into a default Tracer

2023-08-19 Thread via GitHub
dsmiley commented on code in PR #1854: URL: https://github.com/apache/solr/pull/1854#discussion_r1299299408 ## solr/modules/opentelemetry/src/test/org/apache/solr/opentelemetry/TestSimplePropagatorDistributedTracing.java: ## @@ -0,0 +1,101 @@ +/* + * Licensed to the Apache Softw

[GitHub] [solr] solrbot commented on pull request #1855: Update org.eclipse.jetty*:* (major)

2023-08-19 Thread via GitHub
solrbot commented on PR #1855: URL: https://github.com/apache/solr/pull/1855#issuecomment-1685144972 ### ⚠ Artifact update problem Renovate failed to update artifacts related to this branch. You probably do not want to merge this PR as-is. ♻ Renovate will retry this branch, inc

[GitHub] [solr] solrbot opened a new pull request, #1855: Update org.eclipse.jetty*:* (major)

2023-08-19 Thread via GitHub
solrbot opened a new pull request, #1855: URL: https://github.com/apache/solr/pull/1855 This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [org.eclipse.jetty.http2:http2-server](https://eclipse.org/jetty) ([source](https://togithub.c

[GitHub] [solr] stillalex commented on pull request #1854: SOLR-15367 Convert "rid" functionality into a default Tracer

2023-08-19 Thread via GitHub
stillalex commented on PR #1854: URL: https://github.com/apache/solr/pull/1854#issuecomment-1685121875 > It's kind of a shame to require the whole open tracing SDK for this functionality but so be it. you raise a very interesting point, and I think this could work without the sdk. it

[GitHub] [solr] stillalex commented on a diff in pull request #1854: SOLR-15367 Convert "rid" functionality into a default Tracer

2023-08-19 Thread via GitHub
stillalex commented on code in PR #1854: URL: https://github.com/apache/solr/pull/1854#discussion_r1299273700 ## solr/modules/opentelemetry/src/java/org/apache/solr/opentelemetry/simplepropagator/SimplePropagator.java: ## @@ -0,0 +1,82 @@ +/* + * Licensed to the Apache Software

[GitHub] [solr] stillalex commented on a diff in pull request #1854: SOLR-15367 Convert "rid" functionality into a default Tracer

2023-08-19 Thread via GitHub
stillalex commented on code in PR #1854: URL: https://github.com/apache/solr/pull/1854#discussion_r1299273658 ## solr/modules/opentelemetry/src/test/org/apache/solr/opentelemetry/TestSimplePropagatorDistributedTracing.java: ## @@ -0,0 +1,101 @@ +/* + * Licensed to the Apache Sof

[GitHub] [solr] stillalex commented on a diff in pull request #1854: SOLR-15367 Convert "rid" functionality into a default Tracer

2023-08-19 Thread via GitHub
stillalex commented on code in PR #1854: URL: https://github.com/apache/solr/pull/1854#discussion_r1299273617 ## solr/modules/opentelemetry/src/test/org/apache/solr/opentelemetry/TestSimplePropagatorDistributedTracing.java: ## @@ -0,0 +1,101 @@ +/* + * Licensed to the Apache Sof

[GitHub] [solr] stillalex commented on a diff in pull request #1854: SOLR-15367 Convert "rid" functionality into a default Tracer

2023-08-19 Thread via GitHub
stillalex commented on code in PR #1854: URL: https://github.com/apache/solr/pull/1854#discussion_r1299273498 ## solr/modules/opentelemetry/src/test/org/apache/solr/opentelemetry/TestSimplePropagatorDistributedTracing.java: ## @@ -0,0 +1,101 @@ +/* + * Licensed to the Apache Sof

[GitHub] [solr] dsmiley commented on a diff in pull request #1854: SOLR-15367 Convert "rid" functionality into a default Tracer

2023-08-19 Thread via GitHub
dsmiley commented on code in PR #1854: URL: https://github.com/apache/solr/pull/1854#discussion_r1299243709 ## solr/modules/opentelemetry/src/test/org/apache/solr/opentelemetry/TestSimplePropagatorDistributedTracing.java: ## @@ -0,0 +1,101 @@ +/* + * Licensed to the Apache Softw

[jira] [Commented] (SOLR-15367) Convert "rid" functionality into a default Tracer

2023-08-19 Thread Alex Deparvu (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17756314#comment-17756314 ] Alex Deparvu commented on SOLR-15367: - Opened a draft PR to show how this can be done

[GitHub] [solr] stillalex commented on pull request #1854: SOLR-15367 Convert "rid" functionality into a default Tracer

2023-08-19 Thread via GitHub
stillalex commented on PR #1854: URL: https://github.com/apache/solr/pull/1854#issuecomment-1684942884 @dsmiley would love your thoughts on this one. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [solr] stillalex opened a new pull request, #1854: SOLR-15367 Convert "rid" functionality into a default Tracer

2023-08-19 Thread via GitHub
stillalex opened a new pull request, #1854: URL: https://github.com/apache/solr/pull/1854 https://issues.apache.org/jira/browse/SOLR-15367 # Description Trace Id propagation only - based on OTEL mechanism. this will only pickup the id from the incoming request (or g