[GitHub] [solr-operator] himanshu-d-soni-db commented on issue #331: Support JWT authentication

himanshu-d-soni-db commented on issue #331: URL: https://github.com/apache/solr-operator/issues/331#issuecomment-1687526606 does SOLR support Solrj client with JWT ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [solr] dsmiley opened a new pull request, #1856: SOLR-16943 Move Jetty HttpClient tracing into InstrumentedHttpListenerFactory

dsmiley opened a new pull request, #1856: URL: https://github.com/apache/solr/pull/1856 https://issues.apache.org/jira/browse/SOLR-16943 TODO the client side span but the test integration from my fork is a PITA to integrate into changes to TestDistributedTracing -- This is an autom

[jira] [Created] (SOLR-16943) Add client tracing spans to HTTP interaction; at least for Jetty HttpClient

David Smiley created SOLR-16943: --- Summary: Add client tracing spans to HTTP interaction; at least for Jetty HttpClient Key: SOLR-16943 URL: https://issues.apache.org/jira/browse/SOLR-16943 Project: Solr

[GitHub] [solr] dsmiley commented on a diff in pull request #1854: SOLR-15367 Convert "rid" functionality into a default Tracer

dsmiley commented on code in PR #1854: URL: https://github.com/apache/solr/pull/1854#discussion_r1300892286 ## solr/core/src/test/org/apache/solr/util/tracing/TestSimplePropagatorDistributedTracing.java: ## @@ -114,6 +115,26 @@ public void test() throws IOException, SolrServerEx

[jira] [Commented] (SOLR-16938) Auto configure tracer without a tag in solr.xml

[ https://issues.apache.org/jira/browse/SOLR-16938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17757178#comment-17757178 ] David Smiley commented on SOLR-16938: - I have such trace manipulations that are somew

[GitHub] [solr] dsmiley commented on pull request #1827: SOLR-16916: JSON boolean queries when solrconfig defType is set to edismax

dsmiley commented on PR #1827: URL: https://github.com/apache/solr/pull/1827#issuecomment-1687328255 Instructions: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/allowing-changes-to-a-pull-request-branch-created-from-a-fork#enabling-repository-m

[GitHub] [solr] wrunderwood commented on pull request #96: SOLR-15056: add circuit breaker for CPU, fix load circuit breaker

wrunderwood commented on PR #96: URL: https://github.com/apache/solr/pull/96#issuecomment-1687150222 > On Jun 2, 2023, at 1:41 AM, Jan Høydahl ***@***.***> wrote: > @wrunderwood , @atris , it's a shame that this fine PR was aband

[GitHub] [solr] stillalex commented on pull request #1854: SOLR-15367 Convert "rid" functionality into a default Tracer

stillalex commented on PR #1854: URL: https://github.com/apache/solr/pull/1854#issuecomment-1687120500 I took a stab at having this on by default, just to see what the tests say. and it looks ok so far. I am also open to not doing this right away, to allow for some more testing time. --

[jira] [Commented] (SOLR-16938) Auto configure tracer without a tag in solr.xml

[ https://issues.apache.org/jira/browse/SOLR-16938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17757107#comment-17757107 ] Jan Høydahl commented on SOLR-16938: > How might one configure their own tracing cust

[GitHub] [solr] stillalex commented on pull request #1854: SOLR-15367 Convert "rid" functionality into a default Tracer

stillalex commented on PR #1854: URL: https://github.com/apache/solr/pull/1854#issuecomment-1687016572 @dsmiley I added a tentative update for the apache httpclient based you feedback so far. please take a look. the test is fragile, as it assumes the api call will rely on apache http client

[GitHub] [solr] stillalex commented on pull request #1854: SOLR-15367 Convert "rid" functionality into a default Tracer

stillalex commented on PR #1854: URL: https://github.com/apache/solr/pull/1854#issuecomment-1686762490 > I disagree; both are "instrumentation" and the class name was already chosen in this generic way instead of being called MetricsBlahBlahBlah. Nonetheless the concerns could be split up t

[GitHub] [solr] dsmiley commented on pull request #1854: SOLR-15367 Convert "rid" functionality into a default Tracer

dsmiley commented on PR #1854: URL: https://github.com/apache/solr/pull/1854#issuecomment-1686750517 > I don't think it's a very good idea to mix functionality like this (metrics collection with tracing headers) I disagree; both are "instrumentation" and the class name was already cho

[GitHub] [solr] stillalex commented on pull request #1854: SOLR-15367 Convert "rid" functionality into a default Tracer

stillalex commented on PR #1854: URL: https://github.com/apache/solr/pull/1854#issuecomment-1686650312 I think I understand what you are saying. but I think it was misleading to say propagation doesn't work (I think you partially corrected later by saying "won't propagate tracing"). a more

[jira] [Assigned] (SOLR-16929) SolrStream propagates undecoded error message

[ https://issues.apache.org/jira/browse/SOLR-16929?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alex Deparvu reassigned SOLR-16929: --- Assignee: Alex Deparvu > SolrStream propagates undecoded error message > ---

[GitHub] [solr] sandbergja commented on pull request #1827: SOLR-16916: JSON boolean queries when solrconfig defType is set to edismax

sandbergja commented on PR #1827: URL: https://github.com/apache/solr/pull/1827#issuecomment-1686541162 Thanks for helping us out with this, @dsmiley ! I was unable to find that setting, so I invited you to have write access to our fork. -- This is an automated message from the Apache Gi

[GitHub] [solr] dsmiley commented on pull request #1854: SOLR-15367 Convert "rid" functionality into a default Tracer

dsmiley commented on PR #1854: URL: https://github.com/apache/solr/pull/1854#issuecomment-1686429704 My local change is to `InstrumentedHttpRequestExecutor` to add a client span and to inject trace headers. This class is used in UpdateShardHandler to create the "defaultClient" (Apache Http

[jira] [Commented] (SOLR-16620) Solr CLI should be able to do a node healthcheck

[ https://issues.apache.org/jira/browse/SOLR-16620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17756925#comment-17756925 ] Houston Putman commented on SOLR-16620: --- We have an integration test for with SSL a

[GitHub] [solr] stillalex commented on pull request #1854: SOLR-15367 Convert "rid" functionality into a default Tracer

stillalex commented on PR #1854: URL: https://github.com/apache/solr/pull/1854#issuecomment-1686314216 > FYI, one gap in propagation is that our Apache HttpClient isn't instrumented with tracing, only the Jetty HttpClient. I actually have a fix for this locally. could you be a bit mo

[jira] [Resolved] (SOLR-16927) Allow SolrClientCache clients to use Jetty HTTP2 clients

[ https://issues.apache.org/jira/browse/SOLR-16927?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alex Deparvu resolved SOLR-16927. - Fix Version/s: 9.4 Resolution: Fixed > Allow SolrClientCache clients to use Jetty HTTP2 cl

[jira] [Commented] (SOLR-16927) Allow SolrClientCache clients to use Jetty HTTP2 clients

[ https://issues.apache.org/jira/browse/SOLR-16927?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17756887#comment-17756887 ] ASF subversion and git services commented on SOLR-16927: Commit b

[jira] [Commented] (SOLR-16927) Allow SolrClientCache clients to use Jetty HTTP2 clients

[ https://issues.apache.org/jira/browse/SOLR-16927?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17756882#comment-17756882 ] ASF subversion and git services commented on SOLR-16927: Commit f

[GitHub] [solr] stillalex merged pull request #1835: SOLR-16927 Allow SolrClientCache clients to use Jetty HTTP2 clients

stillalex merged PR #1835: URL: https://github.com/apache/solr/pull/1835 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.

[jira] [Commented] (SOLR-7233) rename zkcli.sh script it clashes with zkCli.sh from ZooKeeper on Mac when both are in $PATH

[ https://issues.apache.org/jira/browse/SOLR-7233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17756861#comment-17756861 ] Eric Pugh commented on SOLR-7233: - Btw, for anyone tracking this issue, it will be closed

[jira] [Commented] (SOLR-16900) Add/fix wrong/missing "solr.home" to zkcli scripts

[ https://issues.apache.org/jira/browse/SOLR-16900?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17756858#comment-17756858 ] Eric Pugh commented on SOLR-16900: -- thanks [~Idjeraoui] > Add/fix wrong/missing "solr.h

[jira] [Resolved] (SOLR-16900) Add/fix wrong/missing "solr.home" to zkcli scripts

[ https://issues.apache.org/jira/browse/SOLR-16900?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eric Pugh resolved SOLR-16900. -- Fix Version/s: main (10.0) 9.4 Assignee: Eric Pugh Resolution: Fixed

[jira] [Updated] (SOLR-16900) Add/fix wrong/missing "solr.home" to zkcli scripts

[ https://issues.apache.org/jira/browse/SOLR-16900?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eric Pugh updated SOLR-16900: - Component/s: cli SolrCLI > Add/fix wrong/missing "solr.home" to zkcli scripts >

[GitHub] [solr] epugh merged pull request #1798: Add/fix wrong/missing "solr.home" to zkcli scripts

epugh merged PR #1798: URL: https://github.com/apache/solr/pull/1798 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

[jira] [Comment Edited] (SOLR-16620) Solr CLI should be able to do a node healthcheck

[ https://issues.apache.org/jira/browse/SOLR-16620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17756855#comment-17756855 ] Eric Pugh edited comment on SOLR-16620 at 8/21/23 11:32 AM: [

[jira] [Commented] (SOLR-16620) Solr CLI should be able to do a node healthcheck

[ https://issues.apache.org/jira/browse/SOLR-16620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17756855#comment-17756855 ] Eric Pugh commented on SOLR-16620: -- [~houston]is the description above still accurate?

[jira] [Commented] (SOLR-15771) bin/solr auth enable should model best practices for security.json

[ https://issues.apache.org/jira/browse/SOLR-15771?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17756853#comment-17756853 ] Eric Pugh commented on SOLR-15771: -- The PR is ready for review. One thought that struc

[jira] [Commented] (SOLR-16928) Add missing unit tests for utilities in solr-core

[ https://issues.apache.org/jira/browse/SOLR-16928?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17756731#comment-17756731 ] Mikhail Khludnev commented on SOLR-16928: - Thank you [~jrhenderson1988] > Add mi

[jira] [Updated] (SOLR-16928) Add missing unit tests for utilities in solr-core

[ https://issues.apache.org/jira/browse/SOLR-16928?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mikhail Khludnev updated SOLR-16928: Fix Version/s: 9.4 > Add missing unit tests for utilities in solr-core > --

[jira] [Resolved] (SOLR-16928) Add missing unit tests for utilities in solr-core

[ https://issues.apache.org/jira/browse/SOLR-16928?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mikhail Khludnev resolved SOLR-16928. - Resolution: Fixed > Add missing unit tests for utilities in solr-core > -