stillalex commented on code in PR #1374:
URL: https://github.com/apache/solr/pull/1374#discussion_r1306315310
##
solr/test-framework/src/java/org/apache/solr/util/SolrJettyTestRule.java:
##
@@ -0,0 +1,129 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or m
stillalex commented on code in PR #1374:
URL: https://github.com/apache/solr/pull/1374#discussion_r1306313084
##
solr/solrj/src/test/org/apache/solr/client/solrj/impl/Http2SolrClientProxyTest.java:
##
Review Comment:
looks good! I like this approach and being the only proxy
dsmiley commented on code in PR #1374:
URL: https://github.com/apache/solr/pull/1374#discussion_r1306288103
##
solr/solrj/src/test/org/apache/solr/client/solrj/impl/Http2SolrClientProxyTest.java:
##
Review Comment:
@stillalex please take a look at my changes here and let me
dsmiley commented on code in PR #1632:
URL: https://github.com/apache/solr/pull/1632#discussion_r1306186982
##
solr/core/src/test/org/apache/solr/servlet/HideStackTraceTest.java:
##
@@ -0,0 +1,131 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ *
stillalex commented on PR #1632:
URL: https://github.com/apache/solr/pull/1632#issuecomment-1693878618
I'm not seeing a new build, I think you have to force push the rebase so the
build can apply correctly
--
This is an automated message from the Apache Git Service.
To respond to the mess
igiguere commented on PR #1632:
URL: https://github.com/apache/solr/pull/1632#issuecomment-1693865778
I rebased this branch on the fork's main (up to date with /solr main).
There were no changes to push, so I don't know if a build will be triggered.
Hopefully, it will work.
--
This is
gerlowskija merged PR #57:
URL: https://github.com/apache/solr-sandbox/pull/57
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.a
psalagnac commented on PR #1864:
URL: https://github.com/apache/solr/pull/1864#issuecomment-1693795795
> this looks very good! much easier to follow along!
> the only minor suggestion would be to add the `isExpensive()` method to
implementors of `CoreAdminAPIBase` which look like candidat
[
https://issues.apache.org/jira/browse/SOLR-16951?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tomas Eduardo Fernandez Lobbe updated SOLR-16951:
-
Affects Version/s: 9.2
9.1
Tomas Eduardo Fernandez Lobbe created SOLR-16951:
Summary: HttpShardHandler perf degradation in Solr 9
Key: SOLR-16951
URL: https://issues.apache.org/jira/browse/SOLR-16951
Project: Sol
[
https://issues.apache.org/jira/browse/SOLR-16951?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tomas Eduardo Fernandez Lobbe updated SOLR-16951:
-
Summary: HttpShardHandler performance degradation in Solr 9 (was:
igiguere commented on PR #1632:
URL: https://github.com/apache/solr/pull/1632#issuecomment-1693777248
@stillalex : I'm in CHANGES.txt a couple of times with my full name
Isabelle Giguere
--
This is an automated message from the Apache Git Service.
To respond to the message, please lo
stillalex commented on PR #1632:
URL: https://github.com/apache/solr/pull/1632#issuecomment-1693721799
@igiguere could you rebase on top of main branch (as suggested on the dev
list)?
also what name should I use in the CHANGES.txt entry for the credit?
--
This is an automated messa
stillalex commented on PR #1864:
URL: https://github.com/apache/solr/pull/1864#issuecomment-1693694755
this looks very good! much easier to follow along!
the only minor suggestion would be to add the `isExpensive()` method to
implementors of `CoreAdminAPIBase` which look like candidates f
[
https://issues.apache.org/jira/browse/SOLR-15367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17759115#comment-17759115
]
Chris M. Hostetter commented on SOLR-15367:
---
blargh ... ok, yeah sorry – i don'
mcarroll1 commented on issue #471:
URL: https://github.com/apache/solr-operator/issues/471#issuecomment-1693639328
Also looking forward to some of the features suggested above...
This probably won't be the route for the operator, but posting an
alternative idea here for others. Our c
[
https://issues.apache.org/jira/browse/SOLR-16916?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Smiley resolved SOLR-16916.
-
Fix Version/s: 9.4
Assignee: David Smiley
Resolution: Fixed
Thanks for contributi
[
https://issues.apache.org/jira/browse/SOLR-16916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17759078#comment-17759078
]
ASF subversion and git services commented on SOLR-16916:
Commit 7
janhoy commented on PR #1725:
URL: https://github.com/apache/solr/pull/1725#issuecomment-1693434188
> When you said "Then this is a nice foundation to build /update circuit
breaking on top of.", I this caught my interest as this is what we're doing
with Solr where I work. If this PR doesn't
epugh commented on PR #1834:
URL: https://github.com/apache/solr/pull/1834#issuecomment-1693381033
Please do! The improvement in the 9x line (as well as main) to the code
quality has been huge, but there is so much more to do.
--
This is an automated message from the Apache Git Servic
dsmiley commented on PR #1725:
URL: https://github.com/apache/solr/pull/1725#issuecomment-1693373966
When you said "Then this is a nice foundation to build /update circuit
breaking on top of.", I this caught my interest as this is what we're doing
with Solr where I work. If this PR doesn't
gerlowskija commented on PR #65:
URL: https://github.com/apache/solr-sandbox/pull/65#issuecomment-1693323424
LGTM on the whole.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific commen
gerlowskija commented on code in PR #65:
URL: https://github.com/apache/solr-sandbox/pull/65#discussion_r1305629572
##
crossdc-producer/src/main/java/org/apache/solr/update/processor/MirroringUpdateRequestProcessorFactory.java:
##
@@ -152,6 +149,22 @@ public void inform(SolrCore
[
https://issues.apache.org/jira/browse/SOLR-16925?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17759019#comment-17759019
]
Ovidiu Mihalcea commented on SOLR-16925:
[~raghavanm] Do you have any updates on
janhoy commented on PR #1725:
URL: https://github.com/apache/solr/pull/1725#issuecomment-1692976849
> My colleagues have done some custom Circuit Breaking stuff in Solr... I'm
hoping one of them might weigh-in here so please don't merge too quickly.
This is not really touching the exi
[
https://issues.apache.org/jira/browse/SOLR-14755?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jan Høydahl updated SOLR-14755:
---
Component/s: Circuit Breakers
> Dedicated Exception Type for Circuit Breakers
> -
[
https://issues.apache.org/jira/browse/SOLR-15056?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jan Høydahl updated SOLR-15056:
---
Component/s: Circuit Breakers
> CPU circuit breaker needs to use CPU utilization, not Unix load avera
[
https://issues.apache.org/jira/browse/SOLR-16216?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jan Høydahl updated SOLR-16216:
---
Component/s: Circuit Breakers
> Circuit Breaker - Kill only the particular search request crossing th
[
https://issues.apache.org/jira/browse/SOLR-15474?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jan Høydahl updated SOLR-15474:
---
Component/s: Circuit Breakers
> pluggable support for custom circuit breakers
> -
29 matches
Mail list logo
