[
https://issues.apache.org/jira/browse/SOLR-14298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17442131#comment-17442131
]
Noble Paul edited comment on SOLR-14298 at 9/7/23 6:29 AM:
---
[~h
dsmiley commented on code in PR #1868:
URL: https://github.com/apache/solr/pull/1868#discussion_r1318070066
##
solr/test-framework/src/java/org/apache/solr/cloud/MiniSolrCloudCluster.java:
##
@@ -1341,5 +1349,10 @@ public Builder withDefaultClusterProperty(String key,
String va
stillalex commented on PR #1868:
URL: https://github.com/apache/solr/pull/1868#issuecomment-1709448692
@dsmiley would like to merge this soon. do you think the context
injection/extraction parts are correct now?
and apologies for the force merge, I wanted to rebase on top of other
backpo
stillalex commented on PR #1884:
URL: https://github.com/apache/solr/pull/1884#issuecomment-1709444570
I sat on this a bit and realized I would prefer adding a test to 9.x
backport and ended up rewriting it so it fits with 9.x constructs. makes me
feel a tiny bit more confident that this re
[
https://issues.apache.org/jira/browse/SOLR-16955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17762515#comment-17762515
]
Alex Deparvu edited comment on SOLR-16955 at 9/7/23 4:04 AM:
-
[
https://issues.apache.org/jira/browse/SOLR-16955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17762561#comment-17762561
]
ASF subversion and git services commented on SOLR-16955:
Commit 8
[
https://issues.apache.org/jira/browse/SOLR-16955?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alex Deparvu resolved SOLR-16955.
-
Resolution: Fixed
fixed on main and I did a best effort backport to 9.x. the test did not make it
[
https://issues.apache.org/jira/browse/SOLR-16955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17762514#comment-17762514
]
ASF subversion and git services commented on SOLR-16955:
Commit 4
[
https://issues.apache.org/jira/browse/SOLR-16955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17762507#comment-17762507
]
ASF subversion and git services commented on SOLR-16955:
Commit b
stillalex merged PR #1884:
URL: https://github.com/apache/solr/pull/1884
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.
dsmiley commented on PR #1884:
URL: https://github.com/apache/solr/pull/1884#issuecomment-1709155346
I'm very sympathetic to the pain of maintaining tests of distributed
tracing! Okay by me to skip such a test in 9x. We don't test details of our
logs... yet we do with tracing... :shrug:
xtenzQ commented on PR #1829:
URL: https://github.com/apache/solr/pull/1829#issuecomment-1709082973
@janhoy I'm not sure if I can improve my fix in some way.
Also, I apologize for the late reply, I was on the move.
--
This is an automated message from the Apache Git Service.
To res
stillalex commented on PR #1884:
URL: https://github.com/apache/solr/pull/1884#issuecomment-1709046355
thank you @dsmiley for the continued review, I am getting ready to merge.
one more aspect of this is the backport to 9.x. it will be extremely
complicated to take the test as is. one eas
janhoy commented on code in PR #96:
URL: https://github.com/apache/solr/pull/96#discussion_r1315215619
##
solr/core/src/java/org/apache/solr/util/circuitbreaker/CPUCircuitBreaker.java:
##
@@ -17,54 +17,49 @@
package org.apache.solr.util.circuitbreaker;
+import com.codahale.
magibney commented on code in PR #1895:
URL: https://github.com/apache/solr/pull/1895#discussion_r1317756118
##
solr/core/src/java/org/apache/solr/core/SolrCore.java:
##
@@ -391,10 +390,6 @@ public String getDataDir() {
return dataDir;
}
- public String getUlogDir() {
magibney opened a new pull request, #1895:
URL: https://github.com/apache/solr/pull/1895
See: SOLR-16962
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-m
Michael Gibney created SOLR-16962:
-
Summary: updateLog tlog dir location config is silently ignored
Key: SOLR-16962
URL: https://issues.apache.org/jira/browse/SOLR-16962
Project: Solr
Issue
[
https://issues.apache.org/jira/browse/SOLR-16951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17762483#comment-17762483
]
Tomas Eduardo Fernandez Lobbe commented on SOLR-16951:
--
Yes, this is
AndreyBozhko opened a new pull request, #1894:
URL: https://github.com/apache/solr/pull/1894
https://issues.apache.org/jira/browse/SOLR-X
# Description
Fix a copy-paste error in the docs for Protected Term Filter.
# Solution
Please provide a short d
stillalex merged PR #1888:
URL: https://github.com/apache/solr/pull/1888
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.
[
https://issues.apache.org/jira/browse/SOLR-16825?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17762431#comment-17762431
]
ASF subversion and git services commented on SOLR-16825:
Commit 9
[
https://issues.apache.org/jira/browse/SOLR-16825?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17762427#comment-17762427
]
ASF subversion and git services commented on SOLR-16825:
Commit b
gerlowskija merged PR #1885:
URL: https://github.com/apache/solr/pull/1885
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apach
Jan Høydahl created SOLR-16961:
--
Summary: Remove deprecated CircuitBreakerManager in 10.0
Key: SOLR-16961
URL: https://issues.apache.org/jira/browse/SOLR-16961
Project: Solr
Issue Type: Task
sigram opened a new pull request, #67:
URL: https://github.com/apache/solr-sandbox/pull/67
Simple Helm chart with a deployment descriptor, and a Jib-based image build.
I added a wrapper to make it easier to pass configuration properties through
environment. We could also roll this int
[
https://issues.apache.org/jira/browse/SOLR-16954?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jan Høydahl resolved SOLR-16954.
Fix Version/s: 9.4
Resolution: Fixed
> Circuit breaker for update requests
> ---
[
https://issues.apache.org/jira/browse/SOLR-16954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17762403#comment-17762403
]
ASF subversion and git services commented on SOLR-16954:
Commit 9
[
https://issues.apache.org/jira/browse/SOLR-16954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17762392#comment-17762392
]
ASF subversion and git services commented on SOLR-16954:
Commit a
janhoy merged PR #1871:
URL: https://github.com/apache/solr/pull/1871
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
[
https://issues.apache.org/jira/browse/SOLR-16917?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alex Deparvu resolved SOLR-16917.
-
Fix Version/s: 9.4
Resolution: Fixed
I verified on 9.3 and indeed there is a 404 but with
[
https://issues.apache.org/jira/browse/SOLR-16951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17762364#comment-17762364
]
Alex Deparvu commented on SOLR-16951:
-
have you checked on 9.3 as well? after SOLR-16
sigram opened a new pull request, #66:
URL: https://github.com/apache/solr-sandbox/pull/66
This test verifies that the optimization in `ExposedByteArrayOutputStream`
(which sometimes produces trailing zeroes in the raw buffer) works correctly
with de-serialization.
--
This is an automate
cpoerschke merged PR #1771:
URL: https://github.com/apache/solr/pull/1771
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache
cpoerschke commented on PR #1871:
URL: https://github.com/apache/solr/pull/1871#issuecomment-1708028911
Hmm, precommit failed with `run the top-level './gradlew tidy' to format
code automatically (see help/formatting.txt for more info).` advisory --
independent of this pull request really,
psalagnac opened a new pull request, #1893:
URL: https://github.com/apache/solr/pull/1893
https://issues.apache.org/jira/browse/SOLR-16953
# Description
`ExtendedDismaxParser` generates _boosts_ queries from parameter `pf` for
unwanted terms when using grouped field
renatoh commented on PR #1873:
URL: https://github.com/apache/solr/pull/1873#issuecomment-1707871257
@cpoerschke I did another merge of origin/main, it looks like the checks
have now passed, or haven't they?
--
This is an automated message from the Apache Git Service.
To respond to the me
janhoy commented on PR #1871:
URL: https://github.com/apache/solr/pull/1871#issuecomment-1707853260
Thanks for the attention to detail @cpoerschke. Accepted all your edits.
Will merge today.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
janhoy commented on code in PR #1871:
URL: https://github.com/apache/solr/pull/1871#discussion_r1316882036
##
solr/core/src/java/org/apache/solr/util/circuitbreaker/CircuitBreaker.java:
##
@@ -52,4 +62,48 @@ public CircuitBreaker() {}
/** Get error message when the circuit
38 matches
Mail list logo