[jira] [Comment Edited] (SOLR-14298) LBSolrClient.checkAZombieServer should be less stupid

2023-09-06 Thread Noble Paul (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17442131#comment-17442131 ] Noble Paul edited comment on SOLR-14298 at 9/7/23 6:29 AM: --- [~h

[GitHub] [solr] dsmiley commented on a diff in pull request #1868: SOLR-15367 [9.x] Convert "rid" functionality into a default Tracer

2023-09-06 Thread via GitHub
dsmiley commented on code in PR #1868: URL: https://github.com/apache/solr/pull/1868#discussion_r1318070066 ## solr/test-framework/src/java/org/apache/solr/cloud/MiniSolrCloudCluster.java: ## @@ -1341,5 +1349,10 @@ public Builder withDefaultClusterProperty(String key, String va

[GitHub] [solr] stillalex commented on pull request #1868: SOLR-15367 [9.x] Convert "rid" functionality into a default Tracer

2023-09-06 Thread via GitHub
stillalex commented on PR #1868: URL: https://github.com/apache/solr/pull/1868#issuecomment-1709448692 @dsmiley would like to merge this soon. do you think the context injection/extraction parts are correct now? and apologies for the force merge, I wanted to rebase on top of other backpo

[GitHub] [solr] stillalex commented on pull request #1884: SOLR-16955 Tracing v2 apis breaks SecurityConfHandler

2023-09-06 Thread via GitHub
stillalex commented on PR #1884: URL: https://github.com/apache/solr/pull/1884#issuecomment-1709444570 I sat on this a bit and realized I would prefer adding a test to 9.x backport and ended up rewriting it so it fits with 9.x constructs. makes me feel a tiny bit more confident that this re

[jira] [Comment Edited] (SOLR-16955) Tracing v2 apis breaks SecurityConfHandler

2023-09-06 Thread Alex Deparvu (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17762515#comment-17762515 ] Alex Deparvu edited comment on SOLR-16955 at 9/7/23 4:04 AM: -

[jira] [Commented] (SOLR-16955) Tracing v2 apis breaks SecurityConfHandler

2023-09-06 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17762561#comment-17762561 ] ASF subversion and git services commented on SOLR-16955: Commit 8

[jira] [Resolved] (SOLR-16955) Tracing v2 apis breaks SecurityConfHandler

2023-09-06 Thread Alex Deparvu (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16955?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alex Deparvu resolved SOLR-16955. - Resolution: Fixed fixed on main and I did a best effort backport to 9.x. the test did not make it

[jira] [Commented] (SOLR-16955) Tracing v2 apis breaks SecurityConfHandler

2023-09-06 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17762514#comment-17762514 ] ASF subversion and git services commented on SOLR-16955: Commit 4

[jira] [Commented] (SOLR-16955) Tracing v2 apis breaks SecurityConfHandler

2023-09-06 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17762507#comment-17762507 ] ASF subversion and git services commented on SOLR-16955: Commit b

[GitHub] [solr] stillalex merged pull request #1884: SOLR-16955 Tracing v2 apis breaks SecurityConfHandler

2023-09-06 Thread via GitHub
stillalex merged PR #1884: URL: https://github.com/apache/solr/pull/1884 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.

[GitHub] [solr] dsmiley commented on pull request #1884: SOLR-16955 Tracing v2 apis breaks SecurityConfHandler

2023-09-06 Thread via GitHub
dsmiley commented on PR #1884: URL: https://github.com/apache/solr/pull/1884#issuecomment-1709155346 I'm very sympathetic to the pain of maintaining tests of distributed tracing! Okay by me to skip such a test in 9x. We don't test details of our logs... yet we do with tracing... :shrug:

[GitHub] [solr] xtenzQ commented on pull request #1829: SOLR-6853: Add slash support for Managed Resources (synonyms and stopwords)

2023-09-06 Thread via GitHub
xtenzQ commented on PR #1829: URL: https://github.com/apache/solr/pull/1829#issuecomment-1709082973 @janhoy I'm not sure if I can improve my fix in some way. Also, I apologize for the late reply, I was on the move. -- This is an automated message from the Apache Git Service. To res

[GitHub] [solr] stillalex commented on pull request #1884: SOLR-16955 Tracing v2 apis breaks SecurityConfHandler

2023-09-06 Thread via GitHub
stillalex commented on PR #1884: URL: https://github.com/apache/solr/pull/1884#issuecomment-1709046355 thank you @dsmiley for the continued review, I am getting ready to merge. one more aspect of this is the backport to 9.x. it will be extremely complicated to take the test as is. one eas

[GitHub] [solr] janhoy commented on a diff in pull request #96: SOLR-15056: add circuit breaker for CPU, fix load circuit breaker

2023-09-06 Thread via GitHub
janhoy commented on code in PR #96: URL: https://github.com/apache/solr/pull/96#discussion_r1315215619 ## solr/core/src/java/org/apache/solr/util/circuitbreaker/CPUCircuitBreaker.java: ## @@ -17,54 +17,49 @@ package org.apache.solr.util.circuitbreaker; +import com.codahale.

[GitHub] [solr] magibney commented on a diff in pull request #1895: SOLR-16962: Restore ability to configure tlog directory

2023-09-06 Thread via GitHub
magibney commented on code in PR #1895: URL: https://github.com/apache/solr/pull/1895#discussion_r1317756118 ## solr/core/src/java/org/apache/solr/core/SolrCore.java: ## @@ -391,10 +390,6 @@ public String getDataDir() { return dataDir; } - public String getUlogDir() {

[GitHub] [solr] magibney opened a new pull request, #1895: SOLR-16962: Restore ability to configure tlog directory

2023-09-06 Thread via GitHub
magibney opened a new pull request, #1895: URL: https://github.com/apache/solr/pull/1895 See: SOLR-16962 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-m

[jira] [Created] (SOLR-16962) updateLog tlog dir location config is silently ignored

2023-09-06 Thread Michael Gibney (Jira)
Michael Gibney created SOLR-16962: - Summary: updateLog tlog dir location config is silently ignored Key: SOLR-16962 URL: https://issues.apache.org/jira/browse/SOLR-16962 Project: Solr Issue

[jira] [Commented] (SOLR-16951) HttpShardHandler performance degradation in Solr 9

2023-09-06 Thread Tomas Eduardo Fernandez Lobbe (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17762483#comment-17762483 ] Tomas Eduardo Fernandez Lobbe commented on SOLR-16951: -- Yes, this is

[GitHub] [solr] AndreyBozhko opened a new pull request, #1894: Fix example for Protected Term Filter

2023-09-06 Thread via GitHub
AndreyBozhko opened a new pull request, #1894: URL: https://github.com/apache/solr/pull/1894 https://issues.apache.org/jira/browse/SOLR-X # Description Fix a copy-paste error in the docs for Protected Term Filter. # Solution Please provide a short d

[GitHub] [solr] stillalex merged pull request #1888: Update org.eclipse.jetty*:* to v10.0.16

2023-09-06 Thread via GitHub
stillalex merged PR #1888: URL: https://github.com/apache/solr/pull/1888 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.

[jira] [Commented] (SOLR-16825) Generate Java bindings from OpenAPI spec

2023-09-06 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16825?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17762431#comment-17762431 ] ASF subversion and git services commented on SOLR-16825: Commit 9

[jira] [Commented] (SOLR-16825) Generate Java bindings from OpenAPI spec

2023-09-06 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16825?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17762427#comment-17762427 ] ASF subversion and git services commented on SOLR-16825: Commit b

[GitHub] [solr] gerlowskija merged pull request #1885: SOLR-16825: Remove unneeded @Produces annotations

2023-09-06 Thread via GitHub
gerlowskija merged PR #1885: URL: https://github.com/apache/solr/pull/1885 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apach

[jira] [Created] (SOLR-16961) Remove deprecated CircuitBreakerManager in 10.0

2023-09-06 Thread Jira
Jan Høydahl created SOLR-16961: -- Summary: Remove deprecated CircuitBreakerManager in 10.0 Key: SOLR-16961 URL: https://issues.apache.org/jira/browse/SOLR-16961 Project: Solr Issue Type: Task

[GitHub] [solr-sandbox] sigram opened a new pull request, #67: Solr CrossDC Consumer Helm chart.

2023-09-06 Thread via GitHub
sigram opened a new pull request, #67: URL: https://github.com/apache/solr-sandbox/pull/67 Simple Helm chart with a deployment descriptor, and a Jib-based image build. I added a wrapper to make it easier to pass configuration properties through environment. We could also roll this int

[jira] [Resolved] (SOLR-16954) Circuit breaker for update requests

2023-09-06 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-16954?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Høydahl resolved SOLR-16954. Fix Version/s: 9.4 Resolution: Fixed > Circuit breaker for update requests > ---

[jira] [Commented] (SOLR-16954) Circuit breaker for update requests

2023-09-06 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17762403#comment-17762403 ] ASF subversion and git services commented on SOLR-16954: Commit 9

[jira] [Commented] (SOLR-16954) Circuit breaker for update requests

2023-09-06 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17762392#comment-17762392 ] ASF subversion and git services commented on SOLR-16954: Commit a

[GitHub] [solr] janhoy merged pull request #1871: SOLR-16954 Make Circuit Breakers available for Update Requests

2023-09-06 Thread via GitHub
janhoy merged PR #1871: URL: https://github.com/apache/solr/pull/1871 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

[jira] [Resolved] (SOLR-16917) v2 DELETEREPLICA not working

2023-09-06 Thread Alex Deparvu (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16917?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alex Deparvu resolved SOLR-16917. - Fix Version/s: 9.4 Resolution: Fixed I verified on 9.3 and indeed there is a 404 but with

[jira] [Commented] (SOLR-16951) HttpShardHandler performance degradation in Solr 9

2023-09-06 Thread Alex Deparvu (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17762364#comment-17762364 ] Alex Deparvu commented on SOLR-16951: - have you checked on 9.3 as well? after SOLR-16

[GitHub] [solr-sandbox] sigram opened a new pull request, #66: Add serialization unit test.

2023-09-06 Thread via GitHub
sigram opened a new pull request, #66: URL: https://github.com/apache/solr-sandbox/pull/66 This test verifies that the optimization in `ExposedByteArrayOutputStream` (which sometimes produces trailing zeroes in the raw buffer) works correctly with de-serialization. -- This is an automate

[GitHub] [solr] cpoerschke merged pull request #1771: Update dependency org.semver4j:semver4j to v5

2023-09-06 Thread via GitHub
cpoerschke merged PR #1771: URL: https://github.com/apache/solr/pull/1771 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache

[GitHub] [solr] cpoerschke commented on pull request #1871: SOLR-16954 Make Circuit Breakers available for Update Requests

2023-09-06 Thread via GitHub
cpoerschke commented on PR #1871: URL: https://github.com/apache/solr/pull/1871#issuecomment-1708028911 Hmm, precommit failed with `run the top-level './gradlew tidy' to format code automatically (see help/formatting.txt for more info).` advisory -- independent of this pull request really,

[GitHub] [solr] psalagnac opened a new pull request, #1893: SOLR-16953: Grouped fields are handled in edismax clauses

2023-09-06 Thread via GitHub
psalagnac opened a new pull request, #1893: URL: https://github.com/apache/solr/pull/1893 https://issues.apache.org/jira/browse/SOLR-16953 # Description `ExtendedDismaxParser` generates _boosts_ queries from parameter `pf` for unwanted terms when using grouped field

[GitHub] [solr] renatoh commented on pull request #1873: Removing List.toArray calls with pre-sized Arrays

2023-09-06 Thread via GitHub
renatoh commented on PR #1873: URL: https://github.com/apache/solr/pull/1873#issuecomment-1707871257 @cpoerschke I did another merge of origin/main, it looks like the checks have now passed, or haven't they? -- This is an automated message from the Apache Git Service. To respond to the me

[GitHub] [solr] janhoy commented on pull request #1871: SOLR-16954 Make Circuit Breakers available for Update Requests

2023-09-06 Thread via GitHub
janhoy commented on PR #1871: URL: https://github.com/apache/solr/pull/1871#issuecomment-1707853260 Thanks for the attention to detail @cpoerschke. Accepted all your edits. Will merge today. -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [solr] janhoy commented on a diff in pull request #1871: SOLR-16954 Make Circuit Breakers available for Update Requests

2023-09-06 Thread via GitHub
janhoy commented on code in PR #1871: URL: https://github.com/apache/solr/pull/1871#discussion_r1316882036 ## solr/core/src/java/org/apache/solr/util/circuitbreaker/CircuitBreaker.java: ## @@ -52,4 +62,48 @@ public CircuitBreaker() {} /** Get error message when the circuit