[GitHub] [solr-site] HoustonPutman merged pull request #94: Add videos and articles to the Operator resources page

2023-09-08 Thread via GitHub
HoustonPutman merged PR #94: URL: https://github.com/apache/solr-site/pull/94 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.ap

[jira] [Assigned] (SOLR-16038) Rename PackageStore as Filestore

2023-09-08 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-16038?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Høydahl reassigned SOLR-16038: -- Assignee: Jan Høydahl > Rename PackageStore as Filestore > >

[GitHub] [solr] janhoy opened a new pull request, #1908: SOLR-16038: Rename PackageStore as Filestore

2023-09-08 Thread via GitHub
janhoy opened a new pull request, #1908: URL: https://github.com/apache/solr/pull/1908 https://issues.apache.org/jira/browse/SOLR-16038 I did NOT rename the `/packagestore` name in zookeeper and related constants, as it would involve migrating/renaming.. -- This is an automated mes

[GitHub] [solr] janhoy opened a new pull request, #1907: SOLR-16044: SlowRequest logging disabled if SolrCore logger set to ERROR

2023-09-08 Thread via GitHub
janhoy opened a new pull request, #1907: URL: https://github.com/apache/solr/pull/1907 https://issues.apache.org/jira/browse/SOLR-16044 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spe

[jira] [Commented] (SOLR-16044) SlowRequest logging disabled if SolrCore logger set to ERROR

2023-09-08 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-16044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17763213#comment-17763213 ] Jan Høydahl commented on SOLR-16044: Thanks [~hossman] I created a PR, have a look if

[jira] [Assigned] (SOLR-16044) SlowRequest logging disabled if SolrCore logger set to ERROR

2023-09-08 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-16044?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Høydahl reassigned SOLR-16044: -- Assignee: Jan Høydahl > SlowRequest logging disabled if SolrCore logger set to ERROR > ---

[jira] [Resolved] (SOLR-16123) TestBulkSchemaConcurrent fails frequently

2023-09-08 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-16123?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Høydahl resolved SOLR-16123. Resolution: Later This only fails 1% of the time now, closing > TestBulkSchemaConcurrent fails fre

[jira] [Resolved] (SOLR-16188) Antora generates wrong .htaccess file

2023-09-08 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-16188?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Høydahl resolved SOLR-16188. Resolution: Done Closing as this really works, follow up in other issues > Antora generates wrong

[jira] [Resolved] (SOLR-16354) Migrate from Jaeger/OpenTracing to OTEL

2023-09-08 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-16354?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Høydahl resolved SOLR-16354. Resolution: Done All child issues resolved, closing umbrella > Migrate from Jaeger/OpenTracing to

[jira] [Updated] (SOLR-16938) Auto configure tracer without a tag in solr.xml

2023-09-08 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-16938?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Høydahl updated SOLR-16938: --- Parent: (was: SOLR-16354) Issue Type: Improvement (was: Sub-task) > Auto configure trace

[jira] [Resolved] (SOLR-14755) Dedicated Exception Type for Circuit Breakers

2023-09-08 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-14755?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Høydahl resolved SOLR-14755. Resolution: Won't Fix > Dedicated Exception Type for Circuit Breakers > ---

[GitHub] [solr] janhoy commented on a diff in pull request #1905: SOLR-16968: The MemoryCircuitBreaker now uses average heap usage

2023-09-08 Thread via GitHub
janhoy commented on code in PR #1905: URL: https://github.com/apache/solr/pull/1905#discussion_r1320180723 ## solr/core/src/java/org/apache/solr/util/circuitbreaker/MemoryCircuitBreaker.java: ## @@ -43,8 +46,34 @@ public class MemoryCircuitBreaker extends CircuitBreaker { pri

[GitHub] [solr] cpoerschke commented on pull request #1873: Removing List.toArray calls with pre-sized Arrays

2023-09-08 Thread via GitHub
cpoerschke commented on PR #1873: URL: https://github.com/apache/solr/pull/1873#issuecomment-1712037914 https://lists.apache.org/thread/ybmp5xz3c9549opqgktdb4cxlpmdmwy4 (I think) is the dev list thread w.r.t. Crave.io CI patch application. -- This is an automated message from the Apache G

[GitHub] [solr] cpoerschke commented on pull request #1883: SOLR-15440: FieldValueFeature now uses DocValues when docValues=true and stored=true are combined.

2023-09-08 Thread via GitHub
cpoerschke commented on PR #1883: URL: https://github.com/apache/solr/pull/1883#issuecomment-1712037291 https://lists.apache.org/thread/ybmp5xz3c9549opqgktdb4cxlpmdmwy4 (I think) is the dev list thread w.r.t. Crave.io CI patch application. -- This is an automated message from the Apache G

[GitHub] [solr] cpoerschke commented on a diff in pull request #1905: SOLR-16968: The MemoryCircuitBreaker now uses average heap usage

2023-09-08 Thread via GitHub
cpoerschke commented on code in PR #1905: URL: https://github.com/apache/solr/pull/1905#discussion_r1320175584 ## solr/core/src/java/org/apache/solr/util/circuitbreaker/MemoryCircuitBreaker.java: ## @@ -43,8 +46,34 @@ public class MemoryCircuitBreaker extends CircuitBreaker {

[GitHub] [solr] cpoerschke commented on pull request #1883: SOLR-15440: FieldValueFeature now uses DocValues when docValues=true and stored=true are combined.

2023-09-08 Thread via GitHub
cpoerschke commented on PR #1883: URL: https://github.com/apache/solr/pull/1883#issuecomment-1712010145 Hi @tomgl - thank you very much for your inputs! > As for my understanding you plan to remove the `LegacyFieldValueFeature` **and** `useDocValuesForStored` in 9.X or 10, correct?

[GitHub] [solr-sandbox] sigram opened a new pull request, #69: Add support for mirroring ConfigSet requests.

2023-09-08 Thread via GitHub
sigram opened a new pull request, #69: URL: https://github.com/apache/solr-sandbox/pull/69 This PR builds on top of PR-68 so it contains also changes from that PR. This PR adds the following: * extends MirroredSolrRequest and serializer to properly handle ContentStream-s. * adds

[jira] [Commented] (SOLR-16917) v2 DELETEREPLICA not working

2023-09-08 Thread Jason Gerlowski (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16917?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17763156#comment-17763156 ] Jason Gerlowski commented on SOLR-16917: Woohoo! This was on my list, but I hadn

[GitHub] [solr-operator] janhoy commented on issue #618: Role Assignment for SOLR Replicas

2023-09-08 Thread via GitHub
janhoy commented on issue #618: URL: https://github.com/apache/solr-operator/issues/618#issuecomment-1711915485 In SIP-14 we discuss adding a `zookeeper` noe-role. Then it would make sense to start a separate statefulSet for the zk pods. They may need different role, different RAM, disk, CP

[GitHub] [solr] janhoy commented on a diff in pull request #1905: SOLR-16968: The MemoryCircuitBreaker now uses average heap usage

2023-09-08 Thread via GitHub
janhoy commented on code in PR #1905: URL: https://github.com/apache/solr/pull/1905#discussion_r1320049767 ## solr/core/src/java/org/apache/solr/util/circuitbreaker/AveragingMetricProvider.java: ## @@ -0,0 +1,86 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under o

[GitHub] [solr] janhoy commented on a diff in pull request #1905: SOLR-16968: The MemoryCircuitBreaker now uses average heap usage

2023-09-08 Thread via GitHub
janhoy commented on code in PR #1905: URL: https://github.com/apache/solr/pull/1905#discussion_r1320042461 ## solr/core/src/java/org/apache/solr/util/circuitbreaker/CircuitBreakerManager.java: ## @@ -91,6 +92,16 @@ public void init(NamedList args) { } } + @Override +

[GitHub] [solr] janhoy commented on a diff in pull request #1905: SOLR-16968: The MemoryCircuitBreaker now uses average heap usage

2023-09-08 Thread via GitHub
janhoy commented on code in PR #1905: URL: https://github.com/apache/solr/pull/1905#discussion_r1320041055 ## solr/core/src/java/org/apache/solr/util/circuitbreaker/AveragingMetricProvider.java: ## @@ -0,0 +1,86 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under o

[GitHub] [solr-operator] HoustonPutman commented on pull request #610: Support TLS with recent Solr 9.x versions

2023-09-08 Thread via GitHub
HoustonPutman commented on PR #610: URL: https://github.com/apache/solr-operator/pull/610#issuecomment-1711838632 Thanks to [SOLR-16964](https://issues.apache.org/jira/browse/SOLR-16964), Solr 9.4 will come with the correct SNI hostCheck default given the value of CheckPeerName. Because of

[GitHub] [solr] janhoy commented on pull request #1821: Update dependency com.adobe.testing:s3mock-junit4 to v3

2023-09-08 Thread via GitHub
janhoy commented on PR #1821: URL: https://github.com/apache/solr/pull/1821#issuecomment-1711838521 Yea, let's see what solrbot does with DRAFT PRs :) We could also close it and open a JIRA to handle it manually later. -- This is an automated message from the Apache Git Service. To respon

[jira] [Resolved] (SOLR-16964) sniHostCheck should default to SOLR_SSL_CHECK_PEER_NAME

2023-09-08 Thread Houston Putman (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16964?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Houston Putman resolved SOLR-16964. --- Fix Version/s: 9.4 Assignee: Houston Putman Resolution: Fixed > sniHostCheck

[jira] [Commented] (SOLR-16964) sniHostCheck should default to SOLR_SSL_CHECK_PEER_NAME

2023-09-08 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16964?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17763130#comment-17763130 ] ASF subversion and git services commented on SOLR-16964: Commit e

[jira] [Commented] (SOLR-16964) sniHostCheck should default to SOLR_SSL_CHECK_PEER_NAME

2023-09-08 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16964?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17763129#comment-17763129 ] ASF subversion and git services commented on SOLR-16964: Commit 7

[GitHub] [solr] HoustonPutman merged pull request #1897: SOLR-16964: Default the sniHostCheck setting to the checkPeerName envVar

2023-09-08 Thread via GitHub
HoustonPutman merged PR #1897: URL: https://github.com/apache/solr/pull/1897 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apa

[GitHub] [solr-operator] HoustonPutman commented on issue #618: Role Assignment for SOLR Replicas

2023-09-08 Thread via GitHub
HoustonPutman commented on issue #618: URL: https://github.com/apache/solr-operator/issues/618#issuecomment-1711811235 This is a very good question, but ultimately it would be a fairly big change to the way that the operator works. Currently the Solr Operator uses a single StatefulSet

[GitHub] [solr-operator] ozlerhakan opened a new issue, #618: Role Assignment for SOLR Replicas

2023-09-08 Thread via GitHub
ozlerhakan opened a new issue, #618: URL: https://github.com/apache/solr-operator/issues/618 Hi Team! I was wondering if we have possibility to assign different roles for replicas, each of which is essentially a SOLR node, using SOLR's [Node Roles](https://solr.apache.org/guide/solr/

[jira] [Created] (SOLR-16969) Allow setting collprops at collection creation time

2023-09-08 Thread Jason Gerlowski (Jira)
Jason Gerlowski created SOLR-16969: -- Summary: Allow setting collprops at collection creation time Key: SOLR-16969 URL: https://issues.apache.org/jira/browse/SOLR-16969 Project: Solr Issue Ty

[GitHub] [solr] gerlowskija commented on a diff in pull request #1119: [SOLR-16461] Create v2 equivalent of v1 ReplicationHandler 'BACKUP'

2023-09-08 Thread via GitHub
gerlowskija commented on code in PR #1119: URL: https://github.com/apache/solr/pull/1119#discussion_r1319865106 ## solr/core/src/java/org/apache/solr/handler/admin/api/SnapshotBackupAPI.java: ## @@ -0,0 +1,174 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] [solr] janhoy commented on pull request #1905: SOLR-16968: The MemoryCircuitBreaker now uses average heap usage

2023-09-08 Thread via GitHub
janhoy commented on PR #1905: URL: https://github.com/apache/solr/pull/1905#issuecomment-1711690475 @atris feel free to weigh in here. The intention is to get fewer "false positive" request rejections due to short spikes. Now there will be some delay (0-30s) from heavy memory pressure start

[jira] [Commented] (SOLR-15797) Improve SolrJ Tracer support

2023-09-08 Thread Alex Deparvu (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15797?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17763095#comment-17763095 ] Alex Deparvu commented on SOLR-15797: - > You can add headers in the HTTP request via

[GitHub] [solr] janhoy commented on a diff in pull request #1905: SOLR-16968: The MemoryCircuitBreaker now uses average heap usage

2023-09-08 Thread via GitHub
janhoy commented on code in PR #1905: URL: https://github.com/apache/solr/pull/1905#discussion_r1319878223 ## solr/core/src/java/org/apache/solr/util/circuitbreaker/MemoryCircuitBreaker.java: ## @@ -43,8 +46,34 @@ public class MemoryCircuitBreaker extends CircuitBreaker { pri

[GitHub] [solr] stillalex commented on a diff in pull request #1898: SOLR-15367 Convert "rid" functionality into a default Tracer

2023-09-08 Thread via GitHub
stillalex commented on code in PR #1898: URL: https://github.com/apache/solr/pull/1898#discussion_r1319873973 ## solr/solr-ref-guide/modules/deployment-guide/pages/distributed-tracing.adoc: ## @@ -25,6 +25,17 @@ A sampled distributed tracing query request displayed in Jaeger UI

[GitHub] [solr] stillalex opened a new pull request, #1906: SOLR-16950 SimpleTracer propagation for manual transaction ids

2023-09-08 Thread via GitHub
stillalex opened a new pull request, #1906: URL: https://github.com/apache/solr/pull/1906 https://issues.apache.org/jira/browse/SOLR-16950 # Description Fix support for client side manual transaction ids on UpdateRequest. Currently due to UpdateRequest getting rec

[GitHub] [solr] cpoerschke commented on a diff in pull request #1905: SOLR-16968: The MemoryCircuitBreaker now uses average heap usage

2023-09-08 Thread via GitHub
cpoerschke commented on code in PR #1905: URL: https://github.com/apache/solr/pull/1905#discussion_r1319856395 ## solr/core/src/java/org/apache/solr/util/circuitbreaker/MemoryCircuitBreaker.java: ## @@ -43,8 +46,34 @@ public class MemoryCircuitBreaker extends CircuitBreaker {

[GitHub] [solr] cpoerschke commented on pull request #1821: Update dependency com.adobe.testing:s3mock-junit4 to v3

2023-09-08 Thread via GitHub
cpoerschke commented on PR #1821: URL: https://github.com/apache/solr/pull/1821#issuecomment-1711614544 > Yeah we can't merge this until Solr is JDK 17+, which presumably will be Solr 10.x, since Lucene 10 will be JDK 17+ Wondering if/how we could communicate this to @solrbot and/or o

[GitHub] [solr] stillalex commented on pull request #1898: SOLR-15367 Convert "rid" functionality into a default Tracer

2023-09-08 Thread via GitHub
stillalex commented on PR #1898: URL: https://github.com/apache/solr/pull/1898#issuecomment-1711610219 I marked `rid` as deprecated, but I can't find a good place in the guide to mention this deprecation. where should this go? under 'major changes in solr 9' maybe? -- This is an automate

[GitHub] [solr] stillalex commented on a diff in pull request #1898: SOLR-15367 Convert "rid" functionality into a default Tracer

2023-09-08 Thread via GitHub
stillalex commented on code in PR #1898: URL: https://github.com/apache/solr/pull/1898#discussion_r1319811898 ## solr/solr-ref-guide/modules/deployment-guide/pages/distributed-tracing.adoc: ## @@ -25,6 +25,17 @@ A sampled distributed tracing query request displayed in Jaeger UI

[GitHub] [solr] stillalex commented on a diff in pull request #1898: SOLR-15367 Convert "rid" functionality into a default Tracer

2023-09-08 Thread via GitHub
stillalex commented on code in PR #1898: URL: https://github.com/apache/solr/pull/1898#discussion_r1319810929 ## solr/solrj/src/java/org/apache/solr/common/params/CommonParams.java: ## @@ -277,9 +279,23 @@ public static EchoParamStyle get(String v) { * Defaults to 'false' if

[GitHub] [solr] janhoy commented on a diff in pull request #1905: SOLR-16968: The MemoryCircuitBreaker now uses average heap usage

2023-09-08 Thread via GitHub
janhoy commented on code in PR #1905: URL: https://github.com/apache/solr/pull/1905#discussion_r1319799318 ## solr/core/src/java/org/apache/solr/util/circuitbreaker/MemoryCircuitBreaker.java: ## @@ -100,17 +123,11 @@ private long getCurrentMemoryThreshold() { return heapMem

[GitHub] [solr] janhoy opened a new pull request, #1905: SOLR-16968: The MemoryCircuitBreaker now uses average heap usage

2023-09-08 Thread via GitHub
janhoy opened a new pull request, #1905: URL: https://github.com/apache/solr/pull/1905 https://issues.apache.org/jira/browse/SOLR-16968 Introduced a new utility class `AveragingMetricProvider` that will cache the average for a `double` value provided by the breaker. Uses a scheduled e

[GitHub] [solr] ctargett commented on a diff in pull request #1898: SOLR-15367 Convert "rid" functionality into a default Tracer

2023-09-08 Thread via GitHub
ctargett commented on code in PR #1898: URL: https://github.com/apache/solr/pull/1898#discussion_r1319788815 ## solr/solr-ref-guide/modules/deployment-guide/pages/distributed-tracing.adoc: ## @@ -25,6 +25,17 @@ A sampled distributed tracing query request displayed in Jaeger UI

[jira] [Created] (SOLR-16968) Use averages for Memory Circuit Breaker

2023-09-08 Thread Jira
Jan Høydahl created SOLR-16968: -- Summary: Use averages for Memory Circuit Breaker Key: SOLR-16968 URL: https://issues.apache.org/jira/browse/SOLR-16968 Project: Solr Issue Type: Improvement

[GitHub] [solr] janhoy opened a new pull request, #1904: SOLR-16961: Remove deprecated CircuitBreakerManager

2023-09-08 Thread via GitHub
janhoy opened a new pull request, #1904: URL: https://github.com/apache/solr/pull/1904 https://issues.apache.org/jira/browse/SOLR-16961 Draft PR for eventually removing deprecated code from main. Will not merge until other in-flight CB efforts have landed.. -- This is an automated

[jira] [Resolved] (SOLR-16954) Circuit breaker for update requests

2023-09-08 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-16954?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Høydahl resolved SOLR-16954. Resolution: Fixed > Circuit breaker for update requests > --- > >

[jira] [Commented] (SOLR-16954) Circuit breaker for update requests

2023-09-08 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17762982#comment-17762982 ] ASF subversion and git services commented on SOLR-16954: Commit 5

[jira] [Commented] (SOLR-16959) Make CoresLocator class configurable

2023-09-08 Thread Vincent Primault (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17762975#comment-17762975 ] Vincent Primault commented on SOLR-16959: - Indeed, it's updated! > Make CoresLoc

[jira] [Updated] (SOLR-16959) Make CoresLocator class configurable

2023-09-08 Thread Vincent Primault (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16959?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vincent Primault updated SOLR-16959: Description: I would like to be able to hook into the process of discovering and persisting

[jira] [Updated] (SOLR-16959) Make CoresLocator class configurable

2023-09-08 Thread Vincent Primault (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16959?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vincent Primault updated SOLR-16959: Summary: Make CoresLocator class configurable (was: Make CoresContainer class configurable

[GitHub] [solr] iamsanjay opened a new pull request, #1903: SOLR-16397: Create v2(JAX-RS) endpoints for RELOAD core

2023-09-08 Thread via GitHub
iamsanjay opened a new pull request, #1903: URL: https://github.com/apache/solr/pull/1903 https://issues.apache.org/jira/browse/SOLR-16397 # Description V2(JAX-RS) Endpoints for core admin op "RELOAD". # Solution There is already one class present in th