[
https://issues.apache.org/jira/browse/SOLR-16992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17768964#comment-17768964
]
Alex Deparvu edited comment on SOLR-16992 at 9/26/23 2:23 AM:
-
[
https://issues.apache.org/jira/browse/SOLR-16992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17768964#comment-17768964
]
Alex Deparvu commented on SOLR-16992:
-
{quote}
I like the impl of {{SolrClientCache.c
[
https://issues.apache.org/jira/browse/SOLR-16992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17768953#comment-17768953
]
Chris M. Hostetter commented on SOLR-16992:
---
{quote}it feels like adding a clos
tflobbe commented on PR #1739:
URL: https://github.com/apache/solr/pull/1739#issuecomment-1734572150
@dsmiley, Any concerns with this approach, given the discussion in the Jira
issue?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
epugh commented on PR #1954:
URL: https://github.com/apache/solr/pull/1954#issuecomment-1734493799
> re. this pattern of parsing `user:password`
>
> ```
> if (credentials != null && credentials.indexOf(":") > 0) {
> String[] credentialsArray = credentials.split(":");
> `
epugh commented on code in PR #1954:
URL: https://github.com/apache/solr/pull/1954#discussion_r1336409323
##
solr/core/src/java/org/apache/solr/cli/DeleteTool.java:
##
@@ -102,13 +110,18 @@ public void runImpl(CommandLine cli) throws Exception {
}
protected void deleteCo
epugh commented on code in PR #1954:
URL: https://github.com/apache/solr/pull/1954#discussion_r1336408616
##
solr/core/src/java/org/apache/solr/cli/DeleteTool.java:
##
@@ -92,7 +94,13 @@ public void runImpl(CommandLine cli) throws Exception {
SolrCLI.raiseLogLevelUnlessVerb
stillalex commented on PR #1958:
URL: https://github.com/apache/solr/pull/1958#issuecomment-1734473783
```
ERROR: The following test(s) have failed:
- org.apache.solr.handler.component.DistributedExpandComponentTest.test
(:solr:core)
Test output:
/Users/alexdeparvu/git/solr/s
stillalex commented on PR #1958:
URL: https://github.com/apache/solr/pull/1958#issuecomment-1734452340
@alessandrobenedetti pinging for a review of the `DenseVectorField` changes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
[
https://issues.apache.org/jira/browse/SOLR-16985?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alex Deparvu reassigned SOLR-16985:
---
Assignee: Alex Deparvu
> Upgrade Lucene to 9.8.0
> ---
>
>
[
https://issues.apache.org/jira/browse/SOLR-16985?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17768908#comment-17768908
]
Alex Deparvu commented on SOLR-16985:
-
WIP PR up for review https://github.com/apache
stillalex opened a new pull request, #1958:
URL: https://github.com/apache/solr/pull/1958
https://issues.apache.org/jira/browse/SOLR-16985
# Description
WIP Lucene upgrade based on RC1
# Solution
Please provide a short description of the approach taken
[
https://issues.apache.org/jira/browse/SOLR-16985?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17768903#comment-17768903
]
Alex Deparvu edited comment on SOLR-16985 at 9/25/23 8:48 PM:
-
[
https://issues.apache.org/jira/browse/SOLR-16985?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17768903#comment-17768903
]
Alex Deparvu edited comment on SOLR-16985 at 9/25/23 8:44 PM:
-
[
https://issues.apache.org/jira/browse/SOLR-16985?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17768903#comment-17768903
]
Alex Deparvu commented on SOLR-16985:
-
first stab using RC1
{noformat}
> Task :solr:
stillalex commented on PR #1954:
URL: https://github.com/apache/solr/pull/1954#issuecomment-1734414823
re. this pattern of parsing `user:password`
```
if (credentials != null && credentials.indexOf(":") > 0) {
String[] credentialsArray = credentials.split(":");
```
stillalex commented on code in PR #1954:
URL: https://github.com/apache/solr/pull/1954#discussion_r1336351310
##
solr/core/src/java/org/apache/solr/cli/DeleteTool.java:
##
@@ -102,13 +110,18 @@ public void runImpl(CommandLine cli) throws Exception {
}
protected void dele
stillalex commented on code in PR #1954:
URL: https://github.com/apache/solr/pull/1954#discussion_r1336349434
##
solr/core/src/java/org/apache/solr/cli/DeleteTool.java:
##
@@ -92,7 +94,13 @@ public void runImpl(CommandLine cli) throws Exception {
SolrCLI.raiseLogLevelUnless
[
https://issues.apache.org/jira/browse/SOLR-16996?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alex Deparvu updated SOLR-16996:
Description:
During review of SOLR-16980 we found out that the prometheus CLI is based on
argparse
[
https://issues.apache.org/jira/browse/SOLR-16996?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alex Deparvu updated SOLR-16996:
Priority: Minor (was: Major)
> Move Prometheus CLI to commons-cli
> --
stillalex commented on PR #1957:
URL: https://github.com/apache/solr/pull/1957#issuecomment-1734256773
sure, created SOLR-16996 and linked to umbrella ticket.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abo
Alex Deparvu created SOLR-16996:
---
Summary: Move Prometheus CLI to commons-cli
Key: SOLR-16996
URL: https://issues.apache.org/jira/browse/SOLR-16996
Project: Solr
Issue Type: Improvement
S
stillalex commented on code in PR #1957:
URL: https://github.com/apache/solr/pull/1957#discussion_r1336243193
##
solr/prometheus-exporter/src/test/org/apache/solr/prometheus/scraper/SolrStandaloneScraperBasicAuthTest.java:
##
@@ -0,0 +1,112 @@
+/*
+ * Licensed to the Apache Soft
epugh commented on code in PR #1957:
URL: https://github.com/apache/solr/pull/1957#discussion_r1336236341
##
solr/prometheus-exporter/src/test/org/apache/solr/prometheus/scraper/SolrStandaloneScraperBasicAuthTest.java:
##
@@ -0,0 +1,112 @@
+/*
+ * Licensed to the Apache Software
epugh commented on code in PR #1957:
URL: https://github.com/apache/solr/pull/1957#discussion_r1336235878
##
solr/prometheus-exporter/src/test-files/solr/security.json:
##
Review Comment:
yeah, a "metrics" role or a "monitor" role that has what you would need,
that way you
stillalex commented on code in PR #1957:
URL: https://github.com/apache/solr/pull/1957#discussion_r1336235696
##
solr/prometheus-exporter/src/test/org/apache/solr/prometheus/scraper/SolrStandaloneScraperBasicAuthTest.java:
##
@@ -0,0 +1,112 @@
+/*
+ * Licensed to the Apache Soft
epugh commented on PR #1957:
URL: https://github.com/apache/solr/pull/1957#issuecomment-1734238649
> @epugh re. `commons-cli` vs `argparse4j` I want to take a stab at
rewriting, but I would like to do it as a part of a different PR as an
improvement. for this PR i am focusing on resolving a
stillalex commented on code in PR #1957:
URL: https://github.com/apache/solr/pull/1957#discussion_r1336232221
##
solr/prometheus-exporter/src/test-files/solr/security.json:
##
Review Comment:
I see a `metrics-read` permission here. is this what you were hinting to?
like ma
stillalex commented on code in PR #1957:
URL: https://github.com/apache/solr/pull/1957#discussion_r1336232221
##
solr/prometheus-exporter/src/test-files/solr/security.json:
##
Review Comment:
I see a `metrics-read` here. is this what you were hinting to?
--
This is an a
stillalex commented on PR #1957:
URL: https://github.com/apache/solr/pull/1957#issuecomment-1734231025
@epugh re. `commons-cli` vs `argparse4j` I want to take a stab at rewriting,
but I would like to do it as a part of a different PR as an improvement. for
this PR i am focusing on resolving
epugh commented on code in PR #1957:
URL: https://github.com/apache/solr/pull/1957#discussion_r1336228358
##
solr/prometheus-exporter/src/java/org/apache/solr/prometheus/exporter/SolrExporter.java:
##
@@ -96,6 +96,13 @@ public class SolrExporter {
+ ARG_NUM_THREADS_DE
epugh commented on code in PR #1957:
URL: https://github.com/apache/solr/pull/1957#discussion_r1336227295
##
solr/prometheus-exporter/src/test-files/solr/security.json:
##
Review Comment:
Here is the "default" security.json that we now have!
https://github.com/apache/solr
epugh commented on code in PR #1957:
URL: https://github.com/apache/solr/pull/1957#discussion_r1336226900
##
solr/prometheus-exporter/src/test/org/apache/solr/prometheus/scraper/SolrStandaloneScraperBasicAuthTest.java:
##
@@ -0,0 +1,112 @@
+/*
+ * Licensed to the Apache Software
stillalex commented on code in PR #1957:
URL: https://github.com/apache/solr/pull/1957#discussion_r1336221018
##
solr/prometheus-exporter/src/test/org/apache/solr/prometheus/scraper/SolrStandaloneScraperBasicAuthTest.java:
##
@@ -0,0 +1,112 @@
+/*
+ * Licensed to the Apache Soft
stillalex commented on code in PR #1957:
URL: https://github.com/apache/solr/pull/1957#discussion_r1336216692
##
solr/prometheus-exporter/src/java/org/apache/solr/prometheus/exporter/SolrExporter.java:
##
@@ -96,6 +96,20 @@ public class SolrExporter {
+ ARG_NUM_THREAD
stillalex commented on code in PR #1957:
URL: https://github.com/apache/solr/pull/1957#discussion_r1336215717
##
solr/prometheus-exporter/src/test/org/apache/solr/prometheus/scraper/SolrStandaloneScraperBasicAuthTest.java:
##
@@ -0,0 +1,112 @@
+/*
+ * Licensed to the Apache Soft
epugh commented on code in PR #1957:
URL: https://github.com/apache/solr/pull/1957#discussion_r1336203092
##
solr/prometheus-exporter/src/java/org/apache/solr/prometheus/exporter/SolrClientFactory.java:
##
Review Comment:
Maybe I just wished we could use one of the other fa
epugh commented on code in PR #1957:
URL: https://github.com/apache/solr/pull/1957#discussion_r1336202283
##
solr/prometheus-exporter/src/test/org/apache/solr/prometheus/scraper/SolrStandaloneScraperBasicAuthTest.java:
##
@@ -0,0 +1,112 @@
+/*
+ * Licensed to the Apache Software
epugh commented on code in PR #1957:
URL: https://github.com/apache/solr/pull/1957#discussion_r1336201491
##
solr/prometheus-exporter/src/test/org/apache/solr/prometheus/scraper/SolrStandaloneScraperTest.java:
##
@@ -47,42 +54,45 @@ public class SolrStandaloneScraperTest extends
epugh commented on PR #1957:
URL: https://github.com/apache/solr/pull/1957#issuecomment-1734189390
> thank you for the review @epugh!
>
> > Awesome work @stillalex Have you looked at #1954
([SOLR-14496](https://issues.apache.org/jira/browse/SOLR-14496)) where I took a
stab at ad
pvcnt commented on PR #1928:
URL: https://github.com/apache/solr/pull/1928#issuecomment-1734182362
@janhoy You're right, I created one:
https://issues.apache.org/jira/browse/SOLR-16995
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
pvcnt commented on code in PR #1928:
URL: https://github.com/apache/solr/pull/1928#discussion_r1336195729
##
solr/solrj/src/java/org/apache/solr/common/cloud/ReplicaCount.java:
##
@@ -0,0 +1,133 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * co
Vincent Primault created SOLR-16995:
---
Summary: Refactor replica types to make it easier to add new ones
Key: SOLR-16995
URL: https://issues.apache.org/jira/browse/SOLR-16995
Project: Solr
I
stillalex commented on PR #1957:
URL: https://github.com/apache/solr/pull/1957#issuecomment-1734090616
thank you for the review @epugh!
> Awesome work @stillalex Have you looked at
https://github.com/apache/solr/pull/1954
([SOLR-14496](https://issues.apache.org/jira/browse/SOLR
stillalex commented on code in PR #1957:
URL: https://github.com/apache/solr/pull/1957#discussion_r1336130056
##
solr/prometheus-exporter/src/java/org/apache/solr/prometheus/exporter/SolrClientFactory.java:
##
Review Comment:
it wires the existing builders with params passe
stillalex commented on code in PR #1957:
URL: https://github.com/apache/solr/pull/1957#discussion_r1336129061
##
solr/prometheus-exporter/src/java/org/apache/solr/prometheus/exporter/SolrExporter.java:
##
@@ -242,6 +256,22 @@ public static void main(String[] args) {
.se
stillalex commented on code in PR #1957:
URL: https://github.com/apache/solr/pull/1957#discussion_r1336128385
##
solr/prometheus-exporter/src/test-files/solr/security.json:
##
Review Comment:
similar to the kubernetes setup (I think)? sounds like a good idea
--
This is
stillalex commented on code in PR #1957:
URL: https://github.com/apache/solr/pull/1957#discussion_r1336127313
##
solr/prometheus-exporter/src/test/org/apache/solr/prometheus/scraper/SolrStandaloneScraperBasicAuthTest.java:
##
@@ -0,0 +1,112 @@
+/*
+ * Licensed to the Apache Soft
stillalex commented on code in PR #1957:
URL: https://github.com/apache/solr/pull/1957#discussion_r1336126560
##
solr/prometheus-exporter/src/test/org/apache/solr/prometheus/scraper/SolrStandaloneScraperBasicAuthTest.java:
##
@@ -0,0 +1,112 @@
+/*
+ * Licensed to the Apache Soft
stillalex commented on code in PR #1957:
URL: https://github.com/apache/solr/pull/1957#discussion_r1336125777
##
solr/prometheus-exporter/src/test/org/apache/solr/prometheus/scraper/SolrStandaloneScraperTest.java:
##
@@ -47,42 +54,45 @@ public class SolrStandaloneScraperTest ext
[
https://issues.apache.org/jira/browse/SOLR-16992?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alex Deparvu reassigned SOLR-16992:
---
Assignee: Alex Deparvu
> Non-reproducible StreamingTest failures -- suggests CloudSolrStream
epugh commented on code in PR #1957:
URL: https://github.com/apache/solr/pull/1957#discussion_r1336087033
##
solr/prometheus-exporter/src/test/org/apache/solr/prometheus/scraper/SolrStandaloneScraperTest.java:
##
@@ -47,42 +54,45 @@ public class SolrStandaloneScraperTest extends
epugh commented on code in PR #1957:
URL: https://github.com/apache/solr/pull/1957#discussion_r1336085950
##
solr/prometheus-exporter/src/test/org/apache/solr/prometheus/scraper/SolrStandaloneScraperBasicAuthTest.java:
##
@@ -0,0 +1,112 @@
+/*
+ * Licensed to the Apache Software
epugh commented on code in PR #1957:
URL: https://github.com/apache/solr/pull/1957#discussion_r1336084359
##
solr/prometheus-exporter/src/test/org/apache/solr/prometheus/scraper/SolrStandaloneScraperBasicAuthTest.java:
##
@@ -0,0 +1,112 @@
+/*
+ * Licensed to the Apache Software
epugh commented on code in PR #1957:
URL: https://github.com/apache/solr/pull/1957#discussion_r1336083135
##
solr/prometheus-exporter/src/test-files/solr/security.json:
##
Review Comment:
have you seen the new "sane defaults" security.json? It declares four
roles, index,
epugh commented on code in PR #1957:
URL: https://github.com/apache/solr/pull/1957#discussion_r1336081208
##
solr/prometheus-exporter/src/java/org/apache/solr/prometheus/exporter/SolrExporter.java:
##
@@ -266,6 +296,12 @@ public static void main(String[] args) {
cluster
epugh commented on code in PR #1957:
URL: https://github.com/apache/solr/pull/1957#discussion_r1336080221
##
solr/prometheus-exporter/src/java/org/apache/solr/prometheus/exporter/SolrExporter.java:
##
@@ -242,6 +256,22 @@ public static void main(String[] args) {
.setDef
epugh commented on code in PR #1957:
URL: https://github.com/apache/solr/pull/1957#discussion_r1336079691
##
solr/prometheus-exporter/src/java/org/apache/solr/prometheus/exporter/SolrExporter.java:
##
@@ -96,6 +96,20 @@ public class SolrExporter {
+ ARG_NUM_THREADS_DE
epugh commented on code in PR #1957:
URL: https://github.com/apache/solr/pull/1957#discussion_r1336078795
##
solr/prometheus-exporter/src/java/org/apache/solr/prometheus/exporter/SolrClientFactory.java:
##
Review Comment:
Do we need this class? Probably, but I wonder if it
epugh commented on PR #1957:
URL: https://github.com/apache/solr/pull/1957#issuecomment-1733998142
Awesome work @stillalex Have you looked at
https://github.com/apache/solr/pull/1954 (SOLR-14496) where I took a stab at
adding credentials to the SolrCLI? It would be great if we used
stillalex opened a new pull request, #1957:
URL: https://github.com/apache/solr/pull/1957
https://issues.apache.org/jira/browse/SOLR-16980
# Description
Adding support for passing basic auth details to cli command
# Solution
Please provide a short descr
Raghavan1988 commented on PR #1842:
URL: https://github.com/apache/solr/pull/1842#issuecomment-1733937894
i ll change and resend the PR soon
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the sp
[
https://issues.apache.org/jira/browse/SOLR-16463?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17768745#comment-17768745
]
Shawn Heisey commented on SOLR-16463:
-
I came up with some changes to the bin/solr sc
epugh commented on PR #1875:
URL: https://github.com/apache/solr/pull/1875#issuecomment-1733907931
i hate having PR's that just hang out open for years in github ;-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
epugh closed pull request #1875: Test user managed index replication
URL: https://github.com/apache/solr/pull/1875
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscrib
epugh commented on PR #1875:
URL: https://github.com/apache/solr/pull/1875#issuecomment-1733906940
;-) Okay. That's fair. I'll close this, and if we see value int he future
we can reopen.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
janhoy commented on PR #1875:
URL: https://github.com/apache/solr/pull/1875#issuecomment-1733905109
Not very convinced still 😉
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment
[
https://issues.apache.org/jira/browse/SOLR-16463?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Shawn Heisey updated SOLR-16463:
Attachment: SOLR-16463.patch
> Serious crash on JDK17+ due to JIT on caffeinecache
> --
epugh commented on PR #1875:
URL: https://github.com/apache/solr/pull/1875#issuecomment-1733679076
i think we're going to see a lot more change in this area, adding basic
auth, the potential changes aorund ZK.. so thinking this helps build
confidence we didn't break anythingDoes th
69 matches
Mail list logo
