Re: [PR] Add sysprop driven XML tags to default solr.xml [solr-operator]

2023-10-02 Thread via GitHub
gerlowskija commented on PR #636: URL: https://github.com/apache/solr-operator/pull/636#issuecomment-1744089624 > might as well include the solr.port.advertise here as well I've added the necessary changes to work `solr.port.advertise` into generated solr.xml files, though I think it'

[jira] [Commented] (SOLR-17000) ExecutorUtilTest failures due to bad concurrency assumptions in test logic

2023-10-02 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17000?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17771309#comment-17771309 ] Kevin Risden commented on SOLR-17000: - [^SOLR-17000-1.patch] looks good > ExecutorUt

[jira] [Updated] (SOLR-17000) ExecutorUtilTest failures due to bad concurrency assumptions in test logic

2023-10-02 Thread Chris M. Hostetter (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17000?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris M. Hostetter updated SOLR-17000: -- Attachment: SOLR-17000-1.patch Status: Open (was: Open) Updated patch to use

Re: [PR] Add sysprop driven XML tags to default solr.xml [solr-operator]

2023-10-02 Thread via GitHub
gerlowskija commented on PR #636: URL: https://github.com/apache/solr-operator/pull/636#issuecomment-1744002994 Ah, yes - sorry, I was being dense. Had an epiphany about what you meant while I was afk getting dinner. I tested it as well - looks good on 8.11 and 9.3 both. So I think we're

Re: [PR] Update dependency org.semver4j:semver4j to v5.2.1 [solr]

2023-10-02 Thread via GitHub
risdenk merged PR #1968: URL: https://github.com/apache/solr/pull/1968 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.or

Re: [PR] Update org.apache.calcite to v1.35.0 [solr]

2023-10-02 Thread via GitHub
risdenk merged PR #1815: URL: https://github.com/apache/solr/pull/1815 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.or

Re: [PR] Update io.dropwizard.metrics:* to v4.2.20 [solr]

2023-10-02 Thread via GitHub
risdenk merged PR #1970: URL: https://github.com/apache/solr/pull/1970 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.or

Re: [PR] Update dependency org.xerial.snappy:snappy-java to v1.1.10.5 [solr]

2023-10-02 Thread via GitHub
risdenk merged PR #1966: URL: https://github.com/apache/solr/pull/1966 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.or

Re: [PR] Update dependency io.swagger.core.v3:swagger-annotations to v2.2.16 [solr]

2023-10-02 Thread via GitHub
risdenk merged PR #1953: URL: https://github.com/apache/solr/pull/1953 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.or

Re: [PR] Documents lost in Consumer during target Solr restart. [solr-sandbox]

2023-10-02 Thread via GitHub
markrmiller commented on PR #73: URL: https://github.com/apache/solr-sandbox/pull/73#issuecomment-1743774649 Good catch, big hole that that test only tests dropping zk and not Solr. I'm just wrapping up a fix. Appears to be caused by batching multiple Kafka records to a SolrRequ

Re: [PR] Add sysprop driven XML tags to default solr.xml [solr-operator]

2023-10-02 Thread via GitHub
HoustonPutman commented on PR #636: URL: https://github.com/apache/solr-operator/pull/636#issuecomment-1743747944 > > If the user doesn't provide solr.sharedLib, the xml section will start with ,. > > Hmm, not quite sure what you mean. Are you talking about the [GenerateAdditionalLib

Re: [PR] Add sysprop driven XML tags to default solr.xml [solr-operator]

2023-10-02 Thread via GitHub
gerlowskija commented on PR #636: URL: https://github.com/apache/solr-operator/pull/636#issuecomment-1743725754 > If the user doesn't provide solr.sharedLib, the xml section will start with ,. Hmm, not quite sure what you mean. Are you talking about the [GenerateAdditionalLibXMLPart

Re: [PR] Pass exporter args as env vars where possible [solr-operator]

2023-10-02 Thread via GitHub
HoustonPutman commented on PR #639: URL: https://github.com/apache/solr-operator/pull/639#issuecomment-1743716056 > 1. How do we want to handle the potential conflict between user-specified env-vars, and values like `.Spec.NumThreads` that are converted into an env-var by the operator? Cur

Re: [PR] Pass exporter args as env vars where possible [solr-operator]

2023-10-02 Thread via GitHub
gerlowskija commented on PR #639: URL: https://github.com/apache/solr-operator/pull/639#issuecomment-1743692444 Two questions I could use a bit of clarity on before this can be merged: 1. How do we want to handle the potential conflict between user-specified env-vars, and values like

[jira] [Updated] (SOLR-14496) Add basic auth support to SolrCLI commands

2023-10-02 Thread Eric Pugh (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14496?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eric Pugh updated SOLR-14496: - Description: This ticket will allow all the logical tools in bin/solr (SolrCLI) to use basic auth creden

[PR] Pass exporter args as env vars where possible [solr-operator]

2023-10-02 Thread via GitHub
gerlowskija opened a new pull request, #639: URL: https://github.com/apache/solr-operator/pull/639 In recent versions of Solr (>=8.8) the prometheus exporter has an env-var equivalent for each CLI argument taken by its start script. This commit switches the operator over to providing

[I] Replace exporter CLI args with env vars where possible [solr-operator]

2023-10-02 Thread via GitHub
gerlowskija opened a new issue, #638: URL: https://github.com/apache/solr-operator/issues/638 In recent versions of Solr (>=8.8) the prometheus exporter has an env-var equivalent for each CLI argument taken in by its start script. Env vars can be easier to read and parse than a long s

Re: [PR] Update io.netty:* to v4.1.98.Final [solr]

2023-10-02 Thread via GitHub
risdenk commented on PR #1967: URL: https://github.com/apache/solr/pull/1967#issuecomment-1743661371 Should wait for 4.1.99.Final to end up on this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

Re: [PR] SOLR-14496: Add Basic Auth support to SolrCLI [solr]

2023-10-02 Thread via GitHub
epugh commented on PR #1954: URL: https://github.com/apache/solr/pull/1954#issuecomment-1743656420 Still need to update the Ref Guide... Hoping to get clarity on if we can re-purpose the `-u` parameter ;-) -- This is an automated message from the Apache Git Service. To respond to the mes

Re: [PR] SOLR-14496: Add Basic Auth support to SolrCLI [solr]

2023-10-02 Thread via GitHub
epugh commented on PR #1954: URL: https://github.com/apache/solr/pull/1954#issuecomment-1743655383 > `Dbasicauth` I looked at `test_ssl.bats` and it has these lines: ``` solr start -c solr auth enable -type basicAuth -credentials name:password solr assert --starte

Re: [PR] Update dependency com.github.ben-manes.caffeine:caffeine to v3.1.8 [solr]

2023-10-02 Thread via GitHub
risdenk merged PR #1812: URL: https://github.com/apache/solr/pull/1812 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.or

Re: [PR] Update software.amazon.awssdk:* to v2.20.155 [solr]

2023-10-02 Thread via GitHub
risdenk merged PR #1877: URL: https://github.com/apache/solr/pull/1877 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.or

Re: [PR] Update dependency no.nav.security:mock-oauth2-server to v0.5.10 [solr]

2023-10-02 Thread via GitHub
risdenk merged PR #1608: URL: https://github.com/apache/solr/pull/1608 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.or

Re: [PR] Update indexing docs in Solr ref guide [solr]

2023-10-02 Thread via GitHub
AndreyBozhko commented on PR #1961: URL: https://github.com/apache/solr/pull/1961#issuecomment-1743605262 @epugh This should be ready now for your review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

Re: [PR] Update dependency org.apache.commons:commons-compress to v1.24.0 [solr]

2023-10-02 Thread via GitHub
risdenk merged PR #1910: URL: https://github.com/apache/solr/pull/1910 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.or

Re: [PR] SOLR-14496: Add Basic Auth support to SolrCLI [solr]

2023-10-02 Thread via GitHub
epugh commented on PR #1954: URL: https://github.com/apache/solr/pull/1954#issuecomment-1743526141 > Will this still support using `-Dbasicauth` and `-Dsolr.httpclient.builder.factory` in `SOLR_TOOL_OPTS`? It *should*, however, to be honest, I've never used those parameters... Do

Re: [PR] SOLR-14496: Add Basic Auth support to SolrCLI [solr]

2023-10-02 Thread via GitHub
HoustonPutman commented on PR #1954: URL: https://github.com/apache/solr/pull/1954#issuecomment-1743507341 Will this still support using `-Dbasicauth` and `-Dsolr.httpclient.builder.factory` in `SOLR_TOOL_OPTS`? -- This is an automated message from the Apache Git Service. To respond to th

[jira] [Commented] (SOLR-16960) Tests should sometimes run with a Tracer (not no-op)

2023-10-02 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17771235#comment-17771235 ] ASF subversion and git services commented on SOLR-16960: Commit b

Re: [PR] SOLR-16960 Tests should sometimes run with a Tracer (not no-op) [solr]

2023-10-02 Thread via GitHub
stillalex merged PR #1972: URL: https://github.com/apache/solr/pull/1972 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.

Re: [PR] Add sysprop driven XML tags to default solr.xml [solr-operator]

2023-10-02 Thread via GitHub
HoustonPutman commented on PR #636: URL: https://github.com/apache/solr-operator/pull/636#issuecomment-1743489917 Oh, might as well include the `solr.port.advertise` here as well, unless you wanted to do that in a separate PR. No worries either way. -- This is an automated message from th

[PR] SOLR-16960 Tests should sometimes run with a Tracer (not no-op) [solr]

2023-10-02 Thread via GitHub
stillalex opened a new pull request, #1972: URL: https://github.com/apache/solr/pull/1972 https://issues.apache.org/jira/browse/SOLR-16960 # Description Regression of SOLR-16960 in the case where the recoding noop span can override the simple trace id with a default

Re: [PR] Update dependency com.google.errorprone:error_prone_annotations to v2.22.0 [solr]

2023-10-02 Thread via GitHub
risdenk merged PR #1701: URL: https://github.com/apache/solr/pull/1701 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.or

Re: [PR] Update dependency com.google.errorprone:error_prone_annotations to v2.22.0 [solr]

2023-10-02 Thread via GitHub
solrbot commented on PR #1701: URL: https://github.com/apache/solr/pull/1701#issuecomment-1743327720 ### Edited/Blocked Notification Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

Re: [PR] SOLR-14496: Add Basic Auth support to SolrCLI [solr]

2023-10-02 Thread via GitHub
stillalex commented on code in PR #1954: URL: https://github.com/apache/solr/pull/1954#discussion_r1342889198 ## solr/core/src/java/org/apache/solr/cli/AssertTool.java: ## @@ -123,6 +123,14 @@ public List getOptions() { Option.builder("e") .desc("Return an

[I] Deploying solr with zk operator makes it unavailable for writing apps outside of the cluster out of the box [solr-operator]

2023-10-02 Thread via GitHub
Ella-eln opened a new issue, #637: URL: https://github.com/apache/solr-operator/issues/637 Pravega's zk operator only allows to expose adminserverservice as external out of the box. Solr itself does not have a problem with it, however, it creates a problem when trying to write data into sol

Re: [PR] SOLR-14496: Add Basic Auth support to SolrCLI [solr]

2023-10-02 Thread via GitHub
epugh commented on code in PR #1954: URL: https://github.com/apache/solr/pull/1954#discussion_r1342815745 ## solr/core/src/java/org/apache/solr/cli/ExportTool.java: ## @@ -202,7 +209,16 @@ DocsSink getSink() { abstract void exportDocs() throws Exception; void fetchUn

[jira] [Updated] (SOLR-16843) timestamp issue with autoscaling framework

2023-10-02 Thread Pierre Salagnac (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16843?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Salagnac updated SOLR-16843: --- Description: The framework does not exist anymore with Solr 9+, so this bug only impacts Sol

Re: [PR] SOLR-14496: Add Basic Auth support to SolrCLI [solr]

2023-10-02 Thread via GitHub
epugh commented on code in PR #1954: URL: https://github.com/apache/solr/pull/1954#discussion_r1342810570 ## solr/solrj/src/java/org/apache/solr/client/solrj/impl/Http2SolrClient.java: ## @@ -1311,6 +1311,22 @@ public Builder withProxyConfiguration( this.proxyIsSecure = i

Re: [PR] SOLR-14496: Add Basic Auth support to SolrCLI [solr]

2023-10-02 Thread via GitHub
epugh commented on PR #1954: URL: https://github.com/apache/solr/pull/1954#issuecomment-1743178358 So, one thing I noticed is that the method `withOptionalBasicAuthCredentials` is ONLY on Http2SolrClient.Builder. It isn't on the `HttpSolrClient builder`. Or on some of the other variations

Re: [PR] Update dependency com.google.errorprone:error_prone_annotations to v2.22.0 [solr]

2023-10-02 Thread via GitHub
risdenk commented on PR #1701: URL: https://github.com/apache/solr/pull/1701#issuecomment-1743173285 Hmmm well apparently locally didn't end up recompiling all the tests so doing that now :D -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [PR] SOLR-14496: Add Basic Auth support to SolrCLI [solr]

2023-10-02 Thread via GitHub
epugh commented on code in PR #1954: URL: https://github.com/apache/solr/pull/1954#discussion_r1342785865 ## solr/solrj/src/java/org/apache/solr/client/solrj/impl/Http2SolrClient.java: ## @@ -1311,6 +1311,22 @@ public Builder withProxyConfiguration( this.proxyIsSecure = i

Re: [PR] Update dependency com.google.errorprone:error_prone_annotations to v2.22.0 [solr]

2023-10-02 Thread via GitHub
risdenk commented on PR #1701: URL: https://github.com/apache/solr/pull/1701#issuecomment-1743101457 I'm looking at this today -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

[jira] [Commented] (SOLR-17004) ZkStateReader waitForState should check clusterState before using watchers

2023-10-02 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17004?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17771133#comment-17771133 ] ASF subversion and git services commented on SOLR-17004: Commit 3

[jira] [Updated] (SOLR-17004) ZkStateReader waitForState should check clusterState before using watchers

2023-10-02 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17004?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Risden updated SOLR-17004: Resolution: Fixed Status: Resolved (was: Patch Available) > ZkStateReader waitForState sho

[jira] [Updated] (SOLR-17004) ZkStateReader waitForState should check clusterState before using watchers

2023-10-02 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17004?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Risden updated SOLR-17004: Fix Version/s: 9.4 > ZkStateReader waitForState should check clusterState before using watchers > -

[jira] [Commented] (SOLR-17004) ZkStateReader waitForState should check clusterState before using watchers

2023-10-02 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17004?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17771130#comment-17771130 ] ASF subversion and git services commented on SOLR-17004: Commit 6

Re: [PR] SOLR-14496: Add Basic Auth support to SolrCLI [solr]

2023-10-02 Thread via GitHub
epugh commented on code in PR #1954: URL: https://github.com/apache/solr/pull/1954#discussion_r1342625748 ## solr/core/src/java/org/apache/solr/cli/AssertTool.java: ## @@ -123,6 +123,14 @@ public List getOptions() { Option.builder("e") .desc("Return an exit

Re: [PR] SOLR-14496: Add Basic Auth support to SolrCLI [solr]

2023-10-02 Thread via GitHub
epugh commented on code in PR #1954: URL: https://github.com/apache/solr/pull/1954#discussion_r1342625290 ## solr/core/src/java/org/apache/solr/cli/ApiTool.java: ## @@ -57,27 +57,28 @@ public List getOptions() { .hasArg() .required(true) .d

Re: [PR] Coordinator node does not have correct collection tagged for TracingSpan [solr]

2023-10-02 Thread via GitHub
dsmiley commented on PR #1962: URL: https://github.com/apache/solr/pull/1962#issuecomment-1742899303 Fantastic docs on CoordinatorHttpSolrCall :-) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] Add dead letter queue functionality on the producer and consumer side [solr-sandbox]

2023-10-02 Thread via GitHub
marcingorski commented on PR #70: URL: https://github.com/apache/solr-sandbox/pull/70#issuecomment-1742859381 If topicName/dlqTopicName is specified but not available on Kafka server, we will throw exception. Log level has been changed to `INFO`. -- This is an automated message from t

[jira] [Resolved] (SOLR-16994) facilitate date-related FieldValueFeature extensions (docValues=True only)

2023-10-02 Thread Christine Poerschke (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16994?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Christine Poerschke resolved SOLR-16994. Fix Version/s: main (10.0) 9.4 Resolution: Fixed > facili

[jira] [Commented] (SOLR-16994) facilitate date-related FieldValueFeature extensions (docValues=True only)

2023-10-02 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17771042#comment-17771042 ] ASF subversion and git services commented on SOLR-16994: Commit 2

[jira] [Commented] (SOLR-16994) facilitate date-related FieldValueFeature extensions (docValues=True only)

2023-10-02 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17771040#comment-17771040 ] ASF subversion and git services commented on SOLR-16994: Commit e

Re: [PR] SOLR-16994: facilitate date-related FieldValueFeature extensions (docValues=True only) [solr]

2023-10-02 Thread via GitHub
cpoerschke merged PR #1950: URL: https://github.com/apache/solr/pull/1950 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache