Re: [PR] Fix test failure on J9: do not mock jre class [solr]

2023-11-23 Thread via GitHub
mkhludnev commented on code in PR #2086: URL: https://github.com/apache/solr/pull/2086#discussion_r1403754766 ## solr/core/src/test/org/apache/solr/core/BlobRepositoryMockingTest.java: ## @@ -71,7 +71,8 @@ public void setUp() throws Exception { super.setUp(); blobFetch

Re: [PR] Fix test failure on J9: do not mock jre class [solr]

2023-11-23 Thread via GitHub
mkhludnev commented on PR #2086: URL: https://github.com/apache/solr/pull/2086#issuecomment-1824921836 pushed fix into main and branch_9x -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

Re: [PR] GH-2086: errorprone build fix #2086 (#2090) [solr]

2023-11-23 Thread via GitHub
mkhludnev merged PR #2091: URL: https://github.com/apache/solr/pull/2091 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.

Re: [PR] GH-2086: errorprone fix #2086 [solr]

2023-11-23 Thread via GitHub
mkhludnev merged PR #2090: URL: https://github.com/apache/solr/pull/2090 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.

Re: [PR] GH-2086: errorprone fix #2086 [solr]

2023-11-23 Thread via GitHub
mkhludnev commented on PR #2090: URL: https://github.com/apache/solr/pull/2090#issuecomment-1824895865 Merging since it's a bit of urgency. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spe

[PR] GH-2086: errorprone fix #2086 [solr]

2023-11-23 Thread via GitHub
mkhludnev opened a new pull request, #2090: URL: https://github.com/apache/solr/pull/2090 resolving warning -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

Re: [PR] Fix test failure on J9: do not mock jre class [solr]

2023-11-23 Thread via GitHub
madrob commented on code in PR #2086: URL: https://github.com/apache/solr/pull/2086#discussion_r1403698891 ## solr/core/src/test/org/apache/solr/core/BlobRepositoryMockingTest.java: ## @@ -71,7 +71,8 @@ public void setUp() throws Exception { super.setUp(); blobFetched

Re: [PR] Fix test failure on J9: do not mock jre class [solr]

2023-11-23 Thread via GitHub
mkhludnev commented on code in PR #2086: URL: https://github.com/apache/solr/pull/2086#discussion_r1403690969 ## solr/core/src/test/org/apache/solr/core/BlobRepositoryMockingTest.java: ## @@ -71,7 +71,8 @@ public void setUp() throws Exception { super.setUp(); blobFetch

Re: [PR] SOLR-16974: Documentation and changes entry for global CB [solr]

2023-11-23 Thread via GitHub
janhoy commented on PR #2069: URL: https://github.com/apache/solr/pull/2069#issuecomment-1824836537 Yea, reported it in https://github.com/apache/solr/pull/2086#issuecomment-1823635256 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] Fix typos and improve grammar in Query Guide [solr]

2023-11-23 Thread via GitHub
mkhludnev commented on PR #2024: URL: https://github.com/apache/solr/pull/2024#issuecomment-1824806791 @epugh if you are busy I'd like to push it. @AndreyBozhko it's awesome. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on t

Re: [PR] SOLR-10653: leader to replica updates fail on UUIDField [solr]

2023-11-23 Thread via GitHub
mkhludnev commented on PR #2078: URL: https://github.com/apache/solr/pull/2078#issuecomment-1824803107 Last call! Going, going.. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comm

Re: [PR] SOLR-16865 : Solr should warn about low disk space upon startup [solr]

2023-11-23 Thread via GitHub
culmat commented on PR #2080: URL: https://github.com/apache/solr/pull/2080#issuecomment-1824777605 Hi there, I don't know why this fails with style warnings on test / mock code I have not modified. -- This is an automated message from the Apache Git Service. To respond to the message

Re: [PR] SOLR-10653: leader to replica updates fail on UUIDField [solr]

2023-11-23 Thread via GitHub
mkhludnev commented on code in PR #2078: URL: https://github.com/apache/solr/pull/2078#discussion_r1403638809 ## solr/core/src/test/org/apache/solr/update/UuidAtomicUpdateTest.java: ## @@ -0,0 +1,167 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more +

[PR] Add endpoint to expose consumer metrics. [solr-sandbox]

2023-11-23 Thread via GitHub
sigram opened a new pull request, #94: URL: https://github.com/apache/solr-sandbox/pull/94 This PR adds a Jetty-based server + servlet to expose the collected consumer metrics. I added two endpoints: * `/threads` to view a thread dump * `/metrics` to view the collected metri

[PR] FUS-4536: Add endpoint to expose consumer metrics. [solr-sandbox]

2023-11-23 Thread via GitHub
sigram opened a new pull request, #93: URL: https://github.com/apache/solr-sandbox/pull/93 This PR adds a Jetty-based server + servlet to expose the collected consumer metrics. I added two endpoints: * `/threads` to view a thread dump * `/metrics` to view the collected metri

Re: [PR] Add endpoint to expose consumer metrics. [solr-sandbox]

2023-11-23 Thread via GitHub
sigram closed pull request #93: Add endpoint to expose consumer metrics. URL: https://github.com/apache/solr-sandbox/pull/93 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[PR] clarify .github/workflows display name: gradle precommit--->check w/ Java 11 [solr]

2023-11-23 Thread via GitHub
cpoerschke opened a new pull request, #2089: URL: https://github.com/apache/solr/pull/2089 To make it clearer what the same command for running locally is. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [PR] SOLR-16974: Documentation and changes entry for global CB [solr]

2023-11-23 Thread via GitHub
cpoerschke commented on PR #2069: URL: https://github.com/apache/solr/pull/2069#issuecomment-1824304685 Hmm, not sure what's up with the precommit failure. Looks unrelated and unable to reproduce locally. -- This is an automated message from the Apache Git Service. To respond to the messa