[jira] [Resolved] (SOLR-17091) Fix cloud.sh to ignore -slim.tgz

2023-11-29 Thread Gus Heck (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17091?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gus Heck resolved SOLR-17091. - Resolution: Fixed > Fix cloud.sh to ignore -slim.tgz > > >

[jira] [Commented] (SOLR-17091) Fix cloud.sh to ignore -slim.tgz

2023-11-29 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17091?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17791374#comment-17791374 ] ASF subversion and git services commented on SOLR-17091: Commit 5

Re: [PR] Backport SOLR-17091 [solr]

2023-11-29 Thread via GitHub
gus-asf merged PR #2106: URL: https://github.com/apache/solr/pull/2106 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.or

[jira] [Commented] (SOLR-17091) Fix cloud.sh to ignore -slim.tgz

2023-11-29 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17091?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17791370#comment-17791370 ] ASF subversion and git services commented on SOLR-17091: Commit 7

Re: [PR] SOLR-17091 fix edit that got missed in last commit [solr]

2023-11-29 Thread via GitHub
gus-asf merged PR #2105: URL: https://github.com/apache/solr/pull/2105 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.or

[PR] SOLR-17091 fix edit that got missed in last commit [solr]

2023-11-29 Thread via GitHub
gus-asf opened a new pull request, #2105: URL: https://github.com/apache/solr/pull/2105 https://issues.apache.org/jira/browse/SOLR-17091 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

[jira] [Commented] (SOLR-17091) Fix cloud.sh to ignore -slim.tgz

2023-11-29 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17091?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17791345#comment-17791345 ] ASF subversion and git services commented on SOLR-17091: Commit 0

Re: [PR] SOLR-17091 Update cloud.sh to ignore -slim.tgz. [solr]

2023-11-29 Thread via GitHub
gus-asf merged PR #2104: URL: https://github.com/apache/solr/pull/2104 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.or

Re: [PR] SOLR-17058: Request param to disable distributed stats request at query time [solr]

2023-11-29 Thread via GitHub
mkhludnev commented on PR #2046: URL: https://github.com/apache/solr/pull/2046#issuecomment-1832719192 Thanks @weiwang19 I'll check it next week. @devs please chime in - I always hesitate to come up with names in API! -- This is an automated message from the Apache Git Service. T

Re: [I] Adding support to dynamic value in values.yaml [solr-operator]

2023-11-29 Thread via GitHub
almogtavor commented on issue #661: URL: https://github.com/apache/solr-operator/issues/661#issuecomment-1832670314 @HoustonPutman I also think that it would be nice and actually I think it's quite common. I've found this [article](https://austindewey.com/2021/02/22/using-the-helm-tpl-funct

[jira] [Updated] (SOLR-17091) Fix cloud.sh to ignore -slim.tgz

2023-11-29 Thread Gus Heck (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17091?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gus Heck updated SOLR-17091: Fix Version/s: main (10.0) 9.5 > Fix cloud.sh to ignore -slim.tgz >

[jira] [Updated] (SOLR-17091) Fix cloud.sh to ignore -slim.tgz

2023-11-29 Thread Gus Heck (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17091?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gus Heck updated SOLR-17091: Description: The change that brought us \-slim.tgz seems to have broken cloud.sh, because cloud.sh was rel

[jira] [Updated] (SOLR-17091) Fix cloud.sh to ignore -slim.tgz

2023-11-29 Thread Gus Heck (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17091?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gus Heck updated SOLR-17091: Issue Type: Bug (was: Improvement) > Fix cloud.sh to ignore -slim.tgz > >

[jira] [Created] (SOLR-17091) Fix cloud.sh to ignore -slim.tgz

2023-11-29 Thread Gus Heck (Jira)
Gus Heck created SOLR-17091: --- Summary: Fix cloud.sh to ignore -slim.tgz Key: SOLR-17091 URL: https://issues.apache.org/jira/browse/SOLR-17091 Project: Solr Issue Type: Improvement Security Le

Re: [PR] SOLR-16995: Associate with each replica type a property for "numReplicas" [solr]

2023-11-29 Thread via GitHub
murblanc commented on code in PR #2039: URL: https://github.com/apache/solr/pull/2039#discussion_r1409743662 ## solr/solrj/src/java/org/apache/solr/common/cloud/Replica.java: ## @@ -103,31 +104,41 @@ public enum Type { * support NRT (soft commits) and RTG. Any {@link Type#

Re: [PR] SOLR-17023: Use Modern NLP Models via ONNX and Apache OpenNLP with Solr [solr]

2023-11-29 Thread via GitHub
jzonthemtn commented on PR #1999: URL: https://github.com/apache/solr/pull/1999#issuecomment-1832486680 Looks like a great first step! Glad that OpenNLP 2.3.1 helped move it along. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitH

Re: [PR] SOLR-17023: Use Modern NLP Models via ONNX and Apache OpenNLP with Solr [solr]

2023-11-29 Thread via GitHub
jzonthemtn commented on code in PR #1999: URL: https://github.com/apache/solr/pull/1999#discussion_r1409711871 ## solr/modules/analysis-extras/src/java/org/apache/solr/update/processor/DocumentCategorizerUpdateProcessorFactory.java: ## @@ -0,0 +1,566 @@ +/* + * Licensed to the A

[PR] SOLR-16952: add DenseVectorField to DocsStreamer.KNOWN_TYPES [solr]

2023-11-29 Thread via GitHub
cpoerschke opened a new pull request, #2103: URL: https://github.com/apache/solr/pull/2103 The demo script was started from the awesome https://github.com/apache/solr/blob/main/solr/example/films/README.md content and is for illustrative purposes only and not to be committed. https:/

Re: [PR] SOLR-16743: Auto reload keystore/truststore on change [solr]

2023-11-29 Thread via GitHub
tflobbe commented on code in PR #2100: URL: https://github.com/apache/solr/pull/2100#discussion_r1409707496 ## solr/bin/solr: ## @@ -208,9 +208,17 @@ if [ -z "${SOLR_SSL_ENABLED:-}" ]; then fi if [ "$SOLR_SSL_ENABLED" == "true" ]; then SOLR_JETTY_CONFIG+=("--module=https"

[jira] [Commented] (SOLR-16952) solr.DenseVectorField does not work on a collection with more than 1 shards

2023-11-29 Thread Christine Poerschke (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17791235#comment-17791235 ] Christine Poerschke commented on SOLR-16952: I'm able to reproduce this -- ar

[jira] [Commented] (SOLR-16835) Generate Python bindings from OpenAPI spec

2023-11-29 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17791191#comment-17791191 ] ASF subversion and git services commented on SOLR-16835: Commit a

[jira] [Commented] (SOLR-16835) Generate Python bindings from OpenAPI spec

2023-11-29 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17791187#comment-17791187 ] ASF subversion and git services commented on SOLR-16835: Commit f

Re: [PR] SOLR-16835: Add approximate-/select to OAS [solr]

2023-11-29 Thread via GitHub
gerlowskija merged PR #2079: URL: https://github.com/apache/solr/pull/2079 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apach

Re: [PR] SOLR-16835: Add approximate-/select to OAS [solr]

2023-11-29 Thread via GitHub
gerlowskija commented on PR #2079: URL: https://github.com/apache/solr/pull/2079#issuecomment-1832327048 Alright- I'm going to merge in our "approximation" for now and use it to dogfood the generated Python client over in #1681. If anyone has any more feedback on this, lmk and we can

Re: [PR] Add endpoint to expose consumer metrics. [solr-sandbox]

2023-11-29 Thread via GitHub
markrmiller commented on PR #94: URL: https://github.com/apache/solr-sandbox/pull/94#issuecomment-1832291359 I actually have some fairly identical work as this, was just waiting to put it up after the merge into Solr. I'll take a look at this today. -- This is an automated message

Re: [PR] SOLR-16743: Auto reload keystore/truststore on change [solr]

2023-11-29 Thread via GitHub
HoustonPutman commented on code in PR #2100: URL: https://github.com/apache/solr/pull/2100#discussion_r1409515440 ## solr/bin/solr: ## @@ -208,9 +208,17 @@ if [ -z "${SOLR_SSL_ENABLED:-}" ]; then fi if [ "$SOLR_SSL_ENABLED" == "true" ]; then SOLR_JETTY_CONFIG+=("--module=ht

[jira] [Created] (SOLR-17090) v2 "delete-alias" API returns 405

2023-11-29 Thread Jason Gerlowski (Jira)
Jason Gerlowski created SOLR-17090: -- Summary: v2 "delete-alias" API returns 405 Key: SOLR-17090 URL: https://issues.apache.org/jira/browse/SOLR-17090 Project: Solr Issue Type: Improvement

[jira] [Updated] (SOLR-17089) Extraction module causes Jersey code to throw NoClassDefFoundError

2023-11-29 Thread Jason Gerlowski (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17089?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gerlowski updated SOLR-17089: --- Description: (Credit to David Smiley for bringing this up and for the repro steps.) In certa

Re: [PR] SOLR-17053: If all shards fail, fail the request despite shards.tolerant [solr]

2023-11-29 Thread via GitHub
aparnasuresh85 commented on PR #2102: URL: https://github.com/apache/solr/pull/2102#issuecomment-1832154967 > Wonderful! Can you please add a CHANGES.txt entry under 9.5 in the Improvements section? > > Suggested text: > > > Distributed search with shards.tolerant: if all shard

[jira] [Created] (SOLR-17089) Extraction module causes Jersey code to throw NoClassDefFoundError

2023-11-29 Thread Jason Gerlowski (Jira)
Jason Gerlowski created SOLR-17089: -- Summary: Extraction module causes Jersey code to throw NoClassDefFoundError Key: SOLR-17089 URL: https://issues.apache.org/jira/browse/SOLR-17089 Project: Solr

[jira] [Assigned] (SOLR-17086) v2 Backup and Replica creation: HTTP 500 error messages

2023-11-29 Thread Jason Gerlowski (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17086?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gerlowski reassigned SOLR-17086: -- Assignee: Jason Gerlowski > v2 Backup and Replica creation: HTTP 500 error messages >

Re: [PR] SOLR-16995: Associate with each replica type a property for "numReplicas" [solr]

2023-11-29 Thread via GitHub
pvcnt commented on code in PR #2039: URL: https://github.com/apache/solr/pull/2039#discussion_r1409418225 ## solr/core/src/java/org/apache/solr/cloud/api/collections/CreateShardCmd.java: ## @@ -97,33 +101,30 @@ public void call(ClusterState clusterState, ZkNodeProps message, Na

Re: [PR] SOLR-16995: Associate with each replica type a property for "numReplicas" [solr]

2023-11-29 Thread via GitHub
pvcnt commented on code in PR #2039: URL: https://github.com/apache/solr/pull/2039#discussion_r1409417510 ## solr/core/src/java/org/apache/solr/cloud/api/collections/ReindexCollectionCmd.java: ## @@ -338,14 +339,8 @@ public void call(ClusterState clusterState, ZkNodeProps messa

Re: [PR] SOLR-16995: Associate with each replica type a property for "numReplicas" [solr]

2023-11-29 Thread via GitHub
pvcnt commented on code in PR #2039: URL: https://github.com/apache/solr/pull/2039#discussion_r1409417129 ## solr/core/src/java/org/apache/solr/cloud/api/collections/RestoreCmd.java: ## @@ -341,10 +318,10 @@ private void createCoreLessCollection( propMap.put(Overseer.QUEU

Re: [PR] SOLR-16995: Associate with each replica type a property for "numReplicas" [solr]

2023-11-29 Thread via GitHub
pvcnt commented on code in PR #2039: URL: https://github.com/apache/solr/pull/2039#discussion_r1409410101 ## solr/core/src/java/org/apache/solr/cloud/api/collections/ReindexCollectionCmd.java: ## @@ -103,17 +104,19 @@ public class ReindexCollectionCmd implements CollApiCmds.Col

Re: [PR] SOLR-16995: Associate with each replica type a property for "numReplicas" [solr]

2023-11-29 Thread via GitHub
pvcnt commented on code in PR #2039: URL: https://github.com/apache/solr/pull/2039#discussion_r1409408694 ## solr/core/src/java/org/apache/solr/cloud/api/collections/CreateShardCmd.java: ## @@ -97,33 +101,30 @@ public void call(ClusterState clusterState, ZkNodeProps message, Na

Re: [PR] SOLR-16995: Associate with each replica type a property for "numReplicas" [solr]

2023-11-29 Thread via GitHub
pvcnt commented on code in PR #2039: URL: https://github.com/apache/solr/pull/2039#discussion_r1409402416 ## solr/core/src/java/org/apache/solr/cloud/api/collections/CreateCollectionCmd.java: ## @@ -590,12 +589,22 @@ public static List populateShardNames(ZkNodeProps message, St

Re: [PR] SOLR-16995: Associate with each replica type a property for "numReplicas" [solr]

2023-11-29 Thread via GitHub
pvcnt commented on code in PR #2039: URL: https://github.com/apache/solr/pull/2039#discussion_r1409402045 ## solr/core/src/java/org/apache/solr/cloud/api/collections/CreateCollectionCmd.java: ## @@ -590,12 +589,22 @@ public static List populateShardNames(ZkNodeProps message, St

[PR] SOLR-17053: If all shards fail, fail the request despite shards.tolerant [solr]

2023-11-29 Thread via GitHub
aparnasuresh85 opened a new pull request, #2102: URL: https://github.com/apache/solr/pull/2102 https://issues.apache.org/jira/browse/SOLR-17053 # Description If the request is tolerant to errors, logic in SearchHandler simply sets partialResults to true upon detecti

Re: [PR] SOLR-16995: Associate with each replica type a property for "numReplicas" [solr]

2023-11-29 Thread via GitHub
pvcnt commented on code in PR #2039: URL: https://github.com/apache/solr/pull/2039#discussion_r1409371156 ## solr/core/src/java/org/apache/solr/cloud/api/collections/CollectionHandlingUtils.java: ## @@ -135,6 +140,20 @@ public class CollectionHandlingUtils { } } + /**

Re: [PR] SOLR-16995: Associate with each replica type a property for "numReplicas" [solr]

2023-11-29 Thread via GitHub
pvcnt commented on code in PR #2039: URL: https://github.com/apache/solr/pull/2039#discussion_r1409398398 ## solr/solrj/src/java/org/apache/solr/common/cloud/ReplicaCount.java: ## @@ -61,6 +122,11 @@ public boolean contains(Replica.Type type) { return countByType.containsKe

Re: [PR] SOLR-16995: Associate with each replica type a property for "numReplicas" [solr]

2023-11-29 Thread via GitHub
pvcnt commented on code in PR #2039: URL: https://github.com/apache/solr/pull/2039#discussion_r1409396424 ## solr/solrj/src/java/org/apache/solr/common/cloud/ReplicaCount.java: ## @@ -100,6 +166,10 @@ public int total() { return countByType.values().stream().reduce(Integer:

Re: [PR] SOLR-16995: Associate with each replica type a property for "numReplicas" [solr]

2023-11-29 Thread via GitHub
pvcnt commented on code in PR #2039: URL: https://github.com/apache/solr/pull/2039#discussion_r1409392996 ## solr/solrj/src/java/org/apache/solr/common/cloud/Replica.java: ## @@ -103,31 +104,41 @@ public enum Type { * support NRT (soft commits) and RTG. Any {@link Type#NRT

Re: [PR] SOLR-16995: Associate with each replica type a property for "numReplicas" [solr]

2023-11-29 Thread via GitHub
pvcnt commented on code in PR #2039: URL: https://github.com/apache/solr/pull/2039#discussion_r1409390333 ## solr/solrj/src/java/org/apache/solr/common/cloud/DocCollection.java: ## @@ -262,12 +258,17 @@ public static Object verifyProp(Map props, String propName) { public s

Re: [PR] SOLR-16995: Associate with each replica type a property for "numReplicas" [solr]

2023-11-29 Thread via GitHub
pvcnt commented on code in PR #2039: URL: https://github.com/apache/solr/pull/2039#discussion_r1409387774 ## solr/core/src/java/org/apache/solr/handler/admin/api/RestoreCollectionAPI.java: ## @@ -70,15 +69,17 @@ @Path("/backups/{backupName}/restore") public class RestoreCollec

Re: [PR] SOLR-16995: Associate with each replica type a property for "numReplicas" [solr]

2023-11-29 Thread via GitHub
pvcnt commented on code in PR #2039: URL: https://github.com/apache/solr/pull/2039#discussion_r1409385922 ## solr/core/src/java/org/apache/solr/cluster/placement/impl/PlacementRequestImpl.java: ## @@ -33,21 +33,6 @@ public class PlacementRequestImpl implements PlacementRequest

Re: [PR] SOLR-16995: Associate with each replica type a property for "numReplicas" [solr]

2023-11-29 Thread via GitHub
pvcnt commented on code in PR #2039: URL: https://github.com/apache/solr/pull/2039#discussion_r1409383558 ## solr/core/src/java/org/apache/solr/cloud/api/collections/CreateShardCmd.java: ## @@ -97,33 +101,30 @@ public void call(ClusterState clusterState, ZkNodeProps message, Na

Re: [PR] SOLR-16995: Associate with each replica type a property for "numReplicas" [solr]

2023-11-29 Thread via GitHub
pvcnt commented on code in PR #2039: URL: https://github.com/apache/solr/pull/2039#discussion_r1409373603 ## solr/solrj/src/java/org/apache/solr/common/cloud/Replica.java: ## @@ -103,31 +104,41 @@ public enum Type { * support NRT (soft commits) and RTG. Any {@link Type#NRT

Re: [PR] SOLR-16995: Associate with each replica type a property for "numReplicas" [solr]

2023-11-29 Thread via GitHub
pvcnt commented on code in PR #2039: URL: https://github.com/apache/solr/pull/2039#discussion_r1409372699 ## solr/core/src/java/org/apache/solr/cloud/api/collections/CreateCollectionCmd.java: ## @@ -97,9 +94,12 @@ public class CreateCollectionCmd implements CollApiCmds.Collecti

Re: [PR] SOLR-16995: Associate with each replica type a property for "numReplicas" [solr]

2023-11-29 Thread via GitHub
pvcnt commented on code in PR #2039: URL: https://github.com/apache/solr/pull/2039#discussion_r1409372280 ## solr/solrj/src/java/org/apache/solr/common/cloud/Replica.java: ## @@ -103,31 +104,41 @@ public enum Type { * support NRT (soft commits) and RTG. Any {@link Type#NRT

Re: [PR] SOLR-16995: Associate with each replica type a property for "numReplicas" [solr]

2023-11-29 Thread via GitHub
pvcnt commented on code in PR #2039: URL: https://github.com/apache/solr/pull/2039#discussion_r1409371156 ## solr/core/src/java/org/apache/solr/cloud/api/collections/CollectionHandlingUtils.java: ## @@ -135,6 +140,20 @@ public class CollectionHandlingUtils { } } + /**

Re: [PR] fix: avoid reset of security.json if get fails (#659) [solr-operator]

2023-11-29 Thread via GitHub
smoldenhauer-ish commented on PR #660: URL: https://github.com/apache/solr-operator/pull/660#issuecomment-1831794092 adapted the expected setup-zk command and tested locally `make prepare check` and the end tests `make e2e-tests SOLR_IMAGE=solr:8.11` -- This is an automated message from

Re: [PR] SOLR-17036: Lazy create VersionBucket in the update log to free memory. [solr]

2023-11-29 Thread via GitHub
bruno-roustant commented on code in PR #2021: URL: https://github.com/apache/solr/pull/2021#discussion_r1408997849 ## solr/core/src/java/org/apache/solr/update/processor/DistributedUpdateProcessor.java: ## @@ -507,29 +504,19 @@ private boolean doVersionAdd(

Re: [PR] SOLR-17036: Lazy create VersionBucket in the update log to free memory. [solr]

2023-11-29 Thread via GitHub
bruno-roustant commented on code in PR #2021: URL: https://github.com/apache/solr/pull/2021#discussion_r1408995357 ## solr/core/src/java/org/apache/solr/update/processor/DistributedUpdateProcessor.java: ## @@ -507,29 +504,19 @@ private boolean doVersionAdd(

Re: [PR] SOLR-17036: Lazy create VersionBucket in the update log to free memory. [solr]

2023-11-29 Thread via GitHub
bruno-roustant commented on code in PR #2021: URL: https://github.com/apache/solr/pull/2021#discussion_r1408995357 ## solr/core/src/java/org/apache/solr/update/processor/DistributedUpdateProcessor.java: ## @@ -507,29 +504,19 @@ private boolean doVersionAdd(