epugh commented on PR #1999:
URL: https://github.com/apache/solr/pull/1999#issuecomment-1883968479
Looking at these build failures and the error message generated, it appears
that it may be caused by us using Java 11 and OpenNLP being compiled with Java
17??
```
/home/runner/wor
janhoy commented on PR #2185:
URL: https://github.com/apache/solr/pull/2185#issuecomment-1883959207
Also, I consider `required_conversation_resolution`, which will require all
conversations to be resolved before merging is possible. I have seen too quick
merges of looong PRs where the autho
janhoy commented on code in PR #2184:
URL: https://github.com/apache/solr/pull/2184#discussion_r1446719703
##
.github/workflows/stale.yml:
##
@@ -0,0 +1,39 @@
+# This workflow warns of PRs that have had no activity for a specified amount
of time.
+#
+# For more information, see
janhoy commented on code in PR #2185:
URL: https://github.com/apache/solr/pull/2185#discussion_r1446716007
##
.asf.yaml:
##
@@ -18,6 +18,18 @@ github:
merge: false
rebase: false
+ protected_branches:
+main: {}
+
+ protected_tags:
+- "releases/*"
+
+ autol
epugh commented on code in PR #1999:
URL: https://github.com/apache/solr/pull/1999#discussion_r1446697110
##
solr/modules/analysis-extras/src/java/org/apache/solr/update/processor/DocumentCategorizerUpdateProcessorFactory.java:
##
@@ -0,0 +1,566 @@
+/*
+ * Licensed to the Apache
epugh commented on code in PR #1999:
URL: https://github.com/apache/solr/pull/1999#discussion_r1446696389
##
solr/licenses/onnxruntime-LICENSE-MIT.txt:
##
@@ -0,0 +1,21 @@
+MIT License
Review Comment:
I *think* we don't specify the version of onnx, so maybe we poke them to
uschindler commented on PR #2186:
URL: https://github.com/apache/solr/pull/2186#issuecomment-1883713569
Will cherrypick this commit on 9.x. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
uschindler commented on PR #2183:
URL: https://github.com/apache/solr/pull/2183#issuecomment-1883708218
Please learn how to use git correctly next time. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL a
uschindler closed pull request #2183: Correct the log.error to include the file
name instead of hard coded …
URL: https://github.com/apache/solr/pull/2183
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to g
uschindler merged PR #2186:
URL: https://github.com/apache/solr/pull/2186
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache
uschindler closed pull request #2183: Correct the log.error to include the file
name instead of hard coded …
URL: https://github.com/apache/solr/pull/2183
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to g
uschindler commented on PR #2183:
URL: https://github.com/apache/solr/pull/2183#issuecomment-1883700130
You could have been merged from main. 😜
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
haldmour-atypon commented on PR #2183:
URL: https://github.com/apache/solr/pull/2183#issuecomment-1883653394
> Can't merge this as there's a conflict. Can you please fix the conflicts?
Will merge the changes asap.
https://github.com/apache/solr/pull/2186
--
This is an a
haldmour-atypon opened a new pull request, #2186:
URL: https://github.com/apache/solr/pull/2186
…value
https://issues.apache.org/jira/browse/SOLR-X
# Description
Please provide a short description of the changes you're making with this
pull request.
cpoerschke commented on code in PR #1999:
URL: https://github.com/apache/solr/pull/1999#discussion_r1446447648
##
solr/licenses/onnxruntime-LICENSE-MIT.txt:
##
@@ -0,0 +1,21 @@
+MIT License
Review Comment:
part-answering own question: OpenNLP 2.3.1 uses onnxruntime 1.15.0 -
cpoerschke commented on code in PR #1999:
URL: https://github.com/apache/solr/pull/1999#discussion_r1446443017
##
solr/modules/analysis-extras/src/java/org/apache/solr/update/processor/DocumentCategorizerUpdateProcessorFactory.java:
##
@@ -0,0 +1,566 @@
+/*
+ * Licensed to the A
cpoerschke commented on code in PR #1999:
URL: https://github.com/apache/solr/pull/1999#discussion_r1446436416
##
solr/licenses/onnxruntime-LICENSE-MIT.txt:
##
@@ -0,0 +1,21 @@
+MIT License
Review Comment:
Looking up https://github.com/microsoft/onnxruntime/blob/v1.15.0/LICE
cpoerschke commented on code in PR #2171:
URL: https://github.com/apache/solr/pull/2171#discussion_r1446419952
##
dev-docs/FAQ.adoc:
##
@@ -91,3 +91,9 @@ If you don't yet have an account, you have to ask for one in
the 'users' or 'dev
1. Please do not delete older files that y
cpoerschke commented on code in PR #2176:
URL: https://github.com/apache/solr/pull/2176#discussion_r1446410422
##
solr/core/src/test/org/apache/solr/search/TestSolrQueryParser.java:
##
@@ -247,9 +247,16 @@ public void testSyntax() throws Exception {
SchemaField foo_dt = h
cpoerschke commented on PR #2176:
URL: https://github.com/apache/solr/pull/2176#issuecomment-1883502943
> `TestSolrQueryParser#testSyntax `- re-run it a few times locally ,
surprisingly it passed then failed, passed, failed; somewhat flaky.
Was able to reproduce the failure locally wi
cpoerschke commented on code in PR #2176:
URL: https://github.com/apache/solr/pull/2176#discussion_r1446374641
##
solr/core/src/java/org/apache/solr/index/SlowCompositeReaderWrapper.java:
##
@@ -111,7 +111,12 @@ public static LeafReader wrap(IndexReader reader) throws
IOExcepti
cpoerschke commented on code in PR #2176:
URL: https://github.com/apache/solr/pull/2176#discussion_r1446372088
##
solr/core/src/java/org/apache/solr/index/SlowCompositeReaderWrapper.java:
##
@@ -97,7 +97,7 @@ public static LeafReader wrap(IndexReader reader) throws
IOException
cpoerschke commented on code in PR #2176:
URL: https://github.com/apache/solr/pull/2176#discussion_r1446361971
##
solr/core/src/java/org/apache/solr/handler/component/QueryComponent.java:
##
@@ -497,7 +498,8 @@ protected int compare(int i, int j) {
// :TODO: would be
cpoerschke commented on code in PR #2185:
URL: https://github.com/apache/solr/pull/2185#discussion_r1446335788
##
.asf.yaml:
##
@@ -18,6 +18,18 @@ github:
merge: false
rebase: false
+ protected_branches:
+main: {}
+
+ protected_tags:
+- "releases/*"
+
+ a
uschindler commented on PR #2183:
URL: https://github.com/apache/solr/pull/2183#issuecomment-1883385837
Can't merge this as there's a conflict. Can you please fix the conflicts?
Will merge the changes asap.
--
This is an automated message from the Apache Git Service.
To respond to the mes
cpoerschke commented on code in PR #2184:
URL: https://github.com/apache/solr/pull/2184#discussion_r1446319712
##
.github/workflows/stale.yml:
##
@@ -0,0 +1,39 @@
+# This workflow warns of PRs that have had no activity for a specified amount
of time.
+#
+# For more information,
epugh commented on PR #1999:
URL: https://github.com/apache/solr/pull/1999#issuecomment-1883364525
@cpoerschke when I demoed this code at the last community meetup,
@gerlowskija asked why not to commit it, and I didn't have a super great
reason. I'd love your thoughts on this PR since you
epugh commented on PR #1833:
URL: https://github.com/apache/solr/pull/1833#issuecomment-1883275132
I'd like to get this merged before tackling the next step of SOLR-16876
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
janhoy opened a new pull request, #2185:
URL: https://github.com/apache/solr/pull/2185
I browsed the [asf.yaml
docs](https://cwiki.apache.org/confluence/pages/viewpage.action?spaceKey=INFRA&title=git+-+.asf.yaml+features),
and found several new capabilities related to GitHub that I believe
janhoy commented on PR #2180:
URL: https://github.com/apache/solr/pull/2180#issuecomment-1883196648
> Does prefixing do something special like give you another filter? I don't
mind `bats-test` or `example` as a label...
No, it's more a convention to namespace different types of tags.
epugh commented on PR #2177:
URL: https://github.com/apache/solr/pull/2177#issuecomment-1883191148
I am having a bit of heart burn on the term "DataStore"The more I
see it proliferate the more it just seems like a bit of classic Enterprise Java
type naming that doesn't mean anything
epugh commented on PR #2180:
URL: https://github.com/apache/solr/pull/2180#issuecomment-1883132692
This is super exciting... I am thinking about other areas of Solr that
specific groups of folks might want to monitor, and therefore might want to
have a label to cue them. `streaming` is o
[
https://issues.apache.org/jira/browse/SOLR-17066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17804743#comment-17804743
]
ASF subversion and git services commented on SOLR-17066:
Commit 0
[
https://issues.apache.org/jira/browse/SOLR-17066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17804738#comment-17804738
]
ASF subversion and git services commented on SOLR-17066:
Commit 1
gerlowskija merged PR #2177:
URL: https://github.com/apache/solr/pull/2177
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apach
janhoy commented on PR #2180:
URL: https://github.com/apache/solr/pull/2180#issuecomment-1883044999
I changed `tool:docker` to `docker`. Would you prefer plain labels `build`
instead of `tool:build` and `scripts` instead of `tool:scripts`?
--
This is an automated message from the Apache G
[
https://issues.apache.org/jira/browse/SOLR-17016?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Eric Pugh resolved SOLR-17016.
--
Fix Version/s: 9.5
Resolution: Fixed
Just checked again and this has been backported to branch_9
Przemyslaw Ciezkowski created SOLR-17113:
Summary: When backup fails unexpected json schema is returned
Key: SOLR-17113
URL: https://issues.apache.org/jira/browse/SOLR-17113
Project: Solr
38 matches
Mail list logo
