Re: [PR] SOLR-17321: Remove Deprecated URL API in Preparation for Java 21 [solr]

2024-06-12 Thread via GitHub
iamsanjay commented on PR #2501: URL: https://github.com/apache/solr/pull/2501#issuecomment-2164294238 Going to merge this and back port to 9x on Friday, around 7PM IST. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

Re: [PR] SOLR-17322 Make RankQuery.getTopDocsCollector use covariant generic types [solr]

2024-06-12 Thread via GitHub
cpoerschke commented on code in PR #2506: URL: https://github.com/apache/solr/pull/2506#discussion_r1636959089 ## solr/core/src/test/org/apache/solr/search/RankQueryTest.java: ## @@ -106,4 +119,65 @@ public void testPluggableCollector() { "//result/doc[2]/str[@name='id'

Re: [PR] SOLR-17037 - Clone LTRScoringQuery on rewriting to preserve queryResultCache key [solr]

2024-06-12 Thread via GitHub
cpoerschke commented on code in PR #2022: URL: https://github.com/apache/solr/pull/2022#discussion_r1636945501 ## solr/modules/ltr/src/java/org/apache/solr/ltr/interleaving/LTRInterleavingScoringQuery.java: ## @@ -45,4 +45,30 @@ public Set getPickedInterleavingDocIds() { publ

Re: [PR] SOLR-17037 - Clone LTRScoringQuery on rewriting to preserve queryResultCache key [solr]

2024-06-12 Thread via GitHub
cpoerschke commented on code in PR #2022: URL: https://github.com/apache/solr/pull/2022#discussion_r1636944566 ## solr/modules/ltr/src/java/org/apache/solr/ltr/interleaving/LTRInterleavingScoringQuery.java: ## @@ -45,4 +45,30 @@ public Set getPickedInterleavingDocIds() { publ

Re: [PR] SOLR-17322 Make RankQuery.getTopDocsCollector use covariant generic types [solr]

2024-06-12 Thread via GitHub
stephen-woods commented on PR #2506: URL: https://github.com/apache/solr/pull/2506#issuecomment-2163702904 I added those static classes as you requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] SOLR-16962: Restore ability to configure tlog directory [solr]

2024-06-12 Thread via GitHub
magibney commented on PR #1895: URL: https://github.com/apache/solr/pull/1895#issuecomment-2163539217 > You might leave the "refactoring" aspect to the commit message and just put in CHANGES.txt what users ought to know. Revised: ``` * SOLR-16962: Restore ability to configure tl

Re: [PR] SOLR-16962: Restore ability to configure tlog directory [solr]

2024-06-12 Thread via GitHub
dsmiley commented on PR #1895: URL: https://github.com/apache/solr/pull/1895#issuecomment-2163436713 You might leave the "refactoring" aspect to the commit message and just put in CHANGES.txt what users ought to know. -- This is an automated message from the Apache Git Service. To respond

Re: [PR] SOLR-16962: Restore ability to configure tlog directory [solr]

2024-06-12 Thread via GitHub
magibney commented on PR #1895: URL: https://github.com/apache/solr/pull/1895#issuecomment-2163387764 Proposed CHANGES.txt: ``` * SOLR-16962: Restore ability to configure tlog directory. Includes substantial refactoring and clarification of logic and definitions around `ulog`

Re: [PR] SOLR-16962: Restore ability to configure tlog directory [solr]

2024-06-12 Thread via GitHub
magibney commented on code in PR #1895: URL: https://github.com/apache/solr/pull/1895#discussion_r1636675376 ## solr/core/src/test/org/apache/solr/update/CustomTLogDirTest.java: ## @@ -36,8 +36,15 @@ public class CustomTLogDirTest extends SolrTestCaseJ4 { new EmbeddedSolr

Re: [PR] SOLR-16962: Restore ability to configure tlog directory [solr]

2024-06-12 Thread via GitHub
magibney commented on PR #1895: URL: https://github.com/apache/solr/pull/1895#issuecomment-2163310662 Ok, I'm planning to merge this tomorrow. The most recent commits add some extra documentation, a test fix, clarity, robustness, and simplify a bit (IMO). I will keep an eye on the builds fo

[PR] SOLR-17330: When not set, loadOnStartup defaults to true [solr]

2024-06-12 Thread via GitHub
psalagnac opened a new pull request, #2513: URL: https://github.com/apache/solr/pull/2513 [SOLR-17330](https://issues.apache.org/jira/browse/SOLR-17330) # Description That's a pretty small change, replacing default value for `loadOnStartup` from `false` to `true` wh

[jira] [Created] (SOLR-17330) Default value for 'loadOnStartup' is fuzzy

2024-06-12 Thread Pierre Salagnac (Jira)
Pierre Salagnac created SOLR-17330: -- Summary: Default value for 'loadOnStartup' is fuzzy Key: SOLR-17330 URL: https://issues.apache.org/jira/browse/SOLR-17330 Project: Solr Issue Type: Bug

Re: [PR] Demonstrate a test framework bug [solr]

2024-06-12 Thread via GitHub
epugh commented on PR #2242: URL: https://github.com/apache/solr/pull/2242#issuecomment-2162851388 @jdyer1 I'd love to see auth testing used a lot more across Solr and this seems like the kind of thing that if not fixed would trip people up in the future. What can I do to help? Your pro

Re: [PR] SOLR-17322 Make RankQuery.getTopDocsCollector use covariant generic types [solr]

2024-06-12 Thread via GitHub
cpoerschke commented on PR #2506: URL: https://github.com/apache/solr/pull/2506#issuecomment-2162712823 > If this gets accepted, I'd like to back port it to 9.X branches Just FYI, whoever merges this PR would cherry-pick to `branch_9x` typically also i.e. no need for a separate pull r

[jira] [Resolved] (SOLR-17326) Wrong class resolution in generated API response classes

2024-06-12 Thread Jason Gerlowski (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17326?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gerlowski resolved SOLR-17326. Fix Version/s: main (10.0) 9.7 Resolution: Fixed Thanks again Chr

[I] Configure Resources for zookeeper operator [solr-operator]

2024-06-12 Thread via GitHub
aloosnetmatch opened a new issue, #708: URL: https://github.com/apache/solr-operator/issues/708 In our kubernetes environment , we require that "resources/requests" are configured. That is not an option right now in the helm chart for the zookeeper operator for the following containers: