[jira] [Commented] (SOLR-17375) Close IndexReader asynchronously on commit for performance

2024-07-21 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17867656#comment-17867656 ] David Smiley commented on SOLR-17375: - Ideally this is fixed in a 9x version but it'l

[jira] [Created] (SOLR-17375) Close IndexReader asynchronously on commit for performance

2024-07-21 Thread David Smiley (Jira)
David Smiley created SOLR-17375: --- Summary: Close IndexReader asynchronously on commit for performance Key: SOLR-17375 URL: https://issues.apache.org/jira/browse/SOLR-17375 Project: Solr Issue T

Re: [PR] SOLR-17367 Unbreak the build caused by bad backport [solr]

2024-07-21 Thread via GitHub
dsmiley commented on PR #2574: URL: https://github.com/apache/solr/pull/2574#issuecomment-2241837644 Non-compile is very preventable. FWIW I've increasingly been a fan of our `dev-tools/scripts/cherrypick.sh` which would not have let this happen. Please try it @epugh -- This is an aut

[jira] [Updated] (SOLR-17321) Bump minimum required Java version to 21

2024-07-21 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17321?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated SOLR-17321: -- Labels: pull-request-available (was: ) > Bump minimum required Java version to 21 > --

Re: [PR] SOLR-17321: Fix TestSolrCoreSnapshots.testBackupRestore [solr]

2024-07-21 Thread via GitHub
dsmiley commented on PR #2539: URL: https://github.com/apache/solr/pull/2539#issuecomment-2241815242 `URIBuilder` is in the Apache HttpClient dependency, using it goes in the opposite direction we're trying to go in! Granted in tests, this isn't a priority, so this PR is acceptable. But b

Re: [PR] SOLR-17336: Eliminate linux/window tabs for bin/solr post. [solr]

2024-07-21 Thread via GitHub
janhoy commented on code in PR #2579: URL: https://github.com/apache/solr/pull/2579#discussion_r1685823352 ## solr/solr-ref-guide/modules/deployment-guide/pages/enabling-ssl.adoc: ## @@ -445,9 +445,9 @@ $ bin/solr post --solr-update-url https://localhost:8984/solr/mycollection/

Re: [PR] SOLR-17336: Eliminate linux/window tabs for bin/solr post. [solr]

2024-07-21 Thread via GitHub
janhoy commented on code in PR #2579: URL: https://github.com/apache/solr/pull/2579#discussion_r1685822399 ## solr/solr-ref-guide/modules/deployment-guide/pages/enabling-ssl.adoc: ## @@ -445,9 +445,9 @@ $ bin/solr post --solr-update-url https://localhost:8984/solr/mycollection/

[jira] [Comment Edited] (SOLR-14985) Slow indexing and search performance when using HttpClusterStateProvider

2024-07-21 Thread Aparna Suresh (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14985?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17867350#comment-17867350 ] Aparna Suresh edited comment on SOLR-14985 at 7/21/24 8:56 PM:

[jira] [Updated] (SOLR-15831) Refactor bin/solr and bin/solr.cmd to delegate args parsing and usage help to SolrCLI

2024-07-21 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15831?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated SOLR-15831: -- Labels: pull-request-available (was: ) > Refactor bin/solr and bin/solr.cmd to delegate args p

Re: [PR] SOLR-15831: Refactor bin/solr and bin/solr.cmd to delegate args parsing and usage help to SolrCLI [solr]

2024-07-21 Thread via GitHub
epugh commented on PR #504: URL: https://github.com/apache/solr/pull/504#issuecomment-2241541204 Some of the ideas in this PR ended up in #2545 as well. I am going to look a bit more at how PackageTool does it's extended help information, and see if we can use that approach more in other

[jira] [Resolved] (SOLR-17371) Forward port relevant CLI changes from branch_9x

2024-07-21 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-17371?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Høydahl resolved SOLR-17371. Resolution: Duplicate > Forward port relevant CLI changes from branch_9x >

[jira] [Commented] (SOLR-16824) Adopt Linux Command line tool pattern of -- for multi character commands.

2024-07-21 Thread Eric Pugh (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17867592#comment-17867592 ] Eric Pugh commented on SOLR-16824: -- When PR 2577 gets merged, I think we can call this o

[jira] [Assigned] (SOLR-17336) Merge windows and linux examples in ref guide for post tool

2024-07-21 Thread Eric Pugh (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17336?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eric Pugh reassigned SOLR-17336: Assignee: Eric Pugh > Merge windows and linux examples in ref guide for post tool > --

[PR] SOLR-17336: Eliminate linux/window tabs for bin/solr post. [solr]

2024-07-21 Thread via GitHub
epugh opened a new pull request, #2579: URL: https://github.com/apache/solr/pull/2579 Also use the same style of formatting for the commands. https://issues.apache.org/jira/browse/SOLR-17336 # Description Please provide a short description of the changes you'r

[jira] [Updated] (SOLR-17336) Merge windows and linux examples in ref guide for post tool

2024-07-21 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17336?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated SOLR-17336: -- Labels: pull-request-available (was: ) > Merge windows and linux examples in ref guide for pos

Re: [PR] SOLR-16824: Replace deprecated single-dash arguments [solr]

2024-07-21 Thread via GitHub
epugh commented on PR #2577: URL: https://github.com/apache/solr/pull/2577#issuecomment-2241516075 There are updates in `main` to `test_post.bats` and `test_help.bats` that you probably want ;-) -- This is an automated message from the Apache Git Service. To respond to the message, please

Re: [PR] SOLR-16824: Replace deprecated single-dash arguments [solr]

2024-07-21 Thread via GitHub
epugh commented on code in PR #2577: URL: https://github.com/apache/solr/pull/2577#discussion_r1685667779 ## solr/bin/solr.cmd: ## @@ -1525,10 +1524,10 @@ IF "!ZK_OP!"=="" ( set CONNECTION_PARAMS="" IF "!ZK_OP!"=="" ( - set CONNECTION_PARAMS="-solrUrl !ZK_SOLR_URL!" + set

Re: [PR] SOLR-16824: Replace deprecated single-dash arguments [solr]

2024-07-21 Thread via GitHub
epugh commented on code in PR #2577: URL: https://github.com/apache/solr/pull/2577#discussion_r1685676831 ## solr/core/src/test/org/apache/solr/cli/AuthToolTest.java: ## @@ -70,7 +70,7 @@ public void testEnableAuth() throws Exception { dir.toAbsolutePath().toString(),

[jira] [Commented] (SOLR-17371) Forward port relevant CLI changes from branch_9x

2024-07-21 Thread Eric Pugh (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17867583#comment-17867583 ] Eric Pugh commented on SOLR-17371: -- Is this ticket closable then? > Forward port releva

Re: [PR] SOLR-16824: Replace deprecated single-dash arguments [solr]

2024-07-21 Thread via GitHub
epugh commented on PR #2577: URL: https://github.com/apache/solr/pull/2577#issuecomment-2241507248 This is some great analysis...Not sure the best way to go through this... Maybe a topic for next week community meetup? Or a working sesion? I think I'll comment in the code, and let

Re: [PR] SOLR-17357 Bug fix. Update to match SolrCLI.printToolHelp formatting rules [solr]

2024-07-21 Thread via GitHub
epugh commented on PR #2573: URL: https://github.com/apache/solr/pull/2573#issuecomment-2241504696 `main` passed! https://ci-builds.apache.org/job/Solr/job/Solr-Check-main/9176/backporting now. -- This is an automated message from the Apache Git Service. To respond to the message, p