[jira] [Commented] (SOLR-13350) Explore collector managers for multi-threaded search

2024-07-25 Thread Gus Heck (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17868834#comment-17868834 ] Gus Heck commented on SOLR-13350: - Not exactly a dedicated test, but some exercise in [h

[jira] [Commented] (SOLR-17298) Multithreaded search breaks limits, and possibly other things

2024-07-25 Thread Gus Heck (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17868833#comment-17868833 ] Gus Heck commented on SOLR-17298: - Added PR that seems to allow searching with &cpuTimeAl

[PR] SOLR-17298 - ThreadCpuTimer safe for multi-threaded search [solr]

2024-07-25 Thread via GitHub
gus-asf opened a new pull request, #2595: URL: https://github.com/apache/solr/pull/2595 https://issues.apache.org/jira/browse/SOLR-17298 This introduces a version of ThreadCpuTimer class that does not need to depend on the request context or be instantiated to track timing. This appro

[jira] [Updated] (SOLR-17379) ParsingFieldUpdateProcessorsTest failures using CLDR locale provider

2024-07-25 Thread Chris M. Hostetter (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17379?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris M. Hostetter updated SOLR-17379: -- Attachment: SOLR-17379.test-1.patch Status: Open (was: Open) Updating patch to

[jira] [Commented] (SOLR-17379) ParsingFieldUpdateProcessorsTest failures using CLDR locale provider

2024-07-25 Thread Chris M. Hostetter (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17868818#comment-17868818 ] Chris M. Hostetter commented on SOLR-17379: --- {quote}+1 thanks {quote} I'm not s

Re: [PR] Create 2024-07-15-apache-solr-performance-jmeter.md [solr-site]

2024-07-25 Thread via GitHub
janhoy commented on PR #114: URL: https://github.com/apache/solr-site/pull/114#issuecomment-2251520522 I merged to production now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific com

Re: [PR] Merge main to production [solr-site]

2024-07-25 Thread via GitHub
janhoy merged PR #116: URL: https://github.com/apache/solr-site/pull/116 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.

[PR] Merge main to production [solr-site]

2024-07-25 Thread via GitHub
janhoy opened a new pull request, #116: URL: https://github.com/apache/solr-site/pull/116 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mai

Re: [PR] Sort blog posts reverse date [solr-site]

2024-07-25 Thread via GitHub
janhoy merged PR #115: URL: https://github.com/apache/solr-site/pull/115 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.

Re: [PR] Sort blog posts reverse date [solr-site]

2024-07-25 Thread via GitHub
janhoy commented on PR #115: URL: https://github.com/apache/solr-site/pull/115#issuecomment-2251510832 Slight change that sorts by the date metadata object. This is auto generated from file name by Pelican, so now we'll get a build exception if there is no date in the file name. Otherwise,

Re: [PR] Create 2024-07-15-apache-solr-performance-jmeter.md [solr-site]

2024-07-25 Thread via GitHub
janhoy commented on PR #114: URL: https://github.com/apache/solr-site/pull/114#issuecomment-2251504640 Perhaps you forgot to merge to production branch? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[jira] [Commented] (SOLR-17379) ParsingFieldUpdateProcessorsTest failures using CLDR locale provider

2024-07-25 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17868804#comment-17868804 ] David Smiley commented on SOLR-17379: - +1 thanks > ParsingFieldUpdateProcessorsTest

Re: [PR] Delegate Collection Property Management to CollectionPropertiesZkStateReader [solr]

2024-07-25 Thread via GitHub
dsmiley commented on code in PR #2585: URL: https://github.com/apache/solr/pull/2585#discussion_r1692105944 ## solr/solrj-zookeeper/src/java/org/apache/solr/common/cloud/ZkStateReader.java: ## @@ -207,6 +207,10 @@ public static ZkStateReader from(CloudSolrClient solrClient) {

Re: [PR] SOLR-13350, SOLR-17298: multi-threaded search: don't (yet) support query limits [solr]

2024-07-25 Thread via GitHub
dsmiley commented on PR #2590: URL: https://github.com/apache/solr/pull/2590#issuecomment-2251356984 [First started failing April 8th](http://fucit.org/solr-jenkins-reports/history-trend-of-recent-failures.html#series/org.apache.solr.ltr.TestLTRQParserPlugin.ltr_expensiveFeatureRescoringAndP

[jira] [Commented] (SOLR-17359) Make SolrCLI handle arg parsing of zk sub commands

2024-07-25 Thread Eric Pugh (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17868796#comment-17868796 ] Eric Pugh commented on SOLR-17359: -- Added a tool to manage the help, and then some speci

[jira] [Updated] (SOLR-17359) Make SolrCLI handle arg parsing of zk sub commands

2024-07-25 Thread Eric Pugh (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17359?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eric Pugh updated SOLR-17359: - Fix Version/s: 9.7 > Make SolrCLI handle arg parsing of zk sub commands > ---

[jira] [Updated] (SOLR-17298) Multithreaded search breaks limits, and possibly other things

2024-07-25 Thread Gus Heck (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17298?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gus Heck updated SOLR-17298: Fix Version/s: 9.7 > Multithreaded search breaks limits, and possibly other things > --

Re: [PR] SOLR-17359: Move Zk Arg parsing into Java Code [solr]

2024-07-25 Thread via GitHub
epugh commented on PR #2593: URL: https://github.com/apache/solr/pull/2593#issuecomment-2251203887 Okay, I changed the short cut "-s" to mean Solr URL instead of "shards". however, in 9x "-s" means shards.. I am thinking that maybe I change allt he tests to use "--shards", and when I back

Re: [PR] SOLR-17378: Add a RequestHandler metric for "number of outstanding concurrent requests" [solr]

2024-07-25 Thread via GitHub
magibney commented on code in PR #2591: URL: https://github.com/apache/solr/pull/2591#discussion_r1691461924 ## solr/core/src/java/org/apache/solr/handler/RequestHandlerBase.java: ## @@ -246,20 +250,24 @@ public void handleRequest(SolrQueryRequest req, SolrQueryResponse rsp) {

[jira] [Created] (SOLR-17380) Consolidate Duplicate Unit Tests between ZkSubcommandsTest and SolrCLIZkToolsTest

2024-07-25 Thread Eric Pugh (Jira)
Eric Pugh created SOLR-17380: Summary: Consolidate Duplicate Unit Tests between ZkSubcommandsTest and SolrCLIZkToolsTest Key: SOLR-17380 URL: https://issues.apache.org/jira/browse/SOLR-17380 Project: Solr

Re: [PR] SOLR-17378: Add a RequestHandler metric for "number of outstanding concurrent requests" [solr]

2024-07-25 Thread via GitHub
magibney commented on code in PR #2591: URL: https://github.com/apache/solr/pull/2591#discussion_r1691465927 ## solr/core/src/java/org/apache/solr/metrics/MaxHistogram.java: ## @@ -0,0 +1,191 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contr

Re: [PR] SOLR-17378: Add a RequestHandler metric for "number of outstanding concurrent requests" [solr]

2024-07-25 Thread via GitHub
magibney commented on code in PR #2591: URL: https://github.com/apache/solr/pull/2591#discussion_r1691506265 ## solr/core/src/java/org/apache/solr/metrics/MaxHistogram.java: ## @@ -0,0 +1,191 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contr

Re: [PR] SOLR-17378: Add a RequestHandler metric for "number of outstanding concurrent requests" [solr]

2024-07-25 Thread via GitHub
magibney commented on code in PR #2591: URL: https://github.com/apache/solr/pull/2591#discussion_r1691502929 ## solr/core/src/java/org/apache/solr/metrics/MetricSuppliers.java: ## @@ -154,17 +155,25 @@ public static Clock getClock(PluginInfo info, String param) { private sta

Re: [PR] SOLR-17378: Add a RequestHandler metric for "number of outstanding concurrent requests" [solr]

2024-07-25 Thread via GitHub
magibney commented on code in PR #2591: URL: https://github.com/apache/solr/pull/2591#discussion_r1691465927 ## solr/core/src/java/org/apache/solr/metrics/MaxHistogram.java: ## @@ -0,0 +1,191 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contr

Re: [PR] SOLR-17378: Add a RequestHandler metric for "number of outstanding concurrent requests" [solr]

2024-07-25 Thread via GitHub
magibney commented on code in PR #2591: URL: https://github.com/apache/solr/pull/2591#discussion_r1691464517 ## solr/core/src/java/org/apache/solr/metrics/MaxHistogram.java: ## @@ -0,0 +1,191 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contr

Re: [PR] SOLR-17378: Add a RequestHandler metric for "number of outstanding concurrent requests" [solr]

2024-07-25 Thread via GitHub
magibney commented on code in PR #2591: URL: https://github.com/apache/solr/pull/2591#discussion_r1691461924 ## solr/core/src/java/org/apache/solr/handler/RequestHandlerBase.java: ## @@ -246,20 +250,24 @@ public void handleRequest(SolrQueryRequest req, SolrQueryResponse rsp) {

[jira] [Commented] (SOLR-17298) Multithreaded search breaks limits, and possibly other things

2024-07-25 Thread Gus Heck (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17868682#comment-17868682 ] Gus Heck commented on SOLR-17298: - Thanks for looking into this, I'm working on a way to

Re: [PR] SOLR-13350, SOLR-17298: multi-threaded search: don't (yet) support query limits [solr]

2024-07-25 Thread via GitHub
sigram commented on PR #2590: URL: https://github.com/apache/solr/pull/2590#issuecomment-2250205498 I wonder whether we should add some information to the response header when `multiThreaded=true` is explicitly set in the params but then it's internally disabled due to the other conditions

Re: [PR] SOLR-13350, SOLR-17298: multi-threaded search: don't (yet) support query limits [solr]

2024-07-25 Thread via GitHub
cpoerschke commented on PR #2590: URL: https://github.com/apache/solr/pull/2590#issuecomment-2249971769 Unable to reproduce the `TestLTRQParserPlugin.ltr_expensiveFeatureRescoringAndPartialResultsNotTolerated_shouldRaiseException` issue locally. Nothing obvious from inspecting the CI output

Re: [PR] Delegate Collection Property Management to CollectionPropertiesZkStateReader [solr]

2024-07-25 Thread via GitHub
aparnasuresh85 commented on code in PR #2585: URL: https://github.com/apache/solr/pull/2585#discussion_r1691147023 ## solr/solrj-zookeeper/src/java/org/apache/solr/common/cloud/CollectionPropertiesZkStateReader.java: ## @@ -0,0 +1,397 @@ +package org.apache.solr.common.cloud; +

Re: [PR] Delegate Collection Property Management to CollectionPropertiesZkStateReader [solr]

2024-07-25 Thread via GitHub
aparnasuresh85 commented on code in PR #2585: URL: https://github.com/apache/solr/pull/2585#discussion_r1691146117 ## solr/solrj-zookeeper/src/java/org/apache/solr/common/cloud/CollectionPropertiesZkStateReader.java: ## @@ -0,0 +1,397 @@ +package org.apache.solr.common.cloud; +

Re: [PR] Delegate Collection Property Management to CollectionPropertiesZkStateReader [solr]

2024-07-25 Thread via GitHub
aparnasuresh85 commented on code in PR #2585: URL: https://github.com/apache/solr/pull/2585#discussion_r1691146117 ## solr/solrj-zookeeper/src/java/org/apache/solr/common/cloud/CollectionPropertiesZkStateReader.java: ## @@ -0,0 +1,397 @@ +package org.apache.solr.common.cloud; +

Re: [PR] SOLR-17337: Show proper distributed stage id [solr]

2024-07-25 Thread via GitHub
cpoerschke commented on code in PR #2526: URL: https://github.com/apache/solr/pull/2526#discussion_r1691092491 ## solr/core/src/java/org/apache/solr/handler/component/DebugComponent.java: ## @@ -181,16 +183,28 @@ public void modifyRequest(ResponseBuilder rb, SearchComponent who