Re: [PR] SOLR-13350, SOLR-17298: use multiThreaded=false default; document multiThreaded parameter; [solr]

dsmiley commented on code in PR #2596: URL: https://github.com/apache/solr/pull/2596#discussion_r1701286420 ## solr/CHANGES.txt: ## @@ -103,7 +103,7 @@ Other Changes == 9.7.0 == New Features - -* SOLR-13350: Multithreaded s

Re: [PR] [SOLR-17368] Change prometheus dummy metric to a more unique label [solr]

dsmiley commented on PR #2613: URL: https://github.com/apache/solr/pull/2613#issuecomment-2264580162 Were you able to reproduce the problem? If I understand the cause, you'd need to run a number of tests, not just this one test. The root fix would be to stop metric leaks between tests!

Re: [PR] SOLR-17386: Fixed SyntheticSolrCore reload issue [solr]

dsmiley commented on PR #2607: URL: https://github.com/apache/solr/pull/2607#issuecomment-2264573626 AFAIUI, This is a bug fix to a regression within 9.7, specifically to SOLR-17269. No released version has this bug. Therefore I don't think we need to list this in the bug fix section or p

Re: [PR] SOLR-17359: Move Zk Arg parsing into Java Code [solr]

rahulgoswami commented on PR #2593: URL: https://github.com/apache/solr/pull/2593#issuecomment-2264499307 Update from tests so far: 1) Commands that work as expected: solr zk ls , solr zk upconfig Yet to test: zk rm, zk mv, zk mkroot, and some more of zk cp . That should cover everythi

Re: [PR] Reduce thread contention in ZkStateReader.getCollectionProperties() [solr]

dsmiley commented on code in PR #2611: URL: https://github.com/apache/solr/pull/2611#discussion_r1700915813 ## solr/solrj-zookeeper/src/java/org/apache/solr/common/cloud/CollectionPropertiesZkStateReader.java: ## @@ -47,7 +46,6 @@ public class CollectionPropertiesZkStateReader i

Re: [PR] [SOLR-17368] Change prometheus dummy metric to a more unique label [solr]

mlbiscoc commented on code in PR #2613: URL: https://github.com/apache/solr/pull/2613#discussion_r1701057393 ## solr/core/src/test/org/apache/solr/response/TestPrometheusResponseWriter.java: ## @@ -78,7 +78,12 @@ public void testPrometheusStructureOutput() throws Exception {

[jira] [Updated] (SOLR-17102) VersionBucket not needed

[ https://issues.apache.org/jira/browse/SOLR-17102?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated SOLR-17102: -- Labels: pull-request-available (was: ) > VersionBucket not needed > >

[jira] [Commented] (SOLR-17368) TestPrometheusResponseWriter redesign

[ https://issues.apache.org/jira/browse/SOLR-17368?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17870295#comment-17870295 ] Chris M. Hostetter commented on SOLR-17368: --- There is no way for typical users

Re: [PR] Change prometheus dummy metric to a more unique label [solr]

mlbiscoc commented on PR #2613: URL: https://github.com/apache/solr/pull/2613#issuecomment-2264053909 @dsmiley This should make the dummy metric unique enough to not clash with real leaking jetty metrics from other tests. I ran tests locally multiple times. Any ideas what we can do to make

[PR] Change prometheus dummy metric to a more unique label [solr]

mlbiscoc opened a new pull request, #2613: URL: https://github.com/apache/solr/pull/2613 https://issues.apache.org/jira/browse/SOLR-17368 # Description `TestPrometheusResponseWriter` was failing ~25% of tests due to dummy metric `dummyMetrics.2xx-responses` not uniq

[PR] Benchmark: HTTP2 fix cancel_stream_error [solr]

dsmiley opened a new pull request, #2612: URL: https://github.com/apache/solr/pull/2612 Fixes Jetty HTTP2 cancel_stream_error by removing the flow control limit. I was encountering this issue with CloudIndexing, esp when using single-node, single-replica, single-shard -- like 30K ops

[jira] [Commented] (SOLR-17368) TestPrometheusResponseWriter redesign

[ https://issues.apache.org/jira/browse/SOLR-17368?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17870287#comment-17870287 ] Matthew Biscocho commented on SOLR-17368: - Ah apologies again for breaking tests.

Re: [PR] Reduce thread contention in ZkStateReader.getCollectionProperties() [solr]

aparnasuresh85 commented on code in PR #2611: URL: https://github.com/apache/solr/pull/2611#discussion_r1700718785 ## solr/solrj-zookeeper/src/java/org/apache/solr/common/cloud/CollectionPropertiesZkStateReader.java: ## @@ -104,46 +103,52 @@ public CollectionPropertiesZkStateRea

Re: [PR] Reduce thread contention in ZkStateReader.getCollectionProperties() [solr]

aparnasuresh85 commented on code in PR #2611: URL: https://github.com/apache/solr/pull/2611#discussion_r1700718785 ## solr/solrj-zookeeper/src/java/org/apache/solr/common/cloud/CollectionPropertiesZkStateReader.java: ## @@ -104,46 +103,52 @@ public CollectionPropertiesZkStateRea

Re: [PR] Reduce thread contention in ZkStateReader.getCollectionProperties() [solr]

aparnasuresh85 commented on PR #2611: URL: https://github.com/apache/solr/pull/2611#issuecomment-2263809638 cc @dsmiley @pmcarthur-apache @pjmcarthur -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[PR] Reduce thread contention in ZkStateReader.getCollectionProperties [solr]

aparnasuresh85 opened a new pull request, #2611: URL: https://github.com/apache/solr/pull/2611 # Description Building on which delegated Collection Properties Management to `CollectionPropertiesZkStateReader`, this PR seek

Re: [PR] SOLR-17386: Fixed SyntheticSolrCore reload issue [solr]

patsonluk commented on PR #2607: URL: https://github.com/apache/solr/pull/2607#issuecomment-2263450355 > Planning ahead to PR merge time -- `solr/CHANGES.txt` -- @patsonluk please could you add an entry in the Solr 9.7 bug fix section, e.g. something like this? > > ``` > SOLR-1738

Re: [PR] SOLR-17386: Fixed SyntheticSolrCore reload issue [solr]

patsonluk commented on code in PR #2607: URL: https://github.com/apache/solr/pull/2607#discussion_r1700444070 ## solr/core/src/java/org/apache/solr/core/CoreContainer.java: ## @@ -2056,7 +2056,7 @@ public void reload(String name, UUID coreId) { newCore = core.reload(cor

Re: [PR] SOLR-13350, SOLR-17298: use multiThreaded=false default; document multiThreaded parameter; [solr]

gus-asf commented on code in PR #2596: URL: https://github.com/apache/solr/pull/2596#discussion_r1700159210 ## solr/solr-ref-guide/modules/query-guide/pages/common-query-parameters.adoc: ## @@ -400,6 +400,16 @@ If early termination is used, a `segmentTerminatedEarly` header wil

Re: [PR] SOLR-13350, SOLR-17298: use multiThreaded=false default; document multiThreaded parameter; [solr]

gus-asf commented on code in PR #2596: URL: https://github.com/apache/solr/pull/2596#discussion_r1700142369 ## solr/core/src/java/org/apache/solr/handler/component/QueryComponent.java: ## @@ -371,7 +371,7 @@ public void process(ResponseBuilder rb) throws IOException { ret

[jira] [Commented] (SOLR-13350) Explore collector managers for multi-threaded search

[ https://issues.apache.org/jira/browse/SOLR-13350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17870194#comment-17870194 ] Gus Heck commented on SOLR-13350: - I seem to recall seeing discussion of making this feat

Re: [PR] SOLR-17298 backport from main. ThreadCpuTimer for multi-threaded search [solr]

gus-asf merged PR #2604: URL: https://github.com/apache/solr/pull/2604 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.or

[jira] [Commented] (SOLR-17298) Multithreaded search breaks limits, and possibly other things

[ https://issues.apache.org/jira/browse/SOLR-17298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17870192#comment-17870192 ] ASF subversion and git services commented on SOLR-17298: Commit 1

Re: [PR] SOLR-17386: Fixed SyntheticSolrCore reload issue [solr]

cpoerschke commented on PR #2607: URL: https://github.com/apache/solr/pull/2607#issuecomment-2262799967 > ... entry in the Solr 9.7 bug fix section ... Solr 9.7 release dev list thread: https://lists.apache.org/thread/trhhb1q84gjzz9z9jx931m2p7v3q6wdn -- This is an automated message

Re: [PR] SOLR-17386: Fixed SyntheticSolrCore reload issue [solr]

ellaeln commented on PR #2607: URL: https://github.com/apache/solr/pull/2607#issuecomment-2262794835 ellaeln is good -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

[jira] [Updated] (SOLR-17386) it's now impossible to update solrconfig for coordinators after core creation

[ https://issues.apache.org/jira/browse/SOLR-17386?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Christine Poerschke updated SOLR-17386: --- Affects Version/s: (was: 9.7) > it's now impossible to update solrconfig for coor

[jira] [Updated] (SOLR-17386) it's now impossible to update solrconfig for coordinators after core creation

[ https://issues.apache.org/jira/browse/SOLR-17386?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Christine Poerschke updated SOLR-17386: --- Fix Version/s: 9.7 > it's now impossible to update solrconfig for coordinators after

[jira] [Assigned] (SOLR-17386) it's now impossible to update solrconfig for coordinators after core creation

[ https://issues.apache.org/jira/browse/SOLR-17386?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Christine Poerschke reassigned SOLR-17386: -- Assignee: Christine Poerschke > it's now impossible to update solrconfig for c

Re: [PR] SOLR-17386: Fixed SyntheticSolrCore reload issue [solr]

cpoerschke commented on PR #2607: URL: https://github.com/apache/solr/pull/2607#issuecomment-2262786338 Planning ahead to PR merge time -- `solr/CHANGES.txt` -- @patsonluk please could you add an entry in the Solr 9.7 bug fix section, e.g. something like this? ``` SOLR-17386: Fix

Re: [PR] SOLR-17386: Fixed SyntheticSolrCore reload issue [solr]

cpoerschke commented on code in PR #2607: URL: https://github.com/apache/solr/pull/2607#discussion_r1699960636 ## solr/core/src/java/org/apache/solr/core/CoreContainer.java: ## @@ -2056,7 +2056,7 @@ public void reload(String name, UUID coreId) { newCore = core.reload(co