Re: [PR] Default to MockDirectoryFactory in test configs [solr]

2024-08-02 Thread via GitHub
dsmiley commented on PR #2598: URL: https://github.com/apache/solr/pull/2598#issuecomment-2266425923 Nevermind; all is well. I looked closer at MockDirectoryFactory, which calls LuceneTestCase.newDirectory which usually uses a memory based directory (ByteBuffersDirectory) and sometim

[jira] [Resolved] (SOLR-17276) Use fixed rate instead of fixed delay in prometheus-exporter

2024-08-02 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17276?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Smiley resolved SOLR-17276. - Fix Version/s: 9.7 Resolution: Fixed Thanks for contributing Rafal! > Use fixed rate inst

[jira] [Commented] (SOLR-17276) Use fixed rate instead of fixed delay in prometheus-exporter

2024-08-02 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17276?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17870660#comment-17870660 ] ASF subversion and git services commented on SOLR-17276: Commit 5

[jira] [Updated] (SOLR-17276) Use fixed rate instead of fixed delay in prometheus-exporter

2024-08-02 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17276?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated SOLR-17276: -- Labels: pull-request-available (was: ) > Use fixed rate instead of fixed delay in prometheus-e

[jira] [Commented] (SOLR-17276) Use fixed rate instead of fixed delay in prometheus-exporter

2024-08-02 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17276?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17870659#comment-17870659 ] ASF subversion and git services commented on SOLR-17276: Commit 7

Re: [PR] SOLR-17276 Scrape metrics at fixed rate in prometheus-exporter [solr]

2024-08-02 Thread via GitHub
dsmiley merged PR #2442: URL: https://github.com/apache/solr/pull/2442 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.or

Re: [PR] SOLR-17359: Move Zk Arg parsing into Java Code [solr]

2024-08-02 Thread via GitHub
rahulgoswami commented on PR #2593: URL: https://github.com/apache/solr/pull/2593#issuecomment-2266361235 Pulled in the latest changes on the branch SOLR-17359 and rebuilt. 1) zk downconfig has been fixed. upconfig worked for me the first time as well. 2) solr zk -help now says

[jira] [Commented] (SOLR-17368) TestPrometheusResponseWriter redesign

2024-08-02 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17368?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17870658#comment-17870658 ] David Smiley commented on SOLR-17368: - Bingo -- see DropWizard's {{SharedMetricRegist

Re: [PR] SOLR-17359: Move Zk Arg parsing into Java Code [solr]

2024-08-02 Thread via GitHub
epugh commented on PR #2593: URL: https://github.com/apache/solr/pull/2593#issuecomment-2266315693 @rahulgoswami would you mind giving another pass through! I fixed a BUNCH of bugs that you found, thank you for the testing. Plus, I updated this branch with other changes that have happene

Re: [PR] SOLR-17359: Move Zk Arg parsing into Java Code [solr]

2024-08-02 Thread via GitHub
epugh commented on PR #2593: URL: https://github.com/apache/solr/pull/2593#issuecomment-2266313899 Okay, just fixed the downconfig and upconfig commands! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[jira] [Comment Edited] (SOLR-16824) Adopt Linux Command line tool pattern of -- for multi character commands.

2024-08-02 Thread Christos Malliaridis (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17868970#comment-17868970 ] Christos Malliaridis edited comment on SOLR-16824 at 8/3/24 12:19 AM: -

[jira] [Commented] (SOLR-17338) Change missing zkHost/solrUrl to system.err

2024-08-02 Thread Eric Pugh (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17870639#comment-17870639 ] Eric Pugh commented on SOLR-17338: -- The message we write out is: Neither --zk-host or -

[jira] [Commented] (SOLR-17298) Multithreaded search breaks limits, and possibly other things

2024-08-02 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17870633#comment-17870633 ] David Smiley commented on SOLR-17298: - bq. What was your reason for disallowing RankQ

[jira] [Resolved] (SOLR-16824) Adopt Linux Command line tool pattern of -- for multi character commands.

2024-08-02 Thread Eric Pugh (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16824?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eric Pugh resolved SOLR-16824. -- Fix Version/s: 9.7 Resolution: Fixed > Adopt Linux Command line tool pattern of -- for multi cha

[jira] [Commented] (SOLR-16824) Adopt Linux Command line tool pattern of -- for multi character commands.

2024-08-02 Thread Eric Pugh (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17870631#comment-17870631 ] Eric Pugh commented on SOLR-16824: -- There may be some other places that need work...  Le

[jira] [Commented] (SOLR-16824) Adopt Linux Command line tool pattern of -- for multi character commands.

2024-08-02 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17870630#comment-17870630 ] ASF subversion and git services commented on SOLR-16824: Commit a

Re: [PR] SOLR-16824: Backport changes to finish migration to dash patterns (kebab-case) [solr]

2024-08-02 Thread via GitHub
epugh merged PR #2614: URL: https://github.com/apache/solr/pull/2614 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

Re: [PR] Reduce thread contention in ZkStateReader.getCollectionProperties() [solr]

2024-08-02 Thread via GitHub
dsmiley commented on code in PR #2611: URL: https://github.com/apache/solr/pull/2611#discussion_r1702323807 ## solr/solrj-zookeeper/src/java/org/apache/solr/common/cloud/CollectionPropertiesZkStateReader.java: ## @@ -77,12 +75,13 @@ public class CollectionPropertiesZkStateReader

Re: [PR] SOLR-17381: Make CLUSTERSTATUS configurable [solr]

2024-08-02 Thread via GitHub
dsmiley commented on code in PR #2599: URL: https://github.com/apache/solr/pull/2599#discussion_r1702298437 ## solr/solrj/src/java/org/apache/solr/client/solrj/impl/BaseHttpClusterStateProvider.java: ## @@ -413,4 +412,11 @@ public String getQuorumHosts() { } return Str

[PR] SOLR-16824: Backport changes to finish migration to dash patterns (kebab-case) [solr]

2024-08-02 Thread via GitHub
epugh opened a new pull request, #2614: URL: https://github.com/apache/solr/pull/2614 Migrate dash patterns in documentation, various tests, and various user messages generated by tools to reflect the move to --kebab-case and double dashes. - https://issues.apache.org/

[jira] [Commented] (SOLR-16824) Adopt Linux Command line tool pattern of -- for multi character commands.

2024-08-02 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17870625#comment-17870625 ] ASF subversion and git services commented on SOLR-16824: Commit 0

Re: [PR] SOLR-16824: Replace deprecated single-dash arguments [solr]

2024-08-02 Thread via GitHub
epugh merged PR #2577: URL: https://github.com/apache/solr/pull/2577 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

Re: [PR] SOLR-17381: Make CLUSTERSTATUS configurable [solr]

2024-08-02 Thread via GitHub
aparnasuresh85 commented on code in PR #2599: URL: https://github.com/apache/solr/pull/2599#discussion_r1702289833 ## solr/solrj-zookeeper/src/java/org/apache/solr/common/cloud/ZkStateReader.java: ## @@ -88,6 +88,9 @@ public class ZkStateReader implements SolrCloseable { publ

Re: [PR] SOLR-17381: Make CLUSTERSTATUS configurable [solr]

2024-08-02 Thread via GitHub
aparnasuresh85 commented on code in PR #2599: URL: https://github.com/apache/solr/pull/2599#discussion_r1702289620 ## solr/solrj/src/java/org/apache/solr/client/solrj/impl/ClusterStateProvider.java: ## @@ -107,9 +111,15 @@ default DocCollection getCollection(String name) throws

[jira] [Commented] (SOLR-10808) Enable DocValues by default for primitive and sorting fields, unless explicitly disabled

2024-08-02 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-10808?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17870619#comment-17870619 ] ASF subversion and git services commented on SOLR-10808: Commit c

Re: [PR] SOLR-17381: Make CLUSTERSTATUS configurable [solr]

2024-08-02 Thread via GitHub
aparnasuresh85 commented on code in PR #2599: URL: https://github.com/apache/solr/pull/2599#discussion_r1702289433 ## solr/solrj/src/java/org/apache/solr/client/solrj/impl/BaseHttpClusterStateProvider.java: ## @@ -228,12 +249,9 @@ > getCacheTimeout()) { } @SuppressWarnin

Re: [PR] SOLR-13350, SOLR-17298: use multiThreaded=false default; document multiThreaded parameter; [solr]

2024-08-02 Thread via GitHub
dsmiley commented on code in PR #2596: URL: https://github.com/apache/solr/pull/2596#discussion_r1702272374 ## solr/solr-ref-guide/modules/query-guide/pages/common-query-parameters.adoc: ## @@ -400,6 +400,16 @@ If early termination is used, a `segmentTerminatedEarly` header wil

Re: [PR] SOLR-13350, SOLR-17298: use multiThreaded=false default; document multiThreaded parameter; [solr]

2024-08-02 Thread via GitHub
dsmiley commented on code in PR #2596: URL: https://github.com/apache/solr/pull/2596#discussion_r1702269724 ## solr/CHANGES.txt: ## @@ -103,7 +103,7 @@ Other Changes == 9.7.0 == New Features - -* SOLR-13350: Multithreaded s

Re: [PR] SOLR-17359: Move Zk Arg parsing into Java Code [solr]

2024-08-02 Thread via GitHub
epugh commented on PR #2593: URL: https://github.com/apache/solr/pull/2593#issuecomment-2266047490 I'm going to try out some of the examples on my Mac, just to see which are OS specific and which are just part of the code movement not being right. I'll also take a stab at adding more bats

Re: [PR] Reduce thread contention in ZkStateReader.getCollectionProperties() [solr]

2024-08-02 Thread via GitHub
aparnasuresh85 commented on code in PR #2611: URL: https://github.com/apache/solr/pull/2611#discussion_r1702180575 ## solr/solrj-zookeeper/src/java/org/apache/solr/common/cloud/CollectionPropertiesZkStateReader.java: ## @@ -217,7 +222,8 @@ public void process(WatchedEvent event)

Re: [PR] Reduce thread contention in ZkStateReader.getCollectionProperties() [solr]

2024-08-02 Thread via GitHub
aparnasuresh85 commented on code in PR #2611: URL: https://github.com/apache/solr/pull/2611#discussion_r1702174830 ## solr/solrj-zookeeper/src/java/org/apache/solr/common/cloud/CollectionPropertiesZkStateReader.java: ## @@ -77,12 +75,13 @@ public class CollectionPropertiesZkStat

[jira] [Resolved] (SOLR-17336) Merge windows and linux examples in ref guide for post tool

2024-08-02 Thread Eric Pugh (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17336?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eric Pugh resolved SOLR-17336. -- Fix Version/s: 9.7 Resolution: Fixed this actually was completed a while ago. > Merge windows a

[jira] [Commented] (SOLR-17384) Update ExportTool's argument representation

2024-08-02 Thread Eric Pugh (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17870596#comment-17870596 ] Eric Pugh commented on SOLR-17384: -- yeah, these should be probably moved to – and the si

[jira] [Resolved] (SOLR-16996) Move Solr Exporter for Prometheus CLI to commons-cli

2024-08-02 Thread Eric Pugh (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16996?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eric Pugh resolved SOLR-16996. -- Fix Version/s: 9.7 Resolution: Fixed > Move Solr Exporter for Prometheus CLI to commons-cli > --

[jira] [Commented] (SOLR-10808) Enable DocValues by default for primitive and sorting fields, unless explicitly disabled

2024-08-02 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-10808?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17870588#comment-17870588 ] ASF subversion and git services commented on SOLR-10808: Commit b

Re: [PR] SOLR-10808: Enable docValues by default on specific fields [solr]

2024-08-02 Thread via GitHub
HoustonPutman merged PR #2606: URL: https://github.com/apache/solr/pull/2606 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apa

Re: [PR] [SOLR-17368] Change prometheus dummy metric to a more unique label [solr]

2024-08-02 Thread via GitHub
mlbiscoc commented on PR #2613: URL: https://github.com/apache/solr/pull/2613#issuecomment-2265399024 Yes, on `main` branch it fails the same way when running Jetty based tests next to it. From Chris's suggestion, `./gradlew -p solr/core test -Ptests.jvms=1 -Ptests.verbose=true --tests Test

Re: [PR] SOLR-17386: Fixed SyntheticSolrCore reload issue [solr]

2024-08-02 Thread via GitHub
dsmiley commented on code in PR #2607: URL: https://github.com/apache/solr/pull/2607#discussion_r1701823507 ## solr/core/src/java/org/apache/solr/core/CoreContainer.java: ## @@ -2056,7 +2056,7 @@ public void reload(String name, UUID coreId) { newCore = core.reload(coreC

Re: [PR] SOLR-16996: Update Solr Exporter for Prometheus cli to use commons-cli [solr]

2024-08-02 Thread via GitHub
epugh merged PR #2602: URL: https://github.com/apache/solr/pull/2602 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

Re: [PR] SOLR-17334: Enable coordinator nodes to handle requests other than `/select` [solr]

2024-08-02 Thread via GitHub
ellaeln commented on PR #2527: URL: https://github.com/apache/solr/pull/2527#issuecomment-2265125294 I opened a draft merge request with the changes of the current main to your branch. https://github.com/otto-de/solr/pull/2 However, it may not be completely finished until https://github

Re: [PR] SOLR-17386: Fixed SyntheticSolrCore reload issue [solr]

2024-08-02 Thread via GitHub
ellaeln commented on PR #2607: URL: https://github.com/apache/solr/pull/2607#issuecomment-2265114996 I tested things again and everything looks OK. Is there anything else that needs to get done before we can move this forward? -- This is an automated message from the Apache Git Service. T