Re: [PR] SOLR-17359: Move Zk Arg parsing into Java Code [solr]

2024-08-05 Thread via GitHub
rahulgoswami commented on PR #2593: URL: https://github.com/apache/solr/pull/2593#issuecomment-2270460370 Submitted a PR for #4 against your branch. Will work on #6 and #7 tonight. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Git

Re: [PR] SOLR-10654: Override PrometheusResponseWriter Content Type [solr]

2024-08-05 Thread via GitHub
mlbiscoc commented on PR #2616: URL: https://github.com/apache/solr/pull/2616#issuecomment-2270328349 > Did you at least test manually? (this is totally adequate) Yes, here is the before: ``` curl -I "localhost:8983/solr/admin/metrics?wt=prometheus" HTTP/1.1 200 OK Content-

[jira] [Commented] (SOLR-17392) Reproducing failure in TestExportWriter (bits = null NPE)

2024-08-05 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17871214#comment-17871214 ] David Smiley commented on SOLR-17392: - Can we assume the new segment/SolrIndexSearche

Re: [PR] SOLR-10654: Override PrometheusResponseWriter Content Type [solr]

2024-08-05 Thread via GitHub
dsmiley commented on PR #2616: URL: https://github.com/apache/solr/pull/2616#issuecomment-2270323650 Did you at least test manually? (this is totally adequate) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

Re: [PR] SOLR-17102: Replaced VersionBucket array with locks on-demand [solr]

2024-08-05 Thread via GitHub
dsmiley commented on PR #2548: URL: https://github.com/apache/solr/pull/2548#issuecomment-2270314171 * updated the upgrade notes to point out the legacy config settings. * removed settings from any config * CHANGES.txt: > * SOLR-17102: The VersionBucket indexing lock mechanism wa

[jira] [Commented] (SOLR-14985) Slow indexing and search performance when using HttpClusterStateProvider

2024-08-05 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14985?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17871209#comment-17871209 ] ASF subversion and git services commented on SOLR-14985: Commit 9

Re: [PR] SOLR-17381: Make CLUSTERSTATUS configurable [solr]

2024-08-05 Thread via GitHub
dsmiley commented on code in PR #2599: URL: https://github.com/apache/solr/pull/2599#discussion_r1704691188 ## solr/core/src/java/org/apache/solr/handler/admin/ClusterStatus.java: ## @@ -89,14 +93,61 @@ public static Health combine(Collection states) { } } - public Cl

Re: [PR] Reduce thread contention in ZkStateReader.getCollectionProperties() [solr]

2024-08-05 Thread via GitHub
dsmiley commented on code in PR #2611: URL: https://github.com/apache/solr/pull/2611#discussion_r1704685321 ## solr/solrj-zookeeper/src/java/org/apache/solr/common/cloud/CollectionPropertiesZkStateReader.java: ## @@ -300,10 +313,11 @@ private VersionedCollectionProps fetchColle

Re: [PR] SOLR-17381: Make CLUSTERSTATUS configurable [solr]

2024-08-05 Thread via GitHub
aparnasuresh85 commented on code in PR #2599: URL: https://github.com/apache/solr/pull/2599#discussion_r1704679908 ## solr/core/src/java/org/apache/solr/handler/admin/ClusterStatus.java: ## @@ -147,6 +191,7 @@ public void getClusterStatus(NamedList results) NamedList coll

Re: [PR] SOLR-17381: Make CLUSTERSTATUS configurable [solr]

2024-08-05 Thread via GitHub
aparnasuresh85 commented on code in PR #2599: URL: https://github.com/apache/solr/pull/2599#discussion_r1704679669 ## solr/core/src/java/org/apache/solr/handler/admin/ClusterStatus.java: ## @@ -191,43 +236,23 @@ public void getClusterStatus(NamedList results) } Str

Re: [PR] SOLR-17381: Make CLUSTERSTATUS configurable [solr]

2024-08-05 Thread via GitHub
aparnasuresh85 commented on code in PR #2599: URL: https://github.com/apache/solr/pull/2599#discussion_r1704679560 ## solr/core/src/java/org/apache/solr/handler/admin/ClusterStatus.java: ## @@ -89,14 +93,61 @@ public static Health combine(Collection states) { } } - pu

Re: [PR] SOLR-17381: Make CLUSTERSTATUS configurable [solr]

2024-08-05 Thread via GitHub
aparnasuresh85 commented on code in PR #2599: URL: https://github.com/apache/solr/pull/2599#discussion_r1704679393 ## solr/solrj/src/java/org/apache/solr/client/solrj/impl/ClusterStateProvider.java: ## @@ -108,8 +112,7 @@ default DocCollection getCollection(String name) throws

Re: [PR] SOLR-17381: Make CLUSTERSTATUS configurable [solr]

2024-08-05 Thread via GitHub
aparnasuresh85 commented on code in PR #2599: URL: https://github.com/apache/solr/pull/2599#discussion_r1704678588 ## solr/solrj/src/java/org/apache/solr/client/solrj/impl/BaseHttpClusterStateProvider.java: ## @@ -413,4 +412,11 @@ public String getQuorumHosts() { } ret

Re: [PR] SOLR-17381: Make CLUSTERSTATUS configurable [solr]

2024-08-05 Thread via GitHub
aparnasuresh85 commented on PR #2599: URL: https://github.com/apache/solr/pull/2599#issuecomment-2270007674 > Can you please update the ref guide, `cluster-node-management.adoc`, as well? Done, let me know if it needs more changes -- This is an automated message from the Apache Git

Re: [PR] SOLR-17381: Make CLUSTERSTATUS configurable [solr]

2024-08-05 Thread via GitHub
aparnasuresh85 commented on code in PR #2599: URL: https://github.com/apache/solr/pull/2599#discussion_r1704678248 ## solr/core/src/java/org/apache/solr/handler/admin/ClusterStatus.java: ## @@ -96,39 +96,43 @@ public static Health combine(Collection states) { public ClusterSt

Re: [PR] SOLR-17381: Make CLUSTERSTATUS configurable [solr]

2024-08-05 Thread via GitHub
aparnasuresh85 commented on code in PR #2599: URL: https://github.com/apache/solr/pull/2599#discussion_r1704677556 ## solr/solrj-zookeeper/src/java/org/apache/solr/common/cloud/ZkStateReader.java: ## @@ -88,6 +88,9 @@ public class ZkStateReader implements SolrCloseable { publ

[jira] [Updated] (SOLR-17383) CLI: Resolve overlapping arguments

2024-08-05 Thread Christos Malliaridis (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17383?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Christos Malliaridis updated SOLR-17383: Description: With the changes from SOLR-16757 arguments were moved to java source c

Re: [PR] SOLR-17381: Make CLUSTERSTATUS configurable [solr]

2024-08-05 Thread via GitHub
dsmiley commented on code in PR #2599: URL: https://github.com/apache/solr/pull/2599#discussion_r1704656293 ## solr/core/src/java/org/apache/solr/handler/admin/ClusterStatus.java: ## @@ -89,14 +93,61 @@ public static Health combine(Collection states) { } } - public Cl

Re: [PR] SOLR-17381: Make CLUSTERSTATUS configurable [solr]

2024-08-05 Thread via GitHub
aparnasuresh85 commented on code in PR #2599: URL: https://github.com/apache/solr/pull/2599#discussion_r1704648811 ## solr/core/src/java/org/apache/solr/handler/admin/ClusterStatus.java: ## @@ -89,14 +93,61 @@ public static Health combine(Collection states) { } } - pu

Re: [PR] Reduce thread contention in ZkStateReader.getCollectionProperties() [solr]

2024-08-05 Thread via GitHub
dsmiley commented on code in PR #2611: URL: https://github.com/apache/solr/pull/2611#discussion_r1704608234 ## solr/solrj-zookeeper/src/java/org/apache/solr/common/cloud/CollectionPropertiesZkStateReader.java: ## @@ -154,8 +150,14 @@ public Map getCollectionProperties(final Str

[jira] [Resolved] (SOLR-10808) Enable DocValues by default for primitive and sorting fields, unless explicitly disabled

2024-08-05 Thread Houston Putman (Jira)
[ https://issues.apache.org/jira/browse/SOLR-10808?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Houston Putman resolved SOLR-10808. --- Resolution: Done > Enable DocValues by default for primitive and sorting fields, unless > ex

Re: [PR] SOLR-17381: Make CLUSTERSTATUS configurable [solr]

2024-08-05 Thread via GitHub
dsmiley commented on code in PR #2599: URL: https://github.com/apache/solr/pull/2599#discussion_r1704589925 ## solr/core/src/java/org/apache/solr/handler/admin/ClusterStatus.java: ## @@ -89,14 +93,61 @@ public static Health combine(Collection states) { } } - public Cl

Re: [I] Solrcloud pods not starting with custom security.json [solr-operator]

2024-08-05 Thread via GitHub
liseli commented on issue #594: URL: https://github.com/apache/solr-operator/issues/594#issuecomment-2269796448 Hi team, I've set up Solr authentication defining my **security.json**. I have created two secrets (**fulltext-solrcloud-basic-auth => type kubernetes.io/basic-auth and so

Re: [PR] SOLR-17381: Make CLUSTERSTATUS configurable [solr]

2024-08-05 Thread via GitHub
aparnasuresh85 commented on code in PR #2599: URL: https://github.com/apache/solr/pull/2599#discussion_r1704512149 ## solr/core/src/java/org/apache/solr/handler/admin/ClusterStatus.java: ## @@ -96,39 +96,43 @@ public static Health combine(Collection states) { public ClusterSt

Re: [PR] SOLR-17381: Make CLUSTERSTATUS configurable [solr]

2024-08-05 Thread via GitHub
aparnasuresh85 commented on code in PR #2599: URL: https://github.com/apache/solr/pull/2599#discussion_r1704511439 ## solr/solrj/src/java/org/apache/solr/client/solrj/impl/BaseHttpClusterStateProvider.java: ## @@ -413,4 +412,11 @@ public String getQuorumHosts() { } ret

Re: [PR] SOLR-17381: Make CLUSTERSTATUS configurable [solr]

2024-08-05 Thread via GitHub
aparnasuresh85 commented on code in PR #2599: URL: https://github.com/apache/solr/pull/2599#discussion_r1704511273 ## solr/core/src/java/org/apache/solr/handler/admin/CollectionsHandler.java: ## @@ -976,7 +980,17 @@ public Map execute( CLUSTERSTATUS, (req, rsp,

Re: [PR] Reduce thread contention in ZkStateReader.getCollectionProperties() [solr]

2024-08-05 Thread via GitHub
aparnasuresh85 commented on code in PR #2611: URL: https://github.com/apache/solr/pull/2611#discussion_r1704493967 ## solr/solrj-zookeeper/src/java/org/apache/solr/common/cloud/CollectionPropertiesZkStateReader.java: ## @@ -77,12 +75,13 @@ public class CollectionPropertiesZkStat

Re: [PR] SOLR-13350, SOLR-17298: use multiThreaded=false default; document multiThreaded parameter; [solr]

2024-08-05 Thread via GitHub
dsmiley commented on code in PR #2596: URL: https://github.com/apache/solr/pull/2596#discussion_r1704478214 ## solr/solr-ref-guide/modules/query-guide/pages/common-query-parameters.adoc: ## @@ -408,7 +408,7 @@ Similar to using <>, when ear |=== This parameter set to `true` o

[jira] [Updated] (SOLR-10654) Expose Metrics in Prometheus format DIRECTLY from Solr

2024-08-05 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/SOLR-10654?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated SOLR-10654: -- Labels: pull-request-available (was: ) > Expose Metrics in Prometheus format DIRECTLY from Sol

[PR] [SOLR-10654] Override PrometheusResponseWriter Content Type [solr]

2024-08-05 Thread via GitHub
mlbiscoc opened a new pull request, #2616: URL: https://github.com/apache/solr/pull/2616 https://issues.apache.org/jira/browse/SOLR-10654 # Description The Prometheus Response Writer response content type was JSON which is incorrect. # Solution Based o

Re: [PR] SOLR-17320: Added support for timeAllowed time out in HttpShardHandler [solr]

2024-08-05 Thread via GitHub
psalagnac commented on code in PR #2493: URL: https://github.com/apache/solr/pull/2493#discussion_r1704360932 ## solr/core/src/java/org/apache/solr/handler/component/HttpShardHandler.java: ## @@ -211,23 +216,33 @@ public ShardResponse takeCompletedIncludingErrors() { */ @

[jira] [Updated] (SOLR-17392) Reproducing failure in TestExportWriter (bits = null NPE)

2024-08-05 Thread Gus Heck (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17392?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gus Heck updated SOLR-17392: Description: While running the test suite locally I came across the NPE below. I notice that there are a c

[jira] [Created] (SOLR-17392) Reproducing failure in TestExportWriter (bits = null NPE)

2024-08-05 Thread Gus Heck (Jira)
Gus Heck created SOLR-17392: --- Summary: Reproducing failure in TestExportWriter (bits = null NPE) Key: SOLR-17392 URL: https://issues.apache.org/jira/browse/SOLR-17392 Project: Solr Issue Type: Bug

Re: [PR] SOLR-17102: Replaced VersionBucket array with locks on-demand [solr]

2024-08-05 Thread via GitHub
dsmiley commented on code in PR #2548: URL: https://github.com/apache/solr/pull/2548#discussion_r1704232054 ## solr/core/src/java/org/apache/solr/update/UpdateLocks.java: ## @@ -0,0 +1,192 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contribu

Re: [PR] Create 2024-07-27-apache-solr-neural-search-tutorial.md (#117) [solr-site]

2024-08-05 Thread via GitHub
alessandrobenedetti merged PR #118: URL: https://github.com/apache/solr-site/pull/118 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...

[PR] Create 2024-07-27-apache-solr-neural-search-tutorial.md (#117) [solr-site]

2024-08-05 Thread via GitHub
alessandrobenedetti opened a new pull request, #118: URL: https://github.com/apache/solr-site/pull/118 Apache Solr neural search tutorial post -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] Blog post Apache Solr Neural Search Tutorial [solr-site]

2024-08-05 Thread via GitHub
alessandrobenedetti merged PR #117: URL: https://github.com/apache/solr-site/pull/117 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...

[jira] [Updated] (SOLR-17391) Optimize Backup/Restore Operations for Large Collections

2024-08-05 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-17391?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hakan Özler updated SOLR-17391: --- Description: The backup/restore performance issue was first reported on [the users mailing|https://l

[jira] [Updated] (SOLR-17391) Optimize Backup/Restore Operations for Large Collections

2024-08-05 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-17391?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hakan Özler updated SOLR-17391: --- Description: The backup/restore performance issue was first reported on [the users mailing|https://l

Re: [PR] SOLR-17102: Replaced VersionBucket array with locks on-demand [solr]

2024-08-05 Thread via GitHub
bruno-roustant commented on code in PR #2548: URL: https://github.com/apache/solr/pull/2548#discussion_r1704168182 ## solr/core/src/java/org/apache/solr/update/UpdateLocks.java: ## @@ -0,0 +1,192 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * c

Re: [PR] SOLR-13350, SOLR-17298: use multiThreaded=false default; document multiThreaded parameter; [solr]

2024-08-05 Thread via GitHub
gus-asf commented on code in PR #2596: URL: https://github.com/apache/solr/pull/2596#discussion_r1704117843 ## solr/CHANGES.txt: ## @@ -103,7 +103,7 @@ Other Changes == 9.7.0 == New Features - -* SOLR-13350: Multithreaded s

[jira] [Updated] (SOLR-17391) Optimize Backup/Restore Operations for Large Collections

2024-08-05 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-17391?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hakan Özler updated SOLR-17391: --- Description: The backup/restore performance issue was first reported on [the users mail|https://list

[jira] [Created] (SOLR-17391) Optimize Backup/Restore Operations for Large Collections

2024-08-05 Thread Jira
Hakan Özler created SOLR-17391: -- Summary: Optimize Backup/Restore Operations for Large Collections Key: SOLR-17391 URL: https://issues.apache.org/jira/browse/SOLR-17391 Project: Solr Issue Type:

Re: [PR] SOLR-17386: Fixed SyntheticSolrCore reload issue [solr]

2024-08-05 Thread via GitHub
cpoerschke commented on code in PR #2607: URL: https://github.com/apache/solr/pull/2607#discussion_r1703764178 ## solr/core/src/java/org/apache/solr/core/CoreContainer.java: ## @@ -2056,7 +2056,7 @@ public void reload(String name, UUID coreId) { newCore = core.reload(co

Re: [PR] SOLR-13350, SOLR-17298: use multiThreaded=false default; document multiThreaded parameter; [solr]

2024-08-05 Thread via GitHub
cpoerschke commented on PR #2596: URL: https://github.com/apache/solr/pull/2596#issuecomment-2268512240 Thanks everyone for your inputs here so far! Unfortunately I won't have bandwidth to iterate on this today or so. _"Allow edits and access to secrets by maintainers"_ is enabled on