Re: [PR] SOLR-17359: Move Zk Arg parsing into Java Code [solr]

2024-08-07 Thread via GitHub
rahulgoswami commented on PR #2593: URL: https://github.com/apache/solr/pull/2593#issuecomment-2275072649 Submitted PR [#8](https://github.com/epugh/solr/pull/8) for issues 6 and 7. 6.iii is the only known open issue for now (File copy from local drive to zk fails). Will tackle soon! -

[jira] [Commented] (SOLR-10654) Expose Metrics in Prometheus format DIRECTLY from Solr

2024-08-07 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-10654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17871844#comment-17871844 ] ASF subversion and git services commented on SOLR-10654: Commit 6

[jira] [Commented] (SOLR-10654) Expose Metrics in Prometheus format DIRECTLY from Solr

2024-08-07 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-10654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17871843#comment-17871843 ] ASF subversion and git services commented on SOLR-10654: Commit 0

[jira] [Commented] (SOLR-10654) Expose Metrics in Prometheus format DIRECTLY from Solr

2024-08-07 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-10654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17871841#comment-17871841 ] ASF subversion and git services commented on SOLR-10654: Commit c

Re: [PR] [SOLR-10654] Rename instances of SolrPrometheusExporter to SolrPrometheusFormatter [solr]

2024-08-07 Thread via GitHub
dsmiley merged PR #2620: URL: https://github.com/apache/solr/pull/2620 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.or

Re: [PR] Reduce thread contention in ZkStateReader.getCollectionProperties() [solr]

2024-08-07 Thread via GitHub
dsmiley commented on code in PR #2611: URL: https://github.com/apache/solr/pull/2611#discussion_r1708537956 ## solr/solrj-zookeeper/src/java/org/apache/solr/common/cloud/CollectionPropertiesZkStateReader.java: ## @@ -300,10 +313,11 @@ private VersionedCollectionProps fetchColle

Re: [PR] Reduce thread contention in ZkStateReader.getCollectionProperties() [solr]

2024-08-07 Thread via GitHub
dsmiley commented on code in PR #2611: URL: https://github.com/apache/solr/pull/2611#discussion_r1708536459 ## solr/solrj-zookeeper/src/java/org/apache/solr/common/cloud/CollectionPropertiesZkStateReader.java: ## @@ -391,13 +383,7 @@ public void run() { private class CacheCle

Re: [PR] [SOLR-10654] Rename instances of SolrPrometheusExporter to SolrPrometheusFormatter [solr]

2024-08-07 Thread via GitHub
dsmiley commented on PR #2620: URL: https://github.com/apache/solr/pull/2620#issuecomment-2274889982 Thanks for doing this. Indeed; IntelliJ excels at refactorings. I'll merge this into 9.7 tonight. -- This is an automated message from the Apache Git Service. To respond to the messag

[jira] [Commented] (SOLR-10654) Expose Metrics in Prometheus format DIRECTLY from Solr

2024-08-07 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-10654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17871836#comment-17871836 ] ASF subversion and git services commented on SOLR-10654: Commit c

[jira] [Commented] (SOLR-10654) Expose Metrics in Prometheus format DIRECTLY from Solr

2024-08-07 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-10654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17871834#comment-17871834 ] ASF subversion and git services commented on SOLR-10654: Commit a

Re: [PR] SOLR-17391: Cached thread pools actually have more than one thread. [solr]

2024-08-07 Thread via GitHub
dsmiley commented on PR #2619: URL: https://github.com/apache/solr/pull/2619#issuecomment-2274878399 Are we good with the CHANGES.txt and other changes? (Pierre or anyone else?) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[jira] [Commented] (SOLR-10654) Expose Metrics in Prometheus format DIRECTLY from Solr

2024-08-07 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-10654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17871833#comment-17871833 ] ASF subversion and git services commented on SOLR-10654: Commit e

Re: [PR] SOLR-10654: Override PrometheusResponseWriter Content Type [solr]

2024-08-07 Thread via GitHub
dsmiley merged PR #2616: URL: https://github.com/apache/solr/pull/2616 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.or

Re: [PR] SOLR-14414: Introduce new UI (SIP-7) [solr]

2024-08-07 Thread via GitHub
malliaridis commented on code in PR #2605: URL: https://github.com/apache/solr/pull/2605#discussion_r1708222059 ## solr/compose-ui/src/commonMain/kotlin/org/apache/solr/composeui/utils/HttpClientUtils.kt: ## @@ -0,0 +1,43 @@ +/* + * Licensed to the Apache Software Foundation (AS

Re: [PR] SOLR-14414: Introduce new UI (SIP-7) [solr]

2024-08-07 Thread via GitHub
malliaridis commented on PR #2605: URL: https://github.com/apache/solr/pull/2605#issuecomment-2274591704 > 2. The biggest downside in the code for me is how boilerplate heavy it is. There are Component interfaces, which have Component implementations, which then reference Models, which com

Re: [PR] SOLR-14414: Introduce new UI (SIP-7) [solr]

2024-08-07 Thread via GitHub
malliaridis commented on code in PR #2605: URL: https://github.com/apache/solr/pull/2605#discussion_r1708121034 ## solr/server/etc/jetty.xml: ## @@ -95,7 +95,7 @@ /solr/* Content-Security-Policy -default-src 'none'; base-uri 'non

Re: [PR] SOLR-14414: Introduce new UI (SIP-7) [solr]

2024-08-07 Thread via GitHub
malliaridis commented on code in PR #2605: URL: https://github.com/apache/solr/pull/2605#discussion_r1708117136 ## solr/compose-ui/src/commonMain/kotlin/org/apache/solr/composeui/utils/HttpClientUtils.kt: ## @@ -0,0 +1,43 @@ +/* + * Licensed to the Apache Software Foundation (AS

Re: [PR] SOLR-14414: Introduce new UI (SIP-7) [solr]

2024-08-07 Thread via GitHub
malliaridis commented on code in PR #2605: URL: https://github.com/apache/solr/pull/2605#discussion_r1708109571 ## solr/compose-ui/src/commonMain/kotlin/org/apache/solr/composeui/ui/theme/Colors.kt: ## @@ -0,0 +1,766 @@ +/* + * Licensed to the Apache Software Foundation (ASF) un

Re: [PR] SOLR-14414: Introduce new UI (SIP-7) [solr]

2024-08-07 Thread via GitHub
malliaridis commented on code in PR #2605: URL: https://github.com/apache/solr/pull/2605#discussion_r1708102341 ## solr/compose-ui/src/commonMain/kotlin/org/apache/solr/composeui/ui/main/MainContent.kt: ## @@ -0,0 +1,78 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

Re: [PR] SOLR-14414: Introduce new UI (SIP-7) [solr]

2024-08-07 Thread via GitHub
malliaridis commented on code in PR #2605: URL: https://github.com/apache/solr/pull/2605#discussion_r1708085072 ## solr/compose-ui/src/commonMain/kotlin/org/apache/solr/composeui/ui/icons/SolrLogo.kt: ## @@ -0,0 +1,257 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

Re: [PR] SOLR-14414: Introduce new UI (SIP-7) [solr]

2024-08-07 Thread via GitHub
malliaridis commented on code in PR #2605: URL: https://github.com/apache/solr/pull/2605#discussion_r1708085072 ## solr/compose-ui/src/commonMain/kotlin/org/apache/solr/composeui/ui/icons/SolrLogo.kt: ## @@ -0,0 +1,257 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

Re: [PR] SOLR-14414: Introduce new UI (SIP-7) [solr]

2024-08-07 Thread via GitHub
malliaridis commented on code in PR #2605: URL: https://github.com/apache/solr/pull/2605#discussion_r1708076547 ## solr/compose-ui/src/commonMain/kotlin/org/apache/solr/composeui/ui/environment/VersionsCard.kt: ## @@ -0,0 +1,101 @@ +/* + * Licensed to the Apache Software Foundat

Re: [PR] SOLR-14414: Introduce new UI (SIP-7) [solr]

2024-08-07 Thread via GitHub
malliaridis commented on code in PR #2605: URL: https://github.com/apache/solr/pull/2605#discussion_r1708073337 ## solr/compose-ui/src/commonMain/kotlin/org/apache/solr/composeui/ui/environment/EnvironmentContent.kt: ## @@ -0,0 +1,123 @@ +/* + * Licensed to the Apache Software F

Re: [PR] SOLR-14414: Introduce new UI (SIP-7) [solr]

2024-08-07 Thread via GitHub
malliaridis commented on code in PR #2605: URL: https://github.com/apache/solr/pull/2605#discussion_r1708066620 ## solr/compose-ui/src/commonMain/kotlin/org/apache/solr/composeui/components/main/MainComponent.kt: ## @@ -0,0 +1,91 @@ +/* + * Licensed to the Apache Software Founda

Re: [PR] SOLR-14414: Introduce new UI (SIP-7) [solr]

2024-08-07 Thread via GitHub
malliaridis commented on code in PR #2605: URL: https://github.com/apache/solr/pull/2605#discussion_r1708065517 ## solr/compose-ui/src/commonMain/kotlin/org/apache/solr/composeui/components/environment/integration/Mappers.kt: ## Review Comment: I am not sure if your questio

Re: [PR] SOLR-14414: Introduce new UI (SIP-7) [solr]

2024-08-07 Thread via GitHub
malliaridis commented on code in PR #2605: URL: https://github.com/apache/solr/pull/2605#discussion_r1708063991 ## solr/compose-ui/src/commonMain/kotlin/org/apache/solr/composeui/components/environment/data/JavaPropertiesResponse.kt: ## @@ -0,0 +1,32 @@ +/* + * Licensed to the A

Re: [PR] SOLR-14414: Introduce new UI (SIP-7) [solr]

2024-08-07 Thread via GitHub
epugh commented on code in PR #2605: URL: https://github.com/apache/solr/pull/2605#discussion_r1708064021 ## solr/compose-ui/src/commonMain/composeResources/font/firacode-variable.ttf: ## Review Comment: also, I would't go through heroics to match the existing UI styles...

Re: [PR] SOLR-14414: Introduce new UI (SIP-7) [solr]

2024-08-07 Thread via GitHub
epugh commented on code in PR #2605: URL: https://github.com/apache/solr/pull/2605#discussion_r1708062769 ## solr/compose-ui/src/commonMain/kotlin/org/apache/solr/composeui/utils/HttpClientUtils.kt: ## @@ -0,0 +1,43 @@ +/* + * Licensed to the Apache Software Foundation (ASF) und

Re: [PR] SOLR-14414: Introduce new UI (SIP-7) [solr]

2024-08-07 Thread via GitHub
malliaridis commented on code in PR #2605: URL: https://github.com/apache/solr/pull/2605#discussion_r1708060169 ## solr/compose-ui/src/commonMain/composeResources/font/firacode-variable.ttf: ## Review Comment: It is possible to use a dependency and load the fonts "dynamical

Re: [PR] SOLR-14414: Introduce new UI (SIP-7) [solr]

2024-08-07 Thread via GitHub
malliaridis commented on code in PR #2605: URL: https://github.com/apache/solr/pull/2605#discussion_r1708057897 ## solr/compose-ui/build.gradle.kts: ## @@ -0,0 +1,134 @@ +/* Review Comment: I was considering migrating to Kotlin DSL if we start using Kotlin in general. But i

Re: [PR] SOLR-14414: Introduce new UI (SIP-7) [solr]

2024-08-07 Thread via GitHub
malliaridis commented on code in PR #2605: URL: https://github.com/apache/solr/pull/2605#discussion_r1708055052 ## solr/api/build.gradle: ## @@ -16,8 +18,8 @@ */ plugins { - id 'io.swagger.core.v3.swagger-gradle-plugin' version '2.2.2' - id "org.openapi.generator" version

Re: [PR] SOLR-14414: Introduce new UI (SIP-7) [solr]

2024-08-07 Thread via GitHub
malliaridis commented on code in PR #2605: URL: https://github.com/apache/solr/pull/2605#discussion_r1708054252 ## gradle/libs.versions.toml: ## @@ -0,0 +1,65 @@ +[versions] Review Comment: I am currently working on a migration to use version catalogs in the entire project

Re: [PR] SOLR-14414: Introduce new UI (SIP-7) [solr]

2024-08-07 Thread via GitHub
malliaridis commented on code in PR #2605: URL: https://github.com/apache/solr/pull/2605#discussion_r1708053334 ## dev-docs/ui/technology-overview.adoc: ## @@ -0,0 +1,83 @@ += Technology Overview Review Comment: I listed all libraries here in detail, even though some of them

Re: [PR] SOLR-14414: Introduce new UI (SIP-7) [solr]

2024-08-07 Thread via GitHub
malliaridis commented on code in PR #2605: URL: https://github.com/apache/solr/pull/2605#discussion_r1708050511 ## build.gradle: ## @@ -20,6 +20,10 @@ import java.time.format.DateTimeFormatter plugins { id 'base' + alias(libs.plugins.kotlinMultiplatform) apply false Revi

Re: [PR] Reduce thread contention in ZkStateReader.getCollectionProperties() [solr]

2024-08-07 Thread via GitHub
aparnasuresh85 commented on code in PR #2611: URL: https://github.com/apache/solr/pull/2611#discussion_r1708045290 ## solr/solrj-zookeeper/src/java/org/apache/solr/common/cloud/CollectionPropertiesZkStateReader.java: ## @@ -300,10 +313,11 @@ private VersionedCollectionProps fet

Re: [PR] SOLR-14414: Introduce new UI (SIP-7) [solr]

2024-08-07 Thread via GitHub
epugh commented on code in PR #2605: URL: https://github.com/apache/solr/pull/2605#discussion_r1708030153 ## solr/server/etc/jetty.xml: ## @@ -95,7 +95,7 @@ /solr/* Content-Security-Policy -default-src 'none'; base-uri 'none'; co

Re: [PR] SOLR-17381: Make CLUSTERSTATUS configurable [solr]

2024-08-07 Thread via GitHub
aparnasuresh85 commented on PR #2599: URL: https://github.com/apache/solr/pull/2599#issuecomment-2274460985 > Nice! Nearly ready to commit IMO; needs a CHANGES.txt (which I could add if needed). Done. -- This is an automated message from the Apache Git Service. To respond to the me

Re: [PR] SOLR-14414: Introduce new UI (SIP-7) [solr]

2024-08-07 Thread via GitHub
epugh commented on code in PR #2605: URL: https://github.com/apache/solr/pull/2605#discussion_r1708029278 ## dev-docs/ui/technology-overview.adoc: ## @@ -0,0 +1,83 @@ += Technology Overview Review Comment: I think "sheer number" is okay, have you ever looked at a React app?

[jira] [Commented] (SOLR-17391) Optimize Backup/Restore Operations for Large Collections

2024-08-07 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17871790#comment-17871790 ] David Smiley commented on SOLR-17391: - For collectorExecutor (parallel segment search

Re: [PR] Merge to production [solr-site]

2024-08-07 Thread via GitHub
janhoy merged PR #120: URL: https://github.com/apache/solr-site/pull/120 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.

Re: [PR] SOLR-17295 Add download link for OpenAPI [solr-site]

2024-08-07 Thread via GitHub
janhoy merged PR #119: URL: https://github.com/apache/solr-site/pull/119 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.

Re: [PR] Reduce thread contention in ZkStateReader.getCollectionProperties() [solr]

2024-08-07 Thread via GitHub
dsmiley commented on code in PR #2611: URL: https://github.com/apache/solr/pull/2611#discussion_r1707774326 ## solr/solrj-zookeeper/src/java/org/apache/solr/common/cloud/CollectionPropertiesZkStateReader.java: ## @@ -300,10 +313,11 @@ private VersionedCollectionProps fetchColle

Re: [PR] Reduce thread contention in ZkStateReader.getCollectionProperties() [solr]

2024-08-07 Thread via GitHub
aparnasuresh85 commented on code in PR #2611: URL: https://github.com/apache/solr/pull/2611#discussion_r1707659461 ## solr/solrj-zookeeper/src/java/org/apache/solr/common/cloud/CollectionPropertiesZkStateReader.java: ## @@ -300,10 +313,11 @@ private VersionedCollectionProps fet

Re: [PR] Reduce thread contention in ZkStateReader.getCollectionProperties() [solr]

2024-08-07 Thread via GitHub
aparnasuresh85 commented on code in PR #2611: URL: https://github.com/apache/solr/pull/2611#discussion_r1707659461 ## solr/solrj-zookeeper/src/java/org/apache/solr/common/cloud/CollectionPropertiesZkStateReader.java: ## @@ -300,10 +313,11 @@ private VersionedCollectionProps fet

Re: [PR] Reduce thread contention in ZkStateReader.getCollectionProperties() [solr]

2024-08-07 Thread via GitHub
aparnasuresh85 commented on code in PR #2611: URL: https://github.com/apache/solr/pull/2611#discussion_r1707659461 ## solr/solrj-zookeeper/src/java/org/apache/solr/common/cloud/CollectionPropertiesZkStateReader.java: ## @@ -300,10 +313,11 @@ private VersionedCollectionProps fet

Re: [PR] Reduce thread contention in ZkStateReader.getCollectionProperties() [solr]

2024-08-07 Thread via GitHub
aparnasuresh85 commented on code in PR #2611: URL: https://github.com/apache/solr/pull/2611#discussion_r1707659461 ## solr/solrj-zookeeper/src/java/org/apache/solr/common/cloud/CollectionPropertiesZkStateReader.java: ## @@ -300,10 +313,11 @@ private VersionedCollectionProps fet

Re: [PR] Reduce thread contention in ZkStateReader.getCollectionProperties() [solr]

2024-08-07 Thread via GitHub
aparnasuresh85 commented on code in PR #2611: URL: https://github.com/apache/solr/pull/2611#discussion_r1707659461 ## solr/solrj-zookeeper/src/java/org/apache/solr/common/cloud/CollectionPropertiesZkStateReader.java: ## @@ -300,10 +313,11 @@ private VersionedCollectionProps fet

[jira] [Updated] (SOLR-17295) The downloads page should link to our OpenAPI spec artifact

2024-08-07 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17295?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated SOLR-17295: -- Labels: good-first-issue newdev pull-request-available (was: good-first-issue newdev) > The d

Re: [PR] SOLR-17381: Make CLUSTERSTATUS configurable [solr]

2024-08-07 Thread via GitHub
dsmiley commented on code in PR #2599: URL: https://github.com/apache/solr/pull/2599#discussion_r1707539294 ## solr/core/src/java/org/apache/solr/handler/admin/ClusterStatus.java: ## @@ -116,9 +118,19 @@ public void getClusterStatus(NamedList results) // add live_nodes

Re: [PR] SOLR-17391: Cached thread pools actually have more than one thread. [solr]

2024-08-07 Thread via GitHub
dsmiley commented on PR #2619: URL: https://github.com/apache/solr/pull/2619#issuecomment-2273984102 After reading ThreadPoolExecutor's docs a bit more, I was surprised to see that a new thread will be created for a new task when the thread count is less than the core size _even if there ar

Re: [PR] SOLR-14414: Introduce new UI (SIP-7) [solr]

2024-08-07 Thread via GitHub
gerlowskija commented on PR #2605: URL: https://github.com/apache/solr/pull/2605#issuecomment-2273958773 Also - when I check out this code locally it compiles fine in my IDE, but I'm having trouble running the packaging tasks (e.g. `./gradlew assemble`) in my terminal. The gradle build han

Re: [PR] SOLR-14414: Introduce new UI (SIP-7) [solr]

2024-08-07 Thread via GitHub
gerlowskija commented on code in PR #2605: URL: https://github.com/apache/solr/pull/2605#discussion_r1707007092 ## dev-docs/ui/testing-and-deployment.adoc: ## @@ -0,0 +1,19 @@ += Testing and Deployment + +== Testing + Review Comment: [0] Not important, just leaving this comm

[PR] chore(deps): update dependency org.apache.commons:commons-lang3 to v3.16.0 [solr]

2024-08-07 Thread via GitHub
solrbot opened a new pull request, #2628: URL: https://github.com/apache/solr/pull/2628 This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [org.apache.commons:commons-lang3](https://commons.apache.org/proper/commons-lang/) ([source]

[jira] [Commented] (SOLR-17253) Release wizard suggests wrong minor version for jira

2024-08-07 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17871716#comment-17871716 ] ASF subversion and git services commented on SOLR-17253: Commit c

[jira] [Commented] (SOLR-17245) Use downloads rather than archive for checking KEYS file in release wizard

2024-08-07 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17871715#comment-17871715 ] ASF subversion and git services commented on SOLR-17245: Commit 5

[jira] [Commented] (SOLR-17253) Release wizard suggests wrong minor version for jira

2024-08-07 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17871712#comment-17871712 ] ASF subversion and git services commented on SOLR-17253: Commit 3

[jira] [Assigned] (SOLR-17253) Release wizard suggests wrong minor version for jira

2024-08-07 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-17253?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Høydahl reassigned SOLR-17253: -- Assignee: Jan Høydahl > Release wizard suggests wrong minor version for jira > ---

[jira] [Resolved] (SOLR-17253) Release wizard suggests wrong minor version for jira

2024-08-07 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-17253?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Høydahl resolved SOLR-17253. Fix Version/s: 9.7 Resolution: Fixed > Release wizard suggests wrong minor version for jira

Re: [PR] SOLR-17253 Release wizard suggests wrong minor version for jira [solr]

2024-08-07 Thread via GitHub
janhoy merged PR #2622: URL: https://github.com/apache/solr/pull/2622 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

[jira] [Resolved] (SOLR-17245) Use downloads rather than archive for checking KEYS file in release wizard

2024-08-07 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-17245?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Høydahl resolved SOLR-17245. Fix Version/s: 9.7 Resolution: Fixed > Use downloads rather than archive for checking KEYS f

[jira] [Assigned] (SOLR-17245) Use downloads rather than archive for checking KEYS file in release wizard

2024-08-07 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-17245?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Høydahl reassigned SOLR-17245: -- Assignee: Jan Høydahl > Use downloads rather than archive for checking KEYS file in release wi

[jira] [Commented] (SOLR-17245) Use downloads rather than archive for checking KEYS file in release wizard

2024-08-07 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17871710#comment-17871710 ] ASF subversion and git services commented on SOLR-17245: Commit 5

Re: [PR] SOLR-17245 Download KEYS from downloads server [solr]

2024-08-07 Thread via GitHub
janhoy merged PR #2623: URL: https://github.com/apache/solr/pull/2623 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

[jira] [Commented] (SOLR-17298) Multithreaded search breaks limits, and possibly other things

2024-08-07 Thread Christine Poerschke (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17871709#comment-17871709 ] Christine Poerschke commented on SOLR-17298: bq. Just realized that the posib

Re: [PR] SOLR-16996: remove no-longer-applicable solr/licenses/argparse4j-* files [solr]

2024-08-07 Thread via GitHub
epugh commented on PR #2627: URL: https://github.com/apache/solr/pull/2627#issuecomment-2273769080 I wonder if this is important enough to bring to branch_9_7? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

Re: [PR] SOLR-16996: remove no-longer-applicable solr/licenses/argparse4j-* files [solr]

2024-08-07 Thread via GitHub
epugh merged PR #2627: URL: https://github.com/apache/solr/pull/2627 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

Re: [PR] SOLR-16996: remove no-longer-applicable solr/licenses/argparse4j-* files [solr]

2024-08-07 Thread via GitHub
epugh commented on PR #2627: URL: https://github.com/apache/solr/pull/2627#issuecomment-2273767606 Like wise! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe

Re: [PR] SOLR-17381: Make CLUSTERSTATUS configurable [solr]

2024-08-07 Thread via GitHub
aparnasuresh85 commented on code in PR #2599: URL: https://github.com/apache/solr/pull/2599#discussion_r1707163750 ## solr/core/src/java/org/apache/solr/handler/admin/ClusterStatus.java: ## @@ -116,9 +118,19 @@ public void getClusterStatus(NamedList results) // add live_n

Re: [PR] SOLR-17381: Make CLUSTERSTATUS configurable [solr]

2024-08-07 Thread via GitHub
aparnasuresh85 commented on code in PR #2599: URL: https://github.com/apache/solr/pull/2599#discussion_r1707163750 ## solr/core/src/java/org/apache/solr/handler/admin/ClusterStatus.java: ## @@ -116,9 +118,19 @@ public void getClusterStatus(NamedList results) // add live_n

Re: [PR] SOLR-17381: Make CLUSTERSTATUS configurable [solr]

2024-08-07 Thread via GitHub
aparnasuresh85 commented on code in PR #2599: URL: https://github.com/apache/solr/pull/2599#discussion_r1707163750 ## solr/core/src/java/org/apache/solr/handler/admin/ClusterStatus.java: ## @@ -116,9 +118,19 @@ public void getClusterStatus(NamedList results) // add live_n

[jira] [Commented] (SOLR-17298) Multithreaded search breaks limits, and possibly other things

2024-08-07 Thread Gus Heck (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17871671#comment-17871671 ] Gus Heck commented on SOLR-17298: - Just realized that the posibility of NaN was not actua

[jira] [Updated] (SOLR-17298) Multithreaded search breaks limits, and possibly other things

2024-08-07 Thread Gus Heck (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17298?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gus Heck updated SOLR-17298: Description: https://issues.apache.org/jira/browse/SOLR-13350 was merged to main somewhat unexpectedly, an

[jira] [Assigned] (SOLR-17394) IndexFetcher should inspect HTTP status codes on its requests

2024-08-07 Thread Jason Gerlowski (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17394?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gerlowski reassigned SOLR-17394: -- Assignee: Jason Gerlowski > IndexFetcher should inspect HTTP status codes on its reque

Re: [PR] SOLR-17381: Make CLUSTERSTATUS configurable [solr]

2024-08-07 Thread via GitHub
dsmiley commented on code in PR #2599: URL: https://github.com/apache/solr/pull/2599#discussion_r1707112138 ## solr/core/src/java/org/apache/solr/handler/admin/ClusterStatus.java: ## @@ -116,9 +118,19 @@ public void getClusterStatus(NamedList results) // add live_nodes

Re: [PR] SOLR-17381: Make CLUSTERSTATUS configurable [solr]

2024-08-07 Thread via GitHub
aparnasuresh85 commented on code in PR #2599: URL: https://github.com/apache/solr/pull/2599#discussion_r1707086097 ## solr/core/src/java/org/apache/solr/handler/admin/ClusterStatus.java: ## @@ -191,43 +234,23 @@ public void getClusterStatus(NamedList results) } Str

Re: [PR] SOLR-17381: Make CLUSTERSTATUS configurable [solr]

2024-08-07 Thread via GitHub
aparnasuresh85 commented on code in PR #2599: URL: https://github.com/apache/solr/pull/2599#discussion_r1707084935 ## solr/solrj/src/test/org/apache/solr/client/solrj/impl/CloudHttp2SolrClientTest.java: ## @@ -100,7 +100,13 @@ public class CloudHttp2SolrClientTest extends SolrC

Re: [PR] SOLR-17381: Make CLUSTERSTATUS configurable [solr]

2024-08-07 Thread via GitHub
aparnasuresh85 commented on code in PR #2599: URL: https://github.com/apache/solr/pull/2599#discussion_r1707084246 ## solr/solrj/src/test/org/apache/solr/client/solrj/impl/CloudHttp2SolrClientTest.java: ## @@ -291,7 +297,7 @@ public void testHttpCspPerf() throws Exception {

Re: [PR] SOLR-16996: Update Solr Exporter for Prometheus cli to use commons-cli [solr]

2024-08-07 Thread via GitHub
cpoerschke commented on code in PR #2602: URL: https://github.com/apache/solr/pull/2602#discussion_r1707047176 ## versions.props: ## @@ -29,7 +29,6 @@ io.prometheus:*=0.16.0 io.swagger.core.v3:*=2.2.22 jakarta.ws.rs:jakarta.ws.rs-api=3.1.0 junit:junit=4.13.2 -net.sourceforge.

[PR] SOLR-16996: remove no-longer-applicable solr/licenses/argparse4j-* files [solr]

2024-08-07 Thread via GitHub
cpoerschke opened a new pull request, #2627: URL: https://github.com/apache/solr/pull/2627 #2602 follow-up https://issues.apache.org/jira/browse/SOLR-16996 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] SOLR-10654: Override PrometheusResponseWriter Content Type [solr]

2024-08-07 Thread via GitHub
dsmiley commented on code in PR #2616: URL: https://github.com/apache/solr/pull/2616#discussion_r1707038840 ## solr/core/src/java/org/apache/solr/response/PrometheusResponseWriter.java: ## @@ -49,7 +49,7 @@ */ @SuppressWarnings(value = "unchecked") public class PrometheusRes

[PR] PeerSync: INFO-log DBQs with NOW [solr]

2024-08-07 Thread via GitHub
cpoerschke opened a new pull request, #2626: URL: https://github.com/apache/solr/pull/2626 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-ma

[PR] SOLR-17298 Add tests to verify that graph, join and rerank queries are unaffected by the use of multithreaded search and re-enable them. [solr]

2024-08-07 Thread via GitHub
gus-asf opened a new pull request, #2625: URL: https://github.com/apache/solr/pull/2625 https://issues.apache.org/jira/browse/SOLR-17298 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

Re: [PR] SOLR-17249 Edit .asf.yaml on main branch [solr]

2024-08-07 Thread via GitHub
janhoy commented on PR #2624: URL: https://github.com/apache/solr/pull/2624#issuecomment-2273467112 Tested locally, both for a major release and a minor release. Output for a major release: ``` Edit `.asf.yaml` to protect new git branch(es) branch_10_0 and branch_10x. Run these comm

Re: [PR] Update io.netty:* to v4.1.112.Final [solr]

2024-08-07 Thread via GitHub
janhoy commented on PR #2592: URL: https://github.com/apache/solr/pull/2592#issuecomment-2273330359 Merging this to `branch_9x` (for 9.8), not backporting to new `branch_9_7` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [PR] Update io.netty:* to v4.1.112.Final [solr]

2024-08-07 Thread via GitHub
janhoy merged PR #2592: URL: https://github.com/apache/solr/pull/2592 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

Re: [PR] Update gradle/wrapper-validation-action action to v3 [solr]

2024-08-07 Thread via GitHub
janhoy merged PR #2578: URL: https://github.com/apache/solr/pull/2578 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org