Re: [PR] SOLR-17394: Check response status in IndexFetcher [solr]

2024-08-15 Thread via GitHub
dsmiley commented on PR #2621: URL: https://github.com/apache/solr/pull/2621#issuecomment-2292801661 I see less than 2 days: August 6th 3:52pm -> 8th 8:32am. That's too short. Also we generally give advanced merge notice if there was no feedback whatsoever. -- This is an automated mess

[jira] [Created] (SOLR-17411) Add randomized testing to apply multithreaded search

2024-08-15 Thread Gus Heck (Jira)
Gus Heck created SOLR-17411: --- Summary: Add randomized testing to apply multithreaded search Key: SOLR-17411 URL: https://issues.apache.org/jira/browse/SOLR-17411 Project: Solr Issue Type: Improveme

[jira] [Resolved] (SOLR-17298) Multithreaded search breaks limits, and possibly other things

2024-08-15 Thread Gus Heck (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17298?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gus Heck resolved SOLR-17298. - Resolution: Fixed > Multithreaded search breaks limits, and possibly other things > -

[jira] [Commented] (SOLR-17298) Multithreaded search breaks limits, and possibly other things

2024-08-15 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17874093#comment-17874093 ] ASF subversion and git services commented on SOLR-17298: Commit e

Re: [PR] SOLR-17298 (backport) verify that graph, join and rerank queries are unaffected by the use of multithreaded search and re-enable them. (#2625) (#2648) [solr]

2024-08-15 Thread via GitHub
anshumg merged PR #2649: URL: https://github.com/apache/solr/pull/2649 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.or

Re: [PR] SOLR-17394: Check response status in IndexFetcher [solr]

2024-08-15 Thread via GitHub
gerlowskija commented on PR #2621: URL: https://github.com/apache/solr/pull/2621#issuecomment-2292530594 > This was merged so fast that it got not review; I wanted to review it I thought 3 days was a reasonable length of time to wait on a pretty clear and minor bugfix; I hope i'm not

Re: [PR] SOLR-17394: Check response status in IndexFetcher [solr]

2024-08-15 Thread via GitHub
gerlowskija commented on code in PR #2621: URL: https://github.com/apache/solr/pull/2621#discussion_r1719161093 ## solr/core/src/java/org/apache/solr/handler/IndexFetcher.java: ## @@ -1988,16 +1989,38 @@ private FastInputStream getStream() throws IOException { req.setBa

Re: [PR] SOLR-17394: Check response status in IndexFetcher [solr]

2024-08-15 Thread via GitHub
gerlowskija commented on code in PR #2621: URL: https://github.com/apache/solr/pull/2621#discussion_r1719161279 ## solr/core/src/java/org/apache/solr/handler/IndexFetcher.java: ## @@ -1988,16 +1989,38 @@ private FastInputStream getStream() throws IOException { req.setBa

Re: [PR] TestExportWriter fix, loosen order constraint [solr]

2024-08-15 Thread via GitHub
dsmiley commented on PR #2615: URL: https://github.com/apache/solr/pull/2615#issuecomment-2292039368 I'll merge this in a couple days. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[I] Cannot specify an imagePullSecret for solr-operator Helm chart [solr-operator]

2024-08-15 Thread via GitHub
jstaf opened a new issue, #718: URL: https://github.com/apache/solr-operator/issues/718 The solr-operator helm chart is missing the ability to specify a custom imagePullSecret to pull images from self-hosted container repos (that require authentication). -- This is an automated message f

[PR] Update dependency commons-cli:commons-cli to v1.9.0 [solr]

2024-08-15 Thread via GitHub
solrbot opened a new pull request, #2650: URL: https://github.com/apache/solr/pull/2650 This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [commons-cli:commons-cli](https://commons.apache.org/proper/commons-cli/) ([source](https://gi

Re: [PR] Benchmark: HTTP2 fix cancel_stream_error [solr]

2024-08-15 Thread via GitHub
dsmiley commented on PR #2612: URL: https://github.com/apache/solr/pull/2612#issuecomment-2291627819 `crave run -- ./jmh.sh CloudIndexing -jvmArgsAppend -Dsolr.bench.seed=823716671780822 -p useSmallDocs=true -p nodeCount=1 -p numShards=1 -p numReplicas=1 -I 8` The benchmark module u

Re: [PR] Bump up dependency analyze to 1.10.0 [solr]

2024-08-15 Thread via GitHub
dsmiley commented on PR #2643: URL: https://github.com/apache/solr/pull/2643#issuecomment-2291555072 @risdenk I know you introduced this plugin but IMO it's more annoying & burdensome than helpful. Maybe we should back out this plugin? I was somewhat appreciative of the Maven equivalent,

Re: [I] It is impossible to setup TLS between Solr and Zookeeper [solr-operator]

2024-08-15 Thread via GitHub
jstaf commented on issue #717: URL: https://github.com/apache/solr-operator/issues/717#issuecomment-2291521058 I got this to work with a custom solr image with a custom version of `solr.in.sh` and `zkcli.sh`. Still needs to be fixed in solr-operator though. solr.in.sh (this change has

Re: [PR] Mark AccessControlContext, AccessController, and SecurityManager as forbidden [solr]

2024-08-15 Thread via GitHub
iamsanjay commented on PR #2634: URL: https://github.com/apache/solr/pull/2634#issuecomment-2291509006 We’ll drop this one for now and revisit it when we're about to upgrade. Thanks for your help @uschindler, and also for clearing up the confusion about the `DocumentObjectBinder`. Appreciat

Re: [PR] Mark AccessControlContext, AccessController, and SecurityManager as forbidden [solr]

2024-08-15 Thread via GitHub
uschindler commented on PR #2634: URL: https://github.com/apache/solr/pull/2634#issuecomment-2291460770 > I'll share my thought process on how I used forbidden APIs. Initially, I added entries to the config files while we were still using Java 11. Once we move to Java 21, there will be no n

Re: [PR] Mark AccessControlContext, AccessController, and SecurityManager as forbidden [solr]

2024-08-15 Thread via GitHub
uschindler commented on PR #2634: URL: https://github.com/apache/solr/pull/2634#issuecomment-2291438971 Hi, in my opinion the whole thing is not needed at all. On the day when you switch to Java 17 or 21 as minimum version you get the forbiddenwarnings automatically (by both forbiddenapi

Re: [PR] Benchmark: HTTP2 fix cancel_stream_error [solr]

2024-08-15 Thread via GitHub
iamsanjay commented on PR #2612: URL: https://github.com/apache/solr/pull/2612#issuecomment-2291372990 Could you please walk me through the process of running this specific benchmark which is giving the error, such as a command, or anything which helps me re-produce it on my system. --

Re: [PR] Bump up dependency analyze to 1.10.0 [solr]

2024-08-15 Thread via GitHub
iamsanjay commented on PR #2643: URL: https://github.com/apache/solr/pull/2643#issuecomment-2291201634 @dsmiley Should I create JIRA for this one? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] Mark AccessControlContext, AccessController, and SecurityManager as forbidden [solr]

2024-08-15 Thread via GitHub
iamsanjay commented on PR #2634: URL: https://github.com/apache/solr/pull/2634#issuecomment-2291197986 I'll share my thought process on how I used forbidden APIs. Initially, I added entries to the config files while we were still using Java 11. Once we move to Java 21, there will be no need

[jira] [Commented] (SOLR-17410) Gradle up-to-date checks not working with openApiGenerate

2024-08-15 Thread Jason Gerlowski (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17873901#comment-17873901 ] Jason Gerlowski commented on SOLR-17410: It looks like Houston identified an open