Re: [PR] [branch_9x] SOLR-17321: Remove Deprecated URL ctors in Preparation for Java 21 (… [solr]

2024-08-21 Thread via GitHub
epugh commented on PR #2528: URL: https://github.com/apache/solr/pull/2528#issuecomment-2303641376 Tests all pass, and no issues raised, so I htink you can merge! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [branch_9x] SOLR-17321: Remove Deprecated URL ctors in Preparation for Java 21 (… [solr]

2024-08-21 Thread via GitHub
iamsanjay commented on PR #2528: URL: https://github.com/apache/solr/pull/2528#issuecomment-2303632234 Can we merge this one? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] Benchmark: HTTP2 fix cancel_stream_error [solr]

2024-08-21 Thread via GitHub
iamsanjay commented on PR #2612: URL: https://github.com/apache/solr/pull/2612#issuecomment-2303631157 I recall encountering a somewhat similar error in the IndexFetcher class when we transitioned to HTTP2. The IndexFetcher class was prematurely closing the client connection and sending a G

Re: [PR] SOLR-17321: Bump up ecj to 3.36.0 [solr]

2024-08-21 Thread via GitHub
iamsanjay closed pull request #2635: SOLR-17321: Bump up ecj to 3.36.0 URL: https://github.com/apache/solr/pull/2635 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscr

Re: [PR] SOLR-17399: Replace the use of the deprecated java.util.Locale ctor [solr]

2024-08-21 Thread via GitHub
iamsanjay commented on PR #2633: URL: https://github.com/apache/solr/pull/2633#issuecomment-2303625744 If everything looks fine, then going to merge it soon! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

Re: [PR] Mark AccessControlContext, AccessController, and SecurityManager as forbidden [solr]

2024-08-21 Thread via GitHub
iamsanjay closed pull request #2634: Mark AccessControlContext, AccessController, and SecurityManager as forbidden URL: https://github.com/apache/solr/pull/2634 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

Re: [PR] Bump up dependency analyze to 1.10.0 [solr]

2024-08-21 Thread via GitHub
iamsanjay commented on PR #2643: URL: https://github.com/apache/solr/pull/2643#issuecomment-2303625310 Planning to merge this shortly! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[jira] [Resolved] (SOLR-17408) Calls to COLSTATUS are not optimized

2024-08-21 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17408?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Smiley resolved SOLR-17408. - Fix Version/s: 9.8 Resolution: Fixed Thanks Mathieu! > Calls to COLSTATUS are not optimiz

[PR] Review code for typos [solr]

2024-08-21 Thread via GitHub
epugh opened a new pull request, #2656: URL: https://github.com/apache/solr/pull/2656 # Description Go through and fix typos and grammer errors. # Solution Clicking on each java class in IntelliJ and looking for typos and grammer errors. Using suggestions from IntelliJ.

[jira] [Commented] (SOLR-17408) Calls to COLSTATUS are not optimized

2024-08-21 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17875719#comment-17875719 ] ASF subversion and git services commented on SOLR-17408: Commit 5

[jira] [Commented] (SOLR-17408) Calls to COLSTATUS are not optimized

2024-08-21 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17875716#comment-17875716 ] ASF subversion and git services commented on SOLR-17408: Commit b

Re: [PR] SOLR-17408 - COLSTATUS is not optimized [solr]

2024-08-21 Thread via GitHub
dsmiley merged PR #2645: URL: https://github.com/apache/solr/pull/2645 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.or

[jira] [Created] (SOLR-17419) Improve HttpShardHandler performance in many-shard collections

2024-08-21 Thread Jason Gerlowski (Jira)
Jason Gerlowski created SOLR-17419: -- Summary: Improve HttpShardHandler performance in many-shard collections Key: SOLR-17419 URL: https://issues.apache.org/jira/browse/SOLR-17419 Project: Solr

[jira] [Created] (SOLR-17416) Streaming Expressions: Exception swallowed and not propagated back to the client leading to inconsistent results

2024-08-21 Thread Lamine (Jira)
Lamine created SOLR-17416: - Summary: Streaming Expressions: Exception swallowed and not  propagated back to the client leading to inconsistent results Key: SOLR-17416 URL: https://issues.apache.org/jira/browse/SOLR-17416

[jira] [Created] (SOLR-17415) TimeLimitingCollector isn't adding value and is deprecated; remove

2024-08-21 Thread David Smiley (Jira)
David Smiley created SOLR-17415: --- Summary: TimeLimitingCollector isn't adding value and is deprecated; remove Key: SOLR-17415 URL: https://issues.apache.org/jira/browse/SOLR-17415 Project: Solr

[jira] [Updated] (SOLR-17415) TimeLimitingCollector isn't adding value and is deprecated; remove

2024-08-21 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17415?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Smiley updated SOLR-17415: Labels: newdev (was: ) > TimeLimitingCollector isn't adding value and is deprecated; remove >

[jira] [Commented] (SOLR-16470) Create V2 equivalent of V1 Replication: Get IndexVersion, Get FileStream, Get File List

2024-08-21 Thread Matthew Biscocho (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16470?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17875605#comment-17875605 ] Matthew Biscocho commented on SOLR-16470: - Hey [~gerlowskija], I'll find time to

Re: [PR] Optimize no rows only count [solr]

2024-08-21 Thread via GitHub
dsmiley commented on PR #2655: URL: https://github.com/apache/solr/pull/2655#issuecomment-2302645694 (I didn't mean to un-DRAFT; I was fiddling with the IntelliJ integration) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[jira] [Commented] (SOLR-17375) Close IndexReader asynchronously on commit for performance

2024-08-21 Thread Mike Drob (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17875595#comment-17875595 ] Mike Drob commented on SOLR-17375: -- I think some future Lucene 9.x version will mitigate

[PR] Optimize no rows only count [solr]

2024-08-21 Thread via GitHub
risdenk opened a new pull request, #2655: URL: https://github.com/apache/solr/pull/2655 https://issues.apache.org/jira/browse/SOLR-X # Description Please provide a short description of the changes you're making with this pull request. # Solution Please provide

[jira] [Commented] (SOLR-17413) UpdateLog Replay can throw ConcurrentModificationException from sharing the request

2024-08-21 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17413?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17875506#comment-17875506 ] David Smiley commented on SOLR-17413: - I'd prefer to avoid catching this exception to

[jira] [Created] (SOLR-17414) multiThreaded=true can result in RejectedExecutionException

2024-08-21 Thread David Smiley (Jira)
David Smiley created SOLR-17414: --- Summary: multiThreaded=true can result in RejectedExecutionException Key: SOLR-17414 URL: https://issues.apache.org/jira/browse/SOLR-17414 Project: Solr Issue

[jira] [Updated] (SOLR-17408) Calls to COLSTATUS are not optimized

2024-08-21 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17408?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Smiley updated SOLR-17408: Description: I found out about it in solr 9.4.1 and is still present in main. When calling COLSTAT

[jira] [Updated] (SOLR-17408) Calls to COLSTATUS are not optimized

2024-08-21 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17408?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Smiley updated SOLR-17408: Affects Version/s: 8.1 (was: main (10.0)) > Calls to COLSTATUS are not o

Re: [PR] SOLR-17408 - COLSTATUS is not optimized [solr]

2024-08-21 Thread via GitHub
dsmiley commented on PR #2645: URL: https://github.com/apache/solr/pull/2645#issuecomment-2302035403 For 9.8, I'll add the following under Optimizations: > SOLR-17408: COLSTATUS command was fetching details remotely from replicas when this information wasn't asked for. (Mathieu Marie

Re: [PR] SOLR-17408 - COLSTATUS is not optimized [solr]

2024-08-21 Thread via GitHub
dsmiley commented on code in PR #2645: URL: https://github.com/apache/solr/pull/2645#discussion_r1724951708 ## solr/core/src/java/org/apache/solr/handler/admin/ColStatus.java: ## @@ -176,48 +182,50 @@ public void getColStatus(NamedList results) { if (url == null) {

[jira] [Resolved] (SOLR-16868) Rethink the structure of our CLI tools

2024-08-21 Thread Eric Pugh (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16868?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eric Pugh resolved SOLR-16868. -- Assignee: Eric Pugh Resolution: Not A Problem At this point in time, i'm quite happy with the bin

Re: [PR] SOLR-17408 - COLSTATUS is not optimized [solr]

2024-08-21 Thread via GitHub
mariemat commented on PR #2645: URL: https://github.com/apache/solr/pull/2645#issuecomment-2301365614 The failed test is a flapper and is not related to my changes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the U

Re: [PR] SOLR-17408 - COLSTATUS is not optimized [solr]

2024-08-21 Thread via GitHub
mariemat commented on code in PR #2645: URL: https://github.com/apache/solr/pull/2645#discussion_r1724577931 ## solr/core/src/java/org/apache/solr/handler/admin/ColStatus.java: ## @@ -176,48 +182,50 @@ public void getColStatus(NamedList results) { if (url == null) {