Re: [PR] SOLR-17406: Introduce Version Catalogs [solr]

2024-09-24 Thread via GitHub
dsmiley commented on PR #2706: URL: https://github.com/apache/solr/pull/2706#issuecomment-2373053917 > spotless and tidy are added to run on build files too Awesome! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

Re: [PR] SOLR-17406: Introduce Version Catalogs [solr]

2024-09-24 Thread via GitHub
dsmiley commented on code in PR #2706: URL: https://github.com/apache/solr/pull/2706#discussion_r1774499355 ## build.gradle: ## @@ -139,7 +143,7 @@ apply from: file('gradle/maven/defaults-maven.gradle') // IDE support, settings and specials. apply from: file('gradle/ide/inte

Re: [PR] SOLR-16503: New home for default http2 client [solr]

2024-09-24 Thread via GitHub
iamsanjay commented on code in PR #2689: URL: https://github.com/apache/solr/pull/2689#discussion_r1774390477 ## solr/core/src/java/org/apache/solr/core/CoreContainer.java: ## @@ -2563,6 +2581,11 @@ public PlacementPluginFactory getPlacementPlugi return this.distributedColl

Re: [PR] SOLR-16503: New home for default http2 client [solr]

2024-09-24 Thread via GitHub
iamsanjay commented on code in PR #2689: URL: https://github.com/apache/solr/pull/2689#discussion_r1774390477 ## solr/core/src/java/org/apache/solr/core/CoreContainer.java: ## @@ -2563,6 +2581,11 @@ public PlacementPluginFactory getPlacementPlugi return this.distributedColl

[jira] [Commented] (SOLR-16503) Switch UpdateShardHandler.getDefaultHttpClient to Jetty HTTP2

2024-09-24 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17884493#comment-17884493 ] David Smiley commented on SOLR-16503: - Sanjay is working on this one but you're welco

Re: [PR] SOLR-17448: Audit usage of ExecutorService#submit in Solr codebase [solr]

2024-09-24 Thread via GitHub
dsmiley commented on code in PR #2707: URL: https://github.com/apache/solr/pull/2707#discussion_r1774359207 ## solr/CHANGES.txt: ## @@ -163,6 +163,8 @@ Other Changes * SOLR-17142: Fix Gradle build sometimes gives spurious "unreferenced license file" warnings. (Uwe Schindler)

Re: [PR] SOLR-17442: Resolve -v flag conflict (version, value, verbose) [solr]

2024-09-24 Thread via GitHub
epugh commented on code in PR #2721: URL: https://github.com/apache/solr/pull/2721#discussion_r1774359308 ## solr/core/src/java/org/apache/solr/cli/SolrCLI.java: ## @@ -137,6 +137,12 @@ public class SolrCLI implements CLIO { public static final Option OPTION_SOLRURL =

Re: [PR] SOLR-14673: Add bin/solr stream CLI [solr]

2024-09-24 Thread via GitHub
epugh commented on code in PR #2479: URL: https://github.com/apache/solr/pull/2479#discussion_r1774352198 ## solr/solr-ref-guide/modules/query-guide/pages/stream-tool.adoc: ## @@ -0,0 +1,167 @@ += Stream Tool +// Licensed to the Apache Software Foundation (ASF) under one +// or

Re: [PR] Release 8.11.4 [solr-docker]

2024-09-24 Thread via GitHub
HoustonPutman merged PR #27: URL: https://github.com/apache/solr-docker/pull/27 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.

[PR] Release 8.11.4 [solr-docker]

2024-09-24 Thread via GitHub
HoustonPutman opened a new pull request, #27: URL: https://github.com/apache/solr-docker/pull/27 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe

[jira] [Created] (SOLR-17461) (cleanup) Move ClusterState string "Interner" json parser to Utils

2024-09-24 Thread David Smiley (Jira)
David Smiley created SOLR-17461: --- Summary: (cleanup) Move ClusterState string "Interner" json parser to Utils Key: SOLR-17461 URL: https://issues.apache.org/jira/browse/SOLR-17461 Project: Solr

[jira] [Commented] (SOLR-16470) Create V2 equivalent of V1 Replication: Get IndexVersion, Get FileStream, Get File List

2024-09-24 Thread Matthew Biscocho (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16470?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=1788#comment-1788 ] Matthew Biscocho commented on SOLR-16470: - [~gerlowskija] Started to look into th

Re: [PR] SOLR-17448: Audit usage of ExecutorService#submit in Solr codebase [solr]

2024-09-24 Thread via GitHub
AndreyBozhko commented on PR #2707: URL: https://github.com/apache/solr/pull/2707#issuecomment-2372354983 Hi @dsmiley, could you review this once you have time? Thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use th

[jira] [Updated] (SOLR-17460) Error During Collection Migration from Solr 7.0 to Solr 8.4: Missing Files and Shard Restoration Failures

2024-09-24 Thread Arda (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17460?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Arda updated SOLR-17460: Description: I was attempting to migrate a collection with 3 shards from a Solr 7.0 cluster to a Solr 8.4 cluster.

[jira] [Commented] (SOLR-17460) Error During Collection Migration from Solr 7.0 to Solr 8.4: Missing Files and Shard Restoration Failures

2024-09-24 Thread Arda (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17460?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17884426#comment-17884426 ] Arda commented on SOLR-17460: - To successfully migrate the collection with all data intact, I

[jira] [Updated] (SOLR-17460) Error During Collection Migration from Solr 7.0 to Solr 8.4: Missing Files and Shard Restoration Failures

2024-09-24 Thread Arda (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17460?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Arda updated SOLR-17460: Description: I was attempting to migrate a collection with 3 shards from a Solr 7.0 cluster to a Solr 8.4 cluster.

[jira] [Created] (SOLR-17460) Error During Collection Migration from Solr 7.0 to Solr 8.4: Missing Files and Shard Restoration Failures

2024-09-24 Thread Arda (Jira)
Arda created SOLR-17460: --- Summary: Error During Collection Migration from Solr 7.0 to Solr 8.4: Missing Files and Shard Restoration Failures Key: SOLR-17460 URL: https://issues.apache.org/jira/browse/SOLR-17460

[jira] [Commented] (SOLR-16503) Switch UpdateShardHandler.getDefaultHttpClient to Jetty HTTP2

2024-09-24 Thread Jason Gerlowski (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17884423#comment-17884423 ] Jason Gerlowski commented on SOLR-16503: +1 to this effort! One additional downs

Re: [PR] Benchmark: HTTP2 fix cancel_stream_error [solr]

2024-09-24 Thread via GitHub
dsmiley commented on PR #2612: URL: https://github.com/apache/solr/pull/2612#issuecomment-2371983637 Yes; our versions are in `versions.props` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] Benchmark: HTTP2 fix cancel_stream_error [solr]

2024-09-24 Thread via GitHub
iamsanjay commented on PR #2612: URL: https://github.com/apache/solr/pull/2612#issuecomment-2371907560 We are using jetty 10, right? https://github.com/jetty/jetty.project/issues/10485 -- This is an automated message from the Apache Git Service. To respond to the message, please log on

Re: [PR] SOLR-17158 Terminate distributed processing quickly when query limit is reached [solr]

2024-09-24 Thread via GitHub
gus-asf commented on code in PR #2666: URL: https://github.com/apache/solr/pull/2666#discussion_r1773633493 ## solr/CHANGES.txt: ## @@ -109,8 +109,11 @@ New Features Improvements - +* SOLR-17158: Users for whom partial results are uninteresting may set p

Re: [PR] SOLR-14673: Add bin/solr stream CLI [solr]

2024-09-24 Thread via GitHub
epugh commented on code in PR #2479: URL: https://github.com/apache/solr/pull/2479#discussion_r1773657326 ## solr/solr-ref-guide/modules/query-guide/pages/stream-tool.adoc: ## @@ -71,13 +72,15 @@ CORSAIR ValueSelect 1GB 184-Pin DDR SDRAM Unbuffered DDR 400 (PC 3200) System Me

Re: [PR] SOLR-17378: Add a RequestHandler metric for "number of outstanding concurrent requests" [solr]

2024-09-24 Thread via GitHub
magibney commented on PR #2591: URL: https://github.com/apache/solr/pull/2591#issuecomment-2371725359 > Have you deployed it / ran it for a while to see if it behaves sensibly? Quick status update -- have _not_ yet deployed it locally. This is still definitely on the radar though, so

Re: [I] BalanceReplicas called even when PopulatePodsOnScaleUp and VacatePodsOnScaleDown are false [solr-operator]

2024-09-24 Thread via GitHub
HoustonPutman commented on issue #724: URL: https://github.com/apache/solr-operator/issues/724#issuecomment-2371628651 It definitely calls it when doing a rolling restart of an ephemeral collection, but that's because we are moving replicas around anyways. We can definitely document that be

Re: [PR] SOLR-17158 Terminate distributed processing quickly when query limit is reached [solr]

2024-09-24 Thread via GitHub
gus-asf commented on code in PR #2666: URL: https://github.com/apache/solr/pull/2666#discussion_r1773584764 ## solr/core/src/java/org/apache/solr/handler/component/HttpShardHandler.java: ## @@ -80,6 +94,39 @@ public HttpShardHandler(HttpShardHandlerFactory httpShardHandlerFacto

[jira] [Commented] (SOLR-17341) Apache Solr website home to include Hybrid and vector-based search references

2024-09-24 Thread Jason Gerlowski (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17341?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17884316#comment-17884316 ] Jason Gerlowski commented on SOLR-17341: Hey [~abenedetti] - SOLR-16295 refreshed

[jira] [Resolved] (SOLR-16295) Modernize and Standardize Solr description across all platforms

2024-09-24 Thread Jason Gerlowski (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16295?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gerlowski resolved SOLR-16295. Fix Version/s: 9.7 Assignee: Jason Gerlowski (was: Eric Pugh) Resolution: F

Re: [PR] Add scripts to fetch+prepare solr-community data [solr-sandbox]

2024-09-24 Thread via GitHub
gerlowskija merged PR #111: URL: https://github.com/apache/solr-sandbox/pull/111 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr

Re: [PR] SOLR-14673: Add bin/solr stream CLI [solr]

2024-09-24 Thread via GitHub
gerlowskija commented on code in PR #2479: URL: https://github.com/apache/solr/pull/2479#discussion_r1773493224 ## solr/solr-ref-guide/modules/query-guide/pages/stream-tool.adoc: ## @@ -71,13 +72,15 @@ CORSAIR ValueSelect 1GB 184-Pin DDR SDRAM Unbuffered DDR 400 (PC 3200) Syste

Re: [PR] SOLR-14673: Add bin/solr stream CLI [solr]

2024-09-24 Thread via GitHub
gerlowskija commented on code in PR #2479: URL: https://github.com/apache/solr/pull/2479#discussion_r1773483777 ## solr/solr-ref-guide/modules/query-guide/pages/stream-tool.adoc: ## @@ -0,0 +1,167 @@ += Stream Tool +// Licensed to the Apache Software Foundation (ASF) under one +

Re: [PR] SOLR-17442: Resolve -v flag conflict (version, value, verbose) [solr]

2024-09-24 Thread via GitHub
malliaridis commented on PR #2721: URL: https://github.com/apache/solr/pull/2721#issuecomment-2371449034 `-d` is one of the conflicting flags that we have to resolve anyway. I would prefer only the long variant in that case, which may be either `debug` or `verbose`, both are fine and when t

Re: [PR] SOLR-17442: Resolve -v flag conflict (version, value, verbose) [solr]

2024-09-24 Thread via GitHub
epugh commented on PR #2721: URL: https://github.com/apache/solr/pull/2721#issuecomment-2371420084 > > I forgot to mention in the ticket that introducing `-d` for `debug` may require further deprecations where `-d` is used for other options as well. > > I am wondering if we should jus

Re: [PR] SOLR-17442: Resolve -v flag conflict (version, value, verbose) [solr]

2024-09-24 Thread via GitHub
epugh commented on PR #2721: URL: https://github.com/apache/solr/pull/2721#issuecomment-2371366107 > I forgot to mention in the ticket that introducing `-d` for `debug` may require further deprecations where `-d` is used for other options as well. I am wondering if we should just stic

Re: [PR] SOLR-17442: Resolve -v flag conflict (version, value, verbose) [solr]

2024-09-24 Thread via GitHub
epugh commented on code in PR #2721: URL: https://github.com/apache/solr/pull/2721#discussion_r1773412097 ## solr/core/src/java/org/apache/solr/cli/SolrCLI.java: ## @@ -148,9 +154,21 @@ public class SolrCLI implements CLIO { public static final Option OPTION_VERBOSE = Review

[jira] [Resolved] (SOLR-17459) ConfigTool does not support -scheme

2024-09-24 Thread Eric Pugh (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17459?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eric Pugh resolved SOLR-17459. -- Fix Version/s: 9.8 Resolution: Fixed > ConfigTool does not support -scheme > ---

Re: [PR] SOLR-17459: Fix unrecognized option -scheme [solr]

2024-09-24 Thread via GitHub
epugh merged PR #2722: URL: https://github.com/apache/solr/pull/2722 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

[jira] [Commented] (SOLR-17457) StatusTool does not support --max-wait-secs

2024-09-24 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17884265#comment-17884265 ] ASF subversion and git services commented on SOLR-17457: Commit 9

Re: [PR] SOLR-17457: Backport fix for max-wait-secs [solr]

2024-09-24 Thread via GitHub
epugh commented on PR #2719: URL: https://github.com/apache/solr/pull/2719#issuecomment-2371182004 Thanks @malliaridis for the back port to `branch_9_7`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] SOLR-17457: Backport fix for max-wait-secs [solr]

2024-09-24 Thread via GitHub
epugh merged PR #2719: URL: https://github.com/apache/solr/pull/2719 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

[jira] [Assigned] (SOLR-17459) ConfigTool does not support -scheme

2024-09-24 Thread Eric Pugh (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17459?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eric Pugh reassigned SOLR-17459: Assignee: Eric Pugh > ConfigTool does not support -scheme > --- >

Re: [PR] Fix bugs in bin/solr in branch_9_7 [solr]

2024-09-24 Thread via GitHub
epugh commented on code in PR #2710: URL: https://github.com/apache/solr/pull/2710#discussion_r1773243472 ## solr/packaging/test/test_create.bats: ## @@ -34,8 +34,31 @@ teardown() { assert_output --partial "Created new core 'COLL_NAME'" } +@test "create_core works" { + ru

[jira] [Commented] (SOLR-17457) StatusTool does not support --max-wait-secs

2024-09-24 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17884256#comment-17884256 ] ASF subversion and git services commented on SOLR-17457: Commit 6

Re: [PR] SOLR-17457: Scavange one change from the SOLR-17457 bug fix for main [solr]

2024-09-24 Thread via GitHub
epugh merged PR #2718: URL: https://github.com/apache/solr/pull/2718 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

[jira] [Updated] (SOLR-17459) ConfigTool does not support -scheme

2024-09-24 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17459?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated SOLR-17459: -- Labels: cli pull-request-available (was: cli) > ConfigTool does not support -scheme >

[PR] SOLR-17459: Fix unrecognized option -scheme [solr]

2024-09-24 Thread via GitHub
malliaridis opened a new pull request, #2722: URL: https://github.com/apache/solr/pull/2722 https://issues.apache.org/jira/browse/SOLR-17459 # Description This PR is a fix for the "unrecognized option: -scheme" exception thrown when using the `bin/solr config` tool. # So

[jira] [Updated] (SOLR-17459) ConfigTool does not support -scheme

2024-09-24 Thread Christos Malliaridis (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17459?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Christos Malliaridis updated SOLR-17459: Description: bin/solr adds the URL scheme to the list of arguments via the -scheme

[jira] [Created] (SOLR-17459) ConfigTool does not support -scheme

2024-09-24 Thread Christos Malliaridis (Jira)
Christos Malliaridis created SOLR-17459: --- Summary: ConfigTool does not support -scheme Key: SOLR-17459 URL: https://issues.apache.org/jira/browse/SOLR-17459 Project: Solr Issue Type: Bu

Re: [PR] SOLR-17442: Resolve -v flag conflict (version, value, verbose) [solr]

2024-09-24 Thread via GitHub
malliaridis commented on code in PR #2721: URL: https://github.com/apache/solr/pull/2721#discussion_r1772845049 ## solr/core/src/java/org/apache/solr/cli/SolrCLI.java: ## @@ -148,9 +154,21 @@ public class SolrCLI implements CLIO { public static final Option OPTION_VERBOSE =