Re: [PR] SOLR-17158 Terminate distributed processing quickly when query limit is reached [solr]

2024-09-26 Thread via GitHub
gus-asf commented on code in PR #2666: URL: https://github.com/apache/solr/pull/2666#discussion_r1778007524 ## solr/core/src/java/org/apache/solr/handler/component/ParallelHttpShardHandler.java: ## @@ -41,57 +39,78 @@ @NotThreadSafe public class ParallelHttpShardHandler extend

Re: [PR] SOLR-17448: Audit usage of ExecutorService#submit in Solr codebase [solr]

2024-09-26 Thread via GitHub
dsmiley merged PR #2707: URL: https://github.com/apache/solr/pull/2707 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.or

[jira] [Commented] (SOLR-17448) Audit usage of ExecutorService#submit in Solr codebase

2024-09-26 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17885204#comment-17885204 ] ASF subversion and git services commented on SOLR-17448: Commit 7

Re: [PR] SOLR-17158 Terminate distributed processing quickly when query limit is reached [solr]

2024-09-26 Thread via GitHub
gus-asf commented on code in PR #2666: URL: https://github.com/apache/solr/pull/2666#discussion_r1777950640 ## solr/CHANGES.txt: ## @@ -109,8 +109,11 @@ New Features Improvements - +* SOLR-17158: Users for whom partial results are uninteresting may set p

[jira] [Resolved] (SOLR-1990) blockUntilFinished() is called in StreamingUpdateSolrServer more often then it should

2024-09-26 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-1990?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Smiley resolved SOLR-1990. Fix Version/s: 4.6 Resolution: Duplicate Marking as duplicate of 2 other issues that resolved

Re: [PR] SOLR-17158 Terminate distributed processing quickly when query limit is reached [solr]

2024-09-26 Thread via GitHub
dsmiley commented on code in PR #2666: URL: https://github.com/apache/solr/pull/2666#discussion_r1776344004 ## solr/CHANGES.txt: ## @@ -109,8 +109,11 @@ New Features Improvements - +* SOLR-17158: Users for whom partial results are uninteresting may set p

Re: [PR] Benchmark: HTTP2 fix cancel_stream_error [solr]

2024-09-26 Thread via GitHub
dsmiley commented on PR #2612: URL: https://github.com/apache/solr/pull/2612#issuecomment-2378283956 This is a low priority thing; feel free to abandon this until we get to Jetty 12 and JDK 17. In the mean time, we know maxConnectionPerDestination is misconfigured to be too low; will be in

[jira] [Commented] (SOLR-17256) Remove SolrRequest.getBasePath setBasePath

2024-09-26 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17885197#comment-17885197 ] David Smiley commented on SOLR-17256: - Do we assume that the lambda doesn't need to r

[jira] [Commented] (SOLR-16470) Create V2 equivalent of V1 Replication: Get IndexVersion, Get FileStream, Get File List

2024-09-26 Thread Matthew Biscocho (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16470?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17885155#comment-17885155 ] Matthew Biscocho commented on SOLR-16470: - I guess this leads me to another quest

[jira] [Comment Edited] (SOLR-17256) Remove SolrRequest.getBasePath setBasePath

2024-09-26 Thread Jason Gerlowski (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17885154#comment-17885154 ] Jason Gerlowski edited comment on SOLR-17256 at 9/26/24 7:43 PM: --

[jira] [Comment Edited] (SOLR-17256) Remove SolrRequest.getBasePath setBasePath

2024-09-26 Thread Jason Gerlowski (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17885154#comment-17885154 ] Jason Gerlowski edited comment on SOLR-17256 at 9/26/24 7:43 PM: --

[jira] [Commented] (SOLR-17256) Remove SolrRequest.getBasePath setBasePath

2024-09-26 Thread Jason Gerlowski (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17885154#comment-17885154 ] Jason Gerlowski commented on SOLR-17256: Alright - I'd love to make some progress

[jira] [Comment Edited] (SOLR-6122) API to cancel an already submitted/running Collections API call

2024-09-26 Thread Yuntong Qu (Jira)
[ https://issues.apache.org/jira/browse/SOLR-6122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17885133#comment-17885133 ] Yuntong Qu edited comment on SOLR-6122 at 9/26/24 6:32 PM: --- "hig

[jira] [Commented] (SOLR-6122) API to cancel an already submitted/running Collections API call

2024-09-26 Thread Yuntong Qu (Jira)
[ https://issues.apache.org/jira/browse/SOLR-6122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17885133#comment-17885133 ] Yuntong Qu commented on SOLR-6122: -- "high level cancel from Overseer":  - cancel submitte

[jira] [Commented] (SOLR-5945) Add retry for zookeeper reconnect failure

2024-09-26 Thread Christos Malliaridis (Jira)
[ https://issues.apache.org/jira/browse/SOLR-5945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17885127#comment-17885127 ] Christos Malliaridis commented on SOLR-5945: This ticket seems to be related t

[jira] [Commented] (SOLR-2070) Search Grouping: single pass implementation

2024-09-26 Thread Christos Malliaridis (Jira)
[ https://issues.apache.org/jira/browse/SOLR-2070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17885119#comment-17885119 ] Christos Malliaridis commented on SOLR-2070: Parent issue closed, can this be

[jira] [Commented] (SOLR-2422) Improve reliability of ZkSolrClientTest

2024-09-26 Thread Christos Malliaridis (Jira)
[ https://issues.apache.org/jira/browse/SOLR-2422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17885126#comment-17885126 ] Christos Malliaridis commented on SOLR-2422: SolrZooKeeper was removed in SOLR

[jira] [Commented] (SOLR-2072) Search Grouping: expand group sort options

2024-09-26 Thread Christos Malliaridis (Jira)
[ https://issues.apache.org/jira/browse/SOLR-2072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17885121#comment-17885121 ] Christos Malliaridis commented on SOLR-2072: Parent issue closed, can this be

[jira] [Commented] (SOLR-2069) Search Grouping: intermediate caches

2024-09-26 Thread Christos Malliaridis (Jira)
[ https://issues.apache.org/jira/browse/SOLR-2069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17885118#comment-17885118 ] Christos Malliaridis commented on SOLR-2069: Parent issue closed, can this be

[jira] [Commented] (SOLR-2071) Search Grouping: unlikely collision implementation

2024-09-26 Thread Christos Malliaridis (Jira)
[ https://issues.apache.org/jira/browse/SOLR-2071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17885120#comment-17885120 ] Christos Malliaridis commented on SOLR-2071: Parent issue closed, can this be

[jira] [Commented] (SOLR-2067) Search Grouping: CSV response writer

2024-09-26 Thread Christos Malliaridis (Jira)
[ https://issues.apache.org/jira/browse/SOLR-2067?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17885117#comment-17885117 ] Christos Malliaridis commented on SOLR-2067: Parent issue closed, can this be

[jira] [Commented] (SOLR-1990) blockUntilFinished() is called in StreamingUpdateSolrServer more often then it should

2024-09-26 Thread Christos Malliaridis (Jira)
[ https://issues.apache.org/jira/browse/SOLR-1990?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17885115#comment-17885115 ] Christos Malliaridis commented on SOLR-1990: More checks have been added where

[jira] [Commented] (SOLR-1827) RunExecutableListener should be able to optionally capture the Error and Output Streams

2024-09-26 Thread Christos Malliaridis (Jira)
[ https://issues.apache.org/jira/browse/SOLR-1827?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17885112#comment-17885112 ] Christos Malliaridis commented on SOLR-1827: RunExecutableListener was removed

Re: [PR] SOLR-16503: New home for default http2 client [solr]

2024-09-26 Thread via GitHub
iamsanjay commented on PR #2689: URL: https://github.com/apache/solr/pull/2689#issuecomment-2377494703 We have already taken a step towards achieving immutability for Http2SolrClient by deprecating addListenerFactory. As I mentioned earlier, the next step should be to ensure that the securi

Re: [PR] SOLR-16503: New home for default http2 client [solr]

2024-09-26 Thread via GitHub
iamsanjay commented on PR #2689: URL: https://github.com/apache/solr/pull/2689#issuecomment-2377485484 Of course I am not suggesting this change for now. But still want to share my concern here. The ability to add a listener factory after initialization introduces the potential for

Re: [PR] SOLR-17448: Audit usage of ExecutorService#submit in Solr codebase [solr]

2024-09-26 Thread via GitHub
AndreyBozhko commented on code in PR #2707: URL: https://github.com/apache/solr/pull/2707#discussion_r1777433286 ## solr/core/src/java/org/apache/solr/handler/admin/PrepRecoveryOp.java: ## @@ -191,11 +195,6 @@ public void execute(CallInfo it) throws Exception {

[jira] [Commented] (SOLR-16470) Create V2 equivalent of V1 Replication: Get IndexVersion, Get FileStream, Get File List

2024-09-26 Thread Matthew Biscocho (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16470?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17885092#comment-17885092 ] Matthew Biscocho commented on SOLR-16470: - Ah ok, think I figured it out. Not a r

Re: [PR] SOLR-17448: Audit usage of ExecutorService#submit in Solr codebase [solr]

2024-09-26 Thread via GitHub
AndreyBozhko commented on code in PR #2707: URL: https://github.com/apache/solr/pull/2707#discussion_r1777421635 ## solr/CHANGES.txt: ## @@ -163,6 +163,8 @@ Other Changes * SOLR-17142: Fix Gradle build sometimes gives spurious "unreferenced license file" warnings. (Uwe Schin

Re: [PR] SOLR-17448: Audit usage of ExecutorService#submit in Solr codebase [solr]

2024-09-26 Thread via GitHub
AndreyBozhko commented on code in PR #2707: URL: https://github.com/apache/solr/pull/2707#discussion_r1777421365 ## solr/test-framework/src/java/org/apache/solr/cloud/AbstractFullDistribZkTestBase.java: ## @@ -1981,29 +1981,18 @@ protected void destroyServers() throws Exception

Re: [PR] Benchmark: HTTP2 fix cancel_stream_error [solr]

2024-09-26 Thread via GitHub
HoustonPutman commented on PR #2612: URL: https://github.com/apache/solr/pull/2612#issuecomment-2377364632 Thanks for getting those numbers, very interesting that it had no effect. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitH

Re: [PR] SOLR-17158 Terminate distributed processing quickly when query limit is reached [solr]

2024-09-26 Thread via GitHub
gus-asf commented on code in PR #2666: URL: https://github.com/apache/solr/pull/2666#discussion_r1777385925 ## solr/core/src/java/org/apache/solr/handler/component/ParallelHttpShardHandler.java: ## @@ -41,57 +39,78 @@ @NotThreadSafe public class ParallelHttpShardHandler extend

[jira] [Updated] (SOLR-17463) Solr hanging at SolrCore.getSearcher

2024-09-26 Thread Jerry Chung (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17463?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jerry Chung updated SOLR-17463: --- Labels: deadlock metrics monitoring (was: ) > Solr hanging at SolrCore.getSearcher > ---

[jira] [Created] (SOLR-17463) Solr hanging at SolrCore.getSearcher

2024-09-26 Thread Jerry Chung (Jira)
Jerry Chung created SOLR-17463: -- Summary: Solr hanging at SolrCore.getSearcher Key: SOLR-17463 URL: https://issues.apache.org/jira/browse/SOLR-17463 Project: Solr Issue Type: Bug Security

[jira] [Comment Edited] (SOLR-17060) CoreContainer#create may deadlock with concurrent requests for metrics

2024-09-26 Thread Jerry Chung (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17060?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17885027#comment-17885027 ] Jerry Chung edited comment on SOLR-17060 at 9/26/24 2:54 PM: -

[jira] [Commented] (SOLR-16470) Create V2 equivalent of V1 Replication: Get IndexVersion, Get FileStream, Get File List

2024-09-26 Thread Jason Gerlowski (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16470?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17885038#comment-17885038 ] Jason Gerlowski commented on SOLR-16470: Huh - I'm not sure this "before" behavio

[jira] [Commented] (SOLR-6122) API to cancel an already submitted/running Collections API call

2024-09-26 Thread Jason Gerlowski (Jira)
[ https://issues.apache.org/jira/browse/SOLR-6122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17885048#comment-17885048 ] Jason Gerlowski commented on SOLR-6122: --- I think I agree that canceling "core-level"

[jira] [Commented] (SOLR-16470) Create V2 equivalent of V1 Replication: Get IndexVersion, Get FileStream, Get File List

2024-09-26 Thread Matthew Biscocho (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16470?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17885045#comment-17885045 ] Matthew Biscocho commented on SOLR-16470: - Not much documentation around this API

Re: [PR] SOLR-17158 Terminate distributed processing quickly when query limit is reached [solr]

2024-09-26 Thread via GitHub
gerlowskija commented on code in PR #2666: URL: https://github.com/apache/solr/pull/2666#discussion_r1777144114 ## solr/core/src/java/org/apache/solr/handler/component/ParallelHttpShardHandler.java: ## @@ -41,57 +39,78 @@ @NotThreadSafe public class ParallelHttpShardHandler ex

Re: [PR] SOLR-17150: Create MemAllowedLimit [solr]

2024-09-26 Thread via GitHub
sigram commented on code in PR #2708: URL: https://github.com/apache/solr/pull/2708#discussion_r1777173213 ## solr/solr-ref-guide/modules/query-guide/pages/common-query-parameters.adoc: ## @@ -382,11 +382,20 @@ This parameter specifies the amount of CPU time, in milliseconds, a

Re: [PR] SOLR-17150: Create MemAllowedLimit [solr]

2024-09-26 Thread via GitHub
sigram commented on code in PR #2708: URL: https://github.com/apache/solr/pull/2708#discussion_r1777168448 ## solr/solr-ref-guide/modules/query-guide/pages/common-query-parameters.adoc: ## @@ -382,11 +382,20 @@ This parameter specifies the amount of CPU time, in milliseconds, a

Re: [PR] SOLR-17150: Create MemAllowedLimit [solr]

2024-09-26 Thread via GitHub
sigram commented on code in PR #2708: URL: https://github.com/apache/solr/pull/2708#discussion_r1777165905 ## solr/core/src/java/org/apache/solr/search/MemAllowedLimit.java: ## @@ -0,0 +1,130 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contr

Re: [PR] SOLR-17158 Terminate distributed processing quickly when query limit is reached [solr]

2024-09-26 Thread via GitHub
gerlowskija commented on code in PR #2666: URL: https://github.com/apache/solr/pull/2666#discussion_r1777144114 ## solr/core/src/java/org/apache/solr/handler/component/ParallelHttpShardHandler.java: ## @@ -41,57 +39,78 @@ @NotThreadSafe public class ParallelHttpShardHandler ex

[jira] [Commented] (SOLR-16470) Create V2 equivalent of V1 Replication: Get IndexVersion, Get FileStream, Get File List

2024-09-26 Thread Matthew Biscocho (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16470?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17885029#comment-17885029 ] Matthew Biscocho commented on SOLR-16470: - Np. Just spinning up a new core and cu

Re: [PR] SOLR-17158 Terminate distributed processing quickly when query limit is reached [solr]

2024-09-26 Thread via GitHub
gerlowskija commented on code in PR #2666: URL: https://github.com/apache/solr/pull/2666#discussion_r1777144114 ## solr/core/src/java/org/apache/solr/handler/component/ParallelHttpShardHandler.java: ## @@ -41,57 +39,78 @@ @NotThreadSafe public class ParallelHttpShardHandler ex

[jira] [Comment Edited] (SOLR-6122) API to cancel an already submitted/running Collections API call

2024-09-26 Thread Yuntong Qu (Jira)
[ https://issues.apache.org/jira/browse/SOLR-6122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17884755#comment-17884755 ] Yuntong Qu edited comment on SOLR-6122 at 9/26/24 1:53 PM: --- I've

[jira] [Commented] (SOLR-16470) Create V2 equivalent of V1 Replication: Get IndexVersion, Get FileStream, Get File List

2024-09-26 Thread Jason Gerlowski (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16470?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17885026#comment-17885026 ] Jason Gerlowski commented on SOLR-16470: Ugh, OK, thanks for finding this Matt!

[jira] [Commented] (SOLR-17060) CoreContainer#create may deadlock with concurrent requests for metrics

2024-09-26 Thread Jerry Chung (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17060?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17885027#comment-17885027 ] Jerry Chung commented on SOLR-17060: It didn't seem to be fixed fully. We are still o

[jira] [Updated] (SOLR-17441) MetricUtils optimization: skip unreadable properties

2024-09-26 Thread Haythem Khiri (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17441?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Haythem Khiri updated SOLR-17441: - Description: This change enhances the property introspection logic in the addMXBeanMetrics metho

Re: [PR] Benchmark: HTTP2 fix cancel_stream_error [solr]

2024-09-26 Thread via GitHub
iamsanjay commented on PR #2612: URL: https://github.com/apache/solr/pull/2612#issuecomment-2376651527 ``` Benchmark (maxConnectionPerHost) (nodeCount) (numReplicas) (numShards) (preGenerate) (useSmallDocs) Mode Cnt Score Error Units CloudIndexing.index

Re: [PR] Blog post - Community Over Code NA 2024 (#126) [solr-site]

2024-09-26 Thread via GitHub
alessandrobenedetti merged PR #127: URL: https://github.com/apache/solr-site/pull/127 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...

[PR] Blog post - Community Over Code NA 2024 (#126) [solr-site]

2024-09-26 Thread via GitHub
alessandrobenedetti opened a new pull request, #127: URL: https://github.com/apache/solr-site/pull/127 * community over code NA new blogpost - conference -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] Blog post - Community Over Code NA 2024 [solr-site]

2024-09-26 Thread via GitHub
alessandrobenedetti merged PR #126: URL: https://github.com/apache/solr-site/pull/126 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...

Re: [PR] Benchmark: HTTP2 fix cancel_stream_error [solr]

2024-09-26 Thread via GitHub
iamsanjay commented on PR #2612: URL: https://github.com/apache/solr/pull/2612#issuecomment-2376350232 > Yes; our versions are in `versions.props` I inquired about the Jetty version because I posted a question regarding the cancel_stream error on the Jetty forum, and they informed me

Re: [PR] Benchmark: HTTP2 fix cancel_stream_error [solr]

2024-09-26 Thread via GitHub
iamsanjay commented on PR #2612: URL: https://github.com/apache/solr/pull/2612#issuecomment-237661 There should be way to provide some sort of setting by which user can control this setting and then can play with it. We do have `maxConnectionPerDestination` but that is being used by htt

Re: [PR] Benchmark: HTTP2 fix cancel_stream_error [solr]

2024-09-26 Thread via GitHub
iamsanjay commented on PR #2612: URL: https://github.com/apache/solr/pull/2612#issuecomment-2376310523 Latest Benchmark with different values for maxConnectionPerDestination ``` Benchmark (maxConnectionPerHost) (nodeCount) (numReplicas) (numShards) (preGenerate)