dsmiley commented on code in PR #2714:
URL: https://github.com/apache/solr/pull/2714#discussion_r1779367542
##
solr/solrj/src/java/org/apache/solr/client/solrj/impl/Http2SolrClient.java:
##
@@ -533,6 +535,47 @@ public NamedList request(SolrRequest
solrRequest, String collection
dsmiley commented on PR #2714:
URL: https://github.com/apache/solr/pull/2714#issuecomment-2380412814
I'm a bit uncomfortable on adding methods to SolrClient that *mostly* throw
UnsupportedOperationException for most implementations.
I added the overloaded method I spoke of in the latest c
dsmiley commented on code in PR #2697:
URL: https://github.com/apache/solr/pull/2697#discussion_r1779363345
##
solr/core/src/java/org/apache/solr/highlight/UnifiedSolrHighlighter.java:
##
@@ -314,6 +343,24 @@ protected PassageFormatter getFormatter(String fieldName) {
ret
iamsanjay commented on PR #2714:
URL: https://github.com/apache/solr/pull/2714#issuecomment-2380392415
IMO, We should stick to keep on using interface reference whereas this
change force to use concrete classes. In #2689, Something similar we faced as
we are still deciding on the type of So
Seunghan-Jung commented on code in PR #2697:
URL: https://github.com/apache/solr/pull/2697#discussion_r1779351977
##
solr/core/src/java/org/apache/solr/highlight/UnifiedSolrHighlighter.java:
##
@@ -314,6 +343,24 @@ protected PassageFormatter getFormatter(String fieldName) {
[
https://issues.apache.org/jira/browse/SOLR-17441?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Haythem Khiri updated SOLR-17441:
-
Attachment: Screenshot 2024-09-27 at 11.28.28.png
> MetricUtils optimization: skip unreadable pro
[
https://issues.apache.org/jira/browse/SOLR-17441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17885485#comment-17885485
]
Haythem Khiri commented on SOLR-17441:
--
Thanks David. Good to know!
> MetricUtils o
[
https://issues.apache.org/jira/browse/SOLR-1827?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Eric Pugh resolved SOLR-1827.
-
Resolution: Won't Do
> RunExecutableListener should be able to optionally capture the Error and
> Output
gerlowskija opened a new pull request, #2723:
URL: https://github.com/apache/solr/pull/2723
# Description
The 'solr.v2RealPath' system property was used to control how SolrJ built v2
API paths, seemingly as a workaround to allow certain tests to work which
didn't at the time use a fu
gerlowskija commented on PR #2723:
URL: https://github.com/apache/solr/pull/2723#issuecomment-2379237802
Hit a few snags when testing this as it looks like there some tests are 100%
broken on 'main' (i.e. without this PR). Leaving this comment as a reminder to
myself to run tests again clo
[
https://issues.apache.org/jira/browse/SOLR-2070?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Eric Pugh resolved SOLR-2070.
-
Resolution: Abandoned
> Search Grouping: single pass implementation
>
gerlowskija commented on PR #2714:
URL: https://github.com/apache/solr/pull/2714#issuecomment-2380057207
Alright, I've updated the PR to get rid of the thread-local which folks
didn't like.
For now the method is available on Http2SolrClient specifically - I'd love
to see this spread
[
https://issues.apache.org/jira/browse/SOLR-17454?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17885467#comment-17885467
]
ASF subversion and git services commented on SOLR-17454:
Commit 0
[
https://issues.apache.org/jira/browse/SOLR-17065?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17885476#comment-17885476
]
ASF subversion and git services commented on SOLR-17065:
Commit 9
dsmiley commented on code in PR #2697:
URL: https://github.com/apache/solr/pull/2697#discussion_r1779120744
##
solr/core/src/java/org/apache/solr/highlight/UnifiedSolrHighlighter.java:
##
@@ -314,6 +343,24 @@ protected PassageFormatter getFormatter(String fieldName) {
ret
dsmiley commented on code in PR #2724:
URL: https://github.com/apache/solr/pull/2724#discussion_r1779101220
##
solr/solrj/src/java/org/apache/solr/client/solrj/SolrClient.java:
##
@@ -1225,4 +1228,30 @@ public SolrRequest.SolrClientContext getContext() {
public String getDefa
dsmiley commented on PR #2704:
URL: https://github.com/apache/solr/pull/2704#issuecomment-2379994879
If you didn't know, the word "tracing" is an industry word nowadays, and
Solr has it but this PR isn't using it :-)
--
This is an automated message from the Apache Git Service.
To respond
[
https://issues.apache.org/jira/browse/SOLR-17454?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17885470#comment-17885470
]
ASF subversion and git services commented on SOLR-17454:
Commit f
[
https://issues.apache.org/jira/browse/SOLR-17454?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Smiley resolved SOLR-17454.
-
Resolution: Fixed
Thanks Andrew!
> ERROR message in logs with multithreaded searches
> -
dsmiley merged PR #2720:
URL: https://github.com/apache/solr/pull/2720
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.or
[
https://issues.apache.org/jira/browse/SOLR-17414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17885462#comment-17885462
]
David Smiley commented on SOLR-17414:
-
(PR is ready)
> multiThreaded=true can result
[
https://issues.apache.org/jira/browse/SOLR-17065?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17885465#comment-17885465
]
ASF subversion and git services commented on SOLR-17065:
Commit 8
HoustonPutman merged PR #2062:
URL: https://github.com/apache/solr/pull/2062
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apa
dsmiley commented on PR #2701:
URL: https://github.com/apache/solr/pull/2701#issuecomment-2379925519
Barring benchmarks & CHANGES.txt, I think this is ready to merge.
I changed to using a blocking strategy instead of caller-runs. It should be
easier to manage a Solr node's CPU consum
[
https://issues.apache.org/jira/browse/SOLR-17441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17885458#comment-17885458
]
David Smiley commented on SOLR-17441:
-
FYI Solr has a great "benchmark" module, and i
HoustonPutman commented on PR #2062:
URL: https://github.com/apache/solr/pull/2062#issuecomment-2379845505
We can't upgrade to kafka 3.8.0, because of
https://issues.apache.org/jira/browse/KAFKA-17227, but 3.8.1 will be released
in early october and we should be good to upgrade to that.
-
[
https://issues.apache.org/jira/browse/SOLR-17065?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated SOLR-17065:
--
Labels: pull-request-available (was: )
> Migrate Sandbox CrossDC functionality into Solr
> ---
[
https://issues.apache.org/jira/browse/SOLR-2422?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Eric Pugh resolved SOLR-2422.
-
Resolution: Not A Problem
> Improve reliability of ZkSolrClientTest
>
dsmiley merged PR #2694:
URL: https://github.com/apache/solr/pull/2694
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.or
[
https://issues.apache.org/jira/browse/SOLR-2067?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Eric Pugh resolved SOLR-2067.
-
Resolution: Abandoned
> Search Grouping: CSV response writer
>
>
>
[
https://issues.apache.org/jira/browse/SOLR-2069?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Eric Pugh resolved SOLR-2069.
-
Resolution: Abandoned
> Search Grouping: intermediate caches
>
>
>
[
https://issues.apache.org/jira/browse/SOLR-2071?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Eric Pugh resolved SOLR-2071.
-
Resolution: Abandoned
> Search Grouping: unlikely collision implementation
> -
[
https://issues.apache.org/jira/browse/SOLR-17464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17885437#comment-17885437
]
Jason Gerlowski commented on SOLR-17464:
FYI [~jdyer] - I think you helped with t
[
https://issues.apache.org/jira/browse/SOLR-17464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17885434#comment-17885434
]
Jason Gerlowski commented on SOLR-17464:
One potential fix would be for the "reus
[
https://issues.apache.org/jira/browse/SOLR-17464?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jason Gerlowski updated SOLR-17464:
---
Labels: newdev (was: )
> Http2SolrClient.requestAsync triggers NPE when using a shared Jetty
Jason Gerlowski created SOLR-17464:
--
Summary: Http2SolrClient.requestAsync triggers NPE when using a
shared Jetty client
Key: SOLR-17464
URL: https://issues.apache.org/jira/browse/SOLR-17464
Project:
[
https://issues.apache.org/jira/browse/SOLR-17464?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jason Gerlowski updated SOLR-17464:
---
Affects Version/s: main (10.0)
9.7
> Http2SolrClient.requestAsync trig
iamsanjay opened a new pull request, #2724:
URL: https://github.com/apache/solr/pull/2724
This PR introduces an abstract requestAsync method in the SolrClient class
to provide a unified and symmetrical API for asynchronous requests across
different implementations of SolrClient. The method
[
https://issues.apache.org/jira/browse/SOLR-17441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17885287#comment-17885287
]
Haythem Khiri edited comment on SOLR-17441 at 9/27/24 10:29 AM:
---
gerlowskija commented on code in PR #2714:
URL: https://github.com/apache/solr/pull/2714#discussion_r1778725864
##
solr/solrj/src/java/org/apache/solr/client/solrj/impl/Http2SolrClient.java:
##
@@ -533,6 +534,25 @@ public NamedList request(SolrRequest
solrRequest, String collec
gerlowskija commented on code in PR #2714:
URL: https://github.com/apache/solr/pull/2714#discussion_r1778714874
##
solr/solrj/src/java/org/apache/solr/client/solrj/SolrClient.java:
##
@@ -1194,6 +1194,17 @@ public final NamedList request(final
SolrRequest request)
return r
[
https://issues.apache.org/jira/browse/SOLR-17441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17885287#comment-17885287
]
Haythem Khiri edited comment on SOLR-17441 at 9/27/24 1:39 PM:
[
https://issues.apache.org/jira/browse/SOLR-17256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17885376#comment-17885376
]
Jason Gerlowski commented on SOLR-17256:
bq. Do we assume that the lambda doesn't
gerlowskija commented on PR #2723:
URL: https://github.com/apache/solr/pull/2723#issuecomment-2379235413
FYI @dsmiley - I know you commented on the weird v2RealPath stuff somewhere
recently...
--
This is an automated message from the Apache Git Service.
To respond to the message, please l
dsmiley commented on code in PR #2666:
URL: https://github.com/apache/solr/pull/2666#discussion_r1778547978
##
solr/CHANGES.txt:
##
@@ -109,8 +109,11 @@ New Features
Improvements
-
+* SOLR-17158: Users for whom partial results are uninteresting may set
p
[
https://issues.apache.org/jira/browse/SOLR-17441?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Smiley resolved SOLR-17441.
-
Fix Version/s: 9.8
Resolution: Fixed
Nice; thanks Haythem!
> MetricUtils optimization: sk
[
https://issues.apache.org/jira/browse/SOLR-17441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17885351#comment-17885351
]
ASF subversion and git services commented on SOLR-17441:
Commit f
[
https://issues.apache.org/jira/browse/SOLR-17441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17885349#comment-17885349
]
ASF subversion and git services commented on SOLR-17441:
Commit e
[
https://issues.apache.org/jira/browse/SOLR-17448?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Smiley resolved SOLR-17448.
-
Fix Version/s: 9.8
Resolution: Fixed
Also back ported to 9.8 –
[24bd803|https://github.co
[
https://issues.apache.org/jira/browse/SOLR-17441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17885287#comment-17885287
]
Haythem Khiri edited comment on SOLR-17441 at 9/27/24 9:34 AM:
[
https://issues.apache.org/jira/browse/SOLR-17441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17885287#comment-17885287
]
Haythem Khiri edited comment on SOLR-17441 at 9/27/24 9:35 AM:
[
https://issues.apache.org/jira/browse/SOLR-17441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17885287#comment-17885287
]
Haythem Khiri commented on SOLR-17441:
--
Run locally a naive benchmark, after Solr wa
[
https://issues.apache.org/jira/browse/SOLR-17441?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Haythem Khiri updated SOLR-17441:
-
Attachment: Screenshot 2024-09-27 at 11.28.51.png
> MetricUtils optimization: skip unreadable pro
[
https://issues.apache.org/jira/browse/SOLR-17441?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Haythem Khiri updated SOLR-17441:
-
Description: The _/solr/admin/info/system_ endpoint, used by the Solr
Operator for start-up and l
[
https://issues.apache.org/jira/browse/SOLR-17441?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Haythem Khiri updated SOLR-17441:
-
Description: The {{/solr/admin/info/system}} endpoint, used by the Solr
Operator for start-up and
cpoerschke commented on code in PR #2248:
URL: https://github.com/apache/solr/pull/2248#discussion_r1778193207
##
solr/core/src/java/org/apache/solr/search/MultiThreadedSearcher.java:
##
@@ -0,0 +1,423 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
56 matches
Mail list logo
