andywebb1975 commented on PR #1324:
URL: https://github.com/apache/solr/pull/1324#issuecomment-1458609616
superseded by https://github.com/apache/solr/pull/1431
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL a
andywebb1975 commented on PR #1324:
URL: https://github.com/apache/solr/pull/1324#issuecomment-1454711385
I've made a new PR introducing both options:
https://github.com/apache/solr/pull/1431 - could you give that a review please?
(It felt cleaner to raise a new PR, though now I'm not
andywebb1975 commented on PR #1324:
URL: https://github.com/apache/solr/pull/1324#issuecomment-1454682268
I have committer rights now - a massive thank you if you were involved in
arranging this!
I'm wondering whether to merge this as-is, or supersede it with a version
including a `r
andywebb1975 commented on PR #1324:
URL: https://github.com/apache/solr/pull/1324#issuecomment-1435271833
> ok. @andywebb1975 I noticed your contributor label! Can you squash-merge
it on your own?
Sure, have just squashed it. I'm just a contributor - don't have committer
rights, if t
andywebb1975 commented on PR #1324:
URL: https://github.com/apache/solr/pull/1324#issuecomment-1435108644
> Oh.. somehow, I stepped in CHANGES. Colleagues, would you mind approve or
point on some stuff to improve?
Is there anything I can do to help here? The update looks fine to me.
andywebb1975 commented on PR #1324:
URL: https://github.com/apache/solr/pull/1324#issuecomment-1433376588
> Hi, @andywebb1975 . I pushed commit replacing switch to closure in doc
scoring loop. Please have a look. WDYT?
Thanks @mkhludnev - yes, that does look cleaner!
--
This is an
andywebb1975 commented on PR #1324:
URL: https://github.com/apache/solr/pull/1324#issuecomment-1419588565
I've updated this to use an `enum` following one of the examples above - how
does it look now?
(I've seen `gradlew check` work locally but Crave.io seems to be having
issues :-(
