anshumg commented on code in PR #796:
URL: https://github.com/apache/solr/pull/796#discussion_r848565568
##########
solr/core/src/java/org/apache/solr/search/Grouping.java:
##########
@@ -461,7 +461,16 @@ private void searchWithTimeLimiter(final Query
filterQuery, Collector collector)
searcher.search(QueryUtils.combineQueryAndFilter(query, filterQuery),
collector);
} catch (TimeLimitingCollector.TimeExceededException
| ExitableDirectoryReader.ExitingReaderException x) {
- log.warn("Query: {}; ", query, x);
+ if (log.isWarnEnabled()) {
+ String queryToLog = query.toString();
+ if (queryToLog.length() > 1000) {
+ // INFO log long queries separately
+ log.info("Query: {}; ", query);
Review Comment:
did you intend to log an `info` line inside the `.isWarnEnabled` block ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
