[GitHub] [solr] cpoerschke commented on a diff in pull request #96: SOLR-15056: add circuit breaker for CPU, fix load circuit breaker

cpoerschke commented on code in PR #96: URL: https://github.com/apache/solr/pull/96#discussion_r1327156515 ## solr/core/src/java/org/apache/solr/util/circuitbreaker/LoadAverageCircuitBreaker.java: ## @@ -0,0 +1,109 @@ +/* + * Licensed to the Apache Software Foundation (ASF) unde

[GitHub] [solr] cpoerschke commented on a diff in pull request #96: SOLR-15056: add circuit breaker for CPU, fix load circuit breaker

cpoerschke commented on code in PR #96: URL: https://github.com/apache/solr/pull/96#discussion_r1311918794 ## solr/core/src/java/org/apache/solr/util/circuitbreaker/CPUCircuitBreaker.java: ## @@ -17,54 +17,49 @@ package org.apache.solr.util.circuitbreaker; +import com.codah

[GitHub] [solr] cpoerschke commented on a diff in pull request #96: SOLR-15056: add circuit breaker for CPU, fix load circuit breaker

cpoerschke commented on code in PR #96: URL: https://github.com/apache/solr/pull/96#discussion_r1310558195 ## solr/core/src/java/org/apache/solr/util/circuitbreaker/CPUCircuitBreaker.java: ## @@ -17,54 +17,49 @@ package org.apache.solr.util.circuitbreaker; +import com.codah

[GitHub] [solr] cpoerschke commented on a diff in pull request #96: SOLR-15056: add circuit breaker for CPU, fix load circuit breaker

cpoerschke commented on code in PR #96: URL: https://github.com/apache/solr/pull/96#discussion_r1310541536 ## solr/core/src/java/org/apache/solr/util/circuitbreaker/CircuitBreakerManager.java: ## @@ -86,7 +86,8 @@ public void init(NamedList args) { memCB.setThreshold(memT

[GitHub] [solr] cpoerschke commented on a diff in pull request #96: SOLR-15056: add circuit breaker for CPU, fix load circuit breaker

cpoerschke commented on code in PR #96: URL: https://github.com/apache/solr/pull/96#discussion_r1310549161 ## solr/core/src/java/org/apache/solr/util/circuitbreaker/CPUCircuitBreaker.java: ## @@ -96,11 +91,46 @@ public String getErrorMessage() { + allowedCPUUsage.get();

[GitHub] [solr] cpoerschke commented on a diff in pull request #96: SOLR-15056: add circuit breaker for CPU, fix load circuit breaker

cpoerschke commented on code in PR #96: URL: https://github.com/apache/solr/pull/96#discussion_r1310547379 ## solr/core/src/java/org/apache/solr/util/circuitbreaker/CPUCircuitBreaker.java: ## @@ -17,54 +17,49 @@ package org.apache.solr.util.circuitbreaker; +import com.codah