[GitHub] [solr] danrosher commented on pull request #989: SOLR-16361 'mod' function query casts to float, returns wrong modulus for large ints

2022-09-16 Thread GitBox
danrosher commented on PR #989: URL: https://github.com/apache/solr/pull/989#issuecomment-1249118320 > Nice work! Can you add a CHANGES.txt entry under 9.1 improvements -- like "mod() is now accurate with even higher integers above 123456789" Thanks! Added entry to CHANGES.txt --

[GitHub] [solr] danrosher commented on pull request #989: SOLR-16361 'mod' function query casts to float, returns wrong modulus for large ints

2022-08-31 Thread GitBox
danrosher commented on PR #989: URL: https://github.com/apache/solr/pull/989#issuecomment-1232980804 > Any chance of a unit test demonstrating the problem? It looks like all reasonable Java code, but it would help me see the unit test demonstrating the problem, and then the fix! Adde