[GitHub] [solr] dsmiley commented on a change in pull request #264: SOLR-10887: Append .xml to managed-schema file

2021-08-27 Thread GitBox
dsmiley commented on a change in pull request #264: URL: https://github.com/apache/solr/pull/264#discussion_r697653753 ## File path: solr/core/src/java/org/apache/solr/core/SolrResourceLoader.java ## @@ -342,7 +342,7 @@ private Path checkPathIsSafe(Path pathToCheck) throws IOE

[GitHub] [solr] dsmiley commented on a change in pull request #264: SOLR-10887: Append .xml to managed-schema file

2021-08-23 Thread GitBox
dsmiley commented on a change in pull request #264: URL: https://github.com/apache/solr/pull/264#discussion_r694333269 ## File path: solr/core/src/java/org/apache/solr/schema/ManagedIndexSchemaFactory.java ## @@ -74,12 +75,12 @@ public void init(NamedList args) { args.rem

[GitHub] [solr] dsmiley commented on a change in pull request #264: SOLR-10887: Append .xml to managed-schema file

2021-08-23 Thread GitBox
dsmiley commented on a change in pull request #264: URL: https://github.com/apache/solr/pull/264#discussion_r694332486 ## File path: solr/core/src/java/org/apache/solr/schema/ManagedIndexSchemaFactory.java ## @@ -195,7 +223,16 @@ private InputStream readSchemaLocally() {

[GitHub] [solr] dsmiley commented on a change in pull request #264: SOLR-10887: Append .xml to managed-schema file

2021-08-23 Thread GitBox
dsmiley commented on a change in pull request #264: URL: https://github.com/apache/solr/pull/264#discussion_r694305186 ## File path: solr/core/src/java/org/apache/solr/schema/ManagedIndexSchemaFactory.java ## @@ -91,6 +92,33 @@ public void init(NamedList args) { public Stri

[GitHub] [solr] dsmiley commented on a change in pull request #264: SOLR-10887: Append .xml to managed-schema file

2021-08-23 Thread GitBox
dsmiley commented on a change in pull request #264: URL: https://github.com/apache/solr/pull/264#discussion_r694311373 ## File path: solr/core/src/test/org/apache/solr/handler/admin/ShowFileRequestHandlerTest.java ## @@ -84,7 +84,7 @@ public void testDirList() throws SolrServe

[GitHub] [solr] dsmiley commented on a change in pull request #264: SOLR-10887: Append .xml to managed-schema file

2021-08-21 Thread GitBox
dsmiley commented on a change in pull request #264: URL: https://github.com/apache/solr/pull/264#discussion_r693444308 ## File path: solr/core/src/java/org/apache/solr/schema/ManagedIndexSchemaFactory.java ## @@ -91,6 +92,33 @@ public void init(NamedList args) { public Stri

[GitHub] [solr] dsmiley commented on a change in pull request #264: SOLR-10887: Append .xml to managed-schema file

2021-08-21 Thread GitBox
dsmiley commented on a change in pull request #264: URL: https://github.com/apache/solr/pull/264#discussion_r693439374 ## File path: solr/core/src/java/org/apache/solr/schema/ManagedIndexSchemaFactory.java ## @@ -195,7 +223,16 @@ private InputStream readSchemaLocally() {