dsmiley commented on a change in pull request #324:
URL: https://github.com/apache/solr/pull/324#discussion_r794173884
##
File path: solr/core/src/java/org/apache/solr/update/UpdateHandler.java
##
@@ -115,12 +115,12 @@ public UpdateHandler(SolrCore core, UpdateLog updateLog)
dsmiley commented on a change in pull request #324:
URL: https://github.com/apache/solr/pull/324#discussion_r792281270
##
File path: solr/core/src/java/org/apache/solr/update/UpdateHandler.java
##
@@ -115,12 +115,9 @@ public UpdateHandler(SolrCore core, UpdateLog updateLog) {
dsmiley commented on a change in pull request #324:
URL: https://github.com/apache/solr/pull/324#discussion_r790960401
##
File path: solr/core/src/java/org/apache/solr/update/UpdateHandler.java
##
@@ -115,12 +115,9 @@ public UpdateHandler(SolrCore core, UpdateLog updateLog) {
dsmiley commented on a change in pull request #324:
URL: https://github.com/apache/solr/pull/324#discussion_r736055291
##
File path: solr/test-framework/src/java/org/apache/solr/handler/package.html
##
@@ -0,0 +1,24 @@
+
+
+
Review comment:
I'm okay with a sub-package,
dsmiley commented on a change in pull request #324:
URL: https://github.com/apache/solr/pull/324#discussion_r730321435
##
File path: solr/contrib/hdfs/build.gradle
##
@@ -0,0 +1,56 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor lic
dsmiley commented on a change in pull request #324:
URL: https://github.com/apache/solr/pull/324#discussion_r734924006
##
File path: solr/contrib/hdfs/build.gradle
##
@@ -0,0 +1,56 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor lic
dsmiley commented on a change in pull request #324:
URL: https://github.com/apache/solr/pull/324#discussion_r730319754
##
File path: solr/contrib/README.md
##
@@ -0,0 +1,31 @@
+Apache Solr HDFS Contrib module
+===
+
+Introduction
+
+This
dsmiley commented on a change in pull request #324:
URL: https://github.com/apache/solr/pull/324#discussion_r730319810
##
File path: solr/contrib/hdfs/.gitignore
##
@@ -0,0 +1,2 @@
+# IDEA project file
+hdfs.iml
Review comment:
Remove please; this is not specific to thi
