[GitHub] [solr] dsmiley commented on a change in pull request #529: SOLR-15257 Add DocSetQuery in lieu of DocSet.getTopFilter

2022-01-25 Thread GitBox
dsmiley commented on a change in pull request #529: URL: https://github.com/apache/solr/pull/529#discussion_r791125848 ## File path: solr/core/src/java/org/apache/solr/search/BitDocSet.java ## @@ -311,72 +307,8 @@ public long cost() { }; } - @Override - public Filte

[GitHub] [solr] dsmiley commented on a change in pull request #529: SOLR-15257 Add DocSetQuery in lieu of DocSet.getTopFilter

2022-01-24 Thread GitBox
dsmiley commented on a change in pull request #529: URL: https://github.com/apache/solr/pull/529#discussion_r791125848 ## File path: solr/core/src/java/org/apache/solr/search/BitDocSet.java ## @@ -311,72 +307,8 @@ public long cost() { }; } - @Override - public Filte

[GitHub] [solr] dsmiley commented on a change in pull request #529: SOLR-15257 Add DocSetQuery in lieu of DocSet.getTopFilter

2022-01-21 Thread GitBox
dsmiley commented on a change in pull request #529: URL: https://github.com/apache/solr/pull/529#discussion_r789901078 ## File path: solr/core/src/java/org/apache/solr/search/DocSet.java ## @@ -117,11 +118,11 @@ public int andNotSize(DocSet other) { } /** - * Returns

[GitHub] [solr] dsmiley commented on a change in pull request #529: SOLR-15257 Add DocSetQuery in lieu of DocSet.getTopFilter

2022-01-21 Thread GitBox
dsmiley commented on a change in pull request #529: URL: https://github.com/apache/solr/pull/529#discussion_r789897875 ## File path: solr/contrib/analytics/src/java/org/apache/solr/analytics/facet/RangeFacet.java ## @@ -54,7 +53,7 @@ public RangeFacet(String name, SchemaField

[GitHub] [solr] dsmiley commented on a change in pull request #529: SOLR-15257 Add DocSetQuery in lieu of DocSet.getTopFilter

2022-01-21 Thread GitBox
dsmiley commented on a change in pull request #529: URL: https://github.com/apache/solr/pull/529#discussion_r789897662 ## File path: solr/contrib/analytics/src/java/org/apache/solr/analytics/facet/AbstractSolrQueryFacet.java ## @@ -50,11 +49,11 @@ protected AbstractSolrQueryFa

[GitHub] [solr] dsmiley commented on a change in pull request #529: SOLR-15257 Add DocSetQuery in lieu of DocSet.getTopFilter

2022-01-18 Thread GitBox
dsmiley commented on a change in pull request #529: URL: https://github.com/apache/solr/pull/529#discussion_r787319124 ## File path: solr/core/src/java/org/apache/solr/search/DocSetQuery.java ## @@ -0,0 +1,76 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one