[GitHub] [solr] dsmiley commented on a diff in pull request #1012: SOLR-16368: Use SolrClient type instead of overly specific subclasses

2022-10-12 Thread GitBox
dsmiley commented on code in PR #1012: URL: https://github.com/apache/solr/pull/1012#discussion_r993854042 ## solr/solrj/src/java/org/apache/solr/client/solrj/io/stream/TopicStream.java: ## @@ -509,7 +509,7 @@ private void getPersistedCheckpoints() throws IOException { fo

[GitHub] [solr] dsmiley commented on a diff in pull request #1012: SOLR-16368: Use SolrClient type instead of overly specific subclasses

2022-10-11 Thread GitBox
dsmiley commented on code in PR #1012: URL: https://github.com/apache/solr/pull/1012#discussion_r992765842 ## solr/solrj/src/java/org/apache/solr/client/solrj/io/SolrClientCache.java: ## @@ -100,10 +100,11 @@ public synchronized CloudSolrClient getCloudSolrClient(String zkHost)

[GitHub] [solr] dsmiley commented on a diff in pull request #1012: SOLR-16368: Use SolrClient type instead of overly specific subclasses

2022-10-11 Thread GitBox
dsmiley commented on code in PR #1012: URL: https://github.com/apache/solr/pull/1012#discussion_r992642897 ## solr/core/src/test/org/apache/solr/filestore/TestDistribPackageStore.java: ## @@ -309,11 +309,10 @@ public static T assertResponseValues( public static void uploadK

[GitHub] [solr] dsmiley commented on a diff in pull request #1012: SOLR-16368: Use SolrClient type instead of overly specific subclasses

2022-10-11 Thread GitBox
dsmiley commented on code in PR #1012: URL: https://github.com/apache/solr/pull/1012#discussion_r992564452 ## solr/core/src/test/org/apache/solr/filestore/TestDistribPackageStore.java: ## @@ -309,11 +309,10 @@ public static T assertResponseValues( public static void uploadK

[GitHub] [solr] dsmiley commented on a diff in pull request #1012: SOLR-16368: Use SolrClient type instead of overly specific subclasses

2022-10-11 Thread GitBox
dsmiley commented on code in PR #1012: URL: https://github.com/apache/solr/pull/1012#discussion_r992533454 ## solr/test-framework/src/java/org/apache/solr/cloud/AbstractFullDistribZkTestBase.java: ## @@ -2747,7 +2747,7 @@ protected void waitForAllWarmingSearchers() throws Inter

[GitHub] [solr] dsmiley commented on a diff in pull request #1012: SOLR-16368: Use SolrClient type instead of overly specific subclasses

2022-10-10 Thread GitBox
dsmiley commented on code in PR #1012: URL: https://github.com/apache/solr/pull/1012#discussion_r991444078 ## solr/core/src/test/org/apache/solr/filestore/TestDistribPackageStore.java: ## @@ -192,10 +192,10 @@ public static void checkAllNodesForFile( assertResponseValues(

[GitHub] [solr] dsmiley commented on a diff in pull request #1012: SOLR-16368: Use SolrClient type instead of overly specific subclasses

2022-10-10 Thread GitBox
dsmiley commented on code in PR #1012: URL: https://github.com/apache/solr/pull/1012#discussion_r991444078 ## solr/core/src/test/org/apache/solr/filestore/TestDistribPackageStore.java: ## @@ -192,10 +192,10 @@ public static void checkAllNodesForFile( assertResponseValues(

[GitHub] [solr] dsmiley commented on a diff in pull request #1012: SOLR-16368: Use SolrClient type instead of overly specific subclasses

2022-10-08 Thread GitBox
dsmiley commented on code in PR #1012: URL: https://github.com/apache/solr/pull/1012#discussion_r990734673 ## solr/core/src/test/org/apache/solr/filestore/TestDistribPackageStore.java: ## @@ -192,10 +192,10 @@ public static void checkAllNodesForFile( assertResponseValues(

[GitHub] [solr] dsmiley commented on a diff in pull request #1012: SOLR-16368: Use SolrClient type instead of overly specific subclasses

2022-10-08 Thread GitBox
dsmiley commented on code in PR #1012: URL: https://github.com/apache/solr/pull/1012#discussion_r990734533 ## solr/core/src/test/org/apache/solr/cloud/DistributedVersionInfoTest.java: ## @@ -58,7 +56,7 @@ import org.slf4j.Logger; import org.slf4j.LoggerFactory; -@LuceneTestC

[GitHub] [solr] dsmiley commented on a diff in pull request #1012: SOLR-16368: Use SolrClient type instead of overly specific subclasses

2022-10-08 Thread GitBox
dsmiley commented on code in PR #1012: URL: https://github.com/apache/solr/pull/1012#discussion_r990733430 ## solr/core/src/java/org/apache/solr/packagemanager/RepositoryManager.java: ## @@ -141,7 +141,7 @@ public void addKey(byte[] key, String destinationKeyFilename) throws Ex

[GitHub] [solr] dsmiley commented on a diff in pull request #1012: SOLR-16368: Use SolrClient type instead of overly specific subclasses

2022-09-15 Thread GitBox
dsmiley commented on code in PR #1012: URL: https://github.com/apache/solr/pull/1012#discussion_r972096194 ## solr/core/src/java/org/apache/solr/util/ExportTool.java: ## @@ -490,7 +491,7 @@ class CoreHandler { } boolean exportDocsFromCore() throws IOException, So