[GitHub] [solr] dsmiley commented on a diff in pull request #1182: SOLR-16504 Convert CLI tools to Jetty HTTP 2 client.

dsmiley commented on code in PR #1182: URL: https://github.com/apache/solr/pull/1182#discussion_r1161954013 ## solr/core/src/test/org/apache/solr/util/ApiToolTest.java: ## @@ -0,0 +1,47 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor

[GitHub] [solr] dsmiley commented on a diff in pull request #1182: SOLR-16504 Convert CLI tools to Jetty HTTP 2 client.

dsmiley commented on code in PR #1182: URL: https://github.com/apache/solr/pull/1182#discussion_r1159203930 ## solr/solrj/src/java/org/apache/solr/client/solrj/impl/Http2SolrClient.java: ## @@ -505,6 +505,9 @@ private NamedList processErrorsAndResponse( if (contentType != n

[GitHub] [solr] dsmiley commented on a diff in pull request #1182: SOLR-16504 Convert CLI tools to Jetty HTTP 2 client.

dsmiley commented on code in PR #1182: URL: https://github.com/apache/solr/pull/1182#discussion_r1159167924 ## solr/core/src/java/org/apache/solr/packagemanager/PackageManager.java: ## @@ -228,20 +229,20 @@ public List fetchInstalledPackageInstances() throws SolrExc public M

[GitHub] [solr] dsmiley commented on a diff in pull request #1182: SOLR-16504 Convert CLI tools to Jetty HTTP 2 client.

dsmiley commented on code in PR #1182: URL: https://github.com/apache/solr/pull/1182#discussion_r1159085529 ## solr/core/src/java/org/apache/solr/packagemanager/DefaultPackageRepository.java: ## @@ -101,16 +106,21 @@ public Path download(String artifactName) throws SolrExceptio

[GitHub] [solr] dsmiley commented on a diff in pull request #1182: SOLR-16504 Convert CLI tools to Jetty HTTP 2 client.

dsmiley commented on code in PR #1182: URL: https://github.com/apache/solr/pull/1182#discussion_r1159085529 ## solr/core/src/java/org/apache/solr/packagemanager/DefaultPackageRepository.java: ## @@ -101,16 +106,21 @@ public Path download(String artifactName) throws SolrExceptio

[GitHub] [solr] dsmiley commented on a diff in pull request #1182: SOLR-16504 Convert CLI tools to Jetty HTTP 2 client.

dsmiley commented on code in PR #1182: URL: https://github.com/apache/solr/pull/1182#discussion_r1142492764 ## solr/core/src/java/org/apache/solr/filestore/DistribPackageStore.java: ## @@ -181,14 +189,17 @@ private boolean fetchFileFromNodeAndPersist(String fromNode) {

[GitHub] [solr] dsmiley commented on a diff in pull request #1182: SOLR-16504 Convert CLI tools to Jetty HTTP 2 client.

dsmiley commented on code in PR #1182: URL: https://github.com/apache/solr/pull/1182#discussion_r1128029913 ## solr/core/src/test/org/apache/solr/cloud/SolrCloudExampleTest.java: ## @@ -260,22 +259,22 @@ protected void doTestConfigUpdate(String testCollectionName, String solrUr

[GitHub] [solr] dsmiley commented on a diff in pull request #1182: SOLR-16504 Convert CLI tools to Jetty HTTP 2 client.

dsmiley commented on code in PR #1182: URL: https://github.com/apache/solr/pull/1182#discussion_r1128021493 ## solr/core/src/java/org/apache/solr/packagemanager/PackageManager.java: ## @@ -268,19 +266,21 @@ public Map getPackagesDeployedAsClusterLevelPlugins MultiValuedMap

[GitHub] [solr] dsmiley commented on a diff in pull request #1182: SOLR-16504 Convert CLI tools to Jetty HTTP 2 client.

dsmiley commented on code in PR #1182: URL: https://github.com/apache/solr/pull/1182#discussion_r1126525931 ## solr/solrj/src/java/org/apache/solr/client/solrj/impl/Http2SolrClient.java: ## @@ -505,6 +505,9 @@ private NamedList processErrorsAndResponse( if (contentType != n

[GitHub] [solr] dsmiley commented on a diff in pull request #1182: SOLR-16504 Convert CLI tools to Jetty HTTP 2 client.

dsmiley commented on code in PR #1182: URL: https://github.com/apache/solr/pull/1182#discussion_r1126492302 ## solr/core/src/java/org/apache/solr/packagemanager/DefaultPackageRepository.java: ## @@ -101,16 +106,21 @@ public Path download(String artifactName) throws SolrExceptio

[GitHub] [solr] dsmiley commented on a diff in pull request #1182: SOLR-16504 Convert CLI tools to Jetty HTTP 2 client.

dsmiley commented on code in PR #1182: URL: https://github.com/apache/solr/pull/1182#discussion_r1124880964 ## solr/core/src/java/org/apache/solr/packagemanager/DefaultPackageRepository.java: ## @@ -101,16 +106,21 @@ public Path download(String artifactName) throws SolrExceptio

[GitHub] [solr] dsmiley commented on a diff in pull request #1182: SOLR-16504 Convert CLI tools to Jetty HTTP 2 client.

dsmiley commented on code in PR #1182: URL: https://github.com/apache/solr/pull/1182#discussion_r1035468060 ## solr/core/src/java/org/apache/solr/util/SolrCLI.java: ## @@ -618,6 +623,10 @@ private static boolean exceptionIsAuthRelated(Exception exc) { && Arrays.asList(