[GitHub] [solr] dsmiley commented on a diff in pull request #1253: SOLR-10452: setQueryParams should be deprecated in favor of SolrClientBuilder methods

dsmiley commented on code in PR #1253: URL: https://github.com/apache/solr/pull/1253#discussion_r1059545466 ## solr/solrj/src/java/org/apache/solr/client/solrj/impl/HttpSolrClient.java: ## @@ -1041,6 +1052,15 @@ public HttpSolrClient build() { if (this.invariantParams.ge

[GitHub] [solr] dsmiley commented on a diff in pull request #1253: SOLR-10452: setQueryParams should be deprecated in favor of SolrClientBuilder methods

dsmiley commented on code in PR #1253: URL: https://github.com/apache/solr/pull/1253#discussion_r1059527327 ## solr/solrj/src/java/org/apache/solr/client/solrj/impl/ConcurrentUpdateSolrClient.java: ## @@ -140,15 +141,26 @@ protected ConcurrentUpdateSolrClient(Builder builder) {

[GitHub] [solr] dsmiley commented on a diff in pull request #1253: SOLR-10452: setQueryParams should be deprecated in favor of SolrClientBuilder methods

dsmiley commented on code in PR #1253: URL: https://github.com/apache/solr/pull/1253#discussion_r1058589620 ## solr/solrj/src/java/org/apache/solr/client/solrj/impl/LBHttp2SolrClient.java: ## @@ -325,9 +338,24 @@ public LBHttp2SolrClient.Builder setAliveCheckInterval(int aliveC

[GitHub] [solr] dsmiley commented on a diff in pull request #1253: SOLR-10452: setQueryParams should be deprecated in favor of SolrClientBuilder methods

dsmiley commented on code in PR #1253: URL: https://github.com/apache/solr/pull/1253#discussion_r1058586092 ## solr/solrj/src/java/org/apache/solr/client/solrj/impl/LBHttp2SolrClient.java: ## @@ -325,9 +338,24 @@ public LBHttp2SolrClient.Builder setAliveCheckInterval(int aliveC

[GitHub] [solr] dsmiley commented on a diff in pull request #1253: SOLR-10452: setQueryParams should be deprecated in favor of SolrClientBuilder methods

dsmiley commented on code in PR #1253: URL: https://github.com/apache/solr/pull/1253#discussion_r1058555293 ## solr/solrj/src/test/org/apache/solr/client/solrj/impl/Http2SolrClientTest.java: ## @@ -661,12 +661,13 @@ private void verifyServletState(Http2SolrClient client, SolrRe