dsmiley commented on PR #1854:
URL: https://github.com/apache/solr/pull/1854#issuecomment-1686750517
> I don't think it's a very good idea to mix functionality like this
(metrics collection with tracing headers)
I disagree; both are "instrumentation" and the class name was already cho
dsmiley commented on PR #1854:
URL: https://github.com/apache/solr/pull/1854#issuecomment-1686429704
My local change is to `InstrumentedHttpRequestExecutor` to add a client span
and to inject trace headers. This class is used in UpdateShardHandler to
create the "defaultClient" (Apache Http
dsmiley commented on PR #1854:
URL: https://github.com/apache/solr/pull/1854#issuecomment-1685595403
I'm so glad you managed to implement this in core! Changes looks good.
FYI, one gap in propagation is that our Apache HttpClient isn't instrumented
with tracing, only the Jetty HttpCl
