[GitHub] [solr] dsmiley commented on pull request #1856: SOLR-16943 Move Jetty HttpClient tracing into InstrumentedHttpListenerFactory

2023-08-30 Thread via GitHub
dsmiley commented on PR #1856: URL: https://github.com/apache/solr/pull/1856#issuecomment-1699913844 > this time I am also attempting to create a span if it does not exist. IMO I think we should only initiate traces at entry points (SolrDispatchFilter) or maybe other moments we expli

[GitHub] [solr] dsmiley commented on pull request #1856: SOLR-16943 Move Jetty HttpClient tracing into InstrumentedHttpListenerFactory

2023-08-23 Thread via GitHub
dsmiley commented on PR #1856: URL: https://github.com/apache/solr/pull/1856#issuecomment-1689973250 > I would propose to go for a simpler solution though, first this was already solved for us by the many #wrap methods on the context and second trace context is always on, might as well make

[GitHub] [solr] dsmiley commented on pull request #1856: SOLR-16943 Move Jetty HttpClient tracing into InstrumentedHttpListenerFactory

2023-08-22 Thread via GitHub
dsmiley commented on PR #1856: URL: https://github.com/apache/solr/pull/1856#issuecomment-1688298154 > would the existing tests cover the basics Yeah I think we don't need 100% coverage in this tests of all Solr's code paths. Really, just some basic scenarios is fine -- query, indexing,