[GitHub] [solr] epugh commented on a diff in pull request #1182: SOLR-16504 Convert CLI tools to Jetty HTTP 2 client.

2023-04-14 Thread via GitHub
epugh commented on code in PR #1182: URL: https://github.com/apache/solr/pull/1182#discussion_r1166745952 ## solr/core/src/java/org/apache/solr/util/SolrCLI.java: ## @@ -1271,14 +1271,13 @@ public static boolean safeCheckCoreExists(String solrUrl, String coreName) {

[GitHub] [solr] epugh commented on a diff in pull request #1182: SOLR-16504 Convert CLI tools to Jetty HTTP 2 client.

2023-04-11 Thread via GitHub
epugh commented on code in PR #1182: URL: https://github.com/apache/solr/pull/1182#discussion_r1162638083 ## solr/core/src/test/org/apache/solr/util/ApiToolTest.java: ## @@ -0,0 +1,47 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor l

[GitHub] [solr] epugh commented on a diff in pull request #1182: SOLR-16504 Convert CLI tools to Jetty HTTP 2 client.

2023-04-05 Thread via GitHub
epugh commented on code in PR #1182: URL: https://github.com/apache/solr/pull/1182#discussion_r1158360488 ## solr/core/src/java/org/apache/solr/packagemanager/DefaultPackageRepository.java: ## @@ -101,16 +106,21 @@ public Path download(String artifactName) throws SolrException,

[GitHub] [solr] epugh commented on a diff in pull request #1182: SOLR-16504 Convert CLI tools to Jetty HTTP 2 client.

2023-04-05 Thread via GitHub
epugh commented on code in PR #1182: URL: https://github.com/apache/solr/pull/1182#discussion_r1158359743 ## solr/core/src/java/org/apache/solr/packagemanager/DefaultPackageRepository.java: ## @@ -101,16 +106,21 @@ public Path download(String artifactName) throws SolrException,

[GitHub] [solr] epugh commented on a diff in pull request #1182: SOLR-16504 Convert CLI tools to Jetty HTTP 2 client.

2023-03-07 Thread via GitHub
epugh commented on code in PR #1182: URL: https://github.com/apache/solr/pull/1182#discussion_r1127911487 ## solr/core/src/java/org/apache/solr/packagemanager/PackageManager.java: ## @@ -230,15 +229,12 @@ public List fetchInstalledPackageInstances() throws SolrExc public Map

[GitHub] [solr] epugh commented on a diff in pull request #1182: SOLR-16504 Convert CLI tools to Jetty HTTP 2 client.

2022-12-30 Thread GitBox
epugh commented on code in PR #1182: URL: https://github.com/apache/solr/pull/1182#discussion_r1059415280 ## solr/core/src/java/org/apache/solr/packagemanager/PackageManager.java: ## @@ -228,20 +230,20 @@ public List fetchInstalledPackageInstances() throws SolrExc public Map

[GitHub] [solr] epugh commented on a diff in pull request #1182: SOLR-16504 Convert CLI tools to Jetty HTTP 2 client.

2022-11-17 Thread GitBox
epugh commented on code in PR #1182: URL: https://github.com/apache/solr/pull/1182#discussion_r1025532208 ## solr/core/src/java/org/apache/solr/util/PackageTool.java: ## @@ -360,15 +366,19 @@ private String getZkHost(CommandLine cli) throws Exception { String zkHost = cli.