epugh commented on code in PR #1218:
URL: https://github.com/apache/solr/pull/1218#discussion_r1098782651
##
solr/solrj/src/test/org/apache/solr/client/solrj/GetByIdTest.java:
##
@@ -35,7 +34,7 @@ public class GetByIdTest extends EmbeddedSolrServerTestBase {
@BeforeClass
epugh commented on code in PR #1218:
URL: https://github.com/apache/solr/pull/1218#discussion_r1097766488
##
solr/solrj/src/test/org/apache/solr/client/solrj/request/SolrPingTest.java:
##
@@ -31,18 +30,18 @@ public class SolrPingTest extends
EmbeddedSolrServerTestBase {
@B
epugh commented on code in PR #1218:
URL: https://github.com/apache/solr/pull/1218#discussion_r1097765893
##
solr/solrj/src/test/org/apache/solr/client/solrj/request/SolrPingTest.java:
##
@@ -31,18 +30,18 @@ public class SolrPingTest extends
EmbeddedSolrServerTestBase {
@B
epugh commented on code in PR #1218:
URL: https://github.com/apache/solr/pull/1218#discussion_r1097765116
##
solr/solrj/src/test/org/apache/solr/client/solrj/LargeVolumeTestBase.java:
##
@@ -41,7 +41,7 @@ public abstract class LargeVolumeTestBase extends
EmbeddedSolrServerTestB
epugh commented on code in PR #1218:
URL: https://github.com/apache/solr/pull/1218#discussion_r1097764373
##
solr/solrj/src/test/org/apache/solr/client/solrj/GetByIdTest.java:
##
@@ -30,7 +35,9 @@ public class GetByIdTest extends EmbeddedSolrServerTestBase {
@BeforeClass
epugh commented on code in PR #1218:
URL: https://github.com/apache/solr/pull/1218#discussion_r1097324599
##
solr/solrj/src/test/org/apache/solr/client/solrj/LargeVolumeTestBase.java:
##
@@ -41,7 +41,7 @@ public abstract class LargeVolumeTestBase extends
EmbeddedSolrServerTestB
epugh commented on code in PR #1218:
URL: https://github.com/apache/solr/pull/1218#discussion_r1096791114
##
solr/solrj/src/test/org/apache/solr/client/solrj/response/TestSpellCheckResponse.java:
##
@@ -34,17 +38,26 @@
* @since solr 1.3
*/
public class TestSpellCheckRespons
epugh commented on code in PR #1218:
URL: https://github.com/apache/solr/pull/1218#discussion_r1096791009
##
solr/solrj/src/test/org/apache/solr/client/solrj/response/TestSpellCheckResponse.java:
##
@@ -34,17 +38,26 @@
* @since solr 1.3
*/
public class TestSpellCheckRespons
epugh commented on code in PR #1218:
URL: https://github.com/apache/solr/pull/1218#discussion_r1096790762
##
solr/solrj/src/test/org/apache/solr/client/solrj/request/SolrPingTest.java:
##
@@ -31,18 +30,18 @@ public class SolrPingTest extends
EmbeddedSolrServerTestBase {
@B
epugh commented on code in PR #1218:
URL: https://github.com/apache/solr/pull/1218#discussion_r1096790167
##
solr/solrj/src/test/org/apache/solr/client/solrj/request/SolrPingTest.java:
##
@@ -31,18 +30,18 @@ public class SolrPingTest extends
EmbeddedSolrServerTestBase {
@B
epugh commented on code in PR #1218:
URL: https://github.com/apache/solr/pull/1218#discussion_r1096789742
##
solr/solrj/src/test/org/apache/solr/client/solrj/embedded/LargeVolumeJettyTest.java:
##
@@ -16,12 +16,17 @@
*/
package org.apache.solr.client.solrj.embedded;
+import
epugh commented on code in PR #1218:
URL: https://github.com/apache/solr/pull/1218#discussion_r1096789692
##
solr/solrj/src/test/org/apache/solr/client/solrj/embedded/AbstractEmbeddedSolrServerTestCase.java:
##
@@ -104,4 +110,8 @@ protected SolrClient getSolrCore1() {
protect
epugh commented on code in PR #1218:
URL: https://github.com/apache/solr/pull/1218#discussion_r1096789163
##
solr/solrj/src/test/org/apache/solr/client/solrj/LargeVolumeTestBase.java:
##
@@ -41,7 +41,7 @@ public abstract class LargeVolumeTestBase extends
EmbeddedSolrServerTestB
epugh commented on code in PR #1218:
URL: https://github.com/apache/solr/pull/1218#discussion_r1096788848
##
solr/solrj/src/test/org/apache/solr/client/solrj/GetByIdTest.java:
##
@@ -30,7 +35,9 @@ public class GetByIdTest extends EmbeddedSolrServerTestBase {
@BeforeClass
epugh commented on code in PR #1218:
URL: https://github.com/apache/solr/pull/1218#discussion_r1096788578
##
solr/core/src/java/org/apache/solr/update/UpdateShardHandlerConfig.java:
##
@@ -32,6 +32,15 @@ public class UpdateShardHandlerConfig {
DEFAULT_METRICNAMESTRATE
epugh commented on code in PR #1218:
URL: https://github.com/apache/solr/pull/1218#discussion_r1087083741
##
solr/core/src/test/org/apache/solr/update/RootFieldTest.java:
##
@@ -54,7 +54,7 @@ public static void beforeTest() throws Exception {
solrClientTestRule.startSolr(Pa
epugh commented on code in PR #1218:
URL: https://github.com/apache/solr/pull/1218#discussion_r1085229423
##
solr/solrj/src/test/org/apache/solr/client/solrj/response/TermsResponseTest.java:
##
@@ -31,16 +35,19 @@ public class TermsResponseTest extends
EmbeddedSolrServerTestBas
epugh commented on code in PR #1218:
URL: https://github.com/apache/solr/pull/1218#discussion_r1058297053
##
solr/test-framework/src/java/org/apache/solr/util/EmbeddedSolrServerTestRule.java:
##
@@ -53,7 +55,7 @@ public class Builder {
private Path solrHome;
private St
epugh commented on code in PR #1218:
URL: https://github.com/apache/solr/pull/1218#discussion_r1057783517
##
solr/test-framework/src/java/org/apache/solr/util/SolrClientTestRule.java:
##
@@ -0,0 +1,51 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
epugh commented on code in PR #1218:
URL: https://github.com/apache/solr/pull/1218#discussion_r1057782874
##
solr/test-framework/src/java/org/apache/solr/util/EmbeddedSolrServerTestRule.java:
##
@@ -0,0 +1,273 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
epugh commented on code in PR #1218:
URL: https://github.com/apache/solr/pull/1218#discussion_r1057782462
##
solr/test-framework/src/java/org/apache/solr/util/EmbeddedSolrServerTestRule.java:
##
@@ -0,0 +1,273 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
epugh commented on code in PR #1218:
URL: https://github.com/apache/solr/pull/1218#discussion_r1042159303
##
solr/test-framework/src/java/org/apache/solr/util/SolrClientTestRule.java:
##
@@ -0,0 +1,45 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
22 matches
Mail list logo