[GitHub] [solr] epugh commented on a diff in pull request #1954: SOLR-14496: Add Basic Auth support to SolrCLI

2023-09-29 Thread via GitHub
epugh commented on code in PR #1954: URL: https://github.com/apache/solr/pull/1954#discussion_r1341456896 ## solr/core/src/test/org/apache/solr/cli/PackageToolTest.java: ## @@ -0,0 +1,436 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contribut

[GitHub] [solr] epugh commented on a diff in pull request #1954: SOLR-14496: Add Basic Auth support to SolrCLI

2023-09-26 Thread via GitHub
epugh commented on code in PR #1954: URL: https://github.com/apache/solr/pull/1954#discussion_r1337191377 ## solr/core/src/java/org/apache/solr/cli/DeleteTool.java: ## @@ -92,7 +94,13 @@ public void runImpl(CommandLine cli) throws Exception { SolrCLI.raiseLogLevelUnlessVerb

[GitHub] [solr] epugh commented on a diff in pull request #1954: SOLR-14496: Add Basic Auth support to SolrCLI

2023-09-26 Thread via GitHub
epugh commented on code in PR #1954: URL: https://github.com/apache/solr/pull/1954#discussion_r1337189240 ## solr/core/src/java/org/apache/solr/cli/DeleteTool.java: ## @@ -102,13 +110,18 @@ public void runImpl(CommandLine cli) throws Exception { } protected void deleteCo

[GitHub] [solr] epugh commented on a diff in pull request #1954: SOLR-14496: Add Basic Auth support to SolrCLI

2023-09-25 Thread via GitHub
epugh commented on code in PR #1954: URL: https://github.com/apache/solr/pull/1954#discussion_r1336409323 ## solr/core/src/java/org/apache/solr/cli/DeleteTool.java: ## @@ -102,13 +110,18 @@ public void runImpl(CommandLine cli) throws Exception { } protected void deleteCo

[GitHub] [solr] epugh commented on a diff in pull request #1954: SOLR-14496: Add Basic Auth support to SolrCLI

2023-09-25 Thread via GitHub
epugh commented on code in PR #1954: URL: https://github.com/apache/solr/pull/1954#discussion_r1336408616 ## solr/core/src/java/org/apache/solr/cli/DeleteTool.java: ## @@ -92,7 +94,13 @@ public void runImpl(CommandLine cli) throws Exception { SolrCLI.raiseLogLevelUnlessVerb